Bug 1071267 - Part 1: Remove padding inside site security assets.
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 08 Oct 2014 17:48:21 -0700
changeset 209665 2de38d7048555446e6188df57080ae9abcb9dbd6
parent 209664 800257dc7f64820b78b5261936a7526afba5e679
child 209666 6e02d0f5d6425ba25f11bfc472e96f704a282849
push id1
push userroot
push dateMon, 20 Oct 2014 17:29:22 +0000
bugs1071267
milestone35.0a1
Bug 1071267 - Part 1: Remove padding inside site security assets.
mobile/android/base/resources/drawable-hdpi/lock_identified.png
mobile/android/base/resources/drawable-hdpi/lock_verified.png
mobile/android/base/resources/drawable-hdpi/shield.png
mobile/android/base/resources/drawable-hdpi/warning.png
mobile/android/base/resources/drawable-mdpi/lock_identified.png
mobile/android/base/resources/drawable-mdpi/lock_verified.png
mobile/android/base/resources/drawable-mdpi/shield.png
mobile/android/base/resources/drawable-mdpi/warning.png
mobile/android/base/resources/drawable-xhdpi/lock_identified.png
mobile/android/base/resources/drawable-xhdpi/lock_verified.png
mobile/android/base/resources/drawable-xhdpi/shield.png
mobile/android/base/resources/drawable-xhdpi/warning.png
mobile/android/base/resources/layout/toolbar_display_layout.xml
mobile/android/base/resources/values/dimens.xml
index fb59a8fed97c35fe529f089794a4880206838e99..781682895789077a55dec2cbf05b3f48d6ce2e93
GIT binary patch
literal 622
zc%17D@N?(olHy`uVBq!ia0vp^LO?9e!3-n~@4mkVq*&4&eH|GXHuiJ>Nn{1`6_P!I
zd>I(3)EF2VS{N990fib~Fff!FFfhDIU|_JC0n}eGXIG#NP-1d`Plzj!o^UP*j{469
zf*5B5C!7V5{bvIE&tjl6Ak=pnhE9RV-cw+75{fzx1%S{&5CR$n)CE-olsysHb3Cy7
zSYY?jz%C#<63_`mhoS2K|NsA}@Be<FvlL5${DK)c^H2Tyd|Ks($kQe7(pPHfH&^VH
zQ@G8@_{QSujo0rY6YNFi@BtMwCV9KN7_7Ua`vl10%y)Au2GVRm%*>!3$0h(0EGuwK
z2hwt2{KNmDEs!zA)5S4F;&Sepn?g+n0xlQXT*Vw&O|-O5`4q(e`~QB5z}lvddzQRj
zCbZz;j^>5tMY4Z>IHt1v+ujnG>blT3d65O@VHLGmH_~11ZILwYKf$xaC9-;^;L@}w
zXFi+h&L}n(+5ETU<eD=bTef8`{ram|WYxO>R<qLcV(yIU596)4cW~_B+QGSlyMm*F
z>&92_&f1@^H2CvZ$LTi;F3y|`bf0R8YeY#(Vo9o1a#1RfVlXl=G|@G%&^0m*F*LI>
tHL)@<(={-+GB9`};xG+GLvDUbW?Cg~4RbwzXaO}ac)I$ztaD0e0svfF?n?jw
index be7d5b1a2860850d66e738dd0cee81788c2984b5..d1e8ed7dc32294378eaddfe02a8022c14748019d
GIT binary patch
literal 532
zc%17D@N?(olHy`uVBq!ia0vp^LO?9e!3-n~@4mkVq*&4&eH|GXHuiJ>Nn{1`6_P!I
zd>I(3)EF2VS{N990fib~Fff!FFfhDIU|_JC0n}eGXIG#NP$D+KC&U#<$0ujd0{#F0
z|4+K=X`ltNB|(0{44nC=|9n=tc2nf>^7rXl`pxB4yX6%2Gd_Q7aVLh?c{<3Oj7i?^
zE^<X&3fe#pXTF<TF_2~hVrB;QI5q*0U|E4<I*^tF;~)MHZGnsuPZ!4!iOW}eqlKCk
zco-ftvmVWQD_r`%{%qEgxnBMk{wAi+R8f+SjGMCTgz?XSs~X#?#IFlv#`x&|IJfhh
zv-EMVGntd`HFWV5+_QI=2+=FJdzts0me`|9$E!k~{+xU0mya>~GtVrcH6IS!FP$K!
z?|tdeC#J8JO0gfWs&NDDS1oakC`m~yNwrEYN(E93Mh1o^x&{`yMy4T#W>%&qRt9Fe
n2If`<25&?hrlDxa%}>cptHiBguICRepaup{S3j3^P6<r_o_Vjg
index cdaf60fdc749f2d67a004127fa7ae9d5529a3ee4..a278aab4658236fd07cb25d8dcca83f3edaf26b7
GIT binary patch
literal 740
zc%17D@N?(olHy`uVBq!ia0vp^B0wy`!3-qNPSte*QY`6?zK#qG8~eHcB(ehe3dtTp
zz6=aiY77hwEes65fI<x~7#K<o7#Ln9FfdrnU|<k0n6oR;1}HHtz$e5NNXI8<3@Y^h
z|9^3Tb)7($8I%P11vBV$U1tn9W`2fi(!U#3j+eZ|^45N+7x~U|-}cGw715t_P53yL
zJlJ@-N&Q8c{M{0x(=SRv-eyelc6Twnd0Vy!$l=U)b1MeYpdeyqSa_;rA4ssQz%d<2
z%YpF^|A)3f#t%;y#}J9ju@m1`H5u@<24`sp{46*yqf6<EWohvFzwvjS1jEbgmb|?E
zY>U5>i5E){Ta(S%DQ%O(Hg}$Nwh=ui+m&>9w(F#2C!2(Y-E-6|Pk(wEebB7(n6&1K
zCx>6zu4`QQX7Qs<lfqV9tunsR%fCWO`%=a=(|-!47q+zCIoK`~&2?d!{svcv>II(@
z`QLc{ZDtD4%dt5zoh7n)$;Sky<WBpl4%><Y>c^G$mC2nccv8`189%Qev*1x{ePqW6
z#>Gq?m0Ryj@~PR*Y*Rel>vsm@t5@m@(Y!OI_U_gekI&nF@aHYx&o5#>$KI~aFDW;-
ztX&@dH0pWqKW<M)4dx3EIaGjQpjzS@QIe8al4_M)lnSI6j0_A-bPX(YjZ8xf&8$pK
rtPIR_4a}_!4Bm)1OheI-o1c=IR*74~T+bg`Kn)C@u6{1-oD!M<h6@v4
index 87f44af2e000422843a00adc28f536ef3946c5bf..39d879880419aed270dc1fb92e854f318b4cf4dc
GIT binary patch
literal 676
zc%17D@N?(olHy`uVBq!ia0vp^Vn8g)!3-oz|Girdq*&4&eH|GXHuiJ>Nn{1`6_P!I
zd>I(3)EF2VS{N990fib~096|>FuY1&V6d9Oz#v{QXIG#NP@*fqC&U#<|6F4@;OPJV
z|4i$C_W)g^QxfDC%n<P;T=UO*^M8jv9`s(y#(XIux48L1$Ap>F`CqTxDe?8>R<$+r
zgdd&%W^JP#ACVUW)W?|Q?e3y`_Lie9ki(hp=2i>}9xztDZg>YISXSVe4y5J4_=o>P
zkjfLDE{-7*ms2O)6l*dNa9-S`r1gMlk-}>0pa0(%?|Kk;!h7=VmnBgPuBTYdO;kCq
z8k^qoT;yzf$wH02M;Y`z@2iLZFY(Q5a*$eEpD8ghI>FuTA^$zE`?duO?!6T~GD-M>
zhPO=3$2i}KOzN|O-Jbg#mASFP)H-_3i<$Zk>&_m$u;|K4rmWmkPLD&_(>#Tw%Y(KQ
zT28plk(ayUUf1faYyV74e-k@T{FdIQ<gIHvLJqg{n$EjcssG?^d~hB2k2AOTweXi*
zt(dgxH$&EWjo4#1=KTTsNwvf^q9i4;B-JXpC>2OC7#SFv=o(n)8kvR|npv5eSQ(h<
o8kk!d7`zd2n1-SuH$NpatrE9}xt>3?fEpM)UHx3vIVCg!07}vq9{>OV
index a5de9125e80252f9b4f1b5657f371b9bc11f72af..a464ac1605a80bad5b8d5243b4a3f73d0f524a05
GIT binary patch
literal 533
zc%17D@N?(olHy`uVBq!ia0vp^JV4CP!3-py+uy4OQY`6?zK#qG8~eHcB(ehe3dtTp
zz6=aiY77hwEes65fI<x~7#K<o7#Ln9FfdrnU|<k0n6oR;1}IS!;1l8sq$ivULZGvO
z6V8IjeoS-*iuz7NQST`*ItfCZhXNpI!da*qpkUAO!0uy#T}K1Ejs$cb2Fd>a|DT=D
zn+a&EbV-n3FoX7nPdesbtXS@TpEi%x`&VGg`sJN-{`CJ_vFhcNiq}A8j7i?^E~<wa
zPx1pfocV5U#UNh;F%v^^@3bh8U|E4<I*=9t<Hgom7lDi<PZ!4!j_bas!uc8uc$fn=
zFYGZotudwYzwsm`mP+|)vaAd;*FVR|_bXgc>B;FA*1hEOLS=d2nMr+(bG)Ul2HkE?
z%ha?^7GC=jsA;8K{PNbR2ahGB7Z_Mb@?1|p@MHZ;w$7~r1`@L@o&#-DEpd$~Nl7e8
zwMs5Z1yT$~28JfO1{S(TrXhxAR;DIa24=bj=2iv<Z$uoXp=ij>PsvQH#I0ej=MOEQ
O1_n=8KbLh*2~7aag}kl+
index f88b451598e482676516c7e7139b7d255545d8bf..e729acf01f9e9b8bbae2c4e88b228cfb065bc2ff
GIT binary patch
literal 476
zc%17D@N?(olHy`uVBq!ia0vp^JV4CP!3-py+uy4OQY`6?zK#qG8~eHcB(ehe3dtTp
zz6=aiY77hwEes65fI<x~7#K<o7#Ln9FfdrnU|<k0n6oR;1}Nbj;1l8sq~nt_C`bSQ
z|5q|7lmQwiUJ~RN%%Hvg^9CLBFIFsfe@vUh>is*gWkqNIzlf=do<JpxN#5=*60<W~
z<$xT{d^fjZkXL}1iJ`c6S`<jItiUlHNQ;2+Vr#97Kt_nCi(?4K^|@V+d<_Z$N8AEJ
z1RNco{kJbwbhEkbY<yRTfye80q0`|EuFpZ=vtF9L&nWLapyB?w!edUzS4G3_T4STV
z8lM#7Dz=OKco;rqA9v9D66OiFxSxluzFGz}U$w+Fq9i4;B-JXpC>2OC7#SFv=o(n)
z8kvR|npv5eSQ(h<8kk!d7`zd2n1-SuH$NpatrE9}xt>3?fEpM)UHx3vIVCg!0A03|
AN&o-=
index 564d4b51466bb725efe00a71fe949aa3a6e284d5..e2d7c59ea2f0a3f17dcf08c992df9ca8d3be4fdb
GIT binary patch
literal 640
zc%17D@N?(olHy`uVBq!ia0vp^d_XL~!3-n?z4mbcDVB6cUq=Rpjs4tz5?O(Kg=CK)
zUj~LMH3o);76yi2K%s^g3=E|P3=FRl7#OT(FffQ0%-I!a1C*E$;1l8sq~nt_1_}EA
z|NoohIUs-Nl?3?(Gbps(*4*@uv*YK(Do>M!%ir^&PO)70;<och`LZIhWV4pnyc-z{
ze_hW?FgWCQR3xm;38<4X$=lsUU-^oHAdthE@8(tvq(LFZ#E{pq>=8(?tiUlHNQ;2+
zVr#97K*k(T7sn8e>#pZt3N;z<usnFWOd&`>Fkt7CfD5(%k8f7s`>kwzUnO%{L)S9t
zwsjB1FK=3z6uqqJF;~?;MT;ttb<Gouy8Kxtd3@s0-<y(Ea+52Ff2Yn4L8IeSx7)wp
zbLg(*1=pR%X`NlAn>VJlUOOizZM>V+NpOC6m{Q2q<sZ7)PWoO5fAg#H@n_Sb7rVdy
zGSSaJfBBng$$S5QanbP$t_XhhpDcO+=uXuV*NBpo#FA92<f2p{#b9J$XrgOip=)Fs
xVrXV%YGP$zrfXnsWnl0|#9<nWhTQy=%(P0}8s>Wb&;n{;@O1TaS?83{1OSH+;n@HH
index a8ac4535e10800712df6a5b2dca3500f3e3cc0ac..d6ea70657b9fdb22a9007703d0259193073167ce
GIT binary patch
literal 533
zc%17D@N?(olHy`uVBq!ia0vp^d?3uh3?wzC-F*zCSkfJR9T^xl_H+M9WCijSl0AZa
z85pY67#JE_7#My5g&JNkFq9fFFuY1&V6d9Oz#v{QXIG#NP$D6~C&U#<|6F58BlQ3O
zf2M1DuLJFnD+%%oW{|ozU+wp@%tD=iENl6N*BHuewy-td^=R*$kIzk-_h@gA0;*(8
z@^*KTXXO>x3*>O-ySWtuX=X4kpFDjrNU*HHF&#*Yfbn8$t&2cLp{I*u2*-8TzG%K?
z10ELMBU6^FchC&bDE^-;blK@!@^R&xlU#LNBgG~KJ5D{Txx#wuvr7T;&zet7eel1k
z`8V@C`)<ZtVorCqGVk%eI&<$Ohxcpmd$OP7QQBKrl6Pl%iqVqkcE>!^4u9(HE}Rzn
zdF?uBQw8n~)3$|u23oFK;u=wsl30>zm0Xkxq!^403{7+mEOd=bLk!KVOiio|%ybRR
ltqcs_h&W6`(U6;;l9^VCTf<z>A6h^S44$rjF6*2UngESH#F_vA
index 6988dc33508d5442538519266ed0c9c2b72858df..6b0fec93855e8fcacd12b0edee2fbb4c7b4b4fc5
GIT binary patch
literal 686
zc%17D@N?(olHy`uVBq!ia0vp^5<o1=!3-qZQ(`KC6id3JuOkD)#(wTUiL5}rLb6AY
zF9SoB8UsT^3j@P1pisjL28L1t28LG&3=CE?7#PG0=Ijcz0ZJ?i@Ck7R(i6@F!BPLY
zKoH|>Q2*(`{<9ziWKTE?Wh0}$GlBhJ)CWPQL8$jsVDCvJbRw|xPyiGi3;-E>7N!NR
z_(Wh25FHQfJ{H(@6o>*kj|6lchHCl$|NqZ@66b)fR4EDa3udsHckj<sGqII&H<h_A
z1`7RN$Hv~>o|G)fXynAd^w*z1M^CF?xp>tasGc#&+ug<V-nN_BKn`cVn_DrE<^Tm5
zLy+jl<siYb0>^Y9tpUc13#R-4G7fpVIEHAPFYUW7)?^^S8qTQM)DZFF63fxJfB$d$
zsB~5&Jb!s_?&g~e25P~c(^OO0{;!BSdg02y7;~*glmBPW-rKW^CzvDEe}mYzy&E!u
zjyUsWzMJHBUiIR|nGsh@&wlr9o?<HOcG*OF-#*o&uNIXn{D}FnrSdMP6tf=FtzF6w
zCo0rQTo9{Ez9N*Qmvl=>YSI?j32KHJZ#ATrEDtOzaBJXZiV-X*bUtuYmQjvlM}^V>
zZpKX?E7^YT&{%M0^Y;mh{xERbMP;?kbKVQ|jcSQ&L`h0wNvc(HQ7VvPFfuSS(KWEp
zH8Kq`G_x`_u`)2zH88g_FnA;4FbzdRZhlH;S|x4`b3K1(0W~mqy85}Sb4q9e04Z$@
A)&Kwi
index ae0a96dd083bc1f4e27b87130339b0bad99ccf6d..9fc5798e33d5ca5208629cef2d2e27f70c388c8d
GIT binary patch
literal 570
zc%17D@N?(olHy`uVBq!ia0vp^5<o1=!3-qZQ(`KC6id3JuOkD)#(wTUiL5}rLb6AY
zF9SoB8UsT^3j@P1pisjL28L1t28LG&3=CE?7#PG0=Ijcz0ZPOM_=LCu>G<RfTA=^`
z|Nlu>Jq>bkNswPKgU!5qe|}Fj6I&^FQ;q9FpwN_cY@JDxj7CoUi;o|D_e2k<kTJ>I
z-9@g5OF<jR;mmh)D+baWAa61RiGExT5-cllOb5~$V7$0s$`2r8mZytjh{pM+6C#D0
z6$D(=14CjibX3py9dEp?;UL#Mg}+~`;?4%JPCWg1<`SioMZ1<wc%#%^5EoXXwsQYx
zwHe0YXElvVu9n5Fc3A&;!j0(ljl1p#PVwV8_^+_EfXU|9SHW=ItUGh}%($?nmdT>p
zaPdudF@@M8MGv^{?749v>_GGf|CT!*MJAJ6VwM~+|CwC)J6ugq<f_`X<X8MNl&vDe
zd^TwTU8!2)8c~vxSdwa$T$Bo=7>o=IO>_+`bd5|y49%=eO{@&ebPdd{3=H0gI7~y)
ckei>9nO2Eg!(7iFAR8DwUHx3vIVCg!0CeHP-T(jq
index ad5265cef1afda2c47250a0cf2bb3e1d4475ce2d..8a91ffb5a2335f675de0c504b6c7fcfb43aa3c89
GIT binary patch
literal 926
zc%17D@N?(olHy`uVBq!ia0vp^GC-`r!3-qLvR@PcDVB6cUq=Rpjs4tz5?Mi#$sR$z
z3=CCj3=9n|3=F@3LJcn%7)lKo7+xhXFj&oCU=S~uvn$XBC~-KzC&U#<$0uhDUG)F|
z|D9V8SpvObUlQaO%)sQ_e?z|Kse-}s-}=)3@;)D}_EmW&;qf7XpCj$$9aGj<JI?K0
zaIfY2nYCf1GY@X@n{4&4RXB3$`b|Z=8WC5$$^xGPjbcplc6V|3cQfV&ki(hp=2i@(
z*+9X~kRd<eI!Lgrz%d<2Yk=|Mf+;_My2?CV978nD=T3f^)MUWZ&}<MQqtIpWVS&}$
zbKH(|XZwBrm%mj&<fxwgEtUA&GP#Ugfm*AUtrTTVsl2%QM9|f2{}p*A8z!`U{MF!d
z_|T+?w#x2Q^Wy%?S=*!i_N~h-&bgkr+IgYP{5P}y9pgLB%25&R%)5K<zSf$M6-7*E
z8D{V*CGs0TmC}?lVC_8?_+sDlnRkMC+*2|PmO1|L)o~WslF1`%6{6X-XZrU>i$={y
zJZ(mE6#W*u>%9+dl9ROkklFK0sOQ9ogG&n+dKWmhaW~!Cx<z%zl4Bfx*-yO-T7NhS
zPu*Rny2Gs}Gf1$#>k5mO-%`!hM@!}{I63u+XZ{!U9VfY#?DXF2eMx;rz^1!CFO~CJ
zqneVsZ=~nCpR4$Pb?4z)pI3dMc15$RgkN)A&VA<jxz*5q%He(ga#L^f)il~~=kWY@
zq;Gk=h3wA?AD6&SmfuUtcCRj~tNEB#m^t%|uSR$M&V}9j|5XGH_Obl0-Ml8VZ*%3A
z{|st3Gjf`aR&@iTLbb#-q9i4;B-JXpC>2OC7#SFv=o(n)8kvR|npv5eSQ(h<8kk!d
k7`zd2n1-SuH$NpatrE9}xt>3?fEpM)UHx3vIVCg!03n=dJ^%m!
index 3f12f83c827c6b5395bbf8bad7a18ff1ba5cf52a..0e59c2a1fb1b114172b9eb5f4c3cb8785fd9a754
GIT binary patch
literal 756
zc%17D@N?(olHy`uVBq!ia0vp^G9b*s3?yAI>n{UREa{HEjtmSN`?>!lvI6-E$sR$z
z3=CCj3=9n|3=F@3LJcn%7)lKo7+xhXFj&oCU=S~uvn$XBC^0j@C&U#<|6F4@*wFv~
z|7WghUk`MgVM&l*Fau-x%i=7)ca3#|AG=z`zVuD|t86Ou?H}u8`JZyL)N~iQSZam)
ztVrIFWVo$zufub;`f8>qpk~G-Z+90Xhf6*ufE><zH@9LS%?8A*423KUr-1~^3LMjc
zv<4V2E|~HIsEftZ#W6(VeD1{T>Lvr8*2NXlQ4^aUJQHwzF5?&Z@BjShD*a2JTj%WY
zue!waz(mUZVhT&5??e;c%{OBX{M6wP*Z3-y^fBmQs!W6Sl_ckFegcbqy>_0gVleNp
zVLp*r^7Yg<)}@_I2^(u0HBC>;u2l`X|NBj{{w$Gco$vo`X4l^NoN>W4*Qc9%PRFei
zTXgYEvwP`bVTZ-57AL2hc8E9Vhkk5s4gYI)U+mG<4ZE()<vidzeb2QIX>p~DACh0q
zPTDE?W@V1*p5%b?gHqW)^JV&XZsk4LUivBDAX}cnzkGtv$+`8vIv>eo{JnB$=BYo{
zYgv@?55Bsy?A~6h{KiI!KO6OWthW7T=lSJ#^4ZUZJYc}6mbgZgq$HN4S|t~y0x1R~
z149#C0}EXv(-1>5D^n9I12bI%b1MUbHzE$xP&DM`r(~v8;?^+N^M@8t1B0ilpUXO@
GgeCyTEj*V1
--- a/mobile/android/base/resources/layout/toolbar_display_layout.xml
+++ b/mobile/android/base/resources/layout/toolbar_display_layout.xml
@@ -8,21 +8,23 @@
 
     <ImageButton android:id="@+id/favicon"
                  style="@style/UrlBar.ImageButton"
                  android:layout_width="@dimen/browser_toolbar_favicon_size"
                  android:scaleType="fitCenter"
                  android:paddingRight="4dip"
                  android:layout_gravity="center_vertical"/>
 
+    <!-- The toolbar elements are not the same height so we add a bottom margin here to align its bottom. -->
     <ImageButton android:id="@+id/site_security"
                  style="@style/UrlBar.ImageButton"
                  android:layout_width="@dimen/browser_toolbar_lock_width"
                  android:scaleType="fitCenter"
-                 android:layout_marginLeft="-4dip"
+                 android:layout_marginRight="4dip"
+                 android:layout_marginBottom="1dp"
                  android:src="@drawable/site_security_level"
                  android:contentDescription="@string/site_security"
                  android:visibility="gone"/>
 
     <org.mozilla.gecko.widget.FadedTextView android:id="@+id/url_bar_title"
                                             style="@style/UrlBar.Title"
                                             android:layout_width="match_parent"
                                             android:layout_height="match_parent"
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -6,17 +6,17 @@
 <resources>
 
     <dimen name="autocomplete_min_width">200dp</dimen>
     <dimen name="autocomplete_row_height">32dp</dimen>
 
     <dimen name="browser_toolbar_height">48dp</dimen>
     <dimen name="browser_toolbar_button_padding">12dp</dimen>
     <dimen name="browser_toolbar_icon_width">48dp</dimen>
-    <dimen name="browser_toolbar_lock_width">20dp</dimen>
+    <dimen name="browser_toolbar_lock_width">12dp</dimen>
     <!-- favicon_size includes 4dp of right padding. We can't use margin (which would allow us to
          specify the actual size) because that would decrease the size of our hit target. -->
     <dimen name="browser_toolbar_favicon_size">21.33dip</dimen>
     <dimen name="browser_toolbar_shadow_size">2dp</dimen>
 
     <dimen name="new_tablet_tab_strip_height">48dp</dimen>
     <dimen name="new_tablet_tab_strip_item_width">250dp</dimen>
     <dimen name="new_tablet_tab_strip_item_margin">-30dp</dimen>