Bug 1393087 - P4. Remove soft assertion. r?kinetik draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Mon, 25 Sep 2017 16:50:55 +0200
changeset 670080 2d9f007918fd0d75872541f0d71420396bd45989
parent 670079 a61e52a975bcf505a6bc2c2affc12f63559471f3
child 670251 543c1a33d94113ad3a3b730524ea47debb0f64cb
push id81501
push userbmo:jyavenard@mozilla.com
push dateMon, 25 Sep 2017 19:17:09 +0000
reviewerskinetik
bugs1393087
milestone58.0a1
Bug 1393087 - P4. Remove soft assertion. r?kinetik MediaRawData::mKeyframe is now only set when both the alpha channel and standard channel are keyframes. Causing this assertion to be often false. MozReview-Commit-ID: 5zYtFNyJSQB
dom/media/platforms/agnostic/VPXDecoder.cpp
--- a/dom/media/platforms/agnostic/VPXDecoder.cpp
+++ b/dom/media/platforms/agnostic/VPXDecoder.cpp
@@ -118,21 +118,16 @@ VPXDecoder::Flush()
   });
 }
 
 RefPtr<MediaDataDecoder::DecodePromise>
 VPXDecoder::ProcessDecode(MediaRawData* aSample)
 {
   MOZ_ASSERT(mTaskQueue->IsCurrentThreadIn());
 
-#if defined(DEBUG)
-  NS_ASSERTION(IsKeyframe(*aSample, mCodec) == aSample->mKeyframe,
-               "VPX Decode Keyframe error sample->mKeyframe and sample data out of sync");
-#endif
-
   if (vpx_codec_err_t r = vpx_codec_decode(&mVPX, aSample->Data(), aSample->Size(), nullptr, 0)) {
     LOG("VPX Decode error: %s", vpx_codec_err_to_string(r));
     return DecodePromise::CreateAndReject(
       MediaResult(NS_ERROR_DOM_MEDIA_DECODE_ERR,
                   RESULT_DETAIL("VPX error: %s", vpx_codec_err_to_string(r))),
       __func__);
   }