Bug 1329922 - Change kMinTelephoneEventDuration to match minimum duration in WebRTC spec; r?jesup draft
authorDan Minor <dminor@mozilla.com>
Tue, 17 Jan 2017 09:59:11 -0500
changeset 462480 2b43d4fc16813f5cca6495f085071b1dbc7b0937
parent 458610 e68cbc3b5b3d3fba4fe3e17e234713020f44e4a0
child 542408 4c6037b2e6764da7110dd6e7534e44db6c84c2ec
push id41767
push userdminor@mozilla.com
push dateTue, 17 Jan 2017 15:06:58 +0000
reviewersjesup
bugs1329922
milestone53.0a1
Bug 1329922 - Change kMinTelephoneEventDuration to match minimum duration in WebRTC spec; r?jesup The spec says 40 is the minimum, but here it is set to 100. MozReview-Commit-ID: AUy7AviiYVh
media/webrtc/trunk/webrtc/voice_engine/voice_engine_defines.h
--- a/media/webrtc/trunk/webrtc/voice_engine/voice_engine_defines.h
+++ b/media/webrtc/trunk/webrtc/voice_engine/voice_engine_defines.h
@@ -42,17 +42,17 @@ const float kMinOutputVolumePanning = 0.
 // Max scale factor for output volume panning
 const float kMaxOutputVolumePanning = 1.0f;
 
 // DTMF
 enum { kMinDtmfEventCode = 0 };         // DTMF digit "0"
 enum { kMaxDtmfEventCode = 15 };        // DTMF digit "D"
 enum { kMinTelephoneEventCode = 0 };    // RFC4733 (Section 2.3.1)
 enum { kMaxTelephoneEventCode = 255 };  // RFC4733 (Section 2.3.1)
-enum { kMinTelephoneEventDuration = 100 };
+enum { kMinTelephoneEventDuration = 40 };
 enum { kMaxTelephoneEventDuration = 60000 };       // Actual limit is 2^16
 enum { kMinTelephoneEventAttenuation = 0 };        // 0 dBm0
 enum { kMaxTelephoneEventAttenuation = 36 };       // -36 dBm0
 enum { kMinTelephoneEventSeparationMs = 100 };     // Min delta time between two
                                                    // telephone events
 enum { kVoiceEngineMaxIpPacketSizeBytes = 1500 };  // assumes Ethernet
 
 enum { kVoiceEngineMaxModuleVersionSize = 960 };