Bug 1379421: Remove dead code in ServoRestyleManager. r?heycam draft
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 09 Jul 2017 00:02:16 +0200
changeset 605706 2855333cdf3e302ce1c55f07b4a31c956524e58d
parent 605705 2ed937c5e72c5a5ffa0b1c4c5200c52033644048
child 605707 c7329938791408c1707960a8e3395044156f42df
push id67497
push userbmo:emilio+bugs@crisal.io
push dateSat, 08 Jul 2017 22:05:12 +0000
reviewersheycam
bugs1379421
milestone56.0a1
Bug 1379421: Remove dead code in ServoRestyleManager. r?heycam MozReview-Commit-ID: zNNcy6p5qD
layout/base/ServoRestyleManager.cpp
layout/base/ServoRestyleManager.h
--- a/layout/base/ServoRestyleManager.cpp
+++ b/layout/base/ServoRestyleManager.cpp
@@ -876,50 +876,16 @@ ServoRestyleManager::UpdateOnlyAnimation
   if (!doCSS) {
     return;
   }
 
   DoProcessPendingRestyles(TraversalRestyleBehavior::ForAnimationOnly);
 }
 
 void
-ServoRestyleManager::RestyleForInsertOrChange(nsINode* aContainer,
-                                              nsIContent* aChild)
-{
-  //
-  // XXXbholley: We need the Gecko logic here to correctly restyle for things
-  // like :empty and positional selectors (though we may not need to post
-  // restyle events as agressively as the Gecko path does).
-  //
-  // Bug 1297899 tracks this work.
-  //
-}
-
-void
-ServoRestyleManager::RestyleForAppend(nsIContent* aContainer,
-                                      nsIContent* aFirstNewContent)
-{
-  //
-  // XXXbholley: We need the Gecko logic here to correctly restyle for things
-  // like :empty and positional selectors (though we may not need to post
-  // restyle events as agressively as the Gecko path does).
-  //
-  // Bug 1297899 tracks this work.
-  //
-}
-
-void
-ServoRestyleManager::ContentRemoved(nsINode* aContainer,
-                                    nsIContent* aOldChild,
-                                    nsIContent* aFollowingSibling)
-{
-  NS_WARNING("stylo: ServoRestyleManager::ContentRemoved not implemented");
-}
-
-void
 ServoRestyleManager::ContentStateChanged(nsIContent* aContent,
                                          EventStates aChangedBits)
 {
   MOZ_ASSERT(!mInStyleRefresh);
 
   if (!aContent->IsElement()) {
     return;
   }
--- a/layout/base/ServoRestyleManager.h
+++ b/layout/base/ServoRestyleManager.h
@@ -120,27 +120,16 @@ public:
   void RebuildAllStyleData(nsChangeHint aExtraHint,
                            nsRestyleHint aRestyleHint);
   void PostRebuildAllStyleDataEvent(nsChangeHint aExtraHint,
                                     nsRestyleHint aRestyleHint);
   void ProcessPendingRestyles();
 
   void UpdateOnlyAnimationStyles();
 
-  void ContentInserted(nsINode* aContainer, nsIContent* aChild);
-  void ContentAppended(nsIContent* aContainer,
-                       nsIContent* aFirstNewContent);
-  void ContentRemoved(nsINode* aContainer,
-                      nsIContent* aOldChild,
-                      nsIContent* aFollowingSibling);
-
-  void RestyleForInsertOrChange(nsINode* aContainer,
-                                nsIContent* aChild);
-  void RestyleForAppend(nsIContent* aContainer,
-                        nsIContent* aFirstNewContent);
   void ContentStateChanged(nsIContent* aContent, EventStates aStateMask);
   void AttributeWillChange(dom::Element* aElement,
                            int32_t aNameSpaceID,
                            nsIAtom* aAttribute,
                            int32_t aModType,
                            const nsAttrValue* aNewValue);
   void ClassAttributeWillBeChangedBySMIL(dom::Element* aElement);