servo: Merge #18382 - Add CEReactions to element creation APIs (from servo:jdm-patch-1); r=cbrewster
authorJosh Matthews <josh@joshmatthews.net>
Wed, 06 Sep 2017 09:38:58 -0500
changeset 660344 26922045f9c131c9e7a391afede31adadfe5d1a1
parent 660343 9383659b5adc4342510710d4f104af8533670c99
child 660345 8cd07fc93f8bc17c7114949adf813d26aeed55d0
push id78390
push userbmo:emilio@crisal.io
push dateWed, 06 Sep 2017 23:04:15 +0000
reviewerscbrewster
milestone57.0a1
servo: Merge #18382 - Add CEReactions to element creation APIs (from servo:jdm-patch-1); r=cbrewster This addresses https://github.com/whatwg/dom/pull/506. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they will exist upstream in the future. Source-Repo: https://github.com/servo/servo Source-Revision: 4ada03febf2ecdae8220f174a80d22a49a232c5f
servo/components/script/dom/webidls/Document.webidl
--- a/servo/components/script/dom/webidls/Document.webidl
+++ b/servo/components/script/dom/webidls/Document.webidl
@@ -27,19 +27,19 @@ interface Document : Node {
   [Pure]
   readonly attribute DocumentType? doctype;
   [Pure]
   readonly attribute Element? documentElement;
   HTMLCollection getElementsByTagName(DOMString qualifiedName);
   HTMLCollection getElementsByTagNameNS(DOMString? namespace, DOMString qualifiedName);
   HTMLCollection getElementsByClassName(DOMString classNames);
 
-  [NewObject, Throws]
+  [CEReactions, NewObject, Throws]
   Element createElement(DOMString localName, optional ElementCreationOptions options);
-  [NewObject, Throws]
+  [CEReactions, NewObject, Throws]
   Element createElementNS(DOMString? namespace, DOMString qualifiedName, optional ElementCreationOptions options);
   [NewObject]
   DocumentFragment createDocumentFragment();
   [NewObject]
   Text createTextNode(DOMString data);
   [NewObject]
   Comment createComment(DOMString data);
   [NewObject, Throws]