Bug 1229057 - Part 5: Remove unused MacroAssemblerX86::addConstantFloat32. r=h4writer
authorTooru Fujisawa <arai_a@mac.com>
Tue, 01 Dec 2015 17:02:44 +0900
changeset 316146 2491e453b8d049a1e27e6ab608c121d25ea1882b
parent 316145 7f0947717a9fe5c60781d17c7e580d7ad7adbdb6
child 316147 23bd21ccb964f7fafff6688bafb3f1b11215cb15
push id8516
push userjlund@mozilla.com
push dateFri, 18 Dec 2015 00:52:34 +0000
reviewersh4writer
bugs1229057
milestone46.0a1
Bug 1229057 - Part 5: Remove unused MacroAssemblerX86::addConstantFloat32. r=h4writer
js/src/jit/none/MacroAssembler-none.h
js/src/jit/x86/MacroAssembler-x86.cpp
js/src/jit/x86/MacroAssembler-x86.h
--- a/js/src/jit/none/MacroAssembler-none.h
+++ b/js/src/jit/none/MacroAssembler-none.h
@@ -407,17 +407,16 @@ class MacroAssemblerNone : public Assemb
     void boolValueToDouble(ValueOperand, FloatRegister) { MOZ_CRASH(); }
     void boolValueToFloat32(ValueOperand, FloatRegister) { MOZ_CRASH(); }
     void int32ValueToDouble(ValueOperand, FloatRegister) { MOZ_CRASH(); }
     void int32ValueToFloat32(ValueOperand, FloatRegister) { MOZ_CRASH(); }
 
     void loadConstantDouble(double, FloatRegister) { MOZ_CRASH(); }
     void addConstantDouble(double, FloatRegister) { MOZ_CRASH(); }
     void loadConstantFloat32(float, FloatRegister) { MOZ_CRASH(); }
-    void addConstantFloat32(float, FloatRegister) { MOZ_CRASH(); }
     Condition testInt32Truthy(bool, ValueOperand) { MOZ_CRASH(); }
     Condition testStringTruthy(bool, ValueOperand) { MOZ_CRASH(); }
     void branchTestInt32Truthy(bool, ValueOperand, Label*) { MOZ_CRASH(); }
     void branchTestBooleanTruthy(bool, ValueOperand, Label*) { MOZ_CRASH(); }
     void branchTestStringTruthy(bool, ValueOperand, Label*) { MOZ_CRASH(); }
     void branchTestDoubleTruthy(bool, FloatRegister, Label*) { MOZ_CRASH(); }
 
     template <typename T> void loadUnboxedValue(T, MIRType, AnyRegister) { MOZ_CRASH(); }
--- a/js/src/jit/x86/MacroAssembler-x86.cpp
+++ b/js/src/jit/x86/MacroAssembler-x86.cpp
@@ -120,26 +120,16 @@ MacroAssemblerX86::loadConstantFloat32(f
     Float* flt = getFloat(f);
     if (!flt)
         return;
     masm.vmovss_mr(nullptr, dest.encoding());
     propagateOOM(flt->uses.append(CodeOffset(masm.size())));
 }
 
 void
-MacroAssemblerX86::addConstantFloat32(float f, FloatRegister dest)
-{
-    Float* flt = getFloat(f);
-    if (!flt)
-        return;
-    masm.vaddss_mr(nullptr, dest.encoding(), dest.encoding());
-    propagateOOM(flt->uses.append(CodeOffset(masm.size())));
-}
-
-void
 MacroAssemblerX86::loadConstantInt32x4(const SimdConstant& v, FloatRegister dest)
 {
     MOZ_ASSERT(v.type() == SimdConstant::Int32x4);
     if (maybeInlineInt32x4(v, dest))
         return;
     SimdData* i4 = getSimdData(v);
     if (!i4)
         return;
--- a/js/src/jit/x86/MacroAssembler-x86.h
+++ b/js/src/jit/x86/MacroAssembler-x86.h
@@ -983,17 +983,16 @@ class MacroAssemblerX86 : public MacroAs
     }
     void int32ValueToFloat32(const ValueOperand& operand, FloatRegister dest) {
         convertInt32ToFloat32(operand.payloadReg(), dest);
     }
 
     void loadConstantDouble(double d, FloatRegister dest);
     void addConstantDouble(double d, FloatRegister dest);
     void loadConstantFloat32(float f, FloatRegister dest);
-    void addConstantFloat32(float f, FloatRegister dest);
     void loadConstantInt32x4(const SimdConstant& v, FloatRegister dest);
     void loadConstantFloat32x4(const SimdConstant& v, FloatRegister dest);
 
     void branchTruncateDouble(FloatRegister src, Register dest, Label* fail) {
         vcvttsd2si(src, dest);
 
         // vcvttsd2si returns 0x80000000 on failure. Test for it by
         // subtracting 1 and testing overflow (this permits the use of a