Bug 1353074 - Test arguments in all sandboxes; r=maja_zf
☠☠ backed out by 7c7029cf53f5 ☠ ☠
authorAndreas Tolfsen <ato@mozilla.com>
Mon, 03 Apr 2017 19:15:13 +0100
changeset 558289 23409efe536f0e06b74dd4fd69c3a3a620d33e57
parent 558288 8112153e07938722d989d6079d0e98ca3cedbac4
child 558290 8dcd190a0a593331f0754cd00111e5c5a44cb6c2
push id52860
push userbmo:walkingice0204@gmail.com
push dateFri, 07 Apr 2017 13:29:26 +0000
reviewersmaja_zf
bugs1353074
milestone55.0a1
Bug 1353074 - Test arguments in all sandboxes; r=maja_zf We were previously missing a test for the arguments variable that is implicitly exposed to functions. MozReview-Commit-ID: IC6aJcUsyhd
testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
@@ -87,17 +87,28 @@ class TestExecuteContent(MarionetteTestC
         self.assertEqual(
             {"foo": {"bar": [1, 2]}},
             self.marionette.execute_script("return {foo: {bar: [1, 2]}}"))
 
     def test_no_return_value(self):
         self.assertIsNone(self.marionette.execute_script("true"))
 
     def test_argument_null(self):
-        self.assertIsNone(self.marionette.execute_script("return arguments[0]", [None]))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox="default"))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox="system"))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox=None))
 
     def test_argument_number(self):
         self.assertEqual(
             1, self.marionette.execute_script("return arguments[0]", (1,)))
         self.assertEqual(
             1.5, self.marionette.execute_script("return arguments[0]", (1.5,)))
 
     def test_argument_boolean(self):