Bug 1283879 - ASan builds shouldn't try to download symbols (since they don't produce symbols zips) r=dustin
authorKim Moir <kmoir@mozilla.com>
Tue, 09 Aug 2016 09:19:55 -0400
changeset 398685 210edbef152a89dbeebb031db918e47b0c99b210
parent 398562 d59fd1ff4bec47d4f49e9ce4edc210b9548aab0c
child 398686 99f20b0c58d01780b427936cc216403535e6b46c
push id25600
push userbmo:tchiovoloni@mozilla.com
push dateTue, 09 Aug 2016 16:33:05 +0000
reviewersdustin
bugs1283879
milestone51.0a1
Bug 1283879 - ASan builds shouldn't try to download symbols (since they don't produce symbols zips) r=dustin
taskcluster/taskgraph/transforms/tests/all_kinds.py
taskcluster/taskgraph/transforms/tests/test_description.py
--- a/taskcluster/taskgraph/transforms/tests/all_kinds.py
+++ b/taskcluster/taskgraph/transforms/tests/all_kinds.py
@@ -54,20 +54,24 @@ def set_expires_after(config, tests):
             else:
                 test['expires-after'] = "1 year"
         yield test
 
 
 @transforms.add
 def set_download_symbols(config, tests):
     """In general, we download symbols immediately for debug builds, but only
-    on demand for everything else."""
+    on demand for everything else. ASAN builds shouldn't download
+    symbols since they don't product symbol zips see bug 1283879"""
     for test in tests:
         if test['test-platform'].split('/')[-1] == 'debug':
             test['mozharness']['download-symbols'] = True
+        elif test['build-platform'] == 'linux64-asan/opt':
+            if 'download-symbols' in test['mozharness']:
+                del test['mozharness']['download-symbols']
         else:
             test['mozharness']['download-symbols'] = 'ondemand'
         yield test
 
 
 @transforms.add
 def resolve_keyed_by(config, tests):
     """Resolve fields that can be keyed by platform, etc."""
--- a/taskcluster/taskgraph/transforms/tests/test_description.py
+++ b/taskcluster/taskgraph/transforms/tests/test_description.py
@@ -140,17 +140,17 @@ test_description_schema = Schema({
         Required('tooltool-downloads', default=False): bool,
 
         # This mozharness script also runs in Buildbot and tries to read a
         # buildbot config file, so tell it not to do so in TaskCluster
         Required('no-read-buildbot-config', default=False): bool,
 
         # The setting for --download-symbols (if omitted, the option will not
         # be passed to mozharness)
-        Optional('download-symbols'): Any(True, False, 'ondemand'),
+        Optional('download-symbols'): Any(True, 'ondemand'),
 
         # If set, then MOZ_NODE_PATH=/usr/local/bin/node is included in the
         # environment.  This is more than just a helpful path setting -- it
         # causes xpcshell tests to start additional servers, and runs
         # additional tests.
         Required('set-moz-node-path', default=False): bool,
 
         # If true, include chunking information in the command even if the number