Bug 1461463 - [geckodriver] Remove extra colon from invalid "WebDriver::Forward" command. r=ato
authorHenrik Skupin <mail@hskupin.info>
Thu, 17 May 2018 09:52:12 +0200
changeset 801185 1c4a5bba3582a3498a992f6a3c8c817f5830e18a
parent 801184 2df57c387242842ee919e65915322d6254c9dd3d
child 801186 9d1398fa66ba134fdb4399eda11aec8abcdbc0d4
push id111603
push usermozilla@kaply.com
push dateTue, 29 May 2018 22:12:07 +0000
reviewersato
bugs1461463, 1452024
milestone62.0a1
Bug 1461463 - [geckodriver] Remove extra colon from invalid "WebDriver::Forward" command. r=ato Bug 1452024 caused a regression in geckodriver which accidentally added an extra colon to the "WebDriver:Forward" command. This breaks Marionette because it is not a known command. MozReview-Commit-ID: JKDVj9YWoZC
testing/geckodriver/src/marionette.rs
--- a/testing/geckodriver/src/marionette.rs
+++ b/testing/geckodriver/src/marionette.rs
@@ -1097,17 +1097,17 @@ impl MarionetteCommand {
             GetElementText(ref x) => (Some("WebDriver:GetElementText"), Some(x.to_marionette())),
             GetPageSource => (Some("WebDriver:GetPageSource"), None),
             GetTimeouts => (Some("WebDriver:GetTimeouts"), None),
             GetTitle => (Some("WebDriver:GetTitle"), None),
             GetWindowHandle => (Some("WebDriver:GetWindowHandle"), None),
             GetWindowHandles => (Some("WebDriver:GetWindowHandles"), None),
             GetWindowRect => (Some("WebDriver:GetWindowRect"), None),
             GoBack => (Some("WebDriver:Back"), None),
-            GoForward => (Some("WebDriver::Forward"), None),
+            GoForward => (Some("WebDriver:Forward"), None),
             IsDisplayed(ref x) => (
                 Some("WebDriver:IsElementDisplayed"),
                 Some(x.to_marionette()),
             ),
             IsEnabled(ref x) => (Some("WebDriver:IsElementEnabled"), Some(x.to_marionette())),
             IsSelected(ref x) => (Some("WebDriver:IsElementSelected"), Some(x.to_marionette())),
             MaximizeWindow => (Some("WebDriver:MaximizeWindow"), None),
             MinimizeWindow => (Some("WebDriver:MinimizeWindow"), None),