Bug 1368084 - Temporarily disable building testing/geckodriver; r=me a=RyanVM
authorAndreas Tolfsen <ato@mozilla.com>
Fri, 26 May 2017 16:39:16 +0100
changeset 585145 1bfa4578aa56f768626ba278a6929e23fc48db54
parent 585129 43b0fdd5b94a28a6b8f4da567b9e6af46a6b5d8e
child 585146 67f62688dc11350a83f8441c3a74104afdbc342e
child 585167 ca04c84bd47c1b96931ac78e645b5da331168649
child 585218 136cb7864ddde52365533258b01268081aa1314c
child 585224 b40696c5ca267bdba9d1c3f7c2d3946c15395eda
child 585227 e008db9c07546d8317661e1f5a62a5bca81a0123
child 585242 c4d0ca7cf54b3bb48afadfe1970f4846751ed379
child 585247 71bc941989c1a66f77f9bfa9d17295dfb18dc105
child 585250 29fc33cbf8286a58f93ca2b518e428b7aaa5b247
child 585251 19401cc835b72d3445cdf0a6da0016fd5a09473e
child 585261 bb1ed1fb29c46c492e73675a6f561d4e9f0d1447
child 585311 ba1a33add29df1cff5931c5bd82725b8ed4990e5
child 585326 4241cfd09e61d60f47bc9292879a22a3f058e14f
child 585332 4d3fc306332e790f29c2503e9004f9c73a0734cc
child 585333 523510f84bb762e195bd1a35a590174b8295eece
child 585334 a267f643712662988f55ca7ae1fec588017fc95b
child 585344 5a56cb2f07d98e6940a9c900bdcb3e81dcc544b7
child 585428 70d09d9c22f462752a6347dfea0763bf5db72e09
child 585462 7a1bbe3809a33914b0506d4174b2c5f9fcef07c8
child 585482 c35bcd5f89a3ba81622f53136da0b67fbf224f69
child 585503 c70a5b403579ef42329ca5bda6ad10f754017790
child 585508 f2b737347ddaddb79abc5d5ff6f949d7e83a473c
child 585524 37d9c4e1c3282f704ba6ac80caefc3ea0736ea60
child 585635 9499f3278cefee7a653d8661e0f2b57ef95e86c4
child 585636 847f0b7113441fdd534eb30fa9f4ff336c284c53
child 585732 d58c6f9bd5a7d2bb717ca989d768804294714842
child 586033 f7db4d059ac94789da8837c5d7057c0114dc8e22
child 586054 c7aed09ada7a84eef3a9d4d8d1aff5f2cd9529a9
child 586093 cf1fec6d91826d4a3043a68602183058d8d0d28b
child 586561 69f88ad323613e8037964ffa41547cefe37754e0
push id61025
push userbmo:gijskruitbosch+bugs@gmail.com
push dateFri, 26 May 2017 16:17:00 +0000
reviewersme, RyanVM
bugs1368084, 1368035, 1367995
milestone55.0a1
Bug 1368084 - Temporarily disable building testing/geckodriver; r=me a=RyanVM Until we add an --enable-geckodriver build config flag in https://bugzilla.mozilla.org/show_bug.cgi?id=1368035, we disable building of geckodriver in mozilla-central due to issues like https://bugzilla.mozilla.org/show_bug.cgi?id=1367995. MozReview-Commit-ID: 6aEh7TYSCKC
toolkit/toolkit.mozbuild
--- a/toolkit/toolkit.mozbuild
+++ b/toolkit/toolkit.mozbuild
@@ -149,31 +149,37 @@ if 'gtk' in CONFIG['MOZ_WIDGET_TOOLKIT']
 DIRS += ['/addon-sdk']
 
 if CONFIG['ENABLE_MARIONETTE']:
     DIRS += [
         '/testing/firefox-ui',
         '/testing/marionette',
     ]
 
+    """
+    Temporarily disable building ../testing/geckodriver
+    until https://bugzilla.mozilla.org/show_bug.cgi?id=1368035,
+    letting local developer builds opt in with --enable-geckodriver is fixed.
+
     # Disable building of geckodriver for artifact builds and in
     # environments where cross compiling occurs (macOS and Android),
     # on hazard builds, and on Linux x86 (linking problems).
     #
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1341041
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1329737
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1367519
     # https://bugzilla.mozilla.org/show_bug.cgi?id=1367736
     if (not CONFIG['COMPILE_ENVIRONMENT'] or
             CONFIG['CROSS_COMPILE'] or
             (CONFIG['OS_TARGET'] == 'Linux' and CONFIG['TARGET_CPU'] == 'i686') or
             CONFIG['MOZ_HAZARD']):
         pass
     else:
         DIRS += ['/testing/geckodriver']
+    """
 
 DIRS += [
     '/tools/quitter',
     '/media/gmp-clearkey/0.1',
 ]
 
 if CONFIG['ENABLE_TESTS']:
     DIRS += [