Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag
authorBrian Grinstead <bgrinstead@mozilla.com>
Mon, 11 Sep 2017 11:34:21 -0700
changeset 662693 1bc15f7fe1af609e913489d6f615b6d41701c731
parent 662692 6616cbb6460fdf486e447248aec1f9803db4acdb
child 662694 0ef39e821b67496cfb9e29de90367952e1a5174f
push id79159
push userhikezoe@mozilla.com
push dateMon, 11 Sep 2017 23:25:15 +0000
reviewerskmag
bugs1374837
milestone57.0a1
Bug 1374837 - Pipe stderr to stdout to fix the Browser Toolbox in certain Windows builds;r=kmag This is working around an issue with Subprocess that affects some developers using a 32 bit build on a 64 bit Windows MozReview-Commit-ID: COsKOkBVjSZ
devtools/client/framework/ToolboxProcess.jsm
--- a/devtools/client/framework/ToolboxProcess.jsm
+++ b/devtools/client/framework/ToolboxProcess.jsm
@@ -272,16 +272,17 @@ BrowserToolboxProcess.prototype = {
     if (!system.constants.MOZILLA_OFFICIAL) {
       args.push("-purgecaches");
     }
 
     this._dbgProcessPromise = Subprocess.call({
       command,
       arguments: args,
       environmentAppend: true,
+      stderr: "stdout",
       environment: {
         // Disable safe mode for the new process in case this was opened via the
         // keyboard shortcut.
         MOZ_DISABLE_SAFE_MODE_KEY: "1",
       },
     }).then(proc => {
       this._dbgProcess = proc;