Bug 1353208 - Drop a few remaining references to attributeType; r?mantaroh draft
authorBrian Birtles <birtles@gmail.com>
Thu, 30 Mar 2017 13:10:06 +0900
changeset 555805 1b07a560157826d9fa3664e4220465f1b9e8609b
parent 555725 b043233ec04f06768d59dcdfb9e928142280f3cc
child 555806 ff28e097934a836d656aaaf871d8a0fbfe4aec2b
push id52357
push userbbirtles@mozilla.com
push dateWed, 05 Apr 2017 01:20:37 +0000
reviewersmantaroh
bugs1353208, 1062106
milestone55.0a1
Bug 1353208 - Drop a few remaining references to attributeType; r?mantaroh These are left over from bug 1062106. MozReview-Commit-ID: 4vfcT4O2tMz
dom/smil/nsSMILCompositor.h
dom/svg/SVGAnimationElement.cpp
--- a/dom/smil/nsSMILCompositor.h
+++ b/dom/smil/nsSMILCompositor.h
@@ -81,17 +81,17 @@ public:
   // sandwich. Also toggles the 'mForceCompositing' flag if it finds that any
   // (used) functions have changed.
   uint32_t GetFirstFuncToAffectSandwich();
 
   // If the passed-in base value differs from our cached base value, this
   // method updates the cached value (and toggles the 'mForceCompositing' flag)
   void UpdateCachedBaseValue(const nsSMILValue& aBaseValue);
 
-  // The hash key (tuple of element/attributeName/attributeType)
+  // The hash key (tuple of element and attributeName)
   KeyType mKey;
 
   // Hash Value: List of animation functions that animate the specified attr
   nsTArray<nsSMILAnimationFunction*> mAnimationFunctions;
 
   // Member data for detecting when we need to force-recompose
   // ---------------------------------------------------------
   // Flag for tracking whether we need to compose. Initialized to false, but
--- a/dom/svg/SVGAnimationElement.cpp
+++ b/dom/svg/SVGAnimationElement.cpp
@@ -243,18 +243,17 @@ SVGAnimationElement::UnbindFromTree(bool
 bool
 SVGAnimationElement::ParseAttribute(int32_t aNamespaceID,
                                     nsIAtom* aAttribute,
                                     const nsAString& aValue,
                                     nsAttrValue& aResult)
 {
   if (aNamespaceID == kNameSpaceID_None) {
     // Deal with target-related attributes here
-    if (aAttribute == nsGkAtoms::attributeName ||
-        aAttribute == nsGkAtoms::attributeType) {
+    if (aAttribute == nsGkAtoms::attributeName) {
       aResult.ParseAtom(aValue);
       AnimationNeedsResample();
       return true;
     }
 
     nsresult rv = NS_ERROR_FAILURE;
 
     // First let the animation function try to parse it...