Bug 1353074 - Use tuples for script arguments; r?maja_zf
We only allow a list type for backwards compatibility. Tuples is what is
recommended because of interoperability with the Python standard library.
MozReview-Commit-ID: 72zPzYvBz7Q
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
@@ -91,34 +91,34 @@ class TestExecuteContent(MarionetteTestC
def test_no_return_value(self):
self.assertIsNone(self.marionette.execute_script("true"))
def test_argument_null(self):
self.assertIsNone(self.marionette.execute_script("return arguments[0]", [None]))
def test_argument_number(self):
self.assertEqual(
- 1, self.marionette.execute_script("return arguments[0]", [1]))
+ 1, self.marionette.execute_script("return arguments[0]", (1,)))
self.assertEqual(
- 1.5, self.marionette.execute_script("return arguments[0]", [1.5]))
+ 1.5, self.marionette.execute_script("return arguments[0]", (1.5,)))
def test_argument_boolean(self):
- self.assertTrue(self.marionette.execute_script("return arguments[0]", [True]))
+ self.assertTrue(self.marionette.execute_script("return arguments[0]", (True,)))
def test_argument_string(self):
self.assertEqual(
- "foo", self.marionette.execute_script("return arguments[0]", ["foo"]))
+ "foo", self.marionette.execute_script("return arguments[0]", ("foo",)))
def test_argument_array(self):
self.assertEqual(
- [1, 2], self.marionette.execute_script("return arguments[0]", [[1, 2]]))
+ [1, 2], self.marionette.execute_script("return arguments[0]", ([1, 2],)))
def test_argument_object(self):
self.assertEqual({"foo": 1}, self.marionette.execute_script(
- "return arguments[0]", [{"foo": 1}]))
+ "return arguments[0]", ({"foo": 1},)))
def test_globals(self):
for property in globals:
self.assert_is_defined(property)
self.assert_is_defined("Components")
self.assert_is_defined("window.wrappedJSObject")
def test_system_globals(self):