Bug 1429857 - Override -moz-appearance on bookmarks popup subviewbuttons, and styles on menuitem-iconic-left;r=dao draft
authorBrian Grinstead <bgrinstead@mozilla.com>
Wed, 17 Jan 2018 10:19:15 -0800
changeset 721670 10190b2d356fde01e62237b383002468efe8ffca
parent 721495 4e429d313fd2e0f9202271ee8f3fb798817ec3e7
child 746416 a7a015c559e0b1ca40b9d0f593c411ffc896e19a
push id95925
push userbgrinstead@mozilla.com
push dateWed, 17 Jan 2018 18:19:28 +0000
reviewersdao
bugs1429857, 1420229
milestone59.0a1
Bug 1429857 - Override -moz-appearance on bookmarks popup subviewbuttons, and styles on menuitem-iconic-left;r=dao This is needed because menu.css is now loaded as a document style and rules there are overriding some in panelUI.inc.css. There are plans to deprioritize menu.css in Bug 1420229, at which point this code can be removed. MozReview-Commit-ID: CF9Ixgqob8
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -1249,16 +1249,29 @@ toolbarpaletteitem[place="menu-panel"] >
   padding-inline-start: .5em;
 }
 
 .subviewbutton > .menu-iconic-left {
   -moz-appearance: none;
   margin-inline-end: 0;
 }
 
+%ifdef XP_WIN
+/* Overrides from menu.css to prevent items in the bookmarks popup from being too tall.
+   These won't be necessary once menu.css is loaded as a UA style (Bug 1420229). */
+#BMB_bookmarksPopup .subviewbutton > .menu-iconic-left {
+  padding-top: 0;
+  -moz-appearance: none;
+}
+
+#BMB_bookmarksPopup .subviewbutton {
+  -moz-appearance: none;
+}
+%endif
+
 menuitem[checked="true"].subviewbutton > .menu-iconic-left {
   visibility: hidden;
 }
 
 #PanelUI-panicView > .panel-subview-body,
 #PanelUI-panicView {
   overflow: visible;
 }