Bug 1406493 - Remove the rest of the attribute deprecation warnings; r=baku f=annevk
--- a/dom/base/Attr.cpp
+++ b/dom/base/Attr.cpp
@@ -232,26 +232,22 @@ Attr::GetOwnerElement(nsIDOMElement** aO
*aOwnerElement = nullptr;
return NS_OK;
}
void
Attr::GetNodeValueInternal(nsAString& aNodeValue)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eNodeValue);
-
GetValue(aNodeValue);
}
void
Attr::SetNodeValueInternal(const nsAString& aNodeValue, ErrorResult& aError)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eNodeValue);
-
aError = SetValue(aNodeValue);
}
nsresult
Attr::Clone(mozilla::dom::NodeInfo *aNodeInfo, nsINode **aResult,
bool aPreallocateChildren) const
{
nsAutoString value;
@@ -275,27 +271,23 @@ Attr::GetBaseURI(bool aTryUseXHRDocBaseU
return parent ? parent->GetBaseURI(aTryUseXHRDocBaseURI) : nullptr;
}
void
Attr::GetTextContentInternal(nsAString& aTextContent,
OOMReporter& aError)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eTextContent);
-
GetValue(aTextContent);
}
void
Attr::SetTextContentInternal(const nsAString& aTextContent,
ErrorResult& aError)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eTextContent);
-
SetNodeValueInternal(aTextContent, aError);
}
NS_IMETHODIMP
Attr::GetIsId(bool* aReturn)
{
*aReturn = mNodeInfo->Equals(nsGkAtoms::id, kNameSpaceID_None);
return NS_OK;
--- a/dom/base/Element.cpp
+++ b/dom/base/Element.cpp
@@ -1338,17 +1338,16 @@ Element::RemoveAttribute(const nsAString
nsAttrName tmp(*name);
aError = UnsetAttr(name->NamespaceID(), name->LocalName(), true);
}
Attr*
Element::GetAttributeNode(const nsAString& aName)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eGetAttributeNode);
return Attributes()->GetNamedItem(aName);
}
already_AddRefed<Attr>
Element::SetAttributeNode(Attr& aNewAttr, ErrorResult& aError)
{
return Attributes()->SetNamedItemNS(aNewAttr, aError);
}
@@ -1358,17 +1357,16 @@ Element::RemoveAttributeNode(Attr& aAttr
ErrorResult& aError)
{
Element *elem = aAttribute.GetElement();
if (elem != this) {
aError.Throw(NS_ERROR_DOM_NOT_FOUND_ERR);
return nullptr;
}
- OwnerDoc()->WarnOnceAbout(nsIDocument::eRemoveAttributeNode);
nsAutoString nameSpaceURI;
aAttribute.NodeInfo()->GetNamespaceURI(nameSpaceURI);
return Attributes()->RemoveNamedItemNS(nameSpaceURI, aAttribute.NodeInfo()->LocalName(), aError);
}
void
Element::GetAttributeNS(const nsAString& aNamespaceURI,
const nsAString& aLocalName,
@@ -1430,18 +1428,16 @@ Element::RemoveAttributeNS(const nsAStri
aError = UnsetAttr(nsid, name, true);
}
Attr*
Element::GetAttributeNodeNS(const nsAString& aNamespaceURI,
const nsAString& aLocalName)
{
- OwnerDoc()->WarnOnceAbout(nsIDocument::eGetAttributeNodeNS);
-
return GetAttributeNodeNSInternal(aNamespaceURI, aLocalName);
}
Attr*
Element::GetAttributeNodeNSInternal(const nsAString& aNamespaceURI,
const nsAString& aLocalName)
{
return Attributes()->GetNamedItemNS(aNamespaceURI, aLocalName);
--- a/dom/base/nsDeprecatedOperationList.h
+++ b/dom/base/nsDeprecatedOperationList.h
@@ -5,23 +5,16 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// IWYU pragma: private, include "nsIDocument.h"
/*
* This file contains the list of deprecated DOM operations. It is
* designed to be used as input to the C preprocessor *only*.
*/
-DEPRECATED_OPERATION(GetAttributeNode)
-DEPRECATED_OPERATION(GetAttributeNodeNS)
-DEPRECATED_OPERATION(RemoveAttributeNode)
-DEPRECATED_OPERATION(CreateAttribute)
-DEPRECATED_OPERATION(CreateAttributeNS)
-DEPRECATED_OPERATION(NodeValue)
-DEPRECATED_OPERATION(TextContent)
DEPRECATED_OPERATION(EnablePrivilege)
DEPRECATED_OPERATION(DOMExceptionCode)
DEPRECATED_OPERATION(MutationEvent)
DEPRECATED_OPERATION(Components)
DEPRECATED_OPERATION(PrefixedVisibilityAPI)
DEPRECATED_OPERATION(NodeIteratorDetach)
DEPRECATED_OPERATION(LenientThis)
DEPRECATED_OPERATION(GetPreventDefault)
--- a/dom/base/nsDocument.cpp
+++ b/dom/base/nsDocument.cpp
@@ -6241,18 +6241,16 @@ nsDocument::CreateAttribute(const nsAStr
ErrorResult rv;
*aReturn = nsIDocument::CreateAttribute(aName, rv).take();
return rv.StealNSResult();
}
already_AddRefed<Attr>
nsIDocument::CreateAttribute(const nsAString& aName, ErrorResult& rv)
{
- WarnOnceAbout(eCreateAttribute);
-
if (!mNodeInfoManager) {
rv.Throw(NS_ERROR_NOT_INITIALIZED);
return nullptr;
}
nsresult res = nsContentUtils::CheckQName(aName, false);
if (NS_FAILED(res)) {
rv.Throw(res);
@@ -6291,18 +6289,16 @@ nsDocument::CreateAttributeNS(const nsAS
return rv.StealNSResult();
}
already_AddRefed<Attr>
nsIDocument::CreateAttributeNS(const nsAString& aNamespaceURI,
const nsAString& aQualifiedName,
ErrorResult& rv)
{
- WarnOnceAbout(eCreateAttributeNS);
-
RefPtr<mozilla::dom::NodeInfo> nodeInfo;
rv = nsContentUtils::GetNodeInfoFromQName(aNamespaceURI,
aQualifiedName,
mNodeInfoManager,
nsIDOMNode::ATTRIBUTE_NODE,
getter_AddRefs(nodeInfo));
if (rv.Failed()) {
return nullptr;
--- a/dom/bindings/test/TestCodeGen.webidl
+++ b/dom/bindings/test/TestCodeGen.webidl
@@ -794,37 +794,37 @@ interface TestInterface {
// Typedefs
const myLong myLongConstant = 5;
void exerciseTypedefInterfaces1(AnotherNameForTestInterface arg);
AnotherNameForTestInterface exerciseTypedefInterfaces2(NullableTestInterface arg);
void exerciseTypedefInterfaces3(YetAnotherNameForTestInterface arg);
// Deprecated methods and attributes
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
attribute byte deprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
byte deprecatedMethod();
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
byte deprecatedMethodWithContext(any arg);
// Static methods and attributes
static attribute boolean staticAttribute;
static void staticMethod(boolean arg);
static void staticMethodWithContext(any arg);
// Testing static method with a reserved C++ keyword as the name
static void assert(boolean arg);
// Deprecated static methods and attributes
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static attribute byte staticDeprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static void staticDeprecatedMethod();
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static void staticDeprecatedMethodWithContext(any arg);
// Overload resolution tests
//void overload1(DOMString... strs);
boolean overload1(TestInterface arg);
TestInterface overload1(DOMString strs, TestInterface arg);
void overload2(TestInterface arg);
void overload2(optional Dict arg);
@@ -1256,17 +1256,17 @@ interface TestNamedDeleterWithRetvalInte
};
interface TestCppKeywordNamedMethodsInterface {
boolean continue();
boolean delete();
long volatile();
};
-[Deprecated="GetAttributeNode", Constructor()]
+[Deprecated="EnablePrivilege", Constructor()]
interface TestDeprecatedInterface {
static void alsoDeprecated();
};
[Constructor(Promise<void> promise)]
interface TestInterfaceWithPromiseConstructorArg {
};
--- a/dom/bindings/test/TestExampleGen.webidl
+++ b/dom/bindings/test/TestExampleGen.webidl
@@ -627,34 +627,34 @@ interface TestExampleInterface {
// Typedefs
const myLong myLongConstant = 5;
void exerciseTypedefInterfaces1(AnotherNameForTestInterface arg);
AnotherNameForTestInterface exerciseTypedefInterfaces2(NullableTestInterface arg);
void exerciseTypedefInterfaces3(YetAnotherNameForTestInterface arg);
// Deprecated methods and attributes
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
attribute boolean deprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
void deprecatedMethod(boolean arg);
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
void deprecatedMethodWithContext(any arg);
// Static methods and attributes
static attribute boolean staticAttribute;
static void staticMethod(boolean arg);
static void staticMethodWithContext(any arg);
// Deprecated methods and attributes;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static attribute boolean staticDeprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static void staticDeprecatedMethod(boolean arg);
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static void staticDeprecatedMethodWithContext(any arg);
// Overload resolution tests
//void overload1(DOMString... strs);
boolean overload1(TestInterface arg);
TestInterface overload1(DOMString strs, TestInterface arg);
void overload2(TestInterface arg);
void overload2(optional Dict arg);
--- a/dom/bindings/test/TestJSImplGen.webidl
+++ b/dom/bindings/test/TestJSImplGen.webidl
@@ -638,36 +638,36 @@ interface TestJSImplInterface {
// Typedefs
const myLong myLongConstant = 5;
void exerciseTypedefInterfaces1(AnotherNameForTestJSImplInterface arg);
AnotherNameForTestJSImplInterface exerciseTypedefInterfaces2(NullableTestJSImplInterface arg);
void exerciseTypedefInterfaces3(YetAnotherNameForTestJSImplInterface arg);
// Deprecated methods and attributes
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
attribute byte deprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
byte deprecatedMethod();
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
void deprecatedMethodWithContext(any arg);
// Static methods and attributes
// FIXME: Bug 863952 Static things are not supported yet
/*
static attribute boolean staticAttribute;
static void staticMethod(boolean arg);
static void staticMethodWithContext(any arg);
// Deprecated static methods and attributes
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static attribute byte staticDeprecatedAttribute;
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static byte staticDeprecatedMethod();
- [Deprecated="GetAttributeNode"]
+ [Deprecated="EnablePrivilege"]
static byte staticDeprecatedMethodWithContext();
*/
// Overload resolution tests
//void overload1(DOMString... strs);
boolean overload1(TestJSImplInterface arg);
TestJSImplInterface overload1(DOMString strs, TestJSImplInterface arg);
void overload2(TestJSImplInterface arg);
--- a/dom/locales/en-US/chrome/dom/dom.properties
+++ b/dom/locales/en-US/chrome/dom/dom.properties
@@ -52,23 +52,16 @@ FormValidationDateTimeRangeOverflow=Plea
FormValidationNumberRangeUnderflow=Please select a value that is no less than %S.
# LOCALIZATION NOTE (FormValidationDateTimeRangeUnderflow): %S is a date or a time.
FormValidationDateTimeRangeUnderflow=Please select a value that is no earlier than %S.
# LOCALIZATION NOTE (FormValidationStepMismatch): both %S can be a number, a date or a time.
FormValidationStepMismatch=Please select a valid value. The two nearest valid values are %S and %S.
# LOCALIZATION NOTE (FormValidationStepMismatchOneValue): %S can be a number, a date or a time. This is called instead of FormValidationStepMismatch when the second value is the same as the first.
FormValidationStepMismatchOneValue=Please select a valid value. The nearest valid value is %S.
FormValidationBadInputNumber=Please enter a number.
-GetAttributeNodeWarning=Use of getAttributeNode() is deprecated. Use getAttribute() instead.
-GetAttributeNodeNSWarning=Use of getAttributeNodeNS() is deprecated. Use getAttributeNS() instead.
-RemoveAttributeNodeWarning=Use of removeAttributeNode() is deprecated. Use removeAttribute() instead.
-CreateAttributeWarning=Use of document.createAttribute() is deprecated. Use element.setAttribute() instead.
-CreateAttributeNSWarning=Use of document.createAttributeNS() is deprecated. Use element.setAttributeNS() instead.
-NodeValueWarning=Use of attributes’ nodeValue attribute is deprecated. Use value instead.
-TextContentWarning=Use of attributes’ textContent attribute is deprecated. Use value instead.
EnablePrivilegeWarning=Use of enablePrivilege is deprecated. Please use code that runs with the system principal (e.g. an extension) instead.
FullscreenDeniedDisabled=Request for fullscreen was denied because Fullscreen API is disabled by user preference.
FullscreenDeniedFocusedPlugin=Request for fullscreen was denied because a windowed plugin is focused.
FullscreenDeniedHidden=Request for fullscreen was denied because the document is no longer visible.
FullscreenDeniedContainerNotAllowed=Request for fullscreen was denied because at least one of the document’s containing elements is not an iframe or does not have an “allowfullscreen” attribute.
FullscreenDeniedNotInputDriven=Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler.
FullscreenDeniedNotHTMLSVGOrMathML=Request for fullscreen was denied because requesting element is not <svg>, <math>, or an HTML element.
FullscreenDeniedNotInDocument=Request for fullscreen was denied because requesting element is no longer in its document.