Bug 1324169 - VoidFunction should be moved to Function.webidl for Worklet global scopes, r=me
authorAndrea Marchesini <amarchesini@mozilla.com>
Sat, 17 Dec 2016 07:19:50 +0100
changeset 450697 0a54b96e3e7e4c07f2d55d4264e1d0bce9c37116
parent 450696 84af9d1e82d19d5b3942a5e76d1ab09a31936041
child 450698 108b378e35084591d5733281b8356b2908c68b3d
push id38944
push userbmo:leftysolara@gmail.com
push dateSun, 18 Dec 2016 16:01:15 +0000
reviewersme
bugs1324169
milestone53.0a1
Bug 1324169 - VoidFunction should be moved to Function.webidl for Worklet global scopes, r=me
dom/webidl/Function.webidl
dom/webidl/RTCPeerConnection.webidl
dom/worklet/AudioWorkletGlobalScope.cpp
dom/worklet/PaintWorkletGlobalScope.cpp
--- a/dom/webidl/Function.webidl
+++ b/dom/webidl/Function.webidl
@@ -7,8 +7,10 @@
  * http://www.whatwg.org/specs/web-apps/current-work/#functiocn
  *
  * © Copyright 2004-2011 Apple Computer, Inc., Mozilla Foundation, and
  * Opera Software ASA. You are granted a license to use, reproduce
  * and create derivative works of this document.
  */
 
 callback Function = any(any... arguments);
+
+callback VoidFunction = void ();
--- a/dom/webidl/RTCPeerConnection.webidl
+++ b/dom/webidl/RTCPeerConnection.webidl
@@ -4,17 +4,16 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/.
  *
  * The origin of this IDL file is
  * http://w3c.github.io/webrtc-pc/#interface-definition
  */
 
 callback RTCSessionDescriptionCallback = void (RTCSessionDescriptionInit description);
 callback RTCPeerConnectionErrorCallback = void (DOMError error);
-callback VoidFunction = void ();
 callback RTCStatsCallback = void (RTCStatsReport report);
 
 enum RTCSignalingState {
     "stable",
     "have-local-offer",
     "have-remote-offer",
     "have-local-pranswer",
     "have-remote-pranswer",
--- a/dom/worklet/AudioWorkletGlobalScope.cpp
+++ b/dom/worklet/AudioWorkletGlobalScope.cpp
@@ -1,17 +1,17 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "AudioWorkletGlobalScope.h"
 #include "mozilla/dom/AudioWorkletGlobalScopeBinding.h"
-#include "mozilla/dom/RTCPeerConnectionBinding.h" // For VoidFunction
+#include "mozilla/dom/FunctionBinding.h"
 
 namespace mozilla {
 namespace dom {
 
 AudioWorkletGlobalScope::AudioWorkletGlobalScope(nsPIDOMWindowInner* aWindow)
   : WorkletGlobalScope(aWindow)
 {
 }
--- a/dom/worklet/PaintWorkletGlobalScope.cpp
+++ b/dom/worklet/PaintWorkletGlobalScope.cpp
@@ -1,17 +1,17 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "PaintWorkletGlobalScope.h"
 #include "mozilla/dom/PaintWorkletGlobalScopeBinding.h"
-#include "mozilla/dom/RTCPeerConnectionBinding.h" // For VoidFunction
+#include "mozilla/dom/FunctionBinding.h"
 
 namespace mozilla {
 namespace dom {
 
 PaintWorkletGlobalScope::PaintWorkletGlobalScope(nsPIDOMWindowInner* aWindow)
   : WorkletGlobalScope(aWindow)
 {
 }