Backed out 2 changesets (bug 1297788) for fixing the commit message r=backout a=backout
authorCiure Andrei <aciure@mozilla.com>
Wed, 22 Nov 2017 17:39:06 +0200
changeset 702036 05a913c5cf3f9f9577d103352c6a593b8fa4fd60
parent 701872 5378dcb45044a160fad93b02eed0c617f3324dbc
child 702037 b743968ee22be9655b17b11dbc4d1baea44da5c9
child 702040 c3a5a33714c674121dc9bd01b6d022f288967a86
child 702048 bea41e1f764af1ad4206440506948aea0007388c
child 702049 bcbaada0cc802c51c9d445287e5e273e9c27ecfe
child 702064 0e9d8fb67dd855778880224f16fc237f854684cf
child 702076 f4e3ae0e8d7dd255f72f20764bb89164b1bcb94e
child 702161 7327a4f02cb59a811a500aebede1ae2b1d3b5eff
child 702162 efe440c26747cf12632237a50ed8931cacf707ff
child 702167 e20608325358b1d5e073782b6893dfd192bf2ce0
child 702249 9f7fb2a444103e35bdd0732c78515d63517f9bc2
child 702254 fb27e2a50e150e66852906a1b76ed842594e79ad
child 702290 8a482563f5cd5cb0911e2e9953ceb3c24c1ad1da
child 702498 d489be7113fe5252c448b7a14786dc62b8a27a7e
child 702507 57eab798d76b0956b491f89a185d2d164f66f161
child 702685 08d20f1fbcc61678731c8efe6f3e3c4288ea984b
child 702692 de9d997cda2a7c9f25c2b9626bd0c2f18be475e8
child 705786 15e983ad4dda2fe700a829e7b236b8a14d143ded
child 706102 b0eaa7eb2485f28379340f46d75c5c0feb9c5125
push id90357
push userbmo:eoger@fastmail.com
push dateWed, 22 Nov 2017 16:30:03 +0000
reviewersbackout, backout
bugs1297788
milestone59.0a1
backs out5a9be669bd5cf3113d5757b30b124460dde0378a
c8d3ad173dbcc225b69ec710bce5b5bec6b13955
Backed out 2 changesets (bug 1297788) for fixing the commit message r=backout a=backout Backed out changeset 5a9be669bd5c (bug 1297788) Backed out changeset c8d3ad173dbc (bug 1297788)
browser/themes/osx/browser.css
browser/themes/shared/compacttheme.inc.css
browser/themes/shared/urlbar-autocomplete.inc.css
browser/themes/windows/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -367,21 +367,21 @@ html|span.ac-tag {
   padding: 0 1px;
 }
 
 .ac-separator:not([selected=true]) {
   color: hsl(0, 0%, 50%);
 }
 
 .ac-url:not([selected=true]) {
-  color: #0a84ff;
+  color: hsl(210, 77%, 47%);
 }
 
 .ac-action:not([selected=true]) {
-  color: #12bc00;
+  color: hsl(178, 100%, 28%);
 }
 
 .ac-tags-text[selected] > html|span.ac-tag {
   background-color: hsl(0, 0%, 100%);
   color: hsl(210, 80%, 40%);
 }
 
 html|span.ac-emphasize-text-title,
--- a/browser/themes/shared/compacttheme.inc.css
+++ b/browser/themes/shared/compacttheme.inc.css
@@ -13,55 +13,50 @@
   --toolbar-gbimage: none;
   --toolbar-non-lwt-bgcolor: var(--toolbar-bgcolor);
   --toolbar-non-lwt-textcolor: var(--chrome-color);
   --toolbar-non-lwt-bgimage: none;
 
   --toolbarbutton-icon-fill-opacity: .7;
 
   --tab-line-color: #0a84ff;
-
-  --urlbar-popup-background: var(--url-and-searchbar-background-color);
-  --urlbar-popup-color: var(--chrome-color);
-  --urlbar-popup-highlight-background: var(--chrome-selection-background-color);
-  --urlbar-popup-highlight-color: var(--chrome-selection-color);
 }
 
 :root:-moz-lwtheme-brighttext {
   /* Chrome */
   --chrome-background-color: hsl(240, 5%, 5%);
   --chrome-color: rgb(249, 249, 250);
   --chrome-secondary-background-color: hsl(240, 1%, 20%);
   --toolbox-border-bottom-color: hsla(240, 5%, 5%, .1);
   --chrome-nav-bar-separator-color: rgba(0,0,0,.2);
   --chrome-nav-buttons-background: hsla(240, 5%, 5%, .1);
   --chrome-nav-buttons-hover-background: hsla(240, 5%, 5%, .15);
   --chrome-nav-bar-controls-border-color: hsla(240, 5%, 5%, .3);
   --chrome-selection-color: #fff;
-  --chrome-selection-background-color: #0060df;
+  --chrome-selection-background-color: #5675B9;
 
   /* Url and search bars */
   --url-and-searchbar-background-color: rgb(71, 71, 73);
   --url-and-searchbar-color: var(--chrome-color);
   --urlbar-separator-color: #5F6670;
 }
 
 :root:-moz-lwtheme-darktext {
   --url-and-searchbar-background-color: #fff;
 
   --chrome-background-color: #E3E4E6;
   --chrome-color: #18191a;
   --chrome-secondary-background-color: #f5f6f7;
   --toolbox-border-bottom-color: #cccccc;
   --chrome-nav-bar-separator-color: #B6B6B8;
-  --chrome-nav-buttons-background: #ffffff;
+  --chrome-nav-buttons-background: #ffffff; /* --theme-body-background */
   --chrome-nav-buttons-hover-background: #DADBDB;
   --chrome-nav-bar-controls-border-color: #ccc;
   --chrome-selection-color: #f5f7fa;
-  --chrome-selection-background-color: #0060df;
+  --chrome-selection-background-color: #4c9ed9;
 }
 
 .toolbarbutton-animatable-box[brighttext],
 toolbar[brighttext] .toolbarbutton-animatable-box,
 toolbar[brighttext] .toolbarbutton-1 {
   fill: rgb(249, 249, 250);
 }
 
@@ -113,13 +108,8 @@ toolbar[brighttext] .toolbarbutton-1 {
   background-color: rgba(255,255,255,.3);
 }
 
 .tab-icon-sound[soundplaying],
 .tab-icon-sound[muted] {
   filter: none !important; /* removes drop-shadow filter */
 }
 
-/* Improve contrast of URL bar notification "Change Settings" link */
-
-#search-suggestions-change-settings {
-  color: #0a84ff;
-}
--- a/browser/themes/shared/urlbar-autocomplete.inc.css
+++ b/browser/themes/shared/urlbar-autocomplete.inc.css
@@ -1,52 +1,29 @@
 %if 0
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 %endif
 
-:root {
-  --urlbar-popup-background: -moz-field;
-  --urlbar-popup-color: -moz-fieldtext;
-  --urlbar-popup-highlight-background: Highlight;
-  --urlbar-popup-highlight-color: HighlightText;
-}
-
 #treecolAutoCompleteImage {
   max-width: 36px;
 }
 
-#PopupAutoCompleteRichResult {
-  background: var(--urlbar-popup-background);
-  color: var(--urlbar-popup-color);
-}
-
 #PopupAutoCompleteRichResult .autocomplete-richlistbox {
   padding: 4px 3px;
-  background: transparent;
-  color: inherit;
 }
 
 #PopupAutoCompleteRichResult .autocomplete-richlistitem {
   min-height: 30px;
   font: message-box;
   border-radius: 2px;
   padding-inline-start: var(--item-padding-start);
   /* For the space after the autocomplete text we have to use a transparent
      border instead of padding, because the latter would considered part of the
      scrollable area when generating the overflow events that we use to
      constrain the autocomplete result item size. */
   border-inline-end: var(--item-padding-end) solid transparent;
 }
 
-#PopupAutoCompleteRichResult .autocomplete-richlistitem[selected] {
-  background: var(--urlbar-popup-highlight-background);
-  color: var(--urlbar-popup-highlight-color);
-}
-
 :root[uidensity=touch] #PopupAutoCompleteRichResult .autocomplete-richlistitem {
   min-height: 40px;
 }
-
-#PopupAutoCompleteRichResult .search-panel-input-value {
-  color: var(--urlbar-popup-color);
-}
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -632,21 +632,21 @@ html|span.ac-emphasize-text-url {
     color: hsl(0, 0%, 0%);
   }
 
   .ac-separator:not([selected=true]) {
     color: hsl(0, 0%, 50%);
   }
 
   .ac-url:not([selected=true]) {
-    color: #0a84ff;
+    color: hsl(210, 77%, 47%);
   }
 
   .ac-action:not([selected=true]) {
-    color: #12bc00;
+    color: hsl(178, 100%, 28%);
   }
 
   html|span.ac-tag {
     background-color: hsl(216, 0%, 88%);
     color: hsl(0, 0%, 0%);
   }
 
   .ac-tags-text[selected] > html|span.ac-tag {