Bug 1359855 - Whitelist DeveloperToolbar because of devtools now being lazy loaded. r=Mossop draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Tue, 18 Jul 2017 16:12:26 +0200
changeset 611340 04b416eff68cbc4aa3fc4b132c4c4268762b122b
parent 611339 13fea1fac16aba8763aefdc3077acb63e28fd01d
child 638128 f23c05de437b29d73202f4c2a4843dc73d6aa1cd
push id69183
push userbmo:poirot.alex@gmail.com
push dateWed, 19 Jul 2017 14:10:39 +0000
reviewersMossop
bugs1359855
milestone56.0a1
Bug 1359855 - Whitelist DeveloperToolbar because of devtools now being lazy loaded. r=Mossop DevTools are now lazy loaded, only when the tests start. But devtools codebase adds a "DeveloperToolbar" to browser window object, it may happen only after the test start and be reported as a leaked attribute not being cleaned up. This property should be considered as a regular browser global as it is not meant to be destroyed until the window closes. MozReview-Commit-ID: HIleXUMsCQU
testing/mochitest/browser-test.js
--- a/testing/mochitest/browser-test.js
+++ b/testing/mochitest/browser-test.js
@@ -211,17 +211,17 @@ Tester.prototype = {
 
     this.structuredLogger.info("*** Start BrowserChrome Test Results ***");
     Services.console.registerListener(this);
     this._globalProperties = Object.keys(window);
     this._globalPropertyWhitelist = [
       "navigator", "constructor", "top",
       "Application",
       "__SS_tabsToRestore", "__SSi",
-      "webConsoleCommandController",
+      "DeveloperToolbar",
     ];
 
     if (this.tests.length)
       this.waitForGraphicsTestWindowToBeGone(this.nextTest.bind(this));
     else
       this.finish();
   },