Bug 1285511 - Improve existing build flavor comments. r=sebastian
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 20 Jul 2016 15:48:53 -0700
changeset 391381 04533ff743455eb7ecdf1aa5fcf4f9935bf54d12
parent 391322 e5ebff5eb655ffefbc777d1ca424b56dc8ce0283
child 391382 6972bef6693c9a78d5e7bb45722fd4990d517f1d
push id23891
push userbmo:ttromey@mozilla.com
push dateFri, 22 Jul 2016 16:40:01 +0000
reviewerssebastian
bugs1285511
milestone50.0a1
Bug 1285511 - Improve existing build flavor comments. r=sebastian MozReview-Commit-ID: CRPqN07Pe9V
mobile/android/app/build.gradle
--- a/mobile/android/app/build.gradle
+++ b/mobile/android/app/build.gradle
@@ -40,30 +40,30 @@ android {
         release {
             shrinkResources true
             minifyEnabled true
             proguardFile "${topsrcdir}/mobile/android/config/proguard/proguard.cfg"
         }
     }
 
     productFlavors {
-        // For fast local development.  If you have an API 21 device, you should
-        // use this.
+        // For API 21+ - with multi dex, this will be faster for local development.
         local {
-            // Setting `minSdkVersion 21` allows the Android gradle plugin to
+            // For multi dex, setting `minSdkVersion 21` allows the Android gradle plugin to
             // pre-DEX each module and produce an APK that can be tested on
             // Android Lollipop without time consuming DEX merging processes.
             minSdkVersion 21
             dexOptions {
                 preDexLibraries true
                 multiDexEnabled true
             }
         }
-        // For local development on older devices.  Use this only if you only
-        // have a pre-API 21 device, or if you want to test API-specific things.
+        // For API < 21 - does not support multi dex because local development
+        // is slow in that case. Most builds will not require multi dex so this
+        // should not be an issue.
         localOld {
         }
         // Automation builds.
         automation {
         }
     }
 
     sourceSets {