Bug 1345791: ICE disconnect state is not a crash. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Wed, 29 Mar 2017 16:39:42 -0500
changeset 553354 0307be2d52b1a68e41290502164f5e83cb13c12f
parent 553344 4c7c05a49f3ce40aa0969beccb397380a8907f4a
child 622041 016d5652085add5385cf0d53b401a5de30f65944
push id51608
push userdrno@ohlmeier.org
push dateWed, 29 Mar 2017 21:40:09 +0000
reviewersbwc
bugs1345791
milestone55.0a1
Bug 1345791: ICE disconnect state is not a crash. r?bwc MozReview-Commit-ID: IwrWVvjkNmX
media/mtransport/nricectx.cpp
--- a/media/mtransport/nricectx.cpp
+++ b/media/mtransport/nricectx.cpp
@@ -1119,17 +1119,18 @@ void NrIceCtx::SetConnectionState(Connec
               time_delta.ToMilliseconds());
         } else {
           Telemetry::Accumulate(
               Telemetry::WEBRTC_ICE_ANSWERER_FAILURE_TIME,
               time_delta.ToMilliseconds());
         }
         break;
       case ICE_CTX_DISCONNECTED:
-        MOZ_CRASH("Transition from checking->disconnected should never happen");
+        // We get this every time an ICE disconnect gets reported.
+        // Do we want a Telemetry probe counting how often this happens?
         break;
       case ICE_CTX_CLOSED:
         // This doesn't seem to be used...
         break;
     }
   }
 
   MOZ_MTLOG(ML_INFO, "NrIceCtx(" << name_ << "): state " <<