Bug 1337154: More information in the crash reports when mismatching DLL versions are present. r=gw280
authorMilan Sreckovic <milan@mozilla.com>
Mon, 06 Feb 2017 17:29:25 -0500
changeset 479872 02e1f85fa542de5b676770da58e3c98996a234f2
parent 479871 9a949ee9c2cdbca560a511eddccd5b96490cf4b4
child 479873 2b5a94ac86a6bfbb4b17e1d02d41f202affeebc6
push id44393
push userVYV03354@nifty.ne.jp
push dateTue, 07 Feb 2017 13:53:48 +0000
reviewersgw280
bugs1337154
milestone54.0a1
Bug 1337154: More information in the crash reports when mismatching DLL versions are present. r=gw280 MozReview-Commit-ID: 7ygQzFVmBsq
widget/windows/GfxInfo.cpp
--- a/widget/windows/GfxInfo.cpp
+++ b/widget/windows/GfxInfo.cpp
@@ -588,17 +588,17 @@ GfxInfo::Init()
     // the driver version is less than knownSafeMismatchVersion.  See the
     // above comment about crashes with old mismatches.  If the GetDllVersion
     // call fails, we are not calling it a mismatch.
     if ((dllNumericVersion != 0 && dllNumericVersion != driverNumericVersion) ||
         (dllNumericVersion2 != 0 && dllNumericVersion2 != driverNumericVersion)) {
       if (driverNumericVersion < knownSafeMismatchVersion ||
           std::max(dllNumericVersion, dllNumericVersion2) < knownSafeMismatchVersion) {
         mHasDriverVersionMismatch = true;
-        gfxWarningOnce() << "Mismatched driver versions between the registry " << mDriverVersion[mActiveGPUIndex].get() << " and DLL(s) " << NS_ConvertUTF16toUTF8(dllVersion).get() << ", " << NS_ConvertUTF16toUTF8(dllVersion2).get() << " reported.";
+        gfxCriticalNoteOnce << "Mismatched driver versions between the registry " << mDriverVersion[mActiveGPUIndex].get() << " and DLL(s) " << NS_ConvertUTF16toUTF8(dllVersion).get() << ", " << NS_ConvertUTF16toUTF8(dllVersion2).get() << " reported.";
       }
     } else if (dllNumericVersion == 0 && dllNumericVersion2 == 0) {
       // Leave it as an asserting error for now, to see if we can find
       // a system that exhibits this kind of a problem internally.
       gfxCriticalErrorOnce() << "Potential driver version mismatch ignored due to missing DLLs " << NS_ConvertUTF16toUTF8(dllVersion).get() << " and " << NS_ConvertUTF16toUTF8(dllVersion2).get();
     }
   }