Bug 1477065 - Remove unreported GRAPHICS_SANITY_TEST_OS_SNAPSHOT telemetry histogram probe. r=jrmuizel
authorRyan Hunt <rhunt@eqrion.net>
Thu, 19 Jul 2018 14:30:37 -0500
changeset 822125 0192f91ce4da84dea97c5c47f00d6d77598cfb00
parent 822124 aa577f54b222917c77f65bb16215c9d91221098f
child 822126 80e4196368f2a2d6d6c61247e947053605701e82
push id117296
push userbmo:gl@mozilla.com
push dateTue, 24 Jul 2018 20:28:07 +0000
reviewersjrmuizel
bugs1477065
milestone63.0a1
Bug 1477065 - Remove unreported GRAPHICS_SANITY_TEST_OS_SNAPSHOT telemetry histogram probe. r=jrmuizel MozReview-Commit-ID: 99Kl2RP1UtG
toolkit/components/gfx/SanityTest.js
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/toolkit/components/gfx/SanityTest.js
+++ b/toolkit/components/gfx/SanityTest.js
@@ -40,24 +40,16 @@ const TEST_TIMEOUT = 4;
 
 // GRAPHICS_SANITY_TEST_REASON enumeration values.
 const REASON_FIRST_RUN = 0;
 const REASON_FIREFOX_CHANGED = 1;
 const REASON_DEVICE_CHANGED = 2;
 const REASON_DRIVER_CHANGED = 3;
 const REASON_AL_CONFIG_CHANGED = 4;
 
-// GRAPHICS_SANITY_TEST_OS_SNAPSHOT histogram enumeration values
-const SNAPSHOT_VIDEO_OK = 0;
-const SNAPSHOT_VIDEO_FAIL = 1;
-const SNAPSHOT_ERROR = 2;
-const SNAPSHOT_TIMEOUT = 3;
-const SNAPSHOT_LAYERS_OK = 4;
-const SNAPSHOT_LAYERS_FAIL = 5;
-
 function testPixel(ctx, x, y, r, g, b, a, fuzz) {
   var data = ctx.getImageData(x, y, 1, 1);
 
   if (Math.abs(data.data[0] - r) <= fuzz &&
       Math.abs(data.data[1] - g) <= fuzz &&
       Math.abs(data.data[2] - b) <= fuzz &&
       Math.abs(data.data[3] - a) <= fuzz) {
     return true;
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -11972,25 +11972,16 @@
     "record_in_processes": ["main", "content"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com","danderson@mozilla.com","msreckovic@mozilla.com"],
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 20,
     "releaseChannelCollection": "opt-out",
     "description": "Reports whether or not graphics drivers crashed during startup."
   },
-  "GRAPHICS_SANITY_TEST_OS_SNAPSHOT": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["gfx-telemetry-alerts@mozilla.com","danderson@mozilla.com","msreckovic@mozilla.com"],
-    "expires_in_version": "never",
-    "kind": "enumerated",
-    "n_values": 10,
-    "releaseChannelCollection": "opt-out",
-    "description": "Reports whether the graphics sanity test passed an OS snapshot test. 0=Pass, 1=Fail, 2=Error, 3=Timed out."
-  },
   "DEVTOOLS_MEMORY_TAKE_SNAPSHOT_COUNT": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "56",
     "kind": "count",
     "bug_numbers": [1221619],
     "description": "The number of heap snapshots taken by a user"
   },
   "DEVTOOLS_MEMORY_IMPORT_SNAPSHOT_COUNT": {
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -753,17 +753,16 @@
     "GEOLOCATION_ERROR",
     "GEOLOCATION_OSX_SOURCE_IS_MLS",
     "GEOLOCATION_WIN8_SOURCE_IS_MLS",
     "GFX_CONTENT_FAILED_TO_ACQUIRE_DEVICE",
     "GFX_CRASH",
     "GHOST_WINDOWS",
     "GRAPHICS_DRIVER_STARTUP_TEST",
     "GRAPHICS_SANITY_TEST",
-    "GRAPHICS_SANITY_TEST_OS_SNAPSHOT",
     "GRAPHICS_SANITY_TEST_REASON",
     "HISTORY_LASTVISITED_TREE_QUERY_TIME_MS",
     "HTTPCONNMGR_TOTAL_SPECULATIVE_CONN",
     "HTTPCONNMGR_UNUSED_SPECULATIVE_CONN",
     "HTTPCONNMGR_USED_SPECULATIVE_CONN",
     "HTTP_CACHE_DISPOSITION_2_V2",
     "HTTP_CACHE_ENTRY_ALIVE_TIME",
     "HTTP_CACHE_ENTRY_RELOAD_TIME",