b=621962 modifiy comment to address review on patch in 57536671a363; a=comment only change which blocks a hardblocker!
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 08 Feb 2011 17:30:42 -0500
changeset 62177 00fcffcbd800a18d163e0c2012693d5341724eb7
parent 62176 37094ed97c9e82d2161c21f9edc6c2a0b97438ab
child 62178 46b44e59d2c5cdaf673f59659833ea0c2548e686
push id1
push userroot
push dateMon, 20 Oct 2014 17:29:22 +0000
reviewerscomment
bugs621962
milestone2.0b12pre
b=621962 modifiy comment to address review on patch in 57536671a363; a=comment only change which blocks a hardblocker!
modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
--- a/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
+++ b/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp
@@ -495,17 +495,18 @@ nsIconChannel::Init(nsIURI* aURI)
     gtk_icon_source_free(icon_source);
   }
 
   GdkPixbuf *icon =
     gtk_icon_set_render_icon (icon_set, style, direction, state,
                               icon_size, gStockImageWidget, NULL);
   gtk_icon_set_unref(icon_set);
 
-  // gtk_icon_set_render_icon() never returns NULL, except when we have
+  // According to documentation, gtk_icon_set_render_icon() never returns
+  // NULL, but it does return NULL when we have the problem reported here:
   // https://bugzilla.gnome.org/show_bug.cgi?id=629878#c13
   if (!icon)
     return NS_ERROR_NOT_AVAILABLE;
   
   nsresult rv = moz_gdk_pixbuf_to_channel(icon, iconURI,
                                           getter_AddRefs(mRealChannel));
 
   g_object_unref(icon);