searching for reviewer(whimboo)
63e890c419e86a2693efb19d3691fa78d0629a0e: Bug 1485414 - Make lazy_static a dev dependency. r=whimboo
Andreas Tolfsen <ato@sny.no> - Wed, 22 Aug 2018 18:06:39 +0100 - rev 831056
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1485414 - Make lazy_static a dev dependency. r=whimboo This silences an unused macro_use warning at build time.
72a737dd8639ab72ddc96d1144f44b06507b915e: Bug 1484941 - Change ErrorStatus::{ScriptTimeout,Timeout} HTTP codes from 408 to 500. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 21 Aug 2018 14:28:56 +0100 - rev 831049
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1484941 - Change ErrorStatus::{ScriptTimeout,Timeout} HTTP codes from 408 to 500. r=whimboo Whilst it is logically correct to use 408 for the ErrorStatus::ScriptTimeout and ::Timeout errors, it causes a collision with HTTP semantics implement in HTTP clients. To support Keep-Alive we allow retries in HTTP clients and if a client sees code 408 it thinks that the server has gone away and retries the request. This causes WebDriverCommand::ExecuteScript, ::Get, and ::Refresh commands to be sent twice with some HTTP clients. This is a backwards incompatible change to WebDriver in order to not break HTTP/1.1 Keep-Alive.
51acbb8dc5013a729f91bb6127d7234be010904b: Bug 1484157 - Add bounds check tests for WebDriver pause action. r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 17 Aug 2018 10:18:01 +0100 - rev 830547
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484157 - Add bounds check tests for WebDriver pause action. r=whimboo The pause action takes an unsigned integer as input, but it was discovered in https://github.com/mozilla/geckodriver/issues/1355 that chromedriver accepts floating point values. To achieve conformance in this area, this will test various allowed and disallowed values so that the pause action's bounds are properly checked.
3a51308cf76adbded60eea9900faeefb16674695: Bug 1465046 - Remove ProcessHandler.waitForFinish(). r=whimboo
Akshay Chiwhane <achiwhane@gmail.com> - Mon, 20 Aug 2018 21:28:21 +0200 - rev 830354
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1465046 - Remove ProcessHandler.waitForFinish(). r=whimboo
f334098ab7bc805488005b3f09537e59a953cccb: Bug 1484153 - Drop duplicate outerWindowID logging in listener.js. r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 17 Aug 2018 09:46:46 +0100 - rev 829948
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1484153 - Drop duplicate outerWindowID logging in listener.js. r=whimboo When receiving observer notifications during navigation, we log the outerWindowID: logger.debug(`Received observer notification ${topic} for ${winID}`); This is no longer necessary as https://bugzilla.mozilla.org/show_bug.cgi?id=1464469 introduced the outerWindowID as a prefix to all log messages originating from this frame script.
131559bd826a1ea9c58f63de32a62eb67d1000bf: Bug 1482829 - Track Marionette logger verbosity with Log#manageLevelFromPref. r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 13 Aug 2018 13:59:39 +0100 - rev 829947
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1482829 - Track Marionette logger verbosity with Log#manageLevelFromPref. r=whimboo This patch adopts Logger#managerLevelFromPref from Log.jsm to set and keep track of the Marionette logger's verbosity. This has the advantage that we do not have to roll separate implementations of Log for the child- and parent processes. It also has the upside that the log level will be reflected when changed at runtime through the use of an observer.
2db292e66641b911f3663e5a29fada5da5c62f16: Bug 1482829 - Convert logging::Level into mozprofile::preferences::Pref. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 14 Aug 2018 15:38:43 +0100 - rev 829946
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1482829 - Convert logging::Level into mozprofile::preferences::Pref. r=whimboo In order to facilitate the use of Log.jsm's Logger#manageLevelFromPref, geckodriver needs to ensure that the input value for the marionette.log.level preference conforms to the variants in the Log.Level enum. This patch implements the Into<T> conversion from geckodriver's logging::Level into mozprofile::preferences::Pref by way of a new function to_gecko(), that ensures the preference value is correctly formatted. Logger#manageLevelFromPref expects a string value such as "Info", which exactly matches Log.Level's own properties. It is in other words case sensitive, and this ensures that Marionette no longer has to case convert the input data.
7f8f670aefa5e065eafc4bfc8f27354cbf77b0b6: Bug 1484161 - Replace nsITimer with Sleep for dispatchPause. r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 17 Aug 2018 10:30:36 +0100 - rev 829944
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1484161 - Replace nsITimer with Sleep for dispatchPause. r=whimboo
c8fa2901262d8e063b3b8f4d6c476888666c23ea: Bug 1483288 - Avoid "as i64" coercion of marionette.port pref value. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 14 Aug 2018 18:15:19 +0100 - rev 829461
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483288 - Avoid "as i64" coercion of marionette.port pref value. r=whimboo
0c727114d3642b64f0e8138b0b83b1093d3e03aa: Bug 1483288 - Provide more number conversions for mozprofile::preferences::PrefValue. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 14 Aug 2018 18:12:05 +0100 - rev 829460
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483288 - Provide more number conversions for mozprofile::preferences::PrefValue. r=whimboo Allow i8, u8, i16, u64, i32, and u32 to be implicitly converted into PrefValue::Int. u64 is not supported because it would overflow, so this still needs to be handled manually. geckodriver stores the port number as u8 and this will allow it to implicitly convert it to PrefValue::Int without using the unsafe "as i64" coercion.
e7eb8b37d85e58a3890867ffa4704dcf2085cdb7: Bug 1478558 - Remove usage of http://mozqa.com/ in services/sync/tests/tps/test_tabs.js r=whimboo,tcsc
Mark Hammond <mhammond@skippinet.com.au> - Wed, 08 Aug 2018 20:59:24 +0000 - rev 827900
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1478558 - Remove usage of http://mozqa.com/ in services/sync/tests/tps/test_tabs.js r=whimboo,tcsc MozReview-Commit-ID: Gd8qmfBWf8u Differential Revision: https://phabricator.services.mozilla.com/D2547
932c1b395217dae543c85e21ec4972d02701cff9: Bug 1443572 - Disable Photon onboarding experience for Marionette and geckodriver r?whimboo draft
Aditya Khadse <akk5597@gmail.com> - Thu, 09 Aug 2018 18:50:41 +0530 - rev 827850
Push 118600 by bmo:akk5597@gmail.com at Thu, 09 Aug 2018 13:21:42 +0000
Bug 1443572 - Disable Photon onboarding experience for Marionette and geckodriver r?whimboo MozReview-Commit-ID: HiT4QaV6FPg
e669c95818bdd82332bcfe99f8a1d7a73e116639: Bug 1480612: Test Register Application Restart more thoroughly. r=whimboo
Adam Gashlin <agashlin@mozilla.com> - Mon, 06 Aug 2018 14:40:00 -0700 - rev 827416
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1480612: Test Register Application Restart more thoroughly. r=whimboo
864df2345f9bb0f94be9a5a86c4ed0bb19609ca8: Bug 1478094 - [marionette] Update crash unit tests to make use of about:crashparent and about:crashcontent r=whimboo
Venkatesh Pitta <venkateshpitta@gmail.com> - Sat, 04 Aug 2018 00:45:53 +1000 - rev 827006
Push 118436 by bmo:ntim.bugs@gmail.com at Mon, 06 Aug 2018 17:34:29 +0000
Bug 1478094 - [marionette] Update crash unit tests to make use of about:crashparent and about:crashcontent r=whimboo MozReview-Commit-ID: H9LBBD7t9vL
1a0c506d69a80ee792d73b4090eeb5e755f17bf8: Bug 1434281 - also delete local/cache profile directory from refresh test, r=whimboo
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 02 Aug 2018 18:54:28 +0000 - rev 826097
Push 118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1434281 - also delete local/cache profile directory from refresh test, r=whimboo Ensure local profile directory is also deleted in test teardown. Differential Revision: https://phabricator.services.mozilla.com/D2671
da105ff7490c3a866170a45f7f19fecd95f5b359: Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r=whimboo
vinicius <viniciuscosta0197@gmail.com> - Wed, 01 Aug 2018 19:04:26 -0300 - rev 825847
Push 118186 by bmo:bpostelnicu@mozilla.com at Thu, 02 Aug 2018 13:24:00 +0000
Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r=whimboo MozReview-Commit-ID: 1lZYKHlhhpn
b5d9ec944fe0e33bdea383a1f0114ada1dcabdc3: Bug 1470659 - Parametrize capabilities tests. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:36:50 +0100 - rev 825618
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Parametrize capabilities tests. r=whimboo To be able to ignore tests for individual capabilities we need to parametrize these tests. geckodriver now supports setWindowRect, but fails the proxy capability test because it is for some reason not propagated back.
0ad9872c27e07e5f9dbbb62ec41e5be180e98f05: Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:35:23 +0100 - rev 825617
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo For similar reasons as for platformName, tests for configuring the timeouts object do not belong in the same parent test as those for response body structure.
a3d141d56e531d882111ccf569c76427091ed088: Bug 1470659 - Move platformName test to separate file. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:33:50 +0100 - rev 825616
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Move platformName test to separate file. r=whimboo Specific tests for the platformName capability do not belong in the test for the response body structure.
203d1449aa592dfa527ed6e7a79d07dcaad8018f: Bug 1470659 - Add setWindowRect capability to Marionette. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:30:55 +0100 - rev 825614
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Add setWindowRect capability to Marionette. r=whimboo The setWindowRect capability is mandated by the WebDriver standard and is an indication whether the driver supports manipulating the window dimensions and position. This will always be true for Firefox and always false for Fennec.
39954f25c48e32f2393d3a4550bd3a85f117d37f: Bug 1470659 - Simplify Marionette capability parsing. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:29:39 +0100 - rev 825613
Push 118150 by maglione.k@gmail.com at Thu, 02 Aug 2018 04:47:08 +0000
Bug 1470659 - Simplify Marionette capability parsing. r=whimboo Change the switch-statement to only do assertions, and replace the v variable with any parsed values before writing it to the matched set of capabilities in one location.
ea17a96c5eb03ae73d347bbe5b4c6661c7aba341: Bug 1451725 - Remove deprecated WebDriver Commands r=whimboo
Venkatesh Pitta <venkateshpitta@gmail.com> - Fri, 27 Jul 2018 11:27:22 +1000 - rev 825489
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1451725 - Remove deprecated WebDriver Commands r=whimboo MozReview-Commit-ID: 7PXrlwyiFvN
cb25e87905b187e28896fa4862c220014a776c52: Bug 1319793 - [marionette harness tests] Default to not swallow stdout from pytest. r=whimboo
Petru Gurita <petru.gurita1@gmail.com> - Wed, 25 Jul 2018 09:00:42 +0300 - rev 825469
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1319793 - [marionette harness tests] Default to not swallow stdout from pytest. r=whimboo Added the flag 'capture --no' to the harness_unit tests. Stdout is now displayed by default. MozReview-Commit-ID: HZj3vntLcKI
6927627378c90f41a7ef3f2b716cbe516620a07e: Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r?whimboo draft
vinicius <viniciuscosta0197@gmail.com> - Wed, 01 Aug 2018 19:04:26 -0300 - rev 825466
Push 118128 by bmo:viniciuscosta0197@gmail.com at Wed, 01 Aug 2018 22:14:04 +0000
Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r?whimboo MozReview-Commit-ID: 1lZYKHlhhpn
981424e5bb13f5792590b0e2f1b4db6d06511094: Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r?whimboo draft
vinicius <viniciuscosta0197@gmail.com> - Wed, 01 Aug 2018 19:04:26 -0300 - rev 825465
Push 118127 by bmo:viniciuscosta0197@gmail.com at Wed, 01 Aug 2018 22:08:06 +0000
Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r?whimboo MozReview-Commit-ID: 1lZYKHlhhpn
6069c381aa8e2443c6317441f4bd42014dadf61e: Bug 1478979 - Disallow pageLoadStrategy to be null. r=whimboo
Andreas Tolfsen <ato@sny.no> - Fri, 27 Jul 2018 14:17:59 +0100 - rev 823815
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1478979 - Disallow pageLoadStrategy to be null. r=whimboo Capabilities matching is now done in geckodriver and Marionette receives the negotiated set of capabilities, so there is no need to derive default values in case the value is null.
036eaf559f72ab3054b2fa1699feb748cc94431d: Bug 1400233 - Drop ContentWebElement.LegacyIdentifier key from Marionette. r=ato,whimboo
Wambui <wambui.dev@gmail.com> - Fri, 27 Jul 2018 16:04:05 +0100 - rev 823566
Push 117726 by bmo:mstriemer@mozilla.com at Fri, 27 Jul 2018 16:23:35 +0000
Bug 1400233 - Drop ContentWebElement.LegacyIdentifier key from Marionette. r=ato,whimboo Remove the legacy key that Marionette uses to identify web elements.
100697883c7d6cebd095c0c738755cab18136bfc: Bug 1477475 - Drop legacy Marionette capabilities duplication. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:25:52 +0100 - rev 822565
Push 117401 by rwood@mozilla.com at Wed, 25 Jul 2018 13:25:47 +0000
Bug 1477475 - Drop legacy Marionette capabilities duplication. r=whimboo geckodriver currently writes a legacy capabilities structure to the WebDriver:NewSession command it uses on creating a new WebDriver session which duplicates the top-level object: {capabilities: {<caps>, desiredCapabilities: <caps>}} Where caps can look something like: {acceptInsecureCerts: true, pageLoadStrategy: "normal", ...} Marionette has picked up the top-level "capabilities" key for a very long time now, and there is no longer any need to duplicate the body.
ffa28183855bf5000a563d9e467c967cfeebc2e4: Bug 1319793 - [marionette harness tests] Default to not swallow stdout from pytest. r?whimboo draft
Petru Gurita <petru.gurita1@gmail.com> - Wed, 25 Jul 2018 09:00:42 +0300 - rev 822290
Push 117350 by bmo:petru.gurita1@gmail.com at Wed, 25 Jul 2018 06:07:00 +0000
Bug 1319793 - [marionette harness tests] Default to not swallow stdout from pytest. r?whimboo Added the flag 'capture --no' to the harness_unit tests. Stdout is now displayed by default. MozReview-Commit-ID: HZj3vntLcKI
ea7b4774caec7c18cbf449c79b4356cf3fb36db6: Bug 1319793 -[marionette harness tests] Default to not swallow stdout from pytest. r?whimboo draft
Petru Gurita <petru.gurita1@gmail.com> - Wed, 25 Jul 2018 09:00:42 +0300 - rev 822289
Push 117349 by bmo:petru.gurita1@gmail.com at Wed, 25 Jul 2018 06:02:42 +0000
Bug 1319793 -[marionette harness tests] Default to not swallow stdout from pytest. r?whimboo Added the flag 'capture --no' to the harness_unit tests. Stdout is now displayed by default. MozReview-Commit-ID: HZj3vntLcKI
59ab6acdee53af4b2b2ac27e2d7cb57c131e9530: Bug 1477978 - Swallow SessionNotCreatedException on session.end(). r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 24 Jul 2018 13:25:23 +0100 - rev 822020
Push 117256 by igorostizaga@mozilla.com at Tue, 24 Jul 2018 14:44:55 +0000
Bug 1477978 - Swallow SessionNotCreatedException on session.end(). r=whimboo Subsequent calls to session.end() should not result in SessionNotCreatedException being raised.
efa8f3f64f1308faad9a9241c604a735fe0df050: Bug 1452179: [mozharness] Don't set virtualenv_modules in talos, since it is unused; r=whimboo
Tom Prince <mozilla@hocat.ca> - Wed, 18 Apr 2018 15:52:14 -0600 - rev 818069
Push 116246 by bmo:tom@mozilla.com at Fri, 13 Jul 2018 20:48:08 +0000
Bug 1452179: [mozharness] Don't set virtualenv_modules in talos, since it is unused; r=whimboo Talos uses an in-tree module that it installs in code, ignoring the config value. Differential Revision: https://phabricator.services.mozilla.com/D986
b5231e22ad76ca0c9bcb238293b5e16cc4a11b88: Bug 1452179: [mozharness] Don't special case the path to mozinstall on windows; r=whimboo
Tom Prince <mozilla@hocat.ca> - Mon, 16 Apr 2018 01:23:04 -0600 - rev 818068
Push 116246 by bmo:tom@mozilla.com at Fri, 13 Jul 2018 20:48:08 +0000
Bug 1452179: [mozharness] Don't special case the path to mozinstall on windows; r=whimboo New versions of pip don't install entrypoint scripts with a `-script.py` on windows. Instead, just call the bare script name everywhere. On unix-like systems, this uses the shebang; on Windows, this executes the `.exe` wrapper. Differential Revision: https://phabricator.services.mozilla.com/D967
8eab40c279038941d767790b2d2cf82b21634ff0: Bug 1452490 - Remove marionetteScriptFinished. r=whimboo
Venkatesh Pitta <venkateshpitta@gmail.com> - Sun, 08 Jul 2018 14:52:49 +1000 - rev 815514
Push 115523 by bmo:tpodder@mozilla.com at Mon, 09 Jul 2018 00:41:46 +0000
Bug 1452490 - Remove marionetteScriptFinished. r=whimboo MozReview-Commit-ID: CdQCmtaodww
c5adc3b888b932065842854e09027cc981b8662d: Bug 1121705 - Look at window handles decrement when closing tab. r=whimboo
Andreas Tolfsen <ato@sny.no> - Wed, 04 Jul 2018 16:36:05 +0100 - rev 815175
Push 115462 by bmo:mreschenberg@berkeley.edu at Fri, 06 Jul 2018 22:06:52 +0000
Bug 1121705 - Look at window handles decrement when closing tab. r=whimboo When Puppeteer opens a new tab using various strategies it relies on the list of window handles increasing. When performing the reverse operation of closing a tab, it looks at the length of <tab> chrome elements in the UI. This changes the close operation to use the same mechanism as opening a new tab to determine if the tab has been closed. This seems to be as reliable as looking at the number of <tab> elements. As part of a forthcoming window tracking refactoring of Marionette (https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking), the list of window handles will be made even more reliable: a content browser will not appear in the window handle list until both the tab and it's linked content browser has been created and properly initialised. MozReview-Commit-ID: FY5vGBpn64R
d337c0e29514d0860cfff7b106359e65f836c758: Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Wed, 04 Jul 2018 16:36:05 +0100 - rev 814592
Push 115273 by bmo:ato@sny.no at Thu, 05 Jul 2018 18:36:16 +0000
Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo When Puppeteer opens a new tab using various strategies it relies on the list of window handles increasing. When performing the reverse operation of closing a tab, it looks at the length of <tab> chrome elements in the UI. This changes the close operation to use the same mechanism as opening a new tab to determine if the tab has been closed. This seems to be as reliable as looking at the number of <tab> elements. As part of a forthcoming window tracking refactoring of Marionette (https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking), the list of window handles will be made even more reliable: a content browser will not appear in the window handle list until both the tab and it's linked content browser has been created and properly initialised. MozReview-Commit-ID: FY5vGBpn64R
f2e3e9a3e164fa6ceaf70a9693cfd5aaddd17503: Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Wed, 04 Jul 2018 16:36:05 +0100 - rev 814495
Push 115235 by bmo:ato@sny.no at Thu, 05 Jul 2018 14:03:34 +0000
Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo When Puppeteer opens a new tab using various strategies it relies on the list of window handles increasing. When performing the reverse operation of closing a tab, it looks at the length of <tab> chrome elements in the UI. This changes the close operation to use the same mechanism as opening a new tab to determine if the tab has been closed. This seems to be as reliable as looking at the number of <tab> elements. As part of a forthcoming window tracking refactoring of Marionette (https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking), the list of window handles will be made even more reliable: a content browser will not appear in the window handle list until both the tab and it's linked content browser has been created and properly initialised. MozReview-Commit-ID: FY5vGBpn64R
c85357d0eaf2bcd07ab37fca66efd74ba7c5fb24: Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Wed, 04 Jul 2018 16:36:05 +0100 - rev 814494
Push 115234 by bmo:ato@sny.no at Thu, 05 Jul 2018 14:01:53 +0000
Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo When Puppeteer opens a new tab using various strategies it relies on the list of window handles increasing. When performing the reverse operation of closing a tab, it looks at the length of <tab> chrome elements in the UI. This changes the close operation to use the same mechanism as opening a new tab to determine if the tab has been closed. This seems to be as reliable as looking at the number of <tab> elements. As part of a forthcoming window tracking refactoring of Marionette (https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking), the list of window handles will be made even more reliable: a content browser will not appear in the window handle list until both the tab and it's linked content browser has been created and properly initialised. MozReview-Commit-ID: FY5vGBpn64R
d3b806f8bdd19d011f3c8680fd3a6f00e8882772: Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Wed, 04 Jul 2018 16:36:05 +0100 - rev 814129
Push 115116 by bmo:ato@sny.no at Wed, 04 Jul 2018 15:40:56 +0000
Bug 1121705 - Look at window handles decrement when closing tab. r?whimboo When Puppeteer opens a new tab using various strategies it relies on the list of window handles increasing. When performing the reverse operation of closing a tab, it looks at the length of <tab> chrome elements in the UI. This changes the close operation to use the same mechanism as opening a new tab to determine if the tab has been closed. This seems to be as reliable as looking at the number of <tab> elements. As part of a forthcoming window tracking refactoring of Marionette (https://bugzilla.mozilla.org/show_bug.cgi?id=marionette-window-tracking), the list of window handles will be made even more reliable: a content browser will not appear in the window handle list until both the tab and it's linked content browser has been created and properly initialised. MozReview-Commit-ID: FY5vGBpn64R
16ba5f9ae84eb89c6755b7dd484f666e1508c000: Bug 1470646 - Update Wd tests to use WebDriver conforming platformName. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:06:21 +0100 - rev 813816
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Update Wd tests to use WebDriver conforming platformName. r=whimboo MozReview-Commit-ID: LCi2BgdMQLb
bcf9a8c4d677a51fdc725aa1dc114b8690a432c5: Bug 1470646 - Update Fxfn tests to use WebDriver conforming platformName. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:03:52 +0100 - rev 813815
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Update Fxfn tests to use WebDriver conforming platformName. r=whimboo MozReview-Commit-ID: 1GYS453pA5D
6ca4afd1f8626951c4c8862b972f19af95002853: Bug 1470646 - Update Mn and Fxfn tests to use WebDriver conforming platformName. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:01:54 +0100 - rev 813814
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Update Mn and Fxfn tests to use WebDriver conforming platformName. r=whimboo MozReview-Commit-ID: 387jlJCbV59
59e8fd258b33f49b420de042934dd17f0445ffc1: Bug 1470646 - Return platformName as recommended by WebDriver. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 23 Jun 2018 14:31:00 +0100 - rev 813813
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Return platformName as recommended by WebDriver. r=whimboo The WebDriver standard recommends that we return one of "windows", "mac", or "linux". Additionally Marionette supports Fennec, for which we return "android": this is fine because the specification does not yet cover mobile browsers. MozReview-Commit-ID: EgZ9UKrbsrd
ba1bd1e1c47f353736314dfecd9f65f9fb219b28: Bug 1470646 - Modularise capabilities module. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 26 Jun 2018 17:15:28 +0100 - rev 813812
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Modularise capabilities module. r=whimboo This removes the "session." prefixed global export type in favour of individually exported types. MozReview-Commit-ID: 3DHTrJsy2IN
4556c3569ccda353457eb6e82f5abb745e9f6584: Bug 1470646 - Rename session module to capabilities. r=whimboo
Andreas Tolfsen <ato@sny.no> - Tue, 26 Jun 2018 17:13:35 +0100 - rev 813811
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Rename session module to capabilities. r=whimboo MozReview-Commit-ID: 4hQN2gv3HDd
da9689d7801b57bc79b6a82fa1b7678d44bed170: Bug 1470646 - Increase wdspec long timeout to three minutes. r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 02 Jul 2018 12:50:13 +0100 - rev 813810
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Increase wdspec long timeout to three minutes. r=whimboo The long timeout for WPT wdspec tests is currently two minutes, but with modifications to make more session tests run in Firefox, it has been discovered that the long timeout is not sufficient time for Firefox to consistently run the New Session command tests in automation without timing out. This increases the long timeout to three minutes (180 seconds). MozReview-Commit-ID: A8A4zecOwES
608e35dbe664777332f5ed774c521678df32caf7: Bug 1470646 - Silence missing nodeType property warning. r=whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 23 Jun 2018 14:00:50 +0100 - rev 813809
Push 115012 by bmo:jgilbert@mozilla.com at Tue, 03 Jul 2018 22:24:25 +0000
Bug 1470646 - Silence missing nodeType property warning. r=whimboo If val does not have a property nodeType, a warning is emitted to the browser console. This is observable when running the xpcshell unit tests because we mock out val without a nodeType property. MozReview-Commit-ID: GzqMoJQQdF8
dc59f5acbebf713478a759c3b1fda67327195d65: Bug 1470646 - Update Wd tests to use WebDriver conforming platformName. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:06:21 +0100 - rev 813594
Push 114929 by bmo:ato@sny.no at Tue, 03 Jul 2018 11:58:17 +0000
Bug 1470646 - Update Wd tests to use WebDriver conforming platformName. r?whimboo MozReview-Commit-ID: LCi2BgdMQLb
541f0cc2ef7a707ab605e56269231dc3aaac824f: Bug 1470646 - Update Fxfn tests to use WebDriver conforming platformName. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:03:52 +0100 - rev 813593
Push 114929 by bmo:ato@sny.no at Tue, 03 Jul 2018 11:58:17 +0000
Bug 1470646 - Update Fxfn tests to use WebDriver conforming platformName. r?whimboo MozReview-Commit-ID: 1GYS453pA5D
f8800eebc06523680e96dece0acd4e5eda306200: Bug 1470646 - Update Mn and Fxfn tests to use WebDriver conforming platformName. r?whimboo draft
Andreas Tolfsen <ato@sny.no> - Sun, 24 Jun 2018 14:01:54 +0100 - rev 813592
Push 114929 by bmo:ato@sny.no at Tue, 03 Jul 2018 11:58:17 +0000
Bug 1470646 - Update Mn and Fxfn tests to use WebDriver conforming platformName. r?whimboo MozReview-Commit-ID: 387jlJCbV59