Bug 1483760 Additionally, pass environment variables to cargo if we are not compiling on Windows r=ted Previously we weren't passing the variables if we were compiling for Windows when really we only want to do it if we're compiling with MSVC/clang-cl. The MinGW-Clang build needs this. Differential Revision: https://phabricator.services.mozilla.com/D3470

Bug 1484485: Create state dir and install node / stylo stuff in bootstrap's non-interactive mode. r=ted The state directory is in $HOME by default, so should be fine to just create it if we get --no-interactive I think. Differential Revision: https://phabricator.services.mozilla.com/D3838

Bug 1482272 - Don't set -DEBUG twice on Windows links. r=ted We already append MOZ_DEBUG_LDFLAGS when MOZ_DEBUG_SYMBOLS is set.

Bug 1413728: Windows DMD builds don't need special LDFLAGS behavior. r=ted

Bug 1440282 - Update breakpad to revision 1459e5df74dd03b7d3d473e6d271413d7aa98a88 r=ted This adds support for the DW_AT_ranges attribute when dumping out symbols and adds basic support for AArch64 (64-bit ARM) on Windows in the minidump processor. Differential Revision: https://phabricator.services.mozilla.com/D3443

Bug 1478813 - Auto-generate ServoStyleConsts. r=xidorn,ted Differential Revision: https://phabricator.services.mozilla.com/D2447

Bug 1478813 - Auto-generate ServoStyleConsts. r=xidorn,ted Differential Revision: https://phabricator.services.mozilla.com/D2447

Bug 1482299 - Replace libxul.mk with OBJDIR_PP_FILES. r=ted,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D3371

Bug 1481638 Do not pass CFI sanitization flags to MOZ_CARGO_WRAP_LDFLAGS r=ted MozReview-Commit-ID: C85uJBNugiY Differential Revision: https://phabricator.services.mozilla.com/D3044

Bug 1474028 - Add a way to exclude libraries from the default build. r=ted MozReview-Commit-ID: MVfplx9lN2

Bug 1478813 - Add cbindgen toolchain job and install via bootstrap. r=ted And require it for taskcluster build already, because it doesn't harm and lets me put all the yml changes in the same commit. I gave up cross-compiling for OSX after a few tries and after realizing it wasn't enough with cctools and such, but that I also needed the Mac SDK, for which I don't have permission... Differential Revision: https://phabricator.services.mozilla.com/D2664

Bug 1482442 - Do not check for gamepad related headers in an artifact build. r=ted,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D3119

Bug 1474028 - Add a way to exclude libraries from the default build. r=ted MozReview-Commit-ID: MVfplx9lN2

Bug 1481619: Upload symbols for the main Android builds r=ted Differential Revision: https://phabricator.services.mozilla.com/D2925

Bug 1450078 - Require rust 1.28 in configure. r=ted,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D2889

Bug 1481378 - Simplify mozconfig.linux32. r=ted All CI builds for linux32 have been running on 64-bits hosts for a long while now, and there are no 32-bits hosts left. We can remove the special-casing that makes the linux32 builds behave differently depending on the bit-width of the host. Furthermore, configure has been able to deal with adding -m32 on its own, so we don't need to add it to $CC/$CXX manually anymore.

Bug 1426176 - Add symbols file for Clang ASan runtime on Windows. r=ted MozReview-Commit-ID: 4P3mwZNP8cY

Bug 1473786 - Enable LTO on macOS builds. r=ted

Bug 1466537: Disable full crashsymbols by branch r=ted Differential Revision: https://phabricator.services.mozilla.com/D1558

Bug 1426176 - Add symbols file for Clang ASan runtime on Windows. r=ted MozReview-Commit-ID: 4P3mwZNP8cY

Bug 1426176 - Add symbols file for Clang ASan runtime on Windows. r?ted MozReview-Commit-ID: 4P3mwZNP8cY

Bug 1426176 - Add symbols file for Clang ASan runtime on Windows. r?ted MozReview-Commit-ID: 4P3mwZNP8cY

Bug 1473423: Allow test symbols to be included in full symbol archive in try builds; r=ted This patch moves the logic for include/exclude/compress from the makefile into symbols_archive.py, and adds an additional check to the full-archive case to allow the inclusion of test symbols in try builds.

Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library r=ted - In bug 1356382, jsoncpp was moved from toolkit/crashreporter to toolkit/components - update-jsoncpp.sh has been moved to the components directory and updated to match the new directories. MozReview-Commit-ID: Cl71Dwoyn0N

Bug 1476174 - Fix-up the change from bug 1474024 to avoid creating lto object files in installed locations. r=ted

Bug 1334940 - Re-enable SCCACHE for linux64-ccov. r=ted MozReview-Commit-ID: 6BQt984Rl39

Bug 1468273 - Fix flake8/pep8 issues by hand in gfx/ r=ted MozReview-Commit-ID: BFnq9JpWZxq

Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP

Bug 1475999 - Use the classic output style with pytest; r=ted MozReview-Commit-ID: FvZjDhPl3RX

Bug 1475999 - Use the classic output style with pytest; r?ted MozReview-Commit-ID: FvZjDhPl3RX

Bug 1473786 - Enable LTO on macOS builds. r=ted

Bug 1473786 - Enable LTO on macOS builds. r=ted

Bug 1459077 - Install known working pip and virtualenv; r=ted Previously, we installed the latest version of pip and virtualenv. This commit pins the pip and virtualenv version so we install known working versions (pip 10 breaks the image build for some reason). MozReview-Commit-ID: hOAMencdcr

Bug 1458700: [python] Vendor attrs; r=dustin,ted Differential Revision: https://phabricator.services.mozilla.com/D1124

Bug 1455127 - Remove --package from upload.py; r=ted The argument is never used in the local file copying function. So let's nuke the argument. MozReview-Commit-ID: JeU4LaVvGD7

Bug 1455127 - Remove --properties-file from upload.py; r=ted This was only used for the remote server case. That code was recently deleted. MozReview-Commit-ID: 7usqWZ7CuBR

Bug 1455127 - Remove functionality for uploading to a server; r=ted With the transition to Taskcluster, "uploads" are artifacts in a local directory. So we don't need to support uploading to a remote server using SCP. This commit removes all the code to support uploading to a remote server. And since property files were only written out for the remote case, all that code can be deleted as well. Since UPLOAD_HOST no longer means anything, we no longer set it in mozharness configs. MozReview-Commit-ID: 66gkM8erkGk

Bug 1455111 - Remove references to ccache from PATH; r=ted We should always be using sccache these days. We shouldn't need ccache on PATH in any modern builds. MozReview-Commit-ID: 1czGAcHhRGC

Bug 1455111 - Remove references to /home/ctlbld; r=ted This is a buildbot holdover and should no longer be relevant in a Taskcluster/Docker world. MozReview-Commit-ID: NeIN0jnW5I

Bug 1455111 - Remove references to /tools/git; r=ted First, we shouldn't need Git for most jobs. Second, this path shouldn't exist in a post-buildbot world using Taskcluster/Docker. MozReview-Commit-ID: 7S8jsPiD2dT

Bug 1455111 - Remove references to /tools/python27; r=ted This path should be dead in a post-buildbot Taskcluster/Docker world. MozReview-Commit-ID: KRsRlfFADvD

Bug 1455111 - Remove references to /tools/python27-mercurial; r=ted This path shouldn't exist in a post buildbot world. MozReview-Commit-ID: 1O7A4xAonHz

Bug 1455111 - Remove references to /tools/gcc-4.3.3; r=ted This path was used on buildbot. It doesn't exist in a Taskcluster/Docker world. MozReview-Commit-ID: KHeRGcfIftO

Bug 1334940 - Re-enable SCCACHE for linux64-ccov. r=ted MozReview-Commit-ID: 6BQt984Rl39

Bug 1474871 - Link dump_syms against rustc-demangle. r=ted The new version of breakpad imported in bug 1309172 doesn't demangle rust symbols at all, contrary to before, where it tried to C++ demangle them, which worked for many, although far from all. It however has rust-demangle support as long as it's linked against a copy of the rust-demangle-capi crate from https://github.com/luser/rust-demangle-capi/ This imports the code from the rust-demangle-capi crate but because of some build system complications it's not taken as-is: - it uses rusty-cheddar, which is deprecated, to generate a C header. - rusty-cheddar depends on syntex_syntax, which now fails to build. - rust-demangle-capi has crate-type staticlib, which can't be used as a dependency in a Cargo.toml. For that reason, we can't create a fake crate that depends on it to have it vendored. Overall, it's only a few lines of rust, and the C header can be written manually, so this is what we do here. The created crate is named in a way specific to dump_syms. The build system doesn't know how to figure out what system libraries are required to link rust static libraries, although the rust compiler has /some/ support to get the information, so we handle that manually.

Bug 1468273 - Fix flake8/pep8 issues by hand in gfx/ r=ted MozReview-Commit-ID: BFnq9JpWZxq

Bug 1468273 - autopep8 on gfx/ r=ted MozReview-Commit-ID: 8j8EU3E08GP

Bug 1474871 - Link dump_syms against rustc-demangle. r?ted The new version of breakpad imported in bug 1309172 doesn't demangle rust symbols at all, contrary to before, where it tried to C++ demangle them, which worked for many, although far from all. It however has rust-demangle support as long as it's linked against a copy of the rust-demangle-capi crate from https://github.com/luser/rust-demangle-capi/ This imports the code from the rust-demangle-capi crate but because of some build system complications it's not taken as-is: - it uses rusty-cheddar, which is deprecated, to generate a C header. - rusty-cheddar depends on syntex_syntax, which now fails to build. - rust-demangle-capi has crate-type staticlib, which can't be used as a dependency in a Cargo.toml. For that reason, we can't create a fake crate that depends on it to have it vendored. Overall, it's only a few lines of rust, and the C header can be written manually, so this is what we do here. The created crate is named in a way specific to dump_syms. The build system doesn't know how to figure out what system libraries are required to link rust static libraries, although the rust compiler has /some/ support to get the information, so we handle that manually.

Bug 1463190 - Add forced-MSVC builds to CI to keep that platform green. r=ted

Bug 1469091 - Build the clang plugin as a host shared library. r=ted This adds just enough host shared library support for this one use case, but also takes shortcuts, because fully supporting host shared library is a deep rabbit hole I'm not ready to take just to fix --enable-lto --enable-clang-plugin on mac builds. One downside is that one my machine the plugin now takes > 80s to build, instead of 15s before, thanks to the lack of unified sources.