searching for reviewer(surkov)
10656d31657321c67425494d554f092d4c1da6ae: Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov
Joanmarie Diggs <jdiggs@igalia.com> - Fri, 17 Aug 2018 08:14:00 +0300 - rev 830065
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov Change the name calculation rule of HTML 'table' element from eNoNameRule to eNameFromSubtreeIfReqRule. That way the table won't get an accessible name, but will be descended when building a name from a parent element's contents.
da7e0c710c7d7a7ff3e124db32d4eae9ffebd2a1: Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 15 Aug 2018 13:07:00 -0400 - rev 829567
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
dad95d849302c966da9a710e96c80e7882eec5c2: Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Tue, 14 Aug 2018 11:46:00 +0300 - rev 829309
Push 118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2a51d4fba8a52208d273bdb3863cd7d2c8524aa2: Bug 1479036 - Android classes role additions. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 09 Aug 2018 14:43:00 +0300 - rev 828189
Push 118647 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 06:14:44 +0000
Bug 1479036 - Android classes role additions. r=surkov
42e2eeaca65d313926e962b6583d52d4bcab6d15: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 828187
Push 118647 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 06:14:44 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant C++ functions are updated to take a typed enum. JavaScript calls are unaffected but they will throw if the string argument does not correspond to one of the known entries in the C++ enum. The existing whitelists and blacklists of annotations are also generated from the YAML file and all duplicate code related to them has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included in the list (and some obsolete ones have been removed) and all call sites have been updated including tests where appropriate.
ab8293506be28247f76acb9e9da78a20e6ffad0f: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 827185
Push 118488 by bmo:hsivonen@hsivonen.fi at Tue, 07 Aug 2018 12:28:14 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
0f3121479e3f0ff0016233534fd78d3262760fe1: Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:27:18 +1000 - rev 827184
Push 118488 by bmo:hsivonen@hsivonen.fi at Tue, 07 Aug 2018 12:28:14 +0000
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov We need to be able to call these methods from const methods, so they must take a const Accessible*. MozReview-Commit-ID: CDsWZG1ik31
a0a9bd6c09dedc6a11043b8cb669b34b883f5a5f: Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:25:09 +1000 - rev 827183
Push 118488 by bmo:hsivonen@hsivonen.fi at Tue, 07 Aug 2018 12:28:14 +0000
Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov MozReview-Commit-ID: JeV5vBffQIq
7875e1d016115e90bd52edb01b25973b0e7530b4: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov draft
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 827113
Push 118470 by bmo:jteh@mozilla.com at Tue, 07 Aug 2018 05:07:07 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
011c0263f2015b267c0607d88f080629b087ae29: Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r?surkov draft
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:27:18 +1000 - rev 827112
Push 118470 by bmo:jteh@mozilla.com at Tue, 07 Aug 2018 05:07:07 +0000
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r?surkov We need to be able to call these methods from const methods, so they must take a const Accessible*. MozReview-Commit-ID: CDsWZG1ik31
f6267cbaefca09a412bf409c7ccdb30075fe9ced: Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r?surkov draft
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:25:09 +1000 - rev 827111
Push 118470 by bmo:jteh@mozilla.com at Tue, 07 Aug 2018 05:07:07 +0000
Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r?surkov MozReview-Commit-ID: JeV5vBffQIq
d640ff079867a7feaafc1a427140ddb50cbd9acf: Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov
Tokio Kajitsuka <kajitsuka-tokio@g.ecc.u-tokyo.ac.jp> - Sat, 04 Aug 2018 19:47:50 +0900 - rev 827042
Push 118448 by bmo:mstriemer@mozilla.com at Mon, 06 Aug 2018 20:24:49 +0000
Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov change the type of AccessibleNode::mRelationProperties to nsRefPtrHashtable and add it to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE
1e9ecba54e7b1e6ee614e323ece9c98c373311a9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826469
Push 118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
86471a18672fb8b1c7edf27076f5e2964e2389f9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826463
Push 118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
d6b36c04143dd9f29c2fd74eb6e29f507839856e: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov draft
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 826201
Push 118267 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 08:54:05 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
e6506af07a21639b59edbc846d653808682ae6f6: Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r?surkov draft
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:27:18 +1000 - rev 826200
Push 118267 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 08:54:05 +0000
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r?surkov We need to be able to call these methods from const methods, so they must take a const Accessible*. MozReview-Commit-ID: CDsWZG1ik31
431966eba4aefc718aa8707a4e5bcb924d412e2d: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov draft
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 826190
Push 118260 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 05:27:18 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
61016c1c326a2a2027e92ca7242623be0d36e841: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov draft
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 826180
Push 118254 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 04:25:18 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r?surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
bd3deeebea8fb4e6e00fe4d3dc6d7a6836b512f3: Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable. r?surkov draft
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:27:18 +1000 - rev 826179
Push 118254 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 04:25:18 +0000
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable. r?surkov MozReview-Commit-ID: CDsWZG1ik31
2c1abb7ffed5b295e42537ec516fb2cf2d0b285a: Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r?surkov draft
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:25:09 +1000 - rev 826178
Push 118254 by bmo:jteh@mozilla.com at Fri, 03 Aug 2018 04:25:18 +0000
Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r?surkov MozReview-Commit-ID: JeV5vBffQIq
de9367e7a51159d2dffe0fc873cd447468516a8e: Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov
James Teh <jteh@mozilla.com> - Tue, 31 Jul 2018 11:22:59 +1000 - rev 824602
Push 117945 by bmo:mikokm@gmail.com at Tue, 31 Jul 2018 10:52:49 +0000
Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov This again exposes the accelerator (e.g. Ctrl+T for New Tab) for menu items via IAccessible::accName on windows. Bug 1438193 made Accessible::Name const. On Windows, XULMenuitemAccessibleWrap::Name is overridden to append the accelerator to the name. Unfortunately, this override was missed when converting Name to const (and wasn't a compile error because it didn't use the override keyword). As such, this override stopped being called; we always called the const version, since that's the one inherited into AccessibleWrap. Making this const causes this override to be called. MozReview-Commit-ID: 7Gb199mzhHa
0bde8c96f409d01b9f054b55d9c4eb2f95bb3099: Bug 1479530 - Swap newPosition with oldPosition in ProxyVirtualCursorChangeEvent. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 30 Jul 2018 11:41:00 +0300 - rev 824515
Push 117936 by nnethercote@mozilla.com at Tue, 31 Jul 2018 06:49:53 +0000
Bug 1479530 - Swap newPosition with oldPosition in ProxyVirtualCursorChangeEvent. r=surkov
6ec1e63a72a8d2725350473607e1110ed04904b0: Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r?surkov draft
James Teh <jteh@mozilla.com> - Tue, 31 Jul 2018 11:22:59 +1000 - rev 824502
Push 117930 by bmo:jteh@mozilla.com at Tue, 31 Jul 2018 01:29:57 +0000
Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r?surkov This again exposes the accelerator (e.g. Ctrl+T for New Tab) for menu items via IAccessible::accName on windows. Bug 1438193 made Accessible::Name const. On Windows, XULMenuitemAccessibleWrap::Name is overridden to append the accelerator to the name. Unfortunately, this override was missed when converting Name to const (and wasn't a compile error because it didn't use the override keyword). As such, this override stopped being called; we always called the const version, since that's the one inherited into AccessibleWrap. Making this const causes this override to be called. MozReview-Commit-ID: 7Gb199mzhHa
2307557b66b17dbc6952cf67995bba138b05443c: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 823292
Push 117637 by felipc@gmail.com at Fri, 27 Jul 2018 01:14:51 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov MozReview-Commit-ID: 2l6rvxykrWB
a809b45ff49ba5814795b30b5a460d7d2d1b6a23: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 822980
Push 117537 by bmo:hskupin@gmail.com at Thu, 26 Jul 2018 12:55:33 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov MozReview-Commit-ID: 2l6rvxykrWB
f24b37ee153f41b25fcf9e880f356a96425a12e0: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r?surkov draft
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 822904
Push 117516 by bmo:standard8@mozilla.com at Thu, 26 Jul 2018 10:20:32 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r?surkov MozReview-Commit-ID: 2l6rvxykrWB
d094defb7c1dc664b006ddf6a9c5d075c45d6460: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r?surkov draft
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 822489
Push 117389 by bmo:standard8@mozilla.com at Wed, 25 Jul 2018 12:36:09 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r?surkov MozReview-Commit-ID: 2l6rvxykrWB
25f6c0e7e2cdaa9f284544df4e944a5864d617ee: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?surkov draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:24:10 +0100 - rev 820746
Push 116919 by bmo:rbartlensky@mozilla.com at Fri, 20 Jul 2018 10:08:29 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?surkov MozReview-Commit-ID: 4xlmEZ4O8d
38ebcdae9bca37cfdb17c2199030cbe4f2612aa8: Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 18 Jul 2018 11:23:32 +0100 - rev 819907
Push 116685 by bmo:mstriemer@mozilla.com at Wed, 18 Jul 2018 18:52:47 +0000
Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov MozReview-Commit-ID: Bx1p1nTurCz
6910e500f30eb42b45032dbab85a3dc9c014390b: Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 18 Jul 2018 11:23:32 +0100 - rev 819751
Push 116638 by paolo.mozmail@amadzone.org at Wed, 18 Jul 2018 13:04:50 +0000
Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov MozReview-Commit-ID: Bx1p1nTurCz
9503f9df661aa2bac483db14a879d4b77a645bb7: Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov
Chris Peterson <cpeterson@mozilla.com> - Mon, 04 Jun 2018 01:44:18 -0700 - rev 819580
Push 116589 by bschouten@mozilla.com at Wed, 18 Jul 2018 06:57:22 +0000
Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov This SelectionManager assertion fails when running the testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py TestBackForwardNavigation.test_non_remote_about_pages marionette test. This assertion failure is bug 1126649. This patch DOES NOT fix the cause of the assertion failure (a missing HyperTextAccessible). It just replaces this failing NS_NOTREACHED with NS_ERROR because I am removing the NS_NOTREACHED macro. MozReview-Commit-ID: EVfyZlMwN4p
99869599a2f547ab414a11b3dedf0e9df7aa3666: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 17 Jul 2018 17:58:37 +0100 - rev 819432
Push 116554 by bmo:dharvey@mozilla.com at Tue, 17 Jul 2018 21:10:08 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
b08febd0a5930ca9e1f02c0ccf49bb72e8c2b0a1: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 17 Jul 2018 17:58:37 +0100 - rev 819337
Push 116519 by paolo.mozmail@amadzone.org at Tue, 17 Jul 2018 16:59:35 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
0fb2b9a769eb581919baf5b824901bcb564c1b74: Bug 1475087 - Include boundaryType in vc change event. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 16 Jul 2018 13:56:00 +0300 - rev 819103
Push 116438 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:49:06 +0000
Bug 1475087 - Include boundaryType in vc change event. r=surkov
d55a38a6be534e3f7c62da7ae36a65d8526ea0a4: Bug 1475078 - Go to last substring in current position when movePreviousByText. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 11 Jul 2018 13:49:28 -0700 - rev 819097
Push 116438 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:49:06 +0000
Bug 1475078 - Go to last substring in current position when movePreviousByText. r=surkov In the case of an unbound pivot (endOffset == startOffset == -1), we should move to the last substring in the current position when movePreviousByText is called.
552130bca48389d0b57fee87f5ab7865e0ae6abe: Bug 1475068 - If accessible's parent has text interface, use it in pivot move by text. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 11 Jul 2018 13:36:02 -0700 - rev 819096
Push 116438 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:49:06 +0000
Bug 1475068 - If accessible's parent has text interface, use it in pivot move by text. r=surkov
ed8baebfeb78bae7b4fa3a78be13173729df2e01: Bug 1475087 - Include boundaryType in vc change event. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 09 Jul 2018 13:50:58 -0700 - rev 819088
Push 116438 by maglione.k@gmail.com at Tue, 17 Jul 2018 05:49:06 +0000
Bug 1475087 - Include boundaryType in vc change event. r=surkov
baa5ff44626ec4ed99c6ac9edb6442adbd46d142: Bug 1472555 - Part 8 - Remove the listbox layout. r=bz,surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 13 Jul 2018 19:22:50 +0100 - rev 817921
Push 116222 by paolo.mozmail@amadzone.org at Fri, 13 Jul 2018 18:23:56 +0000
Bug 1472555 - Part 8 - Remove the listbox layout. r=bz,surkov MozReview-Commit-ID: Bx1p1nTurCz
e403c2d8cb01e3ef352ffb7e3e6023916d19d6e2: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Sat, 07 Jul 2018 17:57:16 +0100 - rev 817913
Push 116222 by paolo.mozmail@amadzone.org at Fri, 13 Jul 2018 18:23:56 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
1d50382ab31725c9473b5e9425eefa2793f2c63e: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Sat, 07 Jul 2018 17:57:16 +0100 - rev 815573
Push 115562 by paolo.mozmail@amadzone.org at Mon, 09 Jul 2018 12:34:02 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
2da40a7cda282e3f8eb8c1d843cbe775e94eecbf: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov draft
Paolo Amadini <paolo.mozmail@amadzone.org> - Sat, 07 Jul 2018 17:57:16 +0100 - rev 815333
Push 115498 by paolo.mozmail@amadzone.org at Sat, 07 Jul 2018 17:03:50 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
178261758dc9ea7bd8ee0d91923003455e07a4ab: Bug 1472274 - Alter selection direction according to the last change. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 05 Jul 2018 15:19:00 +0300 - rev 814746
Push 115330 by bmo:emilio@crisal.io at Fri, 06 Jul 2018 02:47:53 +0000
Bug 1472274 - Alter selection direction according to the last change. r=surkov nsIAccessibleText.setSelectionBounds should accept a start offset that is larger than an end offset. This is an indica tion that it is a reverse selection, and the caret should be at the start of the selection. This should also be consistent with how multiple range selections work interactively - the caret should re main at the last offset reached.
b9e8b65d2db1ec517ee5bcc7a3a1aad95585433f: Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r?surkov draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 04 Jul 2018 14:39:57 -0700 - rev 814372
Push 115173 by cpeterson@mozilla.com at Thu, 05 Jul 2018 03:25:42 +0000
Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r?surkov Fix clang-tidy warning about bool pointers: [misc-bool-pointer-implicit-conversion] accessible/generic/Accessible.cpp:644:9: warning: dubious check of 'bool *' against 'nullptr', did you mean to dereference it? The `hitregion` property is always null or points to a true bool, set here: https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/canvas/CanvasRenderingContext2D.cpp#3936-3937 The `hitregion` property used to be an nsRect pointer: https://searchfox.org/mozilla-central/diff/c797577640f306df87e8c32313c5b826d1e58a9b/accessible/src/generic/Accessible.cpp#928 MozReview-Commit-ID: HYlAnMyaitB
335d37068a98acdb703f6f2da58388b21f63e477: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 813556
Push 114926 by dgottwald@mozilla.com at Tue, 03 Jul 2018 10:42:28 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
3cd2b65581cc41a9633d8c992f43f1c526270b18: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov draft
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 813408
Push 114887 by bmo:jteh@mozilla.com at Tue, 03 Jul 2018 03:26:30 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
f32174f44c65f500d8f69b73bee6f42d306a23e5: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 812432
Push 114542 by jdescottes@mozilla.com at Fri, 29 Jun 2018 10:33:35 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
02609a2664a7fd555bbad6fddbb709cc144815f1: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov draft
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 812295
Push 114529 by bmo:jteh@mozilla.com at Fri, 29 Jun 2018 02:56:46 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
f81dce9c6f2f8cd44099a5e7a7b1847630401e8b: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov draft
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 811191
Push 114224 by bmo:jteh@mozilla.com at Wed, 27 Jun 2018 05:42:05 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r?surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
2fa69e8f19b92e2bc11de7cbea3300cdab6a56c4: Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 21 Jun 2018 14:47:00 +0300 - rev 809527
Push 113710 by bmo:emilio@crisal.io at Fri, 22 Jun 2018 11:59:04 +0000
Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov
ca59f5dfd548d64d7b8c480f358bfcc80433bdc6: Bug 1469379 - let is missing from accessible/tests/mochitest/aom/test_general.html. r=surkov
Tokio Kajitsuka <kajitsuka-tokio@g.ecc.u-tokyo.ac.jp> - Tue, 19 Jun 2018 04:49:16 +0900 - rev 808325
Push 113350 by bmo:hsivonen@hsivonen.fi at Tue, 19 Jun 2018 06:48:11 +0000
Bug 1469379 - let is missing from accessible/tests/mochitest/aom/test_general.html. r=surkov