searching for reviewer(smaug)
d57a6d415507fb7e43cad18c2755aa124b84bbbe: Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 22:27:12 +0000 - rev 830944
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4008
06caf48cb3b5001f8b67b80e6c7c75d306c05b60: Bug 1485029 - Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 22 Aug 2018 13:59:43 +0000 - rev 830881
Push 118857 by bmo:mtigley@mozilla.com at Thu, 23 Aug 2018 04:55:06 +0000
Bug 1485029 - Use SIMD for PopulateBufferForBinaryString() in FileReader.cpp. r=smaug MozReview-Commit-ID: Gwoj13lFJsJ Differential Revision: https://phabricator.services.mozilla.com/D3889
87b754ac0db00abdd8286253d28eca0150f9a769: Bug 1481851 - Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug
Philipp Hancke <fippo@appear.in> - Wed, 08 Aug 2018 17:30:40 +0200 - rev 830828
Push 118857 by bmo:mtigley@mozilla.com at Thu, 23 Aug 2018 04:55:06 +0000
Bug 1481851 - Add kind to RTCRtpStreamStats as alias to mediaType. r=ng,smaug spec change in https://github.com/w3c/webrtc-stats/issues/301
94cfd6113ca7c7efef708d2b0af8bcd5703d7fe2: Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
Dylan Roeh <droeh@mozilla.com> - Tue, 21 Aug 2018 12:52:39 -0500 - rev 830817
Push 118857 by bmo:mtigley@mozilla.com at Thu, 23 Aug 2018 04:55:06 +0000
Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
db66903f54cc0b27224255efab79cef50ca16540: Bug 1484855: Match the 'is rendered' definition from the spec in innerText. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 09:05:09 +0000 - rev 830755
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1484855: Match the 'is rendered' definition from the spec in innerText. r=smaug This matches other implementations and the spec for fallback content like: <canvas><div>abc (calling div.innerText). We're treating the <div> as 'rendered' because it's not in a display: none subtree, but that's not ok, since it is in fact not rendered. This was added in bug 1226293, and Boris suggested this change, but roc opposed because it'd be hard to spec properly in comment 15. Looks like the HTML spec ended up merging roc's innerText spec, and now it's spec'd in terms of 'being rendered'. I think IsOrHasAncestorWithDisplayNone just doesn't work in any reasonable way for stuff out of the flat tree. Thus I think this change is the right thing. The canvas test fails because of bug 1485076. Differential Revision: https://phabricator.services.mozilla.com/D3887
f9417ef4b9568f7edf1fc6854b38ef75a13db086: Bug 1485099 - Add some logging to the AntiTracking component for the saving and reading of storage access permissions; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 21 Aug 2018 14:28:49 -0400 - rev 830603
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1485099 - Add some logging to the AntiTracking component for the saving and reading of storage access permissions; r=smaug
1598dc35d16af3bcb77e855190b47df1992dc6e3: Bug 1484773 - Containing shadow could be null after unlink. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 23:28:57 +0000 - rev 830504
Push 118839 by mixedpuppy@gmail.com at Tue, 21 Aug 2018 18:59:46 +0000
Bug 1484773 - Containing shadow could be null after unlink. r=smaug Bug 1483882 removed the line that used to remove the SHADOW_TREE bit during unbind. I missed this caller which still assumed that `IsInShadowTree() -> GetContainingShadow()`. That means that before that patch it was going through nsIDocument::RemoveStyleSheet, which looks pretty wrong to me. Fix it so that we don't remove the stylesheet (we weren't doing it before anyway), but we don't crash. Differential Revision: https://phabricator.services.mozilla.com/D3831
31ed81aa4f4682946b228f6db2b0d7a67a0975cd: Bug 1484478 - Use a node bit for connectedness. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 11:56:27 +0000 - rev 830231
Push 118825 by bmo:rob@robwu.nl at Mon, 20 Aug 2018 17:24:40 +0000
Bug 1484478 - Use a node bit for connectedness. r=smaug While trying to repro bug 1484293 I noticed that this assertion failed: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/base/ShadowRoot.cpp#160 (during unlink, while unbinding the kids) We rely on GetComposedDoc returning the right thing during unbind to cleanup some stuff (see bug 1473637 for example), so it should probably be correct all the time, regardless of whether something is unlinked or not. Also this makes GetComposedDoc() much faster, which is nice too, since we call it somewhat often. I removed NodeHasRelevantHoverRules, since it's unused (was used by the old style system). I moved the SetIsConnected(false) call for the shadow root to before unbinding the kids for consistency with what Element does with the uncomposed doc flag, now that the children's connectedness doesn't depend on the shadow root's. Differential Revision: https://phabricator.services.mozilla.com/D3715
39f61de4e7bb164f1ad812852b4f46bd18e3d96d: Bug 1484478 - Use a node bit for connectedness. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 19 Aug 2018 18:22:48 +0000 - rev 830227
Push 118825 by bmo:rob@robwu.nl at Mon, 20 Aug 2018 17:24:40 +0000
Bug 1484478 - Use a node bit for connectedness. r=smaug While trying to repro bug 1484293 I noticed that this assertion failed: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/base/ShadowRoot.cpp#160 (during unlink, while unbinding the kids) We rely on GetComposedDoc returning the right thing during unbind to cleanup some stuff (see bug 1473637 for example), so it should probably be correct all the time, regardless of whether something is unlinked or not. Also this makes GetComposedDoc() much faster, which is nice too, since we call it somewhat often. I removed NodeHasRelevantHoverRules, since it's unused (was used by the old style system). I moved the SetIsConnected(false) call for the shadow root to before unbinding the kids for consistency with what Element does with the uncomposed doc flag, now that the children's connectedness doesn't depend on the shadow root's. Differential Revision: https://phabricator.services.mozilla.com/D3715
2d78ad30fa75b7334ef6ab7aa30ed01a7166ca85: Bug 1484474 - Make the ua widget flag in ShadowRoot write-only. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 18 Aug 2018 21:32:38 +0000 - rev 830226
Push 118825 by bmo:rob@robwu.nl at Mon, 20 Aug 2018 17:24:40 +0000
Bug 1484474 - Make the ua widget flag in ShadowRoot write-only. r=smaug Letting people set it back to false would be bad. Differential Revision: https://phabricator.services.mozilla.com/D3714
765311be9111caa8c14db72f0652a0b5a384916c: Bug 1482968 Part 2: Add a test of modifier key clicks and drags on input elements. r=smaug!
Brad Werth <bwerth@mozilla.com> - Fri, 17 Aug 2018 18:59:36 +0000 - rev 830100
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1482968 Part 2: Add a test of modifier key clicks and drags on input elements. r=smaug! Depends on D3450 Differential Revision: https://phabricator.services.mozilla.com/D3451
b42785b1186cb24c42e6e8fb56342fbe40867b07: Bug 1482968 Part 1: Relax input event modifier filtering to allow most modifier keys to be pressed during mouse and key events. r=smaug!
Brad Werth <bwerth@mozilla.com> - Fri, 17 Aug 2018 18:59:13 +0000 - rev 830099
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1482968 Part 1: Relax input event modifier filtering to allow most modifier keys to be pressed during mouse and key events. r=smaug! Differential Revision: https://phabricator.services.mozilla.com/D3450
3b7671939ef8e47308674f77de1e644008bc9965: Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Aug 2018 11:35:15 +0000 - rev 830087
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3533
777ba79e0e0a8cfbea6c3a9d2fe4ff9fdb58bb3c: Bug 1484363: Treat FrameMessageManagers as chrome event targets. r=smaug
Kris Maglione <maglione.k@gmail.com> - Fri, 17 Aug 2018 15:11:11 -0700 - rev 830085
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484363: Treat FrameMessageManagers as chrome event targets. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3663
43cdb715d393bb8cb140cada1c0aaec27e898a14: Bug 1483764 - Fix EOF behavior when decoding responseText lazily. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 17 Aug 2018 17:04:22 +0000 - rev 830055
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483764 - Fix EOF behavior when decoding responseText lazily. r=smaug * Drop the decoder when it finishes regardless of who called it. * Match criteria for having mDecoder process EOF from OnStopRequest to the criteria used for eager decoding in StreamReaderFunc. * Process EOF when decoding lazily. * Get rid of the useless mResponseCharset field. MozReview-Commit-ID: 7oJwyKQYP8K Differential Revision: https://phabricator.services.mozilla.com/D3591
61909c98d50d54bcedec18a3c963ac8c37aa0664: Bug 1481252 - Part 0: add tracker statistics fields to document; r=smaug
Liang-Heng Chen <xeonchen@gmail.com> - Fri, 17 Aug 2018 17:04:44 +0000 - rev 830052
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1481252 - Part 0: add tracker statistics fields to document; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3023
9c08d6d5d6f29b6bd44166cc1054d2f4b31c77d6: Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Aug 2018 11:35:15 +0000 - rev 830049
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3533
4105f56578d414b83e302fe5f835824f1b6f3aac: Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Aug 2018 11:35:15 +0000 - rev 830031
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3533
d25d4da4aad2c680854931bdde183f0e2f8948c7: Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Aug 2018 09:19:47 +0000 - rev 830018
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483882 - Teach IDTracker about Shadow DOM. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3533
89c81ab0254376e6a7ae4a61fa2607d4ecd7b08b: Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley
Kris Maglione <maglione.k@gmail.com> - Wed, 15 Aug 2018 19:22:30 -0700 - rev 830003
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1483738: Part 2 - Add MozInvalidForm event, which can be handled in place of notifyInvalidSubmit observers. r=smaug,mconley Differential Revision: https://phabricator.services.mozilla.com/D3467
335facce978ea7f9ef1e8dcfafc082e5b99f5a47: Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley
Kris Maglione <maglione.k@gmail.com> - Wed, 15 Aug 2018 20:06:49 -0700 - rev 830000
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1483664: Part 0 - Dispatch pagehide/pageshow to all system group listeners on frameloader swap. r=smaug,mconley Having to add pagehide/pageshow listeners to the chrome event target is a serious inconvience for the use cases of this bug. Dispatching to system group listeners has approximately the same effect as the old code, but is much easier for window-bound code to handle.
22cb98ed738bcc1de2c1d04ee8837df80c05a193: Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 16 Aug 2018 16:44:37 -0400 - rev 829996
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug
2c7d388314b8bebc85707da16b6b7ce1c5e62e15: Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 16 Aug 2018 16:44:37 -0400 - rev 829991
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1483765 - Fix the image cache key computation logic to only consider first-party storage access for third-party windows; r=smaug
a7a2da45f8f7663d7fa3b3b2066d1eb05dad1d14: Bug 1483964: Unify InternalAttr and ServoAttrSnapshot. r=smaug,xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 14 Aug 2018 18:43:26 +0200 - rev 829950
Push 118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1483964: Unify InternalAttr and ServoAttrSnapshot. r=smaug,xidorn They're the same, and they aren't complex enough to be an AttrArray implementation detail I think. Differential Revision: https://phabricator.services.mozilla.com/D3535
6f8ddade347deb25d3d3dfc9df97dad6e933d0bf: Bug 1483404 - Move conversion of CompositeOperation enum types to KeyframeUtils::GetAnimationPropertiesFromKeyframes; r=smaug
Brian Birtles <birtles@gmail.com> - Thu, 16 Aug 2018 16:24:52 +0000 - rev 829910
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1483404 - Move conversion of CompositeOperation enum types to KeyframeUtils::GetAnimationPropertiesFromKeyframes; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3457
1d4014247f20ee46f294f131209151de6850c643: Bug 1483818: Disable MSVC warning C4200 about zero-size arrays in AttrArray::Impl. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Aug 2018 12:45:50 +0200 - rev 829779
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1483818: Disable MSVC warning C4200 about zero-size arrays in AttrArray::Impl. r=smaug
42d6f6784fc21d04838241d35d3ceb82a1ecc935: Bug 1349528 - Use encoding_rs for normalizing USVString. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 16 Aug 2018 10:15:07 +0000 - rev 829726
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1349528 - Use encoding_rs for normalizing USVString. r=smaug MozReview-Commit-ID: 9uG6j8UdfKR Differential Revision: https://phabricator.services.mozilla.com/D3413
06335a11cf2ad167ad4118747fd102485a712c4b: Bug 1431255 - Part VII, Trap mouse/touch/pointer events in audio/video element for UI Widgets r=smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 12 Jul 2018 12:32:44 +0800 - rev 829676
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1431255 - Part VII, Trap mouse/touch/pointer events in audio/video element for UI Widgets r=smaug This is akin to what's done in bug 1327097. MozReview-Commit-ID: EERkjrxWZOu
cfecf5444baf6d15aca77461d9fc3daac59458e6: Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols> r=dholbert,smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 27 Jun 2018 11:12:38 -0700 - rev 829671
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols> r=dholbert,smaug This prevents XBL binding from being attached, and create the Shadow Root to host controls to be created by the script. Shadow Root and the JS controls are lazily constructed when the controls attribute is set. Set nsVideoFrame as dynamic-leaf so it will ignore content child frames when the controls are XBL anonymous content, and handles child frames from controls in the Shadow DOM. The content nodes are still ignored since there is no <slot>s in our Shadow DOM. MozReview-Commit-ID: 3hk41iMa07n
d82268ca14630e7534045f169c57a5277b1190dc: Bug 1431255 - Part I, Add dom.ua_widget.enabled pref and enable for Desktop Nightly only r=smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 06 Jul 2018 08:46:43 +0800 - rev 829670
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1431255 - Part I, Add dom.ua_widget.enabled pref and enable for Desktop Nightly only r=smaug This would allow us to control this feature independently of the Shadow DOM pref. The feature is only turned on when Shadow DOM is turned on. MozReview-Commit-ID: 4g6BJigFUZs
92832d7ecc29acb44a81ceb7836baaf528c20282: Bug 1483274 - Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug
Brian Grinstead <bgrinstead@mozilla.com> - Wed, 15 Aug 2018 19:21:22 +0000 - rev 829666
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1483274 - Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug Browsers can switch at runtime from remote to non-remote and vice versa, which on the C++ side is detected from a XBL binding change which causes nsIRemoteBrowser to either be implemented or not. Custom Elements can't change at runtime in the same way, so unifying on a single [implements] will allow browser (both remote and non-remote) to be migrated to a single Custom Element. To keep current functionality, this updates Qi calls into nsIRemoteBrowser to instead Qi into nsIBrowser and check isRemoteBrowser. Differential Revision: https://phabricator.services.mozilla.com/D3346
a972e755df1b9809ea45aaab942dffea06105900: Bug 1483404 - Use "auto" values for unspecified keyframe-specific composite operations; r=smaug
Brian Birtles <birtles@gmail.com> - Wed, 15 Aug 2018 09:51:28 +0900 - rev 829598
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483404 - Use "auto" values for unspecified keyframe-specific composite operations; r=smaug Summary: This brings our implementation into line with the following spec change: https://github.com/w3c/csswg-drafts/commit/ced6b5aac02e0e021001f10e4d63e03456686dad See https://github.com/w3c/csswg-drafts/issues/3000 Reviewers: smaug Tags: #secure-revision Bug #: 1483404 Differential Revision: https://phabricator.services.mozilla.com/D3384
6b9aaa303e9a193b92d02659a0b19059007b5665: Bug 1483604 - Part 3: Pass in a channel object when calling InternalStorageAllowedForPrincipal() from StorageAllowedForWindow() and StorageAllowedForDocument(); r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 15 Aug 2018 18:17:10 -0400 - rev 829596
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483604 - Part 3: Pass in a channel object when calling InternalStorageAllowedForPrincipal() from StorageAllowedForWindow() and StorageAllowedForDocument(); r=smaug
be2d0537375471a1a5d0607821d06805a3c4ae8b: Bug 1483604 - Part 2: Make all of the external consumers of nsContentUtils::StorageDisabledByAntiTracking() pass a channel if available; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 15 Aug 2018 18:02:48 -0400 - rev 829595
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483604 - Part 2: Make all of the external consumers of nsContentUtils::StorageDisabledByAntiTracking() pass a channel if available; r=smaug
05a3c486ad1e5472cb22c0184adc26beecc39cb0: Bug 1483604 - Part 1: Only call NotifyContentBlockingState() when the channel argument is non-null; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 15 Aug 2018 17:55:37 -0400 - rev 829594
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483604 - Part 1: Only call NotifyContentBlockingState() when the channel argument is non-null; r=smaug
cba97273eb10aa51a654d7a802c843b3e149b903: Bug 1482866: Simplify AttrArray's implementation. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 Aug 2018 15:35:57 +0200 - rev 829462
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1482866: Simplify AttrArray's implementation. r=smaug No need for void* stuff, but I had to keep the semi-manual memory management to allocate everything inline as we currently do. Differential Revision: https://phabricator.services.mozilla.com/D3218
22c19ba1a3955746f361f8d9d9431e180616a1e4: Bug 1480224: It's not needed to explicitly exclude <use> trees from XBL scopes anymore. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Aug 2018 14:25:09 +0200 - rev 829454
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1480224: It's not needed to explicitly exclude <use> trees from XBL scopes anymore. r=smaug Now that the content is not anonymous we don't need to exclude them explicitly. This happens because anonymous content inside the shadow tree does report to be inside the shadow tree, which is true but at the same time slightly footgunny. In any case the other uses of the use shadow tree stuff are base-uri related, and changing anon content's base uri in that case sounds like the right thing, even though anon content shouldn't rely on those anyway. Differential Revision: https://phabricator.services.mozilla.com/D3409
413c0f58374c3fd8af375ea1b680cb86c4a1492b: Bug 1480465: Infer the namespace for custom elements at definition time by following the class hierarchy. r=smaug
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 15 Aug 2018 10:31:16 +0000 - rev 829432
Push 118781 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 02:46:06 +0000
Bug 1480465: Infer the namespace for custom elements at definition time by following the class hierarchy. r=smaug When a custom element is defined we can check whether its class is an instance of XULElement or HTMLElement and tag the defintion with a namespace accordingly. This allows us to know the correct namespace for the custom element when created. Differential Revision: https://phabricator.services.mozilla.com/D2680
8fdd88cea1887c403c09a486cff98313bd191f13: Bug 1480618 - Cloning node for Range APIs should be in tree order; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 14 Aug 2018 14:01:35 +0000 - rev 829256
Push 118755 by michael.l.comella@gmail.com at Wed, 15 Aug 2018 01:48:30 +0000
Bug 1480618 - Cloning node for Range APIs should be in tree order; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3216
02b3167c1a8e87b2cb09cf2c6508df76e3e03c76: Bug 1482640 - Null out mDecoder in OnStopRequest to avoid asserting when there is more than one OnStopRequest. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 13 Aug 2018 17:10:06 +0000 - rev 828933
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482640 - Null out mDecoder in OnStopRequest to avoid asserting when there is more than one OnStopRequest. r=smaug MozReview-Commit-ID: K25XhiYGzhl Differential Revision: https://phabricator.services.mozilla.com/D3217
f93a51060a07cb216d9c44cb538a948155e1ad32: Bug 1482988 - Handle null arguments in nsContentUtils::StorageDisabledByAntiTracking correctly; r=smaug
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 13 Aug 2018 15:54:55 -0400 - rev 828891
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482988 - Handle null arguments in nsContentUtils::StorageDisabledByAntiTracking correctly; r=smaug
dc6e00ee89a8fcbd48d5d7cc086db7754e0194e5: Bug 1482694 - Don't clear the insertion point from ClearInsertedChildren if we're not the insertion point the node is assigned to. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 12 Aug 2018 18:17:48 +0000 - rev 828701
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1482694 - Don't clear the insertion point from ClearInsertedChildren if we're not the insertion point the node is assigned to. r=smaug What's going on is that nested XBL insertion points are completely unsound, and we leave all sorts of kids in mInsertedChildren when bindings dynamically change. So if bindings change in a particular way so that the innermost insertion point is cleared, but the outermost bindings aren't, like this, we end up with an inconsistent flattened tree. This prevents the inconsistent flattened tree in this case, though what ought to happen in the SetXBLInsertionPoint(nullptr) case is setting the insertion point to the outer insertion point. But we don't keep track of all our insertion points, and I don't think it's worth to fix that given XBL is going away unless it gives us more problems. See also bug 1425362 & co. Differential Revision: https://phabricator.services.mozilla.com/D3163
9e40d14b0c5ab413c310c218b82fb50a38fa765c: Bug 1472976 part 3 - Use JS::GetRealmPrincipals instead of JS_GetCompartmentPrincipals in nsContentUtils::ObjectPrincipal. r=smaug
Jan de Mooij <jdemooij@mozilla.com> - Fri, 10 Aug 2018 11:57:39 +0200 - rev 828300
Push 118671 by bmo:mstriemer@mozilla.com at Fri, 10 Aug 2018 18:51:19 +0000
Bug 1472976 part 3 - Use JS::GetRealmPrincipals instead of JS_GetCompartmentPrincipals in nsContentUtils::ObjectPrincipal. r=smaug This also removes an outdated comment, nsScriptSecurityManager::doGetObjectPrincipal was removed in bug 1464374.
650a29193146b0b045af38ea3c76e4c9a32620a9: Bug 1472976 part 2 - Use the callback global instead of the callback in JSEventHandler::HandleEvent. r=smaug
Jan de Mooij <jdemooij@mozilla.com> - Fri, 10 Aug 2018 11:57:39 +0200 - rev 828299
Push 118671 by bmo:mstriemer@mozilla.com at Fri, 10 Aug 2018 18:51:19 +0000
Bug 1472976 part 2 - Use the callback global instead of the callback in JSEventHandler::HandleEvent. r=smaug The callback and the global here must be same-compartment, but the callback might be a CCW.
088210d062b7659f4b7dafb3f0baa8d411f20c37: Bug 1472976 part 1 - Unwrap the object before getting its principal in CustomElementRegistry::IsCustomElementEnabled. r=smaug
Jan de Mooij <jdemooij@mozilla.com> - Fri, 10 Aug 2018 11:57:39 +0200 - rev 828298
Push 118671 by bmo:mstriemer@mozilla.com at Fri, 10 Aug 2018 18:51:19 +0000
Bug 1472976 part 1 - Unwrap the object before getting its principal in CustomElementRegistry::IsCustomElementEnabled. r=smaug
f79db264e82c5b7a931818296312515122a1873e: Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r?bryce,smaug draft
Alex Chronopoulos <achronop@gmail.com> - Thu, 09 Aug 2018 17:14:28 +0300 - rev 827855
Push 118601 by achronop@gmail.com at Thu, 09 Aug 2018 14:17:09 +0000
Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r?bryce,smaug MozReview-Commit-ID: 2fvxZDe5A94
b7c54bc98cc7143112e114a996de58615feb5b28: bug 1397297, make SnowWhite freeing more incremental, r=smaug
agashlin@mozilla.com - Wed, 08 Aug 2018 09:14:58 +0300 - rev 827557
Push 118551 by bmo:mtigley@mozilla.com at Wed, 08 Aug 2018 15:37:58 +0000
bug 1397297, make SnowWhite freeing more incremental, r=smaug
fcf0193311b07f01b62eaa3c0aa53606ce5c5deb: Bug 1481292 - part 2: Make ContentEventHandler::GetLastFrameInRangeForTextRect() and ContentEventHandler::AdjustCollapsedRangeMaybeIntoTextNode() use RangeBoundary when they treat start or end of range r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 08 Aug 2018 01:43:31 +0000 - rev 827530
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1481292 - part 2: Make ContentEventHandler::GetLastFrameInRangeForTextRect() and ContentEventHandler::AdjustCollapsedRangeMaybeIntoTextNode() use RangeBoundary when they treat start or end of range r=smaug ContentEventHandler::GetLastFrameInRangeForTextRect() and ContentEventHandler::AdjustCollapsedRangeMaybeIntoTextNode() use nsINode::GetChildAt_Deprecated() directly. They use this method when they treat start or end of a range. So, we can make them use RangeBoundary instead. Differential Revision: https://phabricator.services.mozilla.com/D2843
43373390fa8dc93e0535ed6661665be963888809: Bug 1481292 - part 1: Get rid of ContentEventHandler::GetNodePositionHavingFlatText() because of unused r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 07 Aug 2018 13:50:23 +0000 - rev 827529
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1481292 - part 1: Get rid of ContentEventHandler::GetNodePositionHavingFlatText() because of unused r=smaug ContentEventHandler::GetNodePositionHavingFlatText() is not used by anybody. So, we should just get rid of it. Differential Revision: https://phabricator.services.mozilla.com/D2842
c54958b74fd29e0d262c3b5a37328ae26cd80a6e: Bug 1480179 - Fix the traverse() of MediaQueryList in nsDocument, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 08 Aug 2018 08:22:37 +0200 - rev 827506
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1480179 - Fix the traverse() of MediaQueryList in nsDocument, r=smaug