searching for reviewer(sebastian)
2110db37093241328f8e2bcff788420e6ad461f2: Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
draft
James Willcox <snorp@snorp.net> - Sat, 07 Jul 2018 13:47:34 -0500 - rev 825968
Push
118217 by bmo:snorp@snorp.net at Thu, 02 Aug 2018 19:02:12 +0000
Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
MozReview-Commit-ID: GPPy5rY7SIe
c3aeb0c88e568ad48c58aacbc894b8ab0196b400: Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
draft
James Willcox <snorp@snorp.net> - Sat, 07 Jul 2018 13:47:34 -0500 - rev 823647
Push
117749 by bmo:snorp@snorp.net at Fri, 27 Jul 2018 18:27:21 +0000
Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
MozReview-Commit-ID: GPPy5rY7SIe
da3eb5e151df7ea1edbdf31cf7858caf1672d9c0: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 822274
Push
117341 by bmo:bugzilla@pansara.org at Wed, 25 Jul 2018 04:54:19 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
91e5ef72652566a9c79f5ba643687164337bcd8f: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 821544
Push
117128 by bmo:bugzilla@pansara.org at Mon, 23 Jul 2018 16:02:05 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
a8865363eacb9f9d963f93ee4aa2595f9330ca60: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 820567
Push
116871 by bmo:bugzilla@pansara.org at Thu, 19 Jul 2018 22:03:45 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian,baku
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
c4ce9377dc520417f6a919b6be9e3c0b04579175: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 820142
Push
116735 by bmo:bugzilla@pansara.org at Thu, 19 Jul 2018 00:46:40 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI. This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: Dzy6t2zYljL
c28ecf6a4c928fe027bb678d455a2e9a05758ec7: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian
draft
Dipen Patel <bugzilla@pansara.org> - Tue, 17 Jul 2018 14:52:23 -0700 - rev 819492
Push
116564 by bmo:bugzilla@pansara.org at Tue, 17 Jul 2018 23:32:37 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,jryans,mcmanus,sebastian
- Removed nsITransportSecurityInfoProvider. Made secInfo a member of nsISecureBrowserUI.
The TabParent implementation GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates
MozReview-Commit-ID: 2oEC4Fqz2lc
4bff231c917ff9dafc406929a5db684cca024b10: Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,pbro,mcmanus,sebastian
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 819491
Push
116564 by bmo:bugzilla@pansara.org at Tue, 17 Jul 2018 23:32:37 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. r?keeler,gijs,pbro,mcmanus,sebastian
Access nsISSLStatus directly as a member of nsITransportSecurityInfo or through
nsITransportSecurityInfoProvider. This is part of a larger effort to consolidte
nsISSLStatus and nsITransportSecurityInfo.
MozReview-Commit-ID: Dzy6t2zYljL
ab69b044f308713fc320a1ba8aa02944ae84e77b: Bug 1475647 - Remove nsISSLStatusProvider interface. Access nsISSLStatus directly as a member of nsITransportSecurityInfo or through nsITransportSecurityInfoProvider. This is part of a larger effort to consolidte nsISSLStatus and nsITransportSecurityInfo. r?keeler,gijs,pbro,mcmanus,sebastian
draft
Dipen Patel <bugzilla@pansara.org> - Fri, 13 Jul 2018 11:48:55 -0700 - rev 818961
Push
116404 by bmo:bugzilla@pansara.org at Mon, 16 Jul 2018 21:09:22 +0000
Bug 1475647 - Remove nsISSLStatusProvider interface. Access nsISSLStatus directly as a member of nsITransportSecurityInfo or through nsITransportSecurityInfoProvider. This is part of a larger effort to consolidte nsISSLStatus and nsITransportSecurityInfo. r?keeler,gijs,pbro,mcmanus,sebastian
MozReview-Commit-ID: Dzy6t2zYljL
2a83f6ea506805055bc8c56ebdd019b26bad83b6: Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
draft
James Willcox <snorp@snorp.net> - Sat, 07 Jul 2018 13:47:34 -0500 - rev 817997
Push
116235 by bmo:snorp@snorp.net at Fri, 13 Jul 2018 19:37:40 +0000
Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
MozReview-Commit-ID: GPPy5rY7SIe
2fb83feb942cca5aa854cf0d694cb7881b134a56: Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
draft
James Willcox <snorp@snorp.net> - Sat, 07 Jul 2018 13:47:34 -0500 - rev 817925
Push
116223 by bmo:snorp@snorp.net at Fri, 13 Jul 2018 18:25:22 +0000
Bug 1463790 - Introduce a Kotlin extension module for GeckoView r=jchen,nalexander,esawin,sebastian
MozReview-Commit-ID: GPPy5rY7SIe
eccd96eb6cf63692df0ca9b87b5b672c87acce65: Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sebastian
draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 25 Jun 2018 19:19:30 +0300 - rev 810615
Push
114052 by plingurar@mozilla.com at Tue, 26 Jun 2018 08:20:48 +0000
Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sebastian
Broke the big IntentService into four small JobIntentServices because
the same JobIntentService class cannot be used with multiple JobIds
(https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121)
Also:
- will make the code easier to be migrated to WorkManager in the future
- more in line with SRP. It was initially doing too much.
Cleaned the code a little, removed the superfluous creation of new Threads for
DownloadContentCatalog().persistChanges() / .startLoadFromDisk()
as those methods are always called from the background threads
of the new JobIntentServices.
The new DlcHelper helps reducing duplicated code.
MozReview-Commit-ID: G3fsWYOGEbR
da439043fa7168fe6fe08f6536a19f0217aee11f: Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sebastian
draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 25 Jun 2018 19:19:30 +0300 - rev 810270
Push
113945 by plingurar@mozilla.com at Mon, 25 Jun 2018 16:58:08 +0000
Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sebastian
Broke the big IntentService into four small JobIntentServices because
the same JobIntentService class cannot be used with multiple JobIds
(https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121)
Also:
- will make the code easier to be migrated to WorkManager in the future
- more in line with SRP. It was initially doing too much.
Cleaned the code a little, removed the superfluous creation of new Threads for
DownloadContentCatalog().persistChanges() / .startLoadFromDisk()
as those methods are always called from the background threads
of the new JobIntentServices.
The new DlcHelper helps reducing duplicated code.
MozReview-Commit-ID: G3fsWYOGEbR
46ea394f0c30fdfef5cc24baa78a667e9e0c1dc0: Bug 1464990 - Allow easier testing Switchboard experiments; r=jchen,sebastian
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 21 Jun 2018 09:33:20 +0300 - rev 809342
Push
113651 by kgupta@mozilla.com at Thu, 21 Jun 2018 22:29:49 +0000
Bug 1464990 - Allow easier testing Switchboard experiments; r=jchen,sebastian
Based on Sebastian's addon - https://github.com/pocmo/Addon-Switchboard-Experiments,
this will allow to easily enable / disable Switchboard experiments, process
that after Firefox 57 and the obsolescence of the addon was too cumbersome.
MozReview-Commit-ID: 2EkYQ42Bd8B
0d03ca9c61ddecad2a84332688381aa598fa95b4: Bug 1464990 - Allow easier testing Switchboard experiments; r?sebastian,jchen
draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 21 Jun 2018 09:33:20 +0300 - rev 809085
Push
113542 by plingurar@mozilla.com at Thu, 21 Jun 2018 06:34:26 +0000
Bug 1464990 - Allow easier testing Switchboard experiments; r?sebastian,jchen
Based on Sebastian's addon - https://github.com/pocmo/Addon-Switchboard-Experiments,
this will allow to easily enable / disable Switchboard experiments, process
that after Firefox 57 and the obsolescence of the addon was too cumbersome.
MozReview-Commit-ID: 2EkYQ42Bd8B
43d2406b3a70c61d53636a3625411c6c148baf94: Bug 1464990 - Allow easier testing Switchboard experiments; r?sebastian,jchen
draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 21 Jun 2018 09:19:14 +0300 - rev 809084
Push
113541 by plingurar@mozilla.com at Thu, 21 Jun 2018 06:21:10 +0000
Bug 1464990 - Allow easier testing Switchboard experiments; r?sebastian,jchen
Based on Sebastian's addon - https://github.com/pocmo/Addon-Switchboard-Experiments,
this will allow to easily enable / disable Switchboard experiments, process
that after Firefox 57 and the obsolescence of the addon was too cumbersome.
MozReview-Commit-ID: 2EkYQ42Bd8B
500e3aa27e585b7ecd4f46aa06a2756b36e1708c: Bug 1416169 - Part 3 - Switch the MediaControlService to only running on demand. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 11 Mar 2018 12:50:22 +0100 - rev 765957
Push
102192 by mozilla@buttercookie.de at Sun, 11 Mar 2018 14:42:35 +0000
Bug 1416169 - Part 3 - Switch the MediaControlService to only running on demand. r?sebastian
Now that the AudioFocusAgent keeps monitoring all relevant tab events and
notifies the MediaControlService as necessary, we can revert to only running the
service when actually required to show the notification.
MozReview-Commit-ID: KV6ars2BbMW
fcf86ac97f2dc04bf9d4f08878c0bda76c5ef99b: Bug 1416169 - Part 3 - Switch the MediaControlService to only running on demand. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 11 Mar 2018 12:50:22 +0100 - rev 765956
Push
102191 by mozilla@buttercookie.de at Sun, 11 Mar 2018 14:15:35 +0000
Bug 1416169 - Part 3 - Switch the MediaControlService to only running on demand. r?sebastian
Now that the AudioFocusAgent keeps monitoring all relevant tab events and
notifies the MediaControlService as necessary, we can revert to only running the
service when actually required to show the notification.
MozReview-Commit-ID: KV6ars2BbMW
9c122a19dc9b8258dfa5b82284a7b8568e9ddb79: Bug 1416169 - Part 2 - Move monitoring of Tab media events out of the MediaControlService. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 10 Mar 2018 18:38:32 +0100 - rev 765955
Push
102191 by mozilla@buttercookie.de at Sun, 11 Mar 2018 14:15:35 +0000
Bug 1416169 - Part 2 - Move monitoring of Tab media events out of the MediaControlService. r?sebastian
At the moment the MediaControlService is structured such that it is started
shortly after Firefox has launched. Then, it registers a Tab event listener and
starts listening for various, mainly media-related tab events, in response to
which the playback notification is then shown or hidden as appropriate.
This setup has the drawback that the service itself has to remain running all
the time, even when we're not actually showing the notification, so Firefox now
keeps showing up as a "Running service" even when in background and not doing
anything interesting.
It is however relatively easily possible to move the tab event tracking into a
different class that won't require a service to stay alive, and set the Media-
ControlService's state (and at the same time start it if necessary) through a
set of special intent actions.
MozReview-Commit-ID: 1CzBpC1LTuZ
0174caea0b446e2928529ed9f454c5b9a7802d68: Bug 1416169 - Part 1 - Silence StaticFieldLeak linter. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 11 Mar 2018 13:06:25 +0100 - rev 765954
Push
102191 by mozilla@buttercookie.de at Sun, 11 Mar 2018 14:15:35 +0000
Bug 1416169 - Part 1 - Silence StaticFieldLeak linter. r?sebastian
In practice we've already been using the application context anyway, but this
way makes it more explicit.
MozReview-Commit-ID: CYOs8MPnlcN
46255cc10c00d855f1bcc9084b95f435cef58be3: Bug 1416169 - Part 0 - Cleanups. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 10 Mar 2018 18:20:39 +0100 - rev 765953
Push
102191 by mozilla@buttercookie.de at Sun, 11 Mar 2018 14:15:35 +0000
Bug 1416169 - Part 0 - Cleanups. r?sebastian
Fix various things Android Studio is complaining about.
MozReview-Commit-ID: BdO0UTTsidi
4d3bc187d05c62dffe50132f328b71220db3f884: Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=sebastian
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 19 Sep 2017 12:05:47 -0400 - rev 756381
Push
99483 by bmo:daniel@haxx.se at Fri, 16 Feb 2018 22:46:48 +0000
Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=sebastian
MozReview-Commit-ID: JHIHB11vdWL
595df7b89b706c3737b3b90e1ddfb8744a2fae4e: Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
draft
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 19 Sep 2017 12:05:47 -0400 - rev 756144
Push
99394 by wisniewskit@gmail.com at Fri, 16 Feb 2018 14:37:01 +0000
Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
MozReview-Commit-ID: JHIHB11vdWL
2a715f8be8018110a4a103c819477a47da089064: Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
draft
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 19 Sep 2017 12:05:47 -0400 - rev 755614
Push
99218 by wisniewskit@gmail.com at Thu, 15 Feb 2018 15:57:25 +0000
Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
MozReview-Commit-ID: JHIHB11vdWL
ffe08b55d5bd46d8f8e37c6dee66b39beac48834: Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
draft
Thomas Wisniewski <wisniewskit@gmail.com> - Tue, 19 Sep 2017 12:05:47 -0400 - rev 755256
Push
99137 by wisniewskit@gmail.com at Thu, 15 Feb 2018 02:38:32 +0000
Bug 792808 - Change mobile/android/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r?sebastian
MozReview-Commit-ID: JHIHB11vdWL
8ac8d4c54c2b402cee26fd9a1e51acdf68f2d5c0: Bug 1372517 - Escape name before joining innerHTML. r=sebastian, a=lizzard
maliu <max@mxli.us> - Fri, 26 Jan 2018 10:04:54 -0600 - rev 750628
Push
97711 by bmo:tom@mozilla.com at Fri, 02 Feb 2018 17:06:03 +0000
Bug 1372517 - Escape name before joining innerHTML. r=sebastian, a=lizzard
MozReview-Commit-ID: 8Wh6SCuHK6F
298a722b096ef75a273ac4c3b21c848d75888db3: Bug 1372517 - Escape name before joining innerHTML, r=sebastian
maliu <max@mxli.us> - Fri, 26 Jan 2018 10:04:54 -0600 - rev 747730
Push
96994 by dholbert@mozilla.com at Fri, 26 Jan 2018 19:12:46 +0000
Bug 1372517 - Escape name before joining innerHTML, r=sebastian
MozReview-Commit-ID: 8Wh6SCuHK6F
527fe8b46d9e84b1bca4cbea7cb9016d389d6307: Bug 1430647 - Remove remaining uses of -moz-border-*-colors from android themes. r?sebastian
draft
Dão Gottwald <dao@mozilla.com> - Mon, 15 Jan 2018 20:36:31 +0100 - rev 720583
Push
95578 by dgottwald@mozilla.com at Mon, 15 Jan 2018 19:36:58 +0000
Bug 1430647 - Remove remaining uses of -moz-border-*-colors from android themes. r?sebastian
MozReview-Commit-ID: 8T3knkCyd9J
6055406a17c0a49afb197b72a93babd162ed04f2: Bug 1414928 - Part 2 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 720086
Push
95435 by mozilla@buttercookie.de at Sat, 13 Jan 2018 12:58:36 +0000
Bug 1414928 - Part 2 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressState hides it, but in all other
cases calling just updateProgressState is enough to set the new progress value.
MozReview-Commit-ID: 9mQr5s83i9F
547208db0c36b0313b2b99529234080165fece14: Bug 1414928 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 716381
Push
94419 by mozilla@buttercookie.de at Fri, 05 Jan 2018 16:35:02 +0000
Bug 1414928 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressVisibility hides it, but in all
other cases calling updateProgressVisibility is enough to set the new progress
value.
MozReview-Commit-ID: 9mQr5s83i9F
e96a224caec5a4d13cfa79c0c86ab7ba07ee7d84: Bug 1414928 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 715780
Push
94264 by mozilla@buttercookie.de at Thu, 04 Jan 2018 18:51:43 +0000
Bug 1414928 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressVisibility hides it, but in all
other cases calling updateProgressVisibility is enough to set the new progress
value.
MozReview-Commit-ID: 9mQr5s83i9F
d50dfb6c1850cc8cf0c505dc36bfdd818621f35f: Bug 1414928 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 714704
Push
94005 by mozilla@buttercookie.de at Thu, 28 Dec 2017 14:56:49 +0000
Bug 1414928 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressVisibility hides it, but in all
other cases calling updateProgressVisibility is enough to set the new progress
value.
MozReview-Commit-ID: 9mQr5s83i9F
6de19cc17677ce05435c367a499dc25c355c7b75: Bug 1414928 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 714597
Push
93959 by mozilla@buttercookie.de at Tue, 26 Dec 2017 13:22:44 +0000
Bug 1414928 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressVisibility hides it, but in all
other cases calling updateProgressVisibility is enough to set the new progress
value.
MozReview-Commit-ID: 9mQr5s83i9F
6658e79bcf488647a44e97a4cb9321bf51c682a0: Bug 1414928 - Updating the progress bar once is enough. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 06 Nov 2017 20:36:10 +0100 - rev 714394
Push
93910 by mozilla@buttercookie.de at Fri, 22 Dec 2017 17:56:06 +0000
Bug 1414928 - Updating the progress bar once is enough. r?sebastian
We still need to explicitly set the progress when loading stops, so the progress
bar animates to completion before updateProgressVisibility hides it, but in all
other cases calling updateProgressVisibility is enough to set the new progress
value.
MozReview-Commit-ID: 9mQr5s83i9F
61f764a76817075b74b43941f7cf340c1be134f0: Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 20:57:33 +0100 - rev 710487
Push
92832 by mozilla@buttercookie.de at Sun, 10 Dec 2017 17:34:06 +0000
Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
There is at least one reference to the MediaManagerService being used within
mobile in conjunction with WebRTC, so we should do the same thing that desktop
Firefox is doing here.
MozReview-Commit-ID: 1z1cLapxK2F
e7499cae2fef7f7ed27146048117e4e0088287bb: Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 21:49:44 +0100 - rev 710486
Push
92832 by mozilla@buttercookie.de at Sun, 10 Dec 2017 17:34:06 +0000
Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
This is a straight copy-and-paste of the desktop code in sanitize.js, except
that we handle importing offlineAppCache.jsm differently (compare also part 1).
MozReview-Commit-ID: 71r8LO4xzYF
33de86ded3e5d7990f508a296536c4fe2c1dd9ed: Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 20:57:33 +0100 - rev 710483
Push
92830 by mozilla@buttercookie.de at Sun, 10 Dec 2017 15:42:17 +0000
Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
There is at least one reference to the MediaManagerService being used within
mobile in conjunction with WebRTC, so we should do the same thing that desktop
Firefox is doing here.
MozReview-Commit-ID: 1z1cLapxK2F
b5bb35b89586a400cd4a26bd98452b931c757730: Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 21:49:44 +0100 - rev 710482
Push
92830 by mozilla@buttercookie.de at Sun, 10 Dec 2017 15:42:17 +0000
Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
This is a straight copy-and-paste of the desktop code in sanitize.js, except
that we handle importing offlineAppCache.jsm differently (compare also part 1).
MozReview-Commit-ID: 71r8LO4xzYF
1f45212f6cebadcfbb8da61a92a0d345ff608e41: Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 20:57:33 +0100 - rev 710441
Push
92826 by mozilla@buttercookie.de at Sun, 10 Dec 2017 12:37:41 +0000
Bug 1415342 - Part 3 - Clear MediaMmanager deviceIds when clearing cookies. r?sebastian
There is at least one reference to the MediaManagerService being used within
mobile in conjunction with WebRTC, so we should do the same thing that desktop
Firefox is doing here.
MozReview-Commit-ID: 1z1cLapxK2F
8dd963e8a737334a687d7544ee03d71b5258c058: Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 21:49:44 +0100 - rev 710440
Push
92826 by mozilla@buttercookie.de at Sun, 10 Dec 2017 12:37:41 +0000
Bug 1415342 - Part 2 - Copy offlineApps sanitizing code from desktop implementation. r?sebastian
This is a straight copy-and-paste of the desktop code in sanitize.js, except
that we handle importing offlineAppCache.jsm differently (compare also part 1).
MozReview-Commit-ID: 71r8LO4xzYF
ef1ac6d87e9246b379c52a39ab0134c0a0fe38dd: Bug 1424523 - Lazify Sanitizer.jsm's imports. r?sebastian
draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Dec 2017 20:23:56 +0100 - rev 710438
Push
92826 by mozilla@buttercookie.de at Sun, 10 Dec 2017 12:37:41 +0000
Bug 1424523 - Lazify Sanitizer.jsm's imports. r?sebastian
Even though the Sanitizer itself will be lazy-loaded, most imports are only
required for specific data categories. Therefore for users who aren't clearing
all data at once, lazy-loading can still be beneficial.
MozReview-Commit-ID: CLM1BN0XeJj
733552921142a406e7d423ebb3b193d5f44ef4a0: Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 01 Dec 2017 15:11:21 +0100 - rev 706805
Push
91936 by bmo:emilio@crisal.io at Mon, 04 Dec 2017 10:24:39 +0000
Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian
MozReview-Commit-ID: IOSHvaOOE19
0f2faf85925519ce4b85f25c715dffb3c8f243ba: Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian
draft
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 01 Dec 2017 15:11:21 +0100 - rev 706675
Push
91878 by mozilla@buttercookie.de at Sun, 03 Dec 2017 20:20:31 +0000
Bug 1421874 - Fix SessionStore to include AppConstants before using it; r=sebastian
MozReview-Commit-ID: IOSHvaOOE19
f73829da13e29ff0bf12c205f15b3cccd6ab7e03: Bug 1421874 - Fix SessionStore to include AppConstants before using it; r?sebastian
draft
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 01 Dec 2017 15:11:21 +0100 - rev 706225
Push
91740 by gsvelto@mozilla.com at Fri, 01 Dec 2017 14:15:49 +0000
Bug 1421874 - Fix SessionStore to include AppConstants before using it; r?sebastian
MozReview-Commit-ID: IOSHvaOOE19
c91b3c467cc3f13d3da878dc2f9b3b7d05227609: Bug 1352497 - Remove about:healthreport. r?gfritzsche,sebastian
draft
Dão Gottwald <dao@mozilla.com> - Tue, 28 Nov 2017 11:38:15 +0100 - rev 704207
Push
91104 by dgottwald@mozilla.com at Tue, 28 Nov 2017 10:38:43 +0000
Bug 1352497 - Remove about:healthreport. r?gfritzsche,sebastian
MozReview-Commit-ID: 4FQ5aL2XrU5
ff75ef015293c18eb00f34b0df278c36f292bf94: Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=ahunt,sebastian
Johann Hofmann <jhofmann@mozilla.com> - Wed, 22 Nov 2017 14:49:35 +0100 - rev 704142
Push
91098 by bmo:igoldan@mozilla.com at Tue, 28 Nov 2017 10:28:18 +0000
Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=ahunt,sebastian
MozReview-Commit-ID: AyYD4HedXFv
9542e943f1003419847cf01925556a130b3fbcef: Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 07 Nov 2017 22:07:05 +0100 - rev 703934
Push
91002 by bmo:psnyde2@uic.edu at Mon, 27 Nov 2017 22:40:16 +0000
Bug 1415297 - Dispatch TabEvents.LOADED again on DOMContentLoaded. r=sebastian
AddToHomeScreenPromotion uses this for triggering the self-same promotion and
the BrowserToolbar uses it to update its progress display.
MozReview-Commit-ID: 1xrwjWP5Idh
5c345ae5cbc2f4b0352d5e34c11478366240cbae: Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=sebastian
draft
Johann Hofmann <jhofmann@mozilla.com> - Wed, 22 Nov 2017 14:49:35 +0100 - rev 703798
Push
90977 by bmo:jhofmann@mozilla.com at Mon, 27 Nov 2017 19:50:43 +0000
Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=sebastian
MozReview-Commit-ID: AyYD4HedXFv
adaf1eeb7f13ce421dbaca3f9ae27d60ba9c1e4a: Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=sebastian
draft
Johann Hofmann <jhofmann@mozilla.com> - Wed, 22 Nov 2017 14:49:35 +0100 - rev 702159
Push
90403 by bmo:jhofmann@mozilla.com at Wed, 22 Nov 2017 20:44:03 +0000
Bug 1374574 - Remove the FlyWeb system add-on from Fennec. r=sebastian
MozReview-Commit-ID: AyYD4HedXFv
b61ba501efd9ecb43689edf7ca23c521a3d46176: Bug 1352497 - Remove about:healthreport. r?gfritzsche,sebastian
draft
Dão Gottwald <dao@mozilla.com> - Wed, 22 Nov 2017 13:51:08 +0100 - rev 701940
Push
90309 by dgottwald@mozilla.com at Wed, 22 Nov 2017 12:51:35 +0000
Bug 1352497 - Remove about:healthreport. r?gfritzsche,sebastian
MozReview-Commit-ID: 8aPg9oDFIlu