searching for reviewer(sdaswani)
555eec3c6e2f7f99c9bfa49f4f4b066b94d2e902: Bug 1480007 Image not displayed for Welcome screen - Sign in to Sync r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 07 Aug 2018 07:39:40 -0700 - rev 827218
Push 118499 by bmo:andrei.a.lazar@softvision.ro at Tue, 07 Aug 2018 14:40:39 +0000
Bug 1480007 Image not displayed for Welcome screen - Sign in to Sync r?sdaswani Fixed the issue where we it was trying to parse a drawable instead of an id from parcelable. MozReview-Commit-ID: IEgmAT39JiQ
2ec4b263cfa779bb40dd3b78340ed71651a5c5f0: Bug 1480079 - Add REQUEST_INSTALL_PACKAGES permission for all builds; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 07 Aug 2018 16:34:25 +0300 - rev 827200
Push 118493 by plingurar@mozilla.com at Tue, 07 Aug 2018 13:36:21 +0000
Bug 1480079 - Add REQUEST_INSTALL_PACKAGES permission for all builds; r?sdaswani This permission is needed on API26+ to be able to install app updates but also other downloaded APKs. MozReview-Commit-ID: Lk0uqBAJ5BH
852950b3b9dd413a13c2346e65b94fa950280737: Bug 1480079 - Add REQUEST_INSTALL_PACKAGES permission for all builds; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 03 Aug 2018 13:52:57 +0300 - rev 826304
Push 118283 by plingurar@mozilla.com at Fri, 03 Aug 2018 13:52:05 +0000
Bug 1480079 - Add REQUEST_INSTALL_PACKAGES permission for all builds; r?sdaswani This permission is needed on API26+ to be able to install app updates but also other downloaded APKs. MozReview-Commit-ID: Lk0uqBAJ5BH
dfd2961c65d087e8cacc9d2ae7331b2318e23197: Bug 1410218 - Fix NPE when cast fails; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 03 Aug 2018 13:26:55 +0300 - rev 826211
Push 118271 by plingurar@mozilla.com at Fri, 03 Aug 2018 10:32:32 +0000
Bug 1410218 - Fix NPE when cast fails; r?sdaswani This happened whenever starting to cast a video and loading the media failed. MediaStatus in this case would be null and querying it would throw a NullPointerException. Avoiding this query when the MediaStatus is null lets the normal execution flow continue and if loading media failed casting will fail gracefully. MozReview-Commit-ID: 8ZOqr1FO1Dt
59bf396efde329725e67491828a959f9b1cd35e4: Bug 1349522 - Provide alternative adaptive-icon with Android SDK O; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 02 Aug 2018 13:22:19 +0300 - rev 825801
Push 118170 by plingurar@mozilla.com at Thu, 02 Aug 2018 10:24:36 +0000
Bug 1349522 - Provide alternative adaptive-icon with Android SDK O; r?sdaswani Used the provided foreground layers and background color for the icons of Release and Nightly. Used the old icon and the provided background color for the icons of Beta and Dev builds. Proper icons for them will be added in bug 1479724. The old icons - /drawable/icon.png are still kept because they are used as logos and also by SiteIdentityPopup.java. MozReview-Commit-ID: EA9pojukhmw
392c1a9922296c71c9f247a9a1bfc22904c8c803: Bug 1476271 - Perma Could not find com.google.android.gms:play-services-analytics:15.0.1; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 01 Aug 2018 18:28:13 +0300 - rev 825362
Push 118084 by plingurar@mozilla.com at Wed, 01 Aug 2018 15:33:37 +0000
Bug 1476271 - Perma Could not find com.google.android.gms:play-services-analytics:15.0.1; r?sdaswani There is no 15.0.1 version of play-services-analytics. But there is a 15.0.2 version released in the same day as 15.0.1 for others so we'll use that until we can consolidate again all play-services to use the same version. Removed the workaround to force using the same gms version as it was already not needed anymore. MozReview-Commit-ID: C5iQrvXZNJt
e9dfe6306a214daa75b9025763b79a2fa2b2539a: Bug 1474859 - Enable Multidex for all builds; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 01 Aug 2018 15:44:01 +0300 - rev 825337
Push 118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1474859 - Enable Multidex for all builds; r?sdaswani Multidex will now be enabled for all builds, not just for the _local_ ones. MozReview-Commit-ID: FRTXBD9Kc6T
f1ac08bb356e8e59c0ac43686087ffba25ba5d78: Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 01 Aug 2018 09:09:11 +0300 - rev 825262
Push 118048 by plingurar@mozilla.com at Wed, 01 Aug 2018 06:10:09 +0000
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani As per https://android-developers.googleblog.com/2017/08/making-it-safer-to-get-apps-on-android-o.html and https://developer.android.com/reference/android/Manifest.permission.html#REQUEST_INSTALL_PACKAGES after targeting API 26 we need a new permission to be able to install Apks. MozReview-Commit-ID: BF28HTkwYTN
db9e524d164894b6a8552b109f43cddc9ea593c7: Bug 1349522 - Provide alternative adaptive-icon with Android SDK O; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 31 Jul 2018 13:18:33 +0300 - rev 824640
Push 117960 by plingurar@mozilla.com at Tue, 31 Jul 2018 14:17:49 +0000
Bug 1349522 - Provide alternative adaptive-icon with Android SDK O; r?sdaswani Used the provided foreground layers and background color for the icons of Release and Nightly. Used the old icon and the provided background color for the icons of Beta and Dev builds. Proper icons for them will be added in bug 1479724. The old icons - /drawable/icon.png are still kept because they are used as logos and also by SiteIdentityPopup.java. MozReview-Commit-ID: EA9pojukhmw
a789b68dd8285d8f9cede97fbfb84b9f4062e6b3: Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 31 Jul 2018 09:48:06 +0300 - rev 824507
Push 117935 by plingurar@mozilla.com at Tue, 31 Jul 2018 06:49:14 +0000
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani As per https://android-developers.googleblog.com/2017/08/making-it-safer-to-get-apps-on-android-o.html and https://developer.android.com/reference/android/Manifest.permission.html#REQUEST_INSTALL_PACKAGES after targeting API 26 we need a new permission to be able to install Apks. MozReview-Commit-ID: BF28HTkwYTN
47d21320b8f23d857bed5cea763c1f0e49d45c0e: Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 30 Jul 2018 18:03:21 +0300 - rev 824282
Push 117859 by plingurar@mozilla.com at Mon, 30 Jul 2018 15:04:03 +0000
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+; r?sdaswani As per https://android-developers.googleblog.com/2017/08/making-it-safer-to-get-apps-on-android-o.html and https://developer.android.com/reference/android/Manifest.permission.html#REQUEST_INSTALL_PACKAGES after targeting API 26 we need a new permission to be able to install Apks. MozReview-Commit-ID: BF28HTkwYTN
eb3011d304daf31650f5fc05a1ead4cdd0b63c49: Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Mon, 30 Jul 2018 16:21:09 +0300 - rev 824268
Push 117848 by vbaicu@mozilla.com at Mon, 30 Jul 2018 13:23:09 +0000
Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani Created a new parcelable which is sent to MediaControlService where the notification is created based on the data of this object instead of referencing a static notification. Toggling the service is now done through startService with a specific action for shutting down instead of calling stopService due to concurrency issues where the service can be stopped before having a chance to call startForeground. MozReview-Commit-ID: 6qNPintkVy
2c8fd20cb103fc7ef68d58a36c125fbfec7d04c3: Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 26 Jul 2018 19:28:29 +0300 - rev 823123
Push 117582 by vbaicu@mozilla.com at Thu, 26 Jul 2018 16:30:30 +0000
Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani Created a new parcelable which is sent to MediaControlService where the notification is created based on the data of this object instead of referencing a static notification. Toggling the service is now done through startService with a specific action for shutting down instead of calling stopService due to concurrency issues where the service can be stopped before having a chance to call startForeground. MozReview-Commit-ID: 6qNPintkVy
52c21f4c0eb9c13e630d554eceb8c77a78f55860: Bug 1476720 - Set MLS notification action. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 26 Jul 2018 17:42:19 +0300 - rev 823098
Push 117561 by vbaicu@mozilla.com at Thu, 26 Jul 2018 14:43:54 +0000
Bug 1476720 - Set MLS notification action. r?sdaswani Moved notification channels to NotificationHelper and created new utility methods to retrieve them when needed. Cleaned unused imports. MozReview-Commit-ID: L3HnV3nD7Og
35bda3090f064a5ff42720c04b2a136d92ad5e88: Bug 1476720 - Set MLS notification action. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 25 Jul 2018 14:32:02 +0300 - rev 823097
Push 117561 by vbaicu@mozilla.com at Thu, 26 Jul 2018 14:43:54 +0000
Bug 1476720 - Set MLS notification action. r?sdaswani Added a content action which will open the privacy settings when tapping the mozilla location services notification. MozReview-Commit-ID: 9h85amcoF0T
48b84a7dc3eec9bfdb64646185f8627ad2809450: Bug 1233706 - Make error message more helpful for instrumented Robocop tests; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 26 Jul 2018 13:36:34 +0300 - rev 822915
Push 117519 by plingurar@mozilla.com at Thu, 26 Jul 2018 10:38:30 +0000
Bug 1233706 - Make error message more helpful for instrumented Robocop tests; r?sdaswani MozReview-Commit-ID: 286GgFXm0vR
db49e15e393d8c930e631217507addb24f5aa1f3: Bug 1474888 - Fix Prompt.java's AlertDialog; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 26 Jul 2018 09:37:26 +0300 - rev 822870
Push 117497 by plingurar@mozilla.com at Thu, 26 Jul 2018 06:39:03 +0000
Bug 1474888 - Fix Prompt.java's AlertDialog; r?sdaswani PromptService will be informed when the screen is rotated and in turn it will ask every Prompt shown to reset it's current layout. For this, every Prompt will - save it's current input value in PromptInput's mValue or similar field already used for storing the default PromptInput value. - create a new widget to be used in the new AlertDialog, with a new appropriate layout for portrait / landscape. This is when the mValue field will be used to initialize the new widget with the previous input. MozReview-Commit-ID: L6eHyGNDt3d
72a6ee705c3f2194f863aefb2d7053164e4c1ea8: Bug 1477700 Android media notification appears swiped down after video starts r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 25 Jul 2018 17:41:26 +0300 - rev 822632
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1477700 Android media notification appears swiped down after video starts r?sdaswani Created a dedicated channel for media notifications. MozReview-Commit-ID: JKFVPNRu2WO
9f8c05a5c6ee6945ab0e0f92c26aa115e1dfbc50: Bug 1412518 - Photon themed DatePicker; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 25 Jul 2018 17:17:28 +0300 - rev 822587
Push 117411 by plingurar@mozilla.com at Wed, 25 Jul 2018 14:20:33 +0000
Bug 1412518 - Photon themed DatePicker; r?sdaswani On Api >=21 the Material DatePicker will have applied a Photon style. Below Api 21 DatePicker will still be using spinners. MozReview-Commit-ID: LuWP6C1o4Ej
c8940fc882ff55cd2eb4d0dd241d4da6c487dab9: Bug 1412518 - Photon themed TimePicker; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 25 Jul 2018 17:03:15 +0300 - rev 822586
Push 117411 by plingurar@mozilla.com at Wed, 25 Jul 2018 14:20:33 +0000
Bug 1412518 - Photon themed TimePicker; r?sdaswani On Api >=21 the Material TimePicker will have applied a Photon style. Below Api 21 TimePicker will still be using spinners. MozReview-Commit-ID: 2jZLPGCx4rI
49b9023788436d3d0a8b0520f1a6cf6b46f79eae: Bug 1476966 Constant notification ringing when downloading a file r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 25 Jul 2018 12:01:30 +0300 - rev 822424
Push 117368 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 09:02:26 +0000
Bug 1476966 Constant notification ringing when downloading a file r?sdaswani Created specific notification channel dedicated to progressive notifications. MozReview-Commit-ID: 88vsQiI2L2
fd2d07394a1bc7bc477362fc1690049fb9ae4561: Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Tue, 24 Jul 2018 20:42:36 +0300 - rev 822079
Push 117280 by vbaicu@mozilla.com at Tue, 24 Jul 2018 18:02:05 +0000
Bug 1477041 - Modified MediaControlService and notification flow. r?sdaswani Created a new parcelable which is sent to MediaControlService where the notification is created based on the data of this object instead of referencing a static notification. Toggling the service is now done through startService with a specific action for shutting down instead of calling stopService due to concurrency issues where the service can be stopped before having a chance to call startForeground. MozReview-Commit-ID: 6qNPintkVy
7553f521384ecb02e5eb9d09e8d97ed938f74401: Bug 1476900 - Can't update Nightly from about:firefox or notification bar; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 24 Jul 2018 17:31:59 +0300 - rev 822015
Push 117253 by plingurar@mozilla.com at Tue, 24 Jul 2018 14:34:45 +0000
Bug 1476900 - Can't update Nightly from about:firefox or notification bar; r?sdaswani The problem was because on API >=26 the JobIntentServices used for the updater functionality will be used by JobScheduler by binding to them. But because they were set to run in a different process the binding was not possible. MozReview-Commit-ID: I8rbcoLyhyJ
b5f79204032bfa3de2826e40c19b718fef404812: Bug 1476710 - Use childFragmentmanager when dismissing TabHistoryFragment; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 24 Jul 2018 10:15:51 +0300 - rev 821899
Push 117213 by plingurar@mozilla.com at Tue, 24 Jul 2018 07:16:44 +0000
Bug 1476710 - Use childFragmentmanager when dismissing TabHistoryFragment; r?sdaswani MozReview-Commit-ID: 1DyoBj0wpRe
e48eee3598f0ad440a04e235ff97579244c578e3: Bug 1474888 - Fix Prompt.java's AlertDialog; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 23 Jul 2018 18:20:15 +0300 - rev 821540
Push 117124 by plingurar@mozilla.com at Mon, 23 Jul 2018 15:22:56 +0000
Bug 1474888 - Fix Prompt.java's AlertDialog; r?sdaswani PromptService will be informed when the screen is rotated and in turn it will ask every Prompt shown to reset it's current layout. For this, every Prompt will - save it's current input value in PromptInput's mValue or similar field already used for storing the default PromptInput value. - create a new widget to be used in the new AlertDialog, with a new appropriate layout for portrait / landscape. This is when the mValue field will be used to initialize the new widget with the previous input. MozReview-Commit-ID: L6eHyGNDt3d
fd178a98784aaf3d4840c3af429169857d1a5fcc: Bug 1476424 Crash in android.os.TransactionTooLargeException: data parcel size 3124056 bytes at android.os.BinderProxy.transactNative(Native Method) r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 23 Jul 2018 13:08:49 +0300 - rev 821450
Push 117097 by bmo:andrei.a.lazar@softvision.ro at Mon, 23 Jul 2018 10:13:05 +0000
Bug 1476424 Crash in android.os.TransactionTooLargeException: data parcel size 3124056 bytes at android.os.BinderProxy.transactNative(Native Method) r?sdaswani Upon saving the state of onboarding fragments, the bundle can exceed 3MB because of the bitmaps. Therefore, now we pass a resources id instead of passing the full bitmap through the bundle. MozReview-Commit-ID: 9zpXrmolT38
195476afb0b45ec0580238a83c76a8f682c5625c: Bug 1477234 - WeekPicker starts with incorrect values; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 23 Jul 2018 10:07:39 +0300 - rev 821420
Push 117086 by plingurar@mozilla.com at Mon, 23 Jul 2018 07:12:39 +0000
Bug 1477234 - WeekPicker starts with incorrect values; r?sdaswani MozReview-Commit-ID: AKXF2e7ktpN
9f65508bb2a3e93ea54c5e3785ae74bb60861180: Bug 1476716 - Use DownloadManager.COLUMN_LOCAL_URI to query downloads; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 19 Jul 2018 17:59:36 +0300 - rev 820428
Push 116824 by plingurar@mozilla.com at Thu, 19 Jul 2018 15:00:35 +0000
Bug 1476716 - Use DownloadManager.COLUMN_LOCAL_URI to query downloads; r?sdaswani After API 24 DownloadManager.COLUMN_LOCAL_FILENAME got deprecated and querying for it would throw an error. To get around this DownloadManager.COLUMN_LOCAL_URI can be used but which adds the "file://" prefix. MozReview-Commit-ID: CvkoFyRCLo6
089400d988a88afd2635f8fdcdf23a418778e6bf: Bug 1476720 - Set MLS notification action. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 19 Jul 2018 16:28:25 +0300 - rev 820380
Push 116802 by vbaicu@mozilla.com at Thu, 19 Jul 2018 13:29:32 +0000
Bug 1476720 - Set MLS notification action. r?sdaswani Added a content action which will open the privacy settings when tapping the mozilla location services notification. MozReview-Commit-ID: 9h85amcoF0T
6861720f593cf8a4fcfefbff0fdab7500c5dc28e: Bug 1476676 - Do Gecko initialization on main thread; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 19 Jul 2018 14:51:41 +0300 - rev 820281
Push 116784 by plingurar@mozilla.com at Thu, 19 Jul 2018 11:52:44 +0000
Bug 1476676 - Do Gecko initialization on main thread; r?sdaswani When migrating GeckoService to Oreo (Bug 1467840), the Gecko initialization was inadvertently moved on a background thread. This patch moves the initialization back on main thread. MozReview-Commit-ID: Cxp7lGzPgXH
511d845915503becddf6fd2a30cb82742ba70c69: Bug 1476596 - Prevent Stumbler notification being shown after reboot. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 18 Jul 2018 18:55:20 +0300 - rev 819766
Push 116653 by vbaicu@mozilla.com at Wed, 18 Jul 2018 15:56:34 +0000
Bug 1476596 - Prevent Stumbler notification being shown after reboot. r?sdaswani Because of the START_STICKY flag, upon boot completed, the service would be started by the system which would trigger onStartCommand and the notification being shown on Android Oreo+ devices without a following call to onHandleIntent. MozReview-Commit-ID: EldSSzRb7Zd
a9780313e941f39f642e718dd07c60a7531fd1b7: Bug 1476352 - Building Fennec fails with crash reporting off; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Jul 2018 17:28:40 +0300 - rev 819756
Push 116643 by plingurar@mozilla.com at Wed, 18 Jul 2018 14:29:51 +0000
Bug 1476352 - Building Fennec fails with crash reporting off; r?sdaswani MozReview-Commit-ID: AvKQIoxNVRJ
bb3bbc4d83d09dbe33e62b2b321554c33c42a081: Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Jul 2018 15:21:03 +0300 - rev 819732
Push 116630 by plingurar@mozilla.com at Wed, 18 Jul 2018 12:27:32 +0000
Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r?sdaswani Refactored the previous test which verified if a Service was started with the right Intent to now check if JobScheduler has the right Job enqueued with the right work Intent. MozReview-Commit-ID: G46GbjVVkqR
729aa7c027ce61c6f51024e8a824ea990c77cd4e: Bug 1476237 - Fix TestFileCleanupController after the Oreo migration; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Jul 2018 12:14:13 +0300 - rev 819731
Push 116630 by plingurar@mozilla.com at Wed, 18 Jul 2018 12:27:32 +0000
Bug 1476237 - Fix TestFileCleanupController after the Oreo migration; r?sdaswani This tests verified if a Service was started or not. After the IntentServices migration to JobIntentService this checks would not work anymore. To keep the same test logic they will now check if JobScheduler has any scheduled jobs. Removed testStartIfReadyDoesNotRunTwiceInSuccession() because JobScheduler already guarantees no two identical jobs can be scheduled in parallel. MozReview-Commit-ID: JZ2XMecjsXq
5fd146333ae0dbf4aa4f9d885ea91144de4368a6: Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Jul 2018 12:20:52 +0300 - rev 819674
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r?sdaswani Refactored the previous test which verified if a Service was started and with which Intent into two tests: - one that will check if the right JobIntentService was enqueued and - one which will check the enqueued Intent of work. MozReview-Commit-ID: G46GbjVVkqR
9851afb6d5bc1776b62bd4d27fe0683aff0f4ac6: Bug 1476237 - Fix TestFileCleanupController after the Oreo migration; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 18 Jul 2018 12:14:13 +0300 - rev 819673
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1476237 - Fix TestFileCleanupController after the Oreo migration; r?sdaswani This tests verified if a Service was started or nor. After the IntentServices migration to JobIntentService this checks would not work anymore. To keep the same test logic they will now check if JobScheduler has any scheduled jobs. Removed testStartIfReadyDoesNotRunTwiceInSuccession() because JobScheduler already guarantees no two identical jobs can be scheduled in parallel. MozReview-Commit-ID: JZ2XMecjsXq
bca835c3d6444dcc7cb157151ff3453ebdd2878d: Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 11 Jul 2018 20:02:24 +0300 - rev 819670
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani Also made broadcasts involving Stumbler explicit. MozReview-Commit-ID: 7CK2Cr2JqX0
2cf9efa9f24234615d8c5474768f867589d90477: Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 05 Jul 2018 19:35:16 +0300 - rev 819668
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani Modified NotificationClient to use new start/stop intents for NotificationService for Android O. We are keeping a reference to the notification the service was first started with in order to comply with the mandatory startForeground call for Oreo. MozReview-Commit-ID: 4CzM4pvANJt
b22385040351696b4b56112773c4352be5e2217b: Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 22 Jun 2018 19:02:54 +0300 - rev 819667
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani Moved the logic ouf of MediaControlService to a new singleton GeckoMediaControlAgent, which delegates all media-related actions.Currently, MediaControlService is used for the foreground notification and to retrieve actions from the notification pending intents. Removed redundant test cases. MozReview-Commit-ID: KukAmpnn33S
8ce142826049783086a85660f0a20c0349dfbf41: Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 06 Jul 2018 13:21:27 +0300 - rev 819666
Push 116608 by plingurar@mozilla.com at Wed, 18 Jul 2018 10:29:34 +0000
Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani Refactored existing LeanplumPushInstanceIDService to support Oreo background execution limits in Leanplum after upgrade. MozReview-Commit-ID: JjUlrOv34KR ***
8cfcd58f4cd29d7ed7ffe1295fa8d800fa07c224: Bug 1460074 - Still cannot switch between years in date picker; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 16 Jul 2018 18:54:26 +0300 - rev 818809
Push 116349 by plingurar@mozilla.com at Mon, 16 Jul 2018 15:56:10 +0000
Bug 1460074 - Still cannot switch between years in date picker; r?sdaswani The problem stemmed from having the DatePicker inside a ScrollView which was receiving the swipe events. To avoid this I've created the new FocusableDatePicker which has the ability to prevent it's parent from receiving touch events. MozReview-Commit-ID: 6VntjE5A0ec
0cb6fbba23a06c5a2fd26b2666bd121159887baf: Bug 1475251 - HTTP auth dialog looks wrong; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 16 Jul 2018 11:47:39 +0300 - rev 818642
Push 116307 by plingurar@mozilla.com at Mon, 16 Jul 2018 08:48:24 +0000
Bug 1475251 - HTTP auth dialog looks wrong; r?sdaswani Specialized the code added in Bug 1412517 so that it will apply only for date/time inputs. The rest will have the previous behaviour. MozReview-Commit-ID: JCAruK4x3r1
14d3505a22182571faa448fd4d43fa6b06ae0ddc: Bug 1474925 - TimePicker swipe not possible in landscape; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 16 Jul 2018 11:34:38 +0300 - rev 818641
Push 116306 by plingurar@mozilla.com at Mon, 16 Jul 2018 08:35:21 +0000
Bug 1474925 - TimePicker swipe not possible in landscape; r?sdaswani MozReview-Commit-ID: DVp6d40OLE3
2d87fc6f48a95558acf268bf1669510abb1d4c02: Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 11 Jul 2018 20:02:24 +0300 - rev 817990
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani Also made broadcasts involving Stumbler explicit. MozReview-Commit-ID: 7CK2Cr2JqX0
9a91c36b6e3c6278f13a0c942d0bdf1f238aeb4d: Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 05 Jul 2018 19:35:16 +0300 - rev 817988
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani Modified NotificationClient to use new start/stop intents for NotificationService for Android O. We are keeping a reference to the notification the service was first started with in order to comply with the mandatory startForeground call for Oreo. MozReview-Commit-ID: 4CzM4pvANJt
60f381e7555e5fe68e84c86da6c868a7a3b004ca: Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 22 Jun 2018 19:02:54 +0300 - rev 817987
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani Moved the logic ouf of MediaControlService to a new singleton GeckoMediaControlAgent, which delegates all media-related actions.Currently, MediaControlService is used for the foreground notification and to retrieve actions from the notification pending intents. Removed redundant test cases. MozReview-Commit-ID: KukAmpnn33S
16f0d980b7ab320f512f7e705f26dd7f58de7d51: Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 06 Jul 2018 13:21:27 +0300 - rev 817986
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani Refactored existing LeanplumPushInstanceIDService to support Oreo background execution limits in Leanplum after upgrade. MozReview-Commit-ID: JjUlrOv34KR ***
86dc30aed7445e07f38ea95cba9d58f162178b67: Bug 1467840 - Use a JobIntentService for GCM token refresh; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 19:04:10 +0300 - rev 817981
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1467840 - Use a JobIntentService for GCM token refresh; r?sdaswani Whenever the GCM token expires it need to be refreshed. For this, after targeting Android 8.0 (API level 26) or higher Google recommends using a JobIntentService https://developers.google.com/cloud-messaging/android/client MozReview-Commit-ID: 1vz092TQfbz
aad8ccc7c64c773d2a2336b332e57dae6c7ea7ab: Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 17:31:19 +0300 - rev 817972
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1407046 - Migrate DownloadContentService to JobIntentService; r?sdaswani Broke the big IntentService into four small JobIntentServices because the same JobIntentService class cannot be used with multiple JobIds (https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121) Also: - will make the code easier to be migrated to WorkManager in the future - more in line with SRP. It was initially doing too much. Cleaned the code a little, removed the superfluous creation of new Threads for DownloadContentCatalog().persistChanges() / .startLoadFromDisk() as those methods are always called from the background threads of the new JobIntentServices. The new DlcHelper helps reducing duplicated code. MozReview-Commit-ID: G3fsWYOGEbR
8c67c2701920dc7f0c0e20547ce40645932be909: Bug 1460074 - Still cannot switch between years in date picker; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 12 Jul 2018 18:30:41 +0300 - rev 817376
Push 116046 by plingurar@mozilla.com at Thu, 12 Jul 2018 15:31:46 +0000
Bug 1460074 - Still cannot switch between years in date picker; r?sdaswani The problem stemmed from having the DatePicker inside a ScrollView which was receiving the swipe events. To avoid this I've created the new FocusableDatePicker which has the ability to prevent it's parent from receiving touch events. MozReview-Commit-ID: 6VntjE5A0ec