searching for reviewer(pbrosset)
7c47bd2ca077c6663a67edf49a67117b7a5de2be: Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/ tests. r?pbrosset draft
Jonathan Kingston <jkt@mozilla.com> - Wed, 21 Feb 2018 23:21:03 +0000 - rev 758194
Push 99977 by bmo:jkt@mozilla.com at Thu, 22 Feb 2018 00:30:37 +0000
Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/ tests. r?pbrosset MozReview-Commit-ID: GNEe8H0sc4L
51d915eb8247ec5ea8a8fa09e80cafbc5e869b45: Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/. r?pbrosset draft
Jonathan Kingston <jkt@mozilla.com> - Wed, 21 Feb 2018 16:01:03 +0000 - rev 758192
Push 99977 by bmo:jkt@mozilla.com at Thu, 22 Feb 2018 00:30:37 +0000
Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/. r?pbrosset MozReview-Commit-ID: KecQcZWeU6a
0e60523388fe048cfe3007d1be6bba0b78f500d2: Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/ tests. r?pbrosset draft
Jonathan Kingston <jkt@mozilla.com> - Wed, 21 Feb 2018 23:21:03 +0000 - rev 758163
Push 99967 by bmo:jkt@mozilla.com at Wed, 21 Feb 2018 23:23:15 +0000
Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/ tests. r?pbrosset MozReview-Commit-ID: GNEe8H0sc4L
9e7ba173c93d0fbb1ffd4224fd68e514bdf62c09: Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/. r?pbrosset draft
Jonathan Kingston <jkt@mozilla.com> - Wed, 21 Feb 2018 16:01:03 +0000 - rev 757954
Push 99895 by bmo:jkt@mozilla.com at Wed, 21 Feb 2018 17:05:53 +0000
Bug 1374741 - Have openUILinkIn() provide the correct triggeringPrincipal within devtools/. r?pbrosset MozReview-Commit-ID: KecQcZWeU6a
0e67208dfe247daf1f03ce4e4e0f17f59e0f04d4: Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset, a=ritu
Henri Kemppainen <mozilla@guu.fi> - Wed, 04 Oct 2017 23:52:53 +0300 - rev 678003
Push 83805 by bmo:rail@mozilla.com at Tue, 10 Oct 2017 19:01:30 +0000
Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset, a=ritu
0936cbb593b99ae0a62efa0440bb2c3d4a3e5735: Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset
Henri Kemppainen <mozilla@guu.fi> - Wed, 04 Oct 2017 23:52:53 +0300 - rev 676091
Push 83398 by bmo:rail@mozilla.com at Fri, 06 Oct 2017 17:12:44 +0000
Bug 1404716 - Hide GCLI in DOM fullscreen mode. r=Gijs, r=pbrosset
e7dded8b15b83ddc158c56cb12e5bfed22c0ec4f: Bug 1377851 - Use srcdoc instead of data: URI within devtools/client/sourceeditor/editor.js. r=pbrosset draft
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 03 Jul 2017 12:16:13 +0200 - rev 617690
Push 71122 by bmo:urbankrajnc92@gmail.com at Fri, 28 Jul 2017 20:51:54 +0000
Bug 1377851 - Use srcdoc instead of data: URI within devtools/client/sourceeditor/editor.js. r=pbrosset
af4b2bded6e04f814419f3d232e39ee00819a312: Bug 1377851 - Load code mirror frame from external file within devtools. r=pbrosset
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 05 Jul 2017 14:10:07 +0200 - rev 604248
Push 67021 by bmo:rail@mozilla.com at Wed, 05 Jul 2017 17:37:39 +0000
Bug 1377851 - Load code mirror frame from external file within devtools. r=pbrosset
4f8bb917762cc4195a0e8c459c84e28e7e93ff66: Bug 1377851 - Use srcdoc instead of data: URI within devtools/client/sourceeditor/editor.js. r=pbrosset
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 03 Jul 2017 12:16:13 +0200 - rev 603463
Push 66805 by bmo:dale@mozilla.com at Tue, 04 Jul 2017 07:03:36 +0000
Bug 1377851 - Use srcdoc instead of data: URI within devtools/client/sourceeditor/editor.js. r=pbrosset
534973efeb5b1450424d0264cdd12738c06fb983: Bug 1298370 - Add SameSite attribute to Cookie Inspector r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 01 Dec 2016 17:11:31 +0000 - rev 446788
Push 37883 by bmo:mratcliffe@mozilla.com at Thu, 01 Dec 2016 21:51:14 +0000
Bug 1298370 - Add SameSite attribute to Cookie Inspector r?pbrosset MozReview-Commit-ID: 3HcVmGiZZEg
c7b8df18b1b3e616f244d28c91c1c0b38da8cdd1: Bug 1317414 - Fix :"Animation names are barely visible with the dark theme". r=pbrosset a=jcristau
Andre <andre@andregarzia.com> - Mon, 21 Nov 2016 09:57:00 +0100 - rev 444391
Push 37233 by martin.thomson@gmail.com at Mon, 28 Nov 2016 00:01:40 +0000
Bug 1317414 - Fix :"Animation names are barely visible with the dark theme". r=pbrosset a=jcristau
e9d1b6c753292df38efd11f5fc4c8989abc96ee1: Bug 1317414 - Fix :"Animation names are barely visible with the dark theme". r=pbrosset
Andre <andre@andregarzia.com> - Mon, 21 Nov 2016 09:57:00 +0100 - rev 442579
Push 36742 by maglione.k@gmail.com at Tue, 22 Nov 2016 20:34:55 +0000
Bug 1317414 - Fix :"Animation names are barely visible with the dark theme". r=pbrosset
cc61f761ef7089dbbc93a192c1c02ae5fe7a8677: Bug 1311941 - Updated addNode function so that on adding a new now the parent node remains selected. r=pbrosset
djmdev <djmdeveloper060796@gmail.com> - Fri, 04 Nov 2016 02:51:12 +0530 - rev 439223
Push 35937 by dminor@mozilla.com at Tue, 15 Nov 2016 17:07:33 +0000
Bug 1311941 - Updated addNode function so that on adding a new now the parent node remains selected. r=pbrosset
8f15d66490c28f0daab4bc5ad1c008f201ca81b4: Bug 1249119 - Prevent exception when opening inspector on a loading document. r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Oct 2016 09:39:44 -0700 - rev 423783
Push 31984 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 16:43:39 +0000
Bug 1249119 - Prevent exception when opening inspector on a loading document. r=pbrosset MozReview-Commit-ID: 9TNRUblT0SW
2ee6b04ba9be76dbacc97084bdcd13efb31f7213: Bug 1249119 - Let shared-head helper cleanup tests instead of duplicating the effort in inspector head. r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Oct 2016 09:23:48 -0700 - rev 423782
Push 31984 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 16:43:39 +0000
Bug 1249119 - Let shared-head helper cleanup tests instead of duplicating the effort in inspector head. r=pbrosset MozReview-Commit-ID: 2GxvXl3GTy8
ae387c0b9db2db66913edac3da647b6f4939ba17: Bug 1249119 - Test loading the inspector while the document is loading. r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Oct 2016 09:23:09 -0700 - rev 423781
Push 31984 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 16:43:39 +0000
Bug 1249119 - Test loading the inspector while the document is loading. r=pbrosset MozReview-Commit-ID: 9iNKx2NUK0T
3e90e96dce91d8499fe57c4f29021e566320e34a: Bug 1249119 - Fix inspector startup when opening it on a loading document r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Oct 2016 07:08:43 -0700 - rev 423780
Push 31984 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 16:43:39 +0000
Bug 1249119 - Fix inspector startup when opening it on a loading document r=pbrosset MozReview-Commit-ID: 5d4K6VFLTgE
9ade096cfb0400357fbb105f279fa094a85a6d4b: Bug 1249119 - Prevent trying to initialize highlighter on still-loading documents. r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Oct 2016 08:20:01 -0700 - rev 423779
Push 31984 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 16:43:39 +0000
Bug 1249119 - Prevent trying to initialize highlighter on still-loading documents. r=pbrosset MozReview-Commit-ID: 3S0LoB40q2W
61c5824ce351d6323dfd8217e3092d89551ce139: Bug 1249119 - Fix inspector startup when opening it on a loading document r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 11 Oct 2016 07:08:43 -0700 - rev 423650
Push 31958 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 14:10:32 +0000
Bug 1249119 - Fix inspector startup when opening it on a loading document r=pbrosset MozReview-Commit-ID: 5d4K6VFLTgE
8937c30e474276f151252473a148c4d2768c301b: Bug 1249119 - Prevent trying to initialize highlighter on still-loading documents. r=pbrosset draft
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 10 Oct 2016 08:20:01 -0700 - rev 423649
Push 31958 by bmo:poirot.alex@gmail.com at Tue, 11 Oct 2016 14:10:32 +0000
Bug 1249119 - Prevent trying to initialize highlighter on still-loading documents. r=pbrosset MozReview-Commit-ID: 3S0LoB40q2W
15bd559b68aa58d884ce155bba5f754ded2daec8: Bug 1271257 - Protocol error (unknownError) can't convert undefined to object r=pbrosset
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 29 Jun 2016 15:27:02 +0100 - rev 382895
Push 21870 by bmo:ttromey@mozilla.com at Thu, 30 Jun 2016 20:27:32 +0000
Bug 1271257 - Protocol error (unknownError) can't convert undefined to object r=pbrosset
2404976eb9efe45aba68c49465f2f44bd2b461d1: Bug 1268538 - Event listener popup can be empty if the listeners are from native code r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 28 Apr 2016 22:57:56 +0100 - rev 357453
Push 16796 by mratcliffe@mozilla.com at Thu, 28 Apr 2016 22:02:58 +0000
Bug 1268538 - Event listener popup can be empty if the listeners are from native code r?pbrosset When native functions were used as handlers we were showing an empty event popup. We now display the following: function() { [native code] } MozReview-Commit-ID: 7Wz1bcLm4ph
1b58b2716de8d781ec1efbf51674f1ea5decaa31: Bug 1263258 - Require space before paren for anonymous functions. r=pbrosset draft
J. Ryan Stinnett <jryans@gmail.com> - Tue, 26 Apr 2016 21:32:42 -0500 - rev 356736
Push 16584 by bmo:jryans@gmail.com at Wed, 27 Apr 2016 02:33:15 +0000
Bug 1263258 - Require space before paren for anonymous functions. r=pbrosset MozReview-Commit-ID: 2F0j45Vxn2I
ec87c9ff42b6583d3d2496d156a0849a8974540c: Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset a=ritu
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 08 Mar 2016 09:54:47 -0800 - rev 351155
Push 15502 by ahunt@mozilla.com at Thu, 14 Apr 2016 20:27:48 +0000
Bug 1253886 - Re-add reference to common.css from the eyedropper frame;r=pbrosset a=ritu Since the frame doesn't allow any theme to load, common.css isn't be loaded automatically MozReview-Commit-ID: 56Iss0VEbee
ad5cb3578e98c4cafcc9d98c836d01ce55ee8c5f: Bug 1230325 - markup-view: skip keyboard shortcuts if any modifier;r=pbrosset a=ritu
Julian Descottes <jdescottes@mozilla.com> - Fri, 04 Mar 2016 18:15:32 +0100 - rev 351147
Push 15502 by ahunt@mozilla.com at Thu, 14 Apr 2016 20:27:48 +0000
Bug 1230325 - markup-view: skip keyboard shortcuts if any modifier;r=pbrosset a=ritu Bail out from the markup view onKeyDown handler if any modifier is currently true. All shortcuts specified in this handler are intended to be used without modifier, so for now this approach is fine. Added a test checking the use case mentioned in Bug 1230325, with the S shortcut. In order to write the test, had to create an additional method on the test actor to be able to wait for events in the window of the content process. MozReview-Commit-ID: 67icou0HkfA
484cdaff31215bf625eb0616247a9d77ad5e1147: Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 16:01:48 +0200 - rev 345608
Push 14126 by bgrinstead@mozilla.com at Tue, 29 Mar 2016 21:43:05 +0000
Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset MozReview-Commit-ID: GbEGN3aNhxz
d8fb6dbbb47874a2ea7f3a5eec7a0784d3fe51ec: Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset
Julian Descottes <jdescottes@mozilla.com> - Sun, 27 Mar 2016 18:24:43 +0200 - rev 345607
Push 14126 by bgrinstead@mozilla.com at Tue, 29 Mar 2016 21:43:05 +0000
Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset MozReview-Commit-ID: 9BEajbI665d
7aacc3495dc8b9d93c3ee3421c6ce1326ad36e11: Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 16:08:17 +0200 - rev 345606
Push 14126 by bgrinstead@mozilla.com at Tue, 29 Mar 2016 21:43:05 +0000
Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset Based on the original patch from danemacmillan. * suggestion-picker.js Add a new shared util to find the most popular css property in an array. The list of popular css properties is extracted from chrome devtools code. * autocomplete-popup.js Can specify selected item index when opening the popup or setting items. * inplace-editor.js Use the suggestion-picker to select a default property. MozReview-Commit-ID: JuWZzbBSBqX
f358ef6b795fe61eebdaee10095e1ec90411ac0c: Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 16:01:48 +0200 - rev 345500
Push 14100 by jdescottes@mozilla.com at Tue, 29 Mar 2016 14:09:21 +0000
Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset MozReview-Commit-ID: GbEGN3aNhxz
cbd8521b2356b976999f18ce301d8967b4ecac16: Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Sun, 27 Mar 2016 18:24:43 +0200 - rev 345499
Push 14100 by jdescottes@mozilla.com at Tue, 29 Mar 2016 14:09:21 +0000
Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset MozReview-Commit-ID: 9BEajbI665d
3317766ae63aea83f845d3cf3d134ecf60135f67: Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 16:08:17 +0200 - rev 345498
Push 14100 by jdescottes@mozilla.com at Tue, 29 Mar 2016 14:09:21 +0000
Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset Based on the original patch from danemacmillan. * suggestion-picker.js Add a new shared util to find the most popular css property in an array. The list of popular css properties is extracted from chrome devtools code. * autocomplete-popup.js Can specify selected item index when opening the popup or setting items. * inplace-editor.js Use the suggestion-picker to select a default property. MozReview-Commit-ID: JuWZzbBSBqX
98f8c14cb54fe1f5eb9b8e5e483c6fac43d5635d: Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 16:01:48 +0200 - rev 345495
Push 14098 by jdescottes@mozilla.com at Tue, 29 Mar 2016 14:05:26 +0000
Bug 1168246 - part3: ES lint fixes for inplace-editor and autocomplete-popup;r=pbrosset MozReview-Commit-ID: GbEGN3aNhxz
0c9d521776ae53056f75d61de6bdff7bf914879c: Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Sun, 27 Mar 2016 18:24:43 +0200 - rev 345492
Push 14096 by jdescottes@mozilla.com at Tue, 29 Mar 2016 13:37:21 +0000
Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset MozReview-Commit-ID: 9BEajbI665d
ac1a734454d78411d8ae09186c058a9576fbcf96: Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Tue, 29 Mar 2016 15:30:22 +0200 - rev 345491
Push 14096 by jdescottes@mozilla.com at Tue, 29 Mar 2016 13:37:21 +0000
Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset Based on the original patch from danemacmillan. * suggestion-picker.js Add a new shared util to find the most popular css property in an array. The list of popular css properties is extracted from chrome devtools code. * autocomplete-popup.js Can specify selected item index when opening the popup or setting items. * inplace-editor.js Use the suggestion-picker to select a default property. MozReview-Commit-ID: JuWZzbBSBqX
409d360ec78e17fd87295765e43e7869707487dc: Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Sun, 27 Mar 2016 18:24:43 +0200 - rev 345233
Push 14028 by jdescottes@mozilla.com at Mon, 28 Mar 2016 16:17:36 +0000
Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset MozReview-Commit-ID: 9BEajbI665d
66a726c2065b8e5bdd258df2b62ba01d5631a663: Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Mon, 28 Mar 2016 18:01:00 +0200 - rev 345232
Push 14028 by jdescottes@mozilla.com at Mon, 28 Mar 2016 16:17:36 +0000
Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset Based on the original patch from danemacmillan. * suggestion-picker.js Add a new shared util to find the most popular css property in an array. The list of popular css properties is extracted from chrome devtools code. * autocomplete-popup.js Can specify selected item index when opening the popup or setting items. * inplace-editor.js Use the suggestion-picker to select a default property. MozReview-Commit-ID: JuWZzbBSBqX
7b0ca58c97aee0ab561a2b4a11fd25b57944a96b: Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Sun, 27 Mar 2016 18:24:43 +0200 - rev 345224
Push 14024 by jdescottes@mozilla.com at Mon, 28 Mar 2016 15:54:23 +0000
Bug 1168246 - part2: fix tests relying on CSS suggestions order;r=pbrosset MozReview-Commit-ID: 9BEajbI665d
66fe45b765144b8634605668be05712185e59e12: Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset draft
Julian Descottes <jdescottes@mozilla.com> - Mon, 28 Mar 2016 13:27:39 +0200 - rev 345223
Push 14024 by jdescottes@mozilla.com at Mon, 28 Mar 2016 15:54:23 +0000
Bug 1168246 - part1: CSS autocomplete picks most popular prop;r=pbrosset Based on the original patch from danemacmillan. * suggestion-picker.js Add a new shared util to find the most popular css property in an array. The list of popular css properties is extracted from chrome devtools code. * autocomplete-popup.js Can specify selected item index when opening the popup or setting items. * inplace-editor.js Use the suggestion-picker to select a default property. MozReview-Commit-ID: JuWZzbBSBqX
9e9f949b36c80f6794a22cbd137c1bce5d9e7098: Bug 1257322 - add more devtools docs r=pbrosset
James Long <longster@gmail.com> - Mon, 21 Mar 2016 10:36:28 -0400 - rev 342907
Push 13490 by bmo:mstriemer@mozilla.com at Mon, 21 Mar 2016 16:13:22 +0000
Bug 1257322 - add more devtools docs r=pbrosset
7c84456c49f4de2ff481d33f7cf9025d6293631c: Bug 1240804 - Allow remaining unhandled rejections. r=ejpbruel,pbrosset,mratcliffe draft
J. Ryan Stinnett <jryans@gmail.com> - Thu, 03 Mar 2016 13:03:18 -0600 - rev 342858
Push 13474 by bmo:jryans@gmail.com at Mon, 21 Mar 2016 13:56:35 +0000
Bug 1240804 - Allow remaining unhandled rejections. r=ejpbruel,pbrosset,mratcliffe MozReview-Commit-ID: 1D5BOz1JxJP
3792c0bc4e320496b4c0a39fb9761f16c533f3e0: Bug 1230325 - markup-view: skip keyboard shortcuts if any modifier. r=pbrosset, a=lizzard
Julian Descottes <jdescottes@mozilla.com> - Fri, 04 Mar 2016 18:15:32 +0100 - rev 342567
Push 13430 by rjesup@wgate.com at Sun, 20 Mar 2016 05:01:22 +0000
Bug 1230325 - markup-view: skip keyboard shortcuts if any modifier. r=pbrosset, a=lizzard Bail out from the markup view onKeyDown handler if any modifier is currently true. All shortcuts specified in this handler are intended to be used without modifier, so for now this approach is fine. Added a test checking the use case mentioned in Bug 1230325, with the S shortcut. In order to write the test, had to create an additional method on the test actor to be able to wait for events in the window of the content process. MozReview-Commit-ID: 67icou0HkfA
9a4a1b792ef43bedc4829b3cf12c9d9b85eae7a2: Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 17 Mar 2016 15:42:43 +0000 - rev 342335
Push 13397 by mratcliffe@mozilla.com at Fri, 18 Mar 2016 21:49:35 +0000
Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset MozReview-Commit-ID: 2mQERql1pOj
b9b4b892bfd80ea726e5926e7ba1af730bb7ba0c: Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 17 Mar 2016 15:42:43 +0000 - rev 342220
Push 13367 by mratcliffe@mozilla.com at Fri, 18 Mar 2016 17:14:24 +0000
Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset MozReview-Commit-ID: 2mQERql1pOj
b758024ce9aea03958c3f27e41a34ab381f951d8: Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 01 Mar 2016 22:47:31 +0000 - rev 342218
Push 13367 by mratcliffe@mozilla.com at Fri, 18 Mar 2016 17:14:24 +0000
Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset In addition to addressing review comments: * If the table is cleared we now close the editor. * If the row that is being edited is removed we now close the editor. * Moved the editableColumns getter into the table object because it should obviously live there. * Added a bunch of comments to explain changes. * We now handle tabbing between cells and rows in and out of edit mode without removing nodes (we simply hide them). this results in much more stability. * When a cellis edited we add the textbox straight away. If the row then moves for any reason we keep the textbox in the correct location. * Editing is cleaner and faster. * The EditableFieldsEngine has been refactored: * We now hide cells instead of removing them from the DOM. * The main methods are now edit, completeEdit and cancelEdit. MozReview-Commit-ID: Amxyp5i3a5F
9a7f99aa560781b867a8bee594d68e9f2d742840: Bug 1257246: Fix addVarToScope to work in both eslint 1.x and eslint 2.x. r=pbrosset
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 16 Mar 2016 12:16:50 -0700 - rev 341696
Push 13270 by bmo:mstriemer@mozilla.com at Thu, 17 Mar 2016 17:33:12 +0000
Bug 1257246: Fix addVarToScope to work in both eslint 1.x and eslint 2.x. r=pbrosset Since we're already relying on internals it makes more sense to just use escope's function for declaring variables. We then have to remove references from the through array and update them to point to their variables, this was cribbed from https://github.com/eslint/eslint/blob/master/lib/eslint.js#L180 MozReview-Commit-ID: JD7CFm1aO6T
f6f44896359085daea3320cda9ab35bc0f101a66: Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 17 Mar 2016 15:42:43 +0000 - rev 341647
Push 13258 by mratcliffe@mozilla.com at Thu, 17 Mar 2016 15:45:37 +0000
Bug 1248447 - Stop grafting prototypes in storage.js::patchMetadataMapsAndProtos() r?pbrosset MozReview-Commit-ID: 2mQERql1pOj
788dc80bedb969ec7fd54626d2a9d637007fd633: Bug 1257246: Fix addVarToScope to work in both eslint 1.x and eslint 2.x. r?pbrosset draft
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 16 Mar 2016 12:16:50 -0700 - rev 341227
Push 13172 by dtownsend@mozilla.com at Wed, 16 Mar 2016 19:41:48 +0000
Bug 1257246: Fix addVarToScope to work in both eslint 1.x and eslint 2.x. r?pbrosset Since we're already relying on internals it makes more sense to just use escope's function for declaring variables. We then have to remove references from the through array and update them to point to their variables, this was cribbed from https://github.com/eslint/eslint/blob/master/lib/eslint.js#L180 MozReview-Commit-ID: JD7CFm1aO6T
b9366f029761917aab7754ca3acd8a5480ab011f: Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 01 Mar 2016 22:47:31 +0000 - rev 341115
Push 13150 by mratcliffe@mozilla.com at Wed, 16 Mar 2016 16:46:28 +0000
Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset In addition to addressing review comments: * If the table is cleared we now close the editor. * If the row that is being edited is removed we now close the editor. * Moved the editableColumns getter into the table object because it should obviously live there. * Added a bunch of comments to explain changes. * We now handle tabbing between cells and rows in and out of edit mode without removing nodes (we simply hide them). this results in much more stability. * When a cellis edited we add the textbox straight away. If the row then moves for any reason we keep the textbox in the correct location. * Editing is cleaner and faster. * The EditableFieldsEngine has been refactored: * We now hide cells instead of removing them from the DOM. * The main methods are now edit, completeEdit and cancelEdit. MozReview-Commit-ID: Amxyp5i3a5F
80addefe85887ee902defa7c3ce6dba585f47252: Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 01 Mar 2016 22:47:31 +0000 - rev 339989
Push 12864 by mratcliffe@mozilla.com at Mon, 14 Mar 2016 17:17:30 +0000
Bug 1235350 - Storage Inspector needs a simplified inline editor r?pbrosset In addition to addressing review comments: * If the table is cleared we now close the editor. * If the row that is being edited is removed we now close the editor. * Moved the editableColumns getter into the table object because it should obviously live there. * Added a bunch of comments to explain changes. * We now handle tabbing between cells and rows in and out of edit mode without removing nodes (we simply hide them). this results in much more stability. * When a cellis edited we add the textbox straight away. If the row then moves for any reason we keep the textbox in the correct location. * Editing is cleaner and faster. * The EditableFieldsEngine has been refactored: * We now hide cells instead of removing them from the DOM. * The main methods are now edit, completeEdit and cancelEdit. MozReview-Commit-ID: Amxyp5i3a5F
b015db3afa462d65b3bd58ab6cc080401f85bafa: Bug 1253785 - fix unhandled promise rejections: wait for 2nd ruleview-changed;r=pbrosset
Julian Descottes <jdescottes@mozilla.com> - Wed, 09 Mar 2016 15:44:13 +0100 - rev 339516
Push 12751 by paolo.mozmail@amadzone.org at Fri, 11 Mar 2016 15:49:53 +0000
Bug 1253785 - fix unhandled promise rejections: wait for 2nd ruleview-changed;r=pbrosset As commented in the test, using createNewRuleViewProperty with "width:" will actually trigger two ruleview-changed events : - one when focusing the property-name input - one when focusing the property value input (which is automatically done when hitting return in this case, since we only entered a property name) MozReview-Commit-ID: GjJnwDr3ON6