Mercurial > mozreview > gecko / search
summary | shortlog | changelog | pushlog | graph | tags | bookmarks | branches | files | zip | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
searching for reviewer(padenot)
15cca5b18ec422dbc5b7f893f07a7410ec18300f: Bug 1484046 reset variables for main thread buffer dropping logic on the same thread r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 17 Aug 2018 12:24:51 +0000 - rev 830190
Push 118824 by bmo:hskupin@gmail.com at Mon, 20 Aug 2018 15:49:57 +0000
Bug 1484046 reset variables for main thread buffer dropping logic on the same thread r=padenot Differential Revision: https://phabricator.services.mozilla.com/D3580
48d142e35106f207b3c286da68652bd9fcbc3960: Bug 1483174 use float constants with float delay time variables r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 16 Aug 2018 11:09:03 +0000 - rev 829912
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1483174 use float constants with float delay time variables r=padenot Differential Revision: https://phabricator.services.mozilla.com/D3396
5a18b9c9a5a610cded246291c1c80498eba9dcfb: bug 1474222 test ConvolverNode channelInterpretation changes r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 829719
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r=padenot MozReview-Commit-ID: 9s7ozdSRofY
7e3fde45f4178449bfe2e2e9954fa3bc627b279f: bug 1474222 move convolver up-mixing test to wpt r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 829718
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 move convolver up-mixing test to wpt r=padenot MozReview-Commit-ID: ItbXaY2GCrF
a10cd240dcaf8d0597a8685df99526c30344b12f: bug 1474222 test ConvolverNode up-mixing r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 829717
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 test ConvolverNode up-mixing r=padenot MozReview-Commit-ID: GZVe85depAj
3ac736416349f088fb710450f85da8ac51d33374: bug 1474222 change ConvolverNode output to mono for single channel convolution r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 829716
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r=padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
e6fc5ab5dd8c2293196f897c068f63f9a41c2919: bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 03 Aug 2018 18:32:28 +1200 - rev 829715
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r=padenot MozReview-Commit-ID: CgA051giSTU
67d29891df6164d538f88fc678fbda5ade597b13: bug 1474222 keep memory allocated for convolver volume premultiplication until no longer required r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 16 Jul 2018 19:33:35 +1200 - rev 829714
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 keep memory allocated for convolver volume premultiplication until no longer required r=padenot MozReview-Commit-ID: D3cfKjp0lwi
7574547bff847ef8e5374afe683abf1bbc093ac0: bug 1474222 uninline ConvolverNodeEngine::ProcessBlock() r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 16 Jul 2018 19:22:15 +1200 - rev 829713
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
bug 1474222 uninline ConvolverNodeEngine::ProcessBlock() r=padenot MozReview-Commit-ID: tbuG2AQJoC
483ff2d2548af15a8fe5f813791c4817d2c4d091: bug 1474470 support convolution of stereo input with a mono impulse response buffer r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 16 Aug 2018 09:59:05 +1200 - rev 829684
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
bug 1474470 support convolution of stereo input with a mono impulse response buffer r=padenot This initial implementation does twice the necessary processing for mono input, but that will be addressed in bug 1474222. MozReview-Commit-ID: AZQ7Zb8jEtK
1c0f3e4b7c1811ea2a800e6eef3d08b7c3fdedfd: bug 1474222 test ConvolverNode channelInterpretation changes r=padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 829641
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r=padenot MozReview-Commit-ID: 9s7ozdSRofY
c22aa29dd44d7fc22d236df93d0be3d0a2625710: bug 1474222 move convolver up-mixing test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 829640
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 move convolver up-mixing test to wpt r?padenot MozReview-Commit-ID: ItbXaY2GCrF
c12964f5c862f5bfde73d05bb64e80779ab221a1: bug 1474222 test ConvolverNode up-mixing r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 829639
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 test ConvolverNode up-mixing r?padenot MozReview-Commit-ID: GZVe85depAj
8c355f5b23f81a682cf01a02682ac62b055a2502: bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 829638
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
22d06a101a1c08d399de99bcd3477f1ff9ba3880: bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r=padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 03 Aug 2018 18:32:28 +1200 - rev 829637
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r=padenot MozReview-Commit-ID: CgA051giSTU
a8e948b758ab0b8c222c33340783c2527ddfbf15: bug 1474222 keep memory allocated for convolver volume premultiplication until no longer required r=padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 16 Jul 2018 19:33:35 +1200 - rev 829636
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 keep memory allocated for convolver volume premultiplication until no longer required r=padenot MozReview-Commit-ID: D3cfKjp0lwi
fd6aeca490b3a9ed1fb116abd25e8d0199802cca: bug 1474222 uninline ConvolverNodeEngine::ProcessBlock() r=padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 16 Jul 2018 19:22:15 +1200 - rev 829635
Push 118784 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:34:20 +0000
bug 1474222 uninline ConvolverNodeEngine::ProcessBlock() r=padenot MozReview-Commit-ID: tbuG2AQJoC
407347f10d590be0ff156994c58a21680e7b3288: bug 1474222 test ConvolverNode channelInterpretation changes r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 829634
Push 118783 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:05:23 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r?padenot MozReview-Commit-ID: 9s7ozdSRofY
b9e29b6f3669f73dc0e177a13991e719986e6183: bug 1474222 move convolver up-mixing test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 829633
Push 118783 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:05:23 +0000
bug 1474222 move convolver up-mixing test to wpt r?padenot MozReview-Commit-ID: ItbXaY2GCrF
3212da4fbeda72b7e1a06b6a10a09c691180547c: bug 1474222 test ConvolverNode up-mixing r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 829632
Push 118783 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:05:23 +0000
bug 1474222 test ConvolverNode up-mixing r?padenot MozReview-Commit-ID: GZVe85depAj
4d4764254657221af00470df6ec22666bac0195d: bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 829631
Push 118783 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 06:05:23 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
9feeb254217dc4e14b78cb03315fb948e3477a16: bug 1474470 support convolution of stereo input with a mono impulse response buffer r=padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 16 Aug 2018 09:59:05 +1200 - rev 829451
Push 118781 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 02:46:06 +0000
bug 1474470 support convolution of stereo input with a mono impulse response buffer r=padenot This initial implementation does twice the necessary processing for mono input, but that will be addressed in bug 1474222. MozReview-Commit-ID: AZQ7Zb8jEtK
0dcc490db922fc504a1b92339be000260448d75b: Bug 1482605 - Don't error on Opus channel mapping version 2. r=padenot
diff
browse
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 11 Aug 2018 20:23:58 +0200 - rev 829032
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1482605 - Don't error on Opus channel mapping version 2. r=padenot We do not perform any channels placement, instead we leave the channels in the order they come in. Add corresponding tests. Differential Revision: https://phabricator.services.mozilla.com/D3153
53d24927729908653f4397f8c34c3a65a919d0a6: Bug 1482841 - P2. Fix opus in mp4 decoding. r=padenot
diff
browse
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 13 Aug 2018 19:23:05 +0200 - rev 829031
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1482841 - P2. Fix opus in mp4 decoding. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D3233
7b1366d8fa15fcce4a300cff135119985f04b167: Bug 1482841 - P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r=padenot
diff
browse
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 13 Aug 2018 22:55:35 +0200 - rev 829030
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1482841 - P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D3261
b3f01b9ce2bf9c4cf05bf4bca16330560439db0b: bug 1480661 use single precision for operating on delay values r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 10:18:24 +1200 - rev 828947
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
bug 1480661 use single precision for operating on delay values r=padenot These are derived from single precision AudioParam values and so there is little to gain from using double. double has the disadvantage that values intended to be integer frame counts are less likely to be integer. e.g. (rr) print ((float)(128.0/48000.0))*48000.f $91 = 128 (rr) print ((float)(128.0/48000.0))*48000.0 $92 = 127.99999862909317 (rr) print ((float)(128.0/44100.0))*44100.f $93 = 128 (rr) print ((float)(128.0/44100.0))*44100.0 $94 = 127.99999765120447 (rr) print ((float)(768.0/48000.0))*48000.f $95 = 768.000061 (rr) print ((float)(768.0/48000.0))*48000.0 $96 = 768.0000364780426 (rr) print ((float)(768.0/44100.0))*44100.f $97 = 768 (rr) print ((float)(768.0/44100.0))*44100.0 $98 = 768.00002697855234 MozReview-Commit-ID: FlmZJeBjUYY
a1f7a37f6390439884af21446f7b62a5924545e8: bug 1480661 remove unused mCurrentDelay r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 02 Aug 2018 18:37:49 +1200 - rev 828946
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
bug 1480661 remove unused mCurrentDelay r=padenot MozReview-Commit-ID: 4EIeOE769Ne
3802f485af6f53722848a0262e9706d468d3ee38: bug 1480661 move DelayNode channelCount test to wpt r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:38:19 +1200 - rev 828945
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
bug 1480661 move DelayNode channelCount test to wpt r=padenot MozReview-Commit-ID: 9RUVk4dMW6g
8d9e3375e91d875f0138373829d861aa1050e895: bug 1480661 add test for DelayNode channelCount r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Wed, 01 Aug 2018 12:18:09 +1200 - rev 828944
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
bug 1480661 add test for DelayNode channelCount r=padenot MozReview-Commit-ID: D6JbCa3Gsmr
d168f623e879463bc4198f231b230706620dc1f7: bug 1480661 avoid reading channel count of most recent delay buffer input when reading samples at max delay r=padenot
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 02 Aug 2018 17:36:05 +1200 - rev 828943
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
bug 1480661 avoid reading channel count of most recent delay buffer input when reading samples at max delay r=padenot When maxDelay was mMaxDelayTicks and these were an integer multiple of block size, the +1 for determining oldestChunk was enough to wrap around the buffer and find the most recent chunk, which may have a different channel count to that of the oldest. MozReview-Commit-ID: KakFeGzuvsW
f10ecb61e741967e42119249f9935779a9a08bd0: bug 1474222 test ConvolverNode channelInterpretation changes r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 828851
Push 118720 by ktomlinson@mozilla.com at Mon, 13 Aug 2018 23:45:35 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r?padenot MozReview-Commit-ID: 9s7ozdSRofY
e38ba3e7e5d9c13ee29bb0f6ca4e66dde6a03cf1: bug 1474222 move convolver up-mixing test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 828850
Push 118720 by ktomlinson@mozilla.com at Mon, 13 Aug 2018 23:45:35 +0000
bug 1474222 move convolver up-mixing test to wpt r?padenot MozReview-Commit-ID: ItbXaY2GCrF
21af6155059a877daf83cad2e4e92bb150bd6f65: bug 1474222 test ConvolverNode up-mixing r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 828849
Push 118720 by ktomlinson@mozilla.com at Mon, 13 Aug 2018 23:45:35 +0000
bug 1474222 test ConvolverNode up-mixing r?padenot MozReview-Commit-ID: GZVe85depAj
d66000fce4c066556c6bbd0e75cb531767136f38: bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 828848
Push 118720 by ktomlinson@mozilla.com at Mon, 13 Aug 2018 23:45:35 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
020ba78b2a58b46ead0f3b27a993c1d9161ee949: bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 03 Aug 2018 18:32:28 +1200 - rev 828847
Push 118720 by ktomlinson@mozilla.com at Mon, 13 Aug 2018 23:45:35 +0000
bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r?padenot MozReview-Commit-ID: CgA051giSTU
6c752dc707f5bc5557bc558d8737c143c658727c: Bug 1481957 - Make input device enumeration for Android similar to other platforms when cubeb is disabled. r=padenot
diff
browse
Alex Chronopoulos <achronop@gmail.com> - Mon, 13 Aug 2018 08:25:38 +0000 - rev 828732
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1481957 - Make input device enumeration for Android similar to other platforms when cubeb is disabled. r=padenot In the case that cubeb is disabled we do not need to offer the dummy device on android because will leave gUM request thinking that everything is good, which will create other side effects. Also the special handling for android increases the complexity. Differential Revision: https://phabricator.services.mozilla.com/D3026
44bfb340b80b9e45b9232ae68d731b8a189ce1a4: Bug 934425 - Set device info in MediaSink and switch sink device. r?padenot draft
diff
browse
Alex Chronopoulos <achronop@gmail.com> - Thu, 09 Aug 2018 17:12:48 +0300 - rev 827853
Push 118601 by achronop@gmail.com at Thu, 09 Aug 2018 14:17:09 +0000
Bug 934425 - Set device info in MediaSink and switch sink device. r?padenot MozReview-Commit-ID: JtrK70ggc6s
195f7ba7a572c2d27f0bc9f40410cec2c4b57578: bug 1474222 test ConvolverNode channelInterpretation changes r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 827398
Push 118528 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:34:54 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r?padenot MozReview-Commit-ID: 9s7ozdSRofY
9e412593976593b0615e707f2a22763d0bc888fb: bug 1474222 move convolver up-mixing test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 827397
Push 118528 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:34:54 +0000
bug 1474222 move convolver up-mixing test to wpt r?padenot MozReview-Commit-ID: ItbXaY2GCrF
4465a7bdad574bab932c9ea303bb15648ff51eff: bug 1474222 test ConvolverNode up-mixing r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 827396
Push 118528 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:34:54 +0000
bug 1474222 test ConvolverNode up-mixing r?padenot MozReview-Commit-ID: GZVe85depAj
79d6569c2c56814d69cb907b427cea714142b139: bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 827395
Push 118528 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:34:54 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
1c40aede075dc5869a08f9f78782bfd820d5d309: bug 1474222 test ConvolverNode channelInterpretation changes r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 20:59:37 +1200 - rev 827389
Push 118526 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:06:51 +0000
bug 1474222 test ConvolverNode channelInterpretation changes r?padenot MozReview-Commit-ID: bKaf74w8fN
47af288a924b59a8efde4cabf5be4d43f3c11d95: bug 1474222 move convolver up-mixing test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:31:40 +1200 - rev 827388
Push 118526 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:06:51 +0000
bug 1474222 move convolver up-mixing test to wpt r?padenot MozReview-Commit-ID: ItbXaY2GCrF
84852172c3a4f1fd483dcc59d69ee405b94ac9dc: bug 1474222 test ConvolverNode up-mixing r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 27 Jul 2018 20:03:39 +1200 - rev 827387
Push 118526 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:06:51 +0000
bug 1474222 test ConvolverNode up-mixing r?padenot MozReview-Commit-ID: GZVe85depAj
432628dfa50dc231f8d5d5074662e5b79426466a: bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 21:24:15 +1200 - rev 827386
Push 118526 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:06:51 +0000
bug 1474222 change ConvolverNode output to mono for single channel convolution r?padenot This also returns to using a single convolver for processing of mono input, which introduces complexity in up-mixing the state of the convolver when a second channel is added. MozReview-Commit-ID: KeBrAswQbtF
3f5b136b8bb08a9066abbc9730228f8df4f2ab90: bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Fri, 03 Aug 2018 18:32:28 +1200 - rev 827385
Push 118526 by ktomlinson@mozilla.com at Wed, 08 Aug 2018 00:06:51 +0000
bug 1474222 consider allocation size instead of used channel count for re-using AudioBlockBuffer r?padenot MozReview-Commit-ID: CgA051giSTU
866336a3b76c6933a71a7712b253d999c9d1a80c: bug 1480661 use single precision for operating on delay values r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 10:18:24 +1200 - rev 826865
Push 118397 by ktomlinson@mozilla.com at Sun, 05 Aug 2018 22:23:41 +0000
bug 1480661 use single precision for operating on delay values r?padenot These are derived from single precision AudioParam values and so there is little to gain from using double. double has the disadvantage that values intended to be integer frame counts are less likely to be integer. e.g. (rr) print ((float)(128.0/48000.0))*48000.f $91 = 128 (rr) print ((float)(128.0/48000.0))*48000.0 $92 = 127.99999862909317 (rr) print ((float)(128.0/44100.0))*44100.f $93 = 128 (rr) print ((float)(128.0/44100.0))*44100.0 $94 = 127.99999765120447 (rr) print ((float)(768.0/48000.0))*48000.f $95 = 768.000061 (rr) print ((float)(768.0/48000.0))*48000.0 $96 = 768.0000364780426 (rr) print ((float)(768.0/44100.0))*44100.f $97 = 768 (rr) print ((float)(768.0/44100.0))*44100.0 $98 = 768.00002697855234 MozReview-Commit-ID: FlmZJeBjUYY
8dfb7e9b72274ad6f11580842f692a23af81df3a: bug 1480661 remove unused mCurrentDelay r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Thu, 02 Aug 2018 18:37:49 +1200 - rev 826864
Push 118397 by ktomlinson@mozilla.com at Sun, 05 Aug 2018 22:23:41 +0000
bug 1480661 remove unused mCurrentDelay r?padenot MozReview-Commit-ID: 4EIeOE769Ne
dabc1046f7796635a36ae61c7ed4634706aef3ef: bug 1480661 move DelayNode channelCount test to wpt r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Mon, 06 Aug 2018 09:38:19 +1200 - rev 826863
Push 118397 by ktomlinson@mozilla.com at Sun, 05 Aug 2018 22:23:41 +0000
bug 1480661 move DelayNode channelCount test to wpt r?padenot MozReview-Commit-ID: 9RUVk4dMW6g
4ba708f7d969b7f5c3a4380170043362a03deac1: bug 1480661 add test for DelayNode channelCount r?padenot draft
diff
browse
Karl Tomlinson <karlt+@karlt.net> - Wed, 01 Aug 2018 12:18:09 +1200 - rev 826862
Push 118397 by ktomlinson@mozilla.com at Sun, 05 Aug 2018 22:23:41 +0000
bug 1480661 add test for DelayNode channelCount r?padenot MozReview-Commit-ID: D6JbCa3Gsmr
gecko
Deployed from a8f3b23c660e at 2023-03-13T16:25:26Z.