searching for reviewer(njn)
b7f4a1596d18d093e8f25bc8947a005d75ee2e7f: Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 22 Aug 2018 08:58:08 +0900 - rev 830687
Push
118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn
When valgrind prints out backtraces, it prints raw addresses and symbol
names, but that doesn't help find the exact code that caused the errors,
because we don't know where the libraries are loaded.
With --sym-offsets=yes, it adds the offset from the symbol, which allows
to find the relevant code in the binary.
baaf4be9a9dc245044589f8fba0992ef7896f915: Bug 1484809 - Put class nsRelativeFilePref into its own include file. r=njn
Jorg K <jorgk@jorgk.com> - Tue, 21 Aug 2018 00:28:00 +0300 - rev 830445
Push
118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484809 - Put class nsRelativeFilePref into its own include file. r=njn
060aa1c7072322d21ec4190fdb07dc1dd89abe0c: Bug 1481139 - fix GMP process IPC channel error on Android. r=jld,njn
John Lin <jolin@mozilla.com> - Fri, 17 Aug 2018 00:06:20 +0000 - rev 830046
Push
118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1481139 - fix GMP process IPC channel error on Android. r=jld,njn
Bug 1481139 - p1: handle invalid file descriptors.
Bug 1481139 - p2: add dummy fds for GMP process.
Two file descriptors were added in
bug 1438678 and 1471025 for content/child
process but not GMP process, and it breaks the IPC channel on Android.
Add dummy values to make it work for now before
bug 1440207 clean up the mess.
Differential Revision:
https://phabricator.services.mozilla.com/D3541
0b2b4da68f04f3431bfff08859d73a210573bec1: Bug 1484109 - Part 3: Make nsRelativeFilePref final; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:27:24 -0400 - rev 829956
Push
118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1484109 - Part 3: Make nsRelativeFilePref final; r=njn
489fccb13b3e963b8bf8b235a7b4c82805061ca9: Bug 1484109 - Part 2: Make nsIRelativeFilePref non-scriptable, since there are no script consumers; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:26:50 -0400 - rev 829955
Push
118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1484109 - Part 2: Make nsIRelativeFilePref non-scriptable, since there are no script consumers; r=njn
0da5607c48f6861e5f2880bb0b596267e03e242e: Bug 1484109 - Part 1: Remove the XPCOM component registration for nsRelativeFilePref; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:26:25 -0400 - rev 829954
Push
118807 by bmo:mtigley@mozilla.com at Sat, 18 Aug 2018 03:08:50 +0000
Bug 1484109 - Part 1: Remove the XPCOM component registration for nsRelativeFilePref; r=njn
5928090fcb23935e819e22f392367309428cb648: Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Aug 2018 11:40:02 +1000 - rev 829629
Push
118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
a91ccbe2b3fd8b9303b034d7a6035de572495fd0: Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Aug 2018 11:40:02 +1000 - rev 829606
Push
118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
0d27c68cfaf85c07e1059184f17354b358228dfe: Bug 1482797 - Don't use MADV_FREE on Linux until we support it properly. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 15 Aug 2018 17:21:25 +0900 - rev 829366
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482797 - Don't use MADV_FREE on Linux until we support it properly. r=njn
e6a44943b17774c94e3c22e85e5260b0a62121ac: Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:52:42 +1000 - rev 829340
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Summary: Depends On D3286
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1483121
Differential Revision:
https://phabricator.services.mozilla.com/D3295
8d6f6eef3c76805d95cde66f354f150b75fbe9e4: Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 829339
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Summary: Depends On D3285
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3286
c4b64bd53e9266f0116a27d9a41488149455005d: Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 829338
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Summary: Depends On D3284
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3285
73c353f1d88fd07830c9034ad67800f333149cee: Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:39 +1000 - rev 829337
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Summary: Depends On D3283
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3284
6605ef249363dcf770e4d07d9753b2252690d1f2: Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829336
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Summary: Depends On D3282
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3283
57507aba8ffd33917ad48c52b29a0fe2dad3f7a1: Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829335
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Summary: Depends On D3281
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3282
7ef73ff1649501f237c2df7d588ad8f9f544bed8: Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829334
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Summary: Depends On D3280
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3281
6c488a5eb81d3e2e41ba0913b2610facf6df465b: Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829333
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Reviewers: njn!, hsivonen!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3280
0a8334bbcf4594d5bc1195d31f15d550ac8e9a4a: Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:52:42 +1000 - rev 829328
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Summary: Depends On D3286
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1483121
Differential Revision:
https://phabricator.services.mozilla.com/D3295
cb2dcb8590711584e1689583a75f66d7195bb550: Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 829327
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Summary: Depends On D3285
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3286
c834d4ca2eef0a7ace7aa7e480bba0ad76bbb8fb: Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 829326
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Summary: Depends On D3284
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3285
887de0efbb67f436a241a60fea0fc4a001656cdd: Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:39 +1000 - rev 829325
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Summary: Depends On D3283
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3284
018fdb50a6bec77b3022b2431334bae21339c4cb: Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829324
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Summary: Depends On D3282
Reviewers: njn!, emilio!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3283
33a8aa8096c94e9be06d4aec7a8ad274f5dcf9de: Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829323
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Summary: Depends On D3281
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3282
e3632354f16ec80028cf3004fcc1322f7c0ff405: Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829322
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Summary: Depends On D3280
Reviewers: njn!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3281
46f8319bee824fe669df21ee6023c9ea55349ac3: Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 829321
Push
118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Reviewers: njn!, hsivonen!
Tags: #secure-revision
Bug #: 1482782
Differential Revision:
https://phabricator.services.mozilla.com/D3280
42e2eeaca65d313926e962b6583d52d4bcab6d15: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 828187
Push
118647 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 06:14:44 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant C++ functions are updated to take a typed enum. JavaScript
calls are unaffected but they will throw if the string argument does not
correspond to one of the known entries in the C++ enum. The existing whitelists
and blacklists of annotations are also generated from the YAML file and all
duplicate code related to them has been consolidated. Once written out to the
.extra file the annotations are converted in string form and are no different
than the existing ones.
All existing annotations have been included in the list (and some obsolete ones
have been removed) and all call sites have been updated including tests where
appropriate.
d323d133324be6cae829825d6d0a894ea219a5b3: Bug 1474701: Fix shutdown profile-save (fix imbalance) and add JSONWriter assertions r=mstange,njn
Randell Jesup <rjesup@jesup.org> - Mon, 06 Aug 2018 10:44:26 -0400 - rev 826977
Push
118431 by bmo:dharvey@mozilla.com at Mon, 06 Aug 2018 15:44:46 +0000
Bug 1474701: Fix shutdown profile-save (fix imbalance) and add JSONWriter assertions r=mstange,njn
1e9ecba54e7b1e6ee614e323ece9c98c373311a9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826469
Push
118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant functions are updated to take a typed enum (in C++) and an
integer constant (in JavaScript). A JavaScript wrapper around the crash
reporter service is provided to hold the constants. The existing whitelists
and blacklists of annotations are also generated from the YAML file and the
existing duplicate code has been consolidated. Once written out to the .extra
file the annotations are converted in string form and are no different than
the existing ones.
All existing annotations have been included (and some obsolete ones removed)
and all call sites have been updated including tests.
86471a18672fb8b1c7edf27076f5e2964e2389f9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826463
Push
118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant functions are updated to take a typed enum (in C++) and an
integer constant (in JavaScript). A JavaScript wrapper around the crash
reporter service is provided to hold the constants. The existing whitelists
and blacklists of annotations are also generated from the YAML file and the
existing duplicate code has been consolidated. Once written out to the .extra
file the annotations are converted in string form and are no different than
the existing ones.
All existing annotations have been included (and some obsolete ones removed)
and all call sites have been updated including tests.
ada1690b63e92f902b1543f38cfb6327d1652a52: Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r=njn,sfink
Markus Stange <mstange@themasta.com> - Thu, 02 Aug 2018 13:49:48 -0400 - rev 826095
Push
118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r=njn,sfink
MozReview-Commit-ID: 6HIWrA27X87
c35817ef16bcdc166faa6741c7b3d46bd44b450e: Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
draft
Markus Stange <mstange@themasta.com> - Thu, 02 Aug 2018 13:49:48 -0400 - rev 825931
Push
118213 by bmo:mstange@themasta.com at Thu, 02 Aug 2018 18:21:17 +0000
Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
MozReview-Commit-ID: 6HIWrA27X87
38b22cd7188cbbb6c65b385489501b18f9ef5d8e: Bug 1477009 - use a dependent CString on Android for finding breakpad ids; r=njn
Nathan Froyd <froydnj@mozilla.com> - Thu, 26 Jul 2018 09:47:05 -0400 - rev 823091
Push
117560 by rwood@mozilla.com at Thu, 26 Jul 2018 14:25:44 +0000
Bug 1477009 - use a dependent CString on Android for finding breakpad ids; r=njn
This is slightly more efficient, since we don't have to copy the string.
d6c5e93d33a1f86946480004fc19c2d4ef3984e1: Bug 1477904: Correctly handle static var caches with changed default values. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 22:50:03 -0700 - rev 822677
Push
117440 by maglione.k@gmail.com at Wed, 25 Jul 2018 17:29:55 +0000
Bug 1477904: Correctly handle static var caches with changed default values. r=njn
MozReview-Commit-ID: H2ImQrmrtAV
1536b65f7006b214457d54cd9bf0940289de4c08: Bug 1477904: Correctly handle static var caches with changed default values. r?njn
draft
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 22:50:03 -0700 - rev 821894
Push
117209 by maglione.k@gmail.com at Tue, 24 Jul 2018 05:50:34 +0000
Bug 1477904: Correctly handle static var caches with changed default values. r?njn
MozReview-Commit-ID: H2ImQrmrtAV
37435502b7c0301bbcf9d161a0700a92b9e0d929: Bug 1475836: Clear cached callback pref when deleting branch. r=njn
Kris Maglione <maglione.k@gmail.com> - Fri, 20 Jul 2018 11:57:37 -0700 - rev 821815
Push
117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1475836: Clear cached callback pref when deleting branch. r=njn
MozReview-Commit-ID: C60kGkoFBL8
d68c6c56856cdd0306fc7c3491438d301526db51: Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 17:32:54 -0700 - rev 821814
Push
117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
In order to avoid the overhead of doing a full pref lookup for every static
var cache at content process startup, we currently assume that the default
value of any static varcache pref will always match the default value of its
database entry (as long as the pref isn't locked). This lets us only perform
lookups for preferences which have a user value, or are locked.
If the default values of those preferences are changed in a bundled preference
file, though, the varcache value will be correct in the parent process, but
not in child processes. Since this is an easy mistake to make, we should
assert that it doesn't happen.
Note: This change only affects applications which use e10s. Applications like
Thunderbird can still override default values of any static pref with
impunity. Repacks and distributors can only do so by changing user values or
locking the preference after the change (which is the standard practice for
enterprise deployments).
MozReview-Commit-ID: JMHQBrp9HN
1b389b00030ed38cdb3543aa5d1a67795be47565: Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 17:32:54 -0700 - rev 821805
Push
117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
In order to avoid the overhead of doing a full pref lookup for every static
var cache at content process startup, we currently assume that the default
value of any static varcache pref will always match the default value of its
database entry (as long as the pref isn't locked). This lets us only perform
lookups for preferences which have a user value, or are locked.
If the default values of those preferences are changed in a bundled preference
file, though, the varcache value will be correct in the parent process, but
not in child processes. Since this is an easy mistake to make, we should
assert that it doesn't happen.
Note: This change only affects applications which use e10s. Applications like
Thunderbird can still override default values of any static pref with
impunity. Repacks and distributors can only do so by changing user values or
locking the preference after the change (which is the standard practice for
enterprise deployments).
MozReview-Commit-ID: JMHQBrp9HN
3b9846062755b05de6729a84aa2b0acf6ddfd0bc: Bug 1475836: Clear cached callback pref when deleting branch. r=njn
Kris Maglione <maglione.k@gmail.com> - Fri, 20 Jul 2018 11:57:37 -0700 - rev 821804
Push
117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1475836: Clear cached callback pref when deleting branch. r=njn
MozReview-Commit-ID: C60kGkoFBL8
6cfed779217f2775c7ed092bc05c40365015f962: Bug 1469495 - Java Sampler never stops profiling. r=njn,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 22 Jun 2018 15:27:45 +0900 - rev 821457
Push
117101 by bmo:dharvey@mozilla.com at Mon, 23 Jul 2018 11:21:39 +0000
Bug 1469495 - Java Sampler never stops profiling. r=njn,snorp
Since GeckoJavaSampler::Stop() isn't called from locked_profiler_stop, Java
sampler is never stopped after stopping profiler.
And when calling GeckoJavaSampler::Stop(), it causes dead lock since stop()
is acquiring lock. So when calling join method, we should release this lock.
MozReview-Commit-ID: BLREo0lH6DS
554c3f761c64f0bc0bb706a481c9f6950025fe7c: Bug 1465452 Part 7 - Don't record a profiler atomic, r=njn.
Brian Hackett <bhackett1024@gmail.com> - Sat, 21 Jul 2018 14:32:11 +0000 - rev 821267
Push
117048 by bmo:ksaini@mozilla.com at Sun, 22 Jul 2018 10:49:35 +0000
Bug 1465452 Part 7 - Don't record a profiler atomic, r=njn.
7b542f98c02c0a22e57ef7472b71cb8659d5058c: Bug 1465452 Part 5 - Don't record some jemalloc atomics, r=njn.
Brian Hackett <bhackett1024@gmail.com> - Sat, 21 Jul 2018 14:30:33 +0000 - rev 821265
Push
117048 by bmo:ksaini@mozilla.com at Sun, 22 Jul 2018 10:49:35 +0000
Bug 1465452 Part 5 - Don't record some jemalloc atomics, r=njn.
ce26ca4168bb361dedf5346ec9fff2b5dae28760: Bug 1477254: Assert that varcache prefs match pref values at content process startup. r?njn
draft
Kris Maglione <maglione.k@gmail.com> - Fri, 20 Jul 2018 12:34:54 -0700 - rev 821033
Push
116996 by maglione.k@gmail.com at Fri, 20 Jul 2018 19:38:36 +0000
Bug 1477254: Assert that varcache prefs match pref values at content process startup. r?njn
In order to avoid the overhead of doing a full pref lookup for every static
var cache at content process startup, we currently assume that the default
value of any static varcache pref will always match the default value of its
database entry (as long as the pref isn't locked). This lets us only perform
lookups for preferences which have a user value, or are locked.
If the default values of those preferences are changed in a bundled preference
file, though, the varcache value will be correct in the parent process, but
not in child processes. Since this is an easy mistake to make, we should
assert that it doesn't happen.
Note: This change only affects applications which use e10s. Applications like
Thunderbird can still override default values of any static pref with
impunity. Repacks and distributors can only do so by changing user values or
locking the preference after the change (which is the standard practice for
enterprise deployments).
MozReview-Commit-ID: JMHQBrp9HN
686becc0ecbc9173b857d650e3de07a111b8c63d: Bug 1475836: Clear cached callback pref when deleting branch. r?njn
draft
Kris Maglione <maglione.k@gmail.com> - Fri, 20 Jul 2018 11:57:37 -0700 - rev 821022
Push
116993 by maglione.k@gmail.com at Fri, 20 Jul 2018 18:58:06 +0000
Bug 1475836: Clear cached callback pref when deleting branch. r?njn
MozReview-Commit-ID: C60kGkoFBL8
aadd0e8ef25069d17a5837c153a9e68d2f1a46bd: Bug 1471347 - part 2 - store an nsCString for SharedLibrary::mBreakpadId; r=njn
Nathan Froyd <froydnj@mozilla.com> - Thu, 19 Jul 2018 10:32:07 -0400 - rev 820520
Push
116859 by rwood@mozilla.com at Thu, 19 Jul 2018 20:03:44 +0000
Bug 1471347 - part 2 - store an nsCString for SharedLibrary::mBreakpadId; r=njn
Similar to the previous part, we convert mBreakpadId to an nsCString to
avoid issues with locale-dependent std::string operations.
There are a lot of non-profiler changes here because a bunch of things
depend on the SharedLibrary object that the profiler defines.
6b7ad73f1f4364cd42459090062580bd7e34811a: Bug 1471347 - part 1 - store an nsCString for SharedLibrary::mVersion; r=njn
Nathan Froyd <froydnj@mozilla.com> - Thu, 19 Jul 2018 10:32:07 -0400 - rev 820519
Push
116859 by rwood@mozilla.com at Thu, 19 Jul 2018 20:03:44 +0000
Bug 1471347 - part 1 - store an nsCString for SharedLibrary::mVersion; r=njn
Using operator<< on stringstream on Windows dives into the registry for
locale-specific formatting details. This behavior is neither desired
or (probably) anticipated by the code. Instead, let's use our normal
Gecko string classes for SharedLibrary::mVersion.
446e18bd766aaadb4b3124423ff75b83fa6eeef2: Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
draft
Markus Stange <mstange@themasta.com> - Thu, 19 Jul 2018 15:08:37 -0400 - rev 820512
Push
116853 by bmo:mstange@themasta.com at Thu, 19 Jul 2018 19:09:04 +0000
Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
MozReview-Commit-ID: 6HIWrA27X87
e32b2f8e11d60ebe917c15c0f407385f09553373: Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
draft
Robert Bartlensky <rbartlensky@mozilla.com> - Thu, 19 Jul 2018 13:36:33 +0100 - rev 820382
Push
116804 by bmo:rbartlensky@mozilla.com at Thu, 19 Jul 2018 13:36:31 +0000
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
MozReview-Commit-ID: B6oqb3tp3ND
33433ab0c0ffeb65c948dab8bc7b23735debbfe5: Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
draft
Robert Bartlensky <rbartlensky@mozilla.com> - Thu, 19 Jul 2018 13:36:33 +0100 - rev 820378
Push
116800 by bmo:rbartlensky@mozilla.com at Thu, 19 Jul 2018 13:13:42 +0000
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
MozReview-Commit-ID: B6oqb3tp3ND
067d547a19f0f4f55a3827e0bf6308111c23ea0b: Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
draft
Robert Bartlensky <rbartlensky@mozilla.com> - Thu, 19 Jul 2018 13:36:33 +0100 - rev 820347
Push
116789 by bmo:rbartlensky@mozilla.com at Thu, 19 Jul 2018 12:37:52 +0000
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r?njn
MozReview-Commit-ID: B6oqb3tp3ND
5b192ebc988f1788c856506fdcdcdbf47a0ddeec: Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
draft
Markus Stange <mstange@themasta.com> - Wed, 13 Jun 2018 17:43:03 -0400 - rev 820100
Push
116723 by bmo:mstange@themasta.com at Wed, 18 Jul 2018 21:49:38 +0000
Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r?njn, r?sfink
MozReview-Commit-ID: 6HIWrA27X87
