searching for reviewer(mixedpuppy)
0503d6eb70a76db7a941202ae05e1bfc448714b2: Bug 1467352 - Fix test_ext_storage_telemetry intermittency on win64-ccov. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 23 Aug 2018 17:50:50 +0000 - rev 831028
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1467352 - Fix test_ext_storage_telemetry intermittency on win64-ccov. r=mixedpuppy I've been unable to reproduce this intermittent locally (even by creating a "win64 ccov debug" build on Windows 10), but it has been easy enough to trigger on try. The failure is triggered when the test has been completed and it is unloading the test extension1, by the `NS_ERROR_FILE_ACCESS_DENIED` error raised from Extension's `cleanupGeneratedFile` (https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/toolkit/components/extensions/Extension.jsm#1835-1841). By comparing the test behavior when it runs successfully locally and fails on try, I've been finally able to identify what goes wrong when it fails: The reason for the `NS_ERROR_FILE_ACCESS_DENIED` is the ScriptCache entry for the test extension1's content script, which is created when we create and load the test content page which triggers it, this script cache entry should be cleared when the extension shutdown (and it is cleared when the test runs successfully) Then, right after the content script is executed, the contentPage is closed and this is where something goes (intermittently) wrong with the ipc (and the following pipe errors may be related to it: https://treeherder.mozilla.org/logviewer.html#?job_id=194750915&repo=mozilla-central&lineNumber=2692-2702) and, because of that, during the extension shutdown the "Extension:Shutdown" message broadcasted to all the process never reaches the process where the content script cache entry has been created (as well as "Extension:FlushJarCache" message sent to ensure that the jar cache is flushed in every process), and so the XPI file is still kept active by that process and so it fails to be removed on windows (where the usual `NS_ERROR_FILE_ACCESS_DENIED` is raised in this kind of scenarios). The underlying issue doesn't seem to be strictly related to the behavior that this test file is verifying (that is "checking that the expected telemetry data is being collected when the storage APIs are being used"), and so I think that it would be reasonable to prevent the intermittent by fixing the test (and closing the page after we unload the test extension 1 is enough to ensure that the script cache entry is always cleared as expected and the file can be removed successfully when the test is exiting). The following push to try seems to confirm it (the oranges are triggered by another unrelated test which fails intermittently in win64 ccov builds): - https://treeherder.mozilla.org/#/jobs?repo=try&revision=978e21c57ef084c4115703bf827306320e81bcad Differential Revision: https://phabricator.services.mozilla.com/D4067
ebcdf2f8e40caa2dc71786df08c9316b4578bb32: Bug 1484845 - Fix test verification failure by focusing an element consistently before synthesizing keys. r=mixedpuppy
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 21 Aug 2018 14:23:42 +0100 - rev 830542
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484845 - Fix test verification failure by focusing an element consistently before synthesizing keys. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3878
f66ffcb2e82af2f8c16b899af352834bd5bc34a9: Bug 1482529 - Support "visible" in menus.create and menus.update r=mixedpuppy
Rob Wu <rob@robwu.nl> - Mon, 20 Aug 2018 15:16:09 +0000 - rev 830372
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482529 - Support "visible" in menus.create and menus.update r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3794
be8aca082faf9aef30236657c9c486750e831a21: Bug 1482610 - Part 2 - Move the remaining attributes and remove the sidebar broadcasters. r=jaws,mixedpuppy
Paolo Amadini <paolo.mozmail@amadzone.org> - Sun, 19 Aug 2018 19:54:02 +0100 - rev 830316
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482610 - Part 2 - Move the remaining attributes and remove the sidebar broadcasters. r=jaws,mixedpuppy This also fixes unintended behavior for which clicking the selected item in the sidebar selector would hide the sidebar. Differential Revision: https://phabricator.services.mozilla.com/D3145
8ceb8813cc1d7beb81e044d411c0bac6babea9da: Bug 1482610 - Part 1 - Move the sidebar title and URL from the broadcasters to a JavaScript object. r=jaws,mixedpuppy
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 14 Aug 2018 15:18:03 +0100 - rev 830315
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482610 - Part 1 - Move the sidebar title and URL from the broadcasters to a JavaScript object. r=jaws,mixedpuppy The immediate goal is only to remove the broadcasters, so we still require the labels to be set manually on the "toolbarbutton" and "menuitem" elements. Generating these elements programmatically from the new SidebarUI.sidebars object, both for built-in sidebars and extensions, can be a future improvement. The autoCheck attribute is also unnecessary since it is only intended for the menu items, and they are already properly updated after their command is invoked. Since the attribute was written with the wrong capitalization, it already had no effect. The persistence of the label of the sidebar selector is also unnecessary since it is already set on startup. Removing this does not seem to cause any additional flickering. Differential Revision: https://phabricator.services.mozilla.com/D3143
0e1d62e81cb1fd01fa992a51446dea4d6ec92663: Bug 1483684 - Fix browserAction ignoring tab-specific or window-specific popups and showing global one instead. r=mixedpuppy
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 16 Aug 2018 13:14:44 +0000 - rev 829904
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1483684 - Fix browserAction ignoring tab-specific or window-specific popups and showing global one instead. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3465
f35fa6e7fb463ce848beb3df1550a12089527974: Bug 1480292 - Fix browser_ext_popup_select intermittent failures. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 16 Aug 2018 13:19:03 +0000 - rev 829761
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1480292 - Fix browser_ext_popup_select intermittent failures. r=mixedpuppy From what I saw by reproducing it locally (e.g. I've also been able to trigger it locally pretty often on linux64 by using "./mach mochitest --verify"), the select popup may sometimes be still using part of its previous position while switching between the test case for the browserAction and the test case for the pageAction. On linux64 this test was also (from time to time) sending the mouse event when the select element wasn't yet ready to be clicked in the extension popup. This patch aims to make the behaviors of this test more stable by applying the following changes: - disable the cosmeticAnimations while running these tests - explicitly wait the select element in the popup (using ContentTask.spawn and ContentTaskUtils.waitForCondition) before sending it a mouse event - explicilty close the select popup (and wait the select popup to be hidden) before proceeding to the next test case The following push to try seems to confirm that these changes are helping to make the test more stable: - https://treeherder.mozilla.org/#/jobs?repo=try&revision=086c526724ba409068d679036dd3ef13788535b6&selectedJob=194152144 Differential Revision: https://phabricator.services.mozilla.com/D3438
bf786c1aca5f35302edb23ae14015ac0f39887ff: Bug 1446274 - Fix browserAction popup resize test intermittency due to initial popup height being detected while still resizing. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Wed, 15 Aug 2018 12:11:19 +0000 - rev 829430
Push 118781 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 02:46:06 +0000
Bug 1446274 - Fix browserAction popup resize test intermittency due to initial popup height being detected while still resizing. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3349
79a59b25e5354e991ba27af9aec9820fe172501a: Bug 1482610 - Part 2 - Move the remaining attributes and remove the sidebar broadcasters. r=jaws,mixedpuppy
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 14 Aug 2018 15:18:25 +0100 - rev 829070
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1482610 - Part 2 - Move the remaining attributes and remove the sidebar broadcasters. r=jaws,mixedpuppy This also fixes unintended behavior for which clicking the selected item in the sidebar selector would hide the sidebar. Differential Revision: https://phabricator.services.mozilla.com/D3145
f5873a719ec0ba10ca55a09c3a36320ee6abbedb: Bug 1482610 - Part 1 - Move the sidebar title and URL from the broadcasters to a JavaScript object. r=jaws,mixedpuppy
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 14 Aug 2018 15:18:03 +0100 - rev 829069
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1482610 - Part 1 - Move the sidebar title and URL from the broadcasters to a JavaScript object. r=jaws,mixedpuppy The immediate goal is only to remove the broadcasters, so we still require the labels to be set manually on the "toolbarbutton" and "menuitem" elements. Generating these elements programmatically from the new SidebarUI.sidebars object, both for built-in sidebars and extensions, can be a future improvement. The autoCheck attribute is also unnecessary since it is only intended for the menu items, and they are already properly updated after their command is invoked. Since the attribute was written with the wrong capitalization, it already had no effect. The persistence of the label of the sidebar selector is also unnecessary since it is already set on startup. Removing this does not seem to cause any additional flickering. Differential Revision: https://phabricator.services.mozilla.com/D3143
776150decf44aa096bea714e975e2dd753e4df0d: Bug 1474440 - Implement support for the 'onHighlighted' API for multiselect tabs r=mixedpuppy
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sat, 28 Jul 2018 13:15:55 +0200 - rev 828872
Push 118725 by jhofmann@mozilla.com at Tue, 14 Aug 2018 08:20:30 +0000
Bug 1474440 - Implement support for the 'onHighlighted' API for multiselect tabs r=mixedpuppy MozReview-Commit-ID: 8aOmdj0AB3e
0b0cb02af89526277fd2ae185e1fffcd8a0f69b0: Bug 1474440 - Rename browser_ext_tabs_onHighlighted.js to browser_ext_tabs_events_order.js r=mixedpuppy
Oriol Brufau <oriol-bugzilla@hotmail.com> - Sun, 05 Aug 2018 22:08:34 +0200 - rev 828871
Push 118725 by jhofmann@mozilla.com at Tue, 14 Aug 2018 08:20:30 +0000
Bug 1474440 - Rename browser_ext_tabs_onHighlighted.js to browser_ext_tabs_events_order.js r=mixedpuppy Basically it tests in which order various tab events are dispatched, so the old name didn't make sense, and it will be more suited for a new test specific to onHighlighted. MozReview-Commit-ID: Kj8GZfHA0Ap
9a65efe88395ef3d8e79f652a317bafbd9bbe962: Bug 1469705: allow menus.refresh() without an onShown listener r=mixedpuppy
Peter Simonyi <pts@petersimonyi.ca> - Thu, 05 Jul 2018 22:06:23 -0400 - rev 828868
Push 118725 by jhofmann@mozilla.com at Tue, 14 Aug 2018 08:20:30 +0000
Bug 1469705: allow menus.refresh() without an onShown listener r=mixedpuppy MozReview-Commit-ID: 3GbQEoSFTW8
6d03373ced3a298e6fdff35f9c9ae8638fded93f: Bug 1481179 - Stop extensions from changing the icon in the top-level menu r=mixedpuppy
Rob Wu <rob@robwu.nl> - Mon, 13 Aug 2018 13:25:50 +0000 - rev 828860
Push 118725 by jhofmann@mozilla.com at Tue, 14 Aug 2018 08:20:30 +0000
Bug 1481179 - Stop extensions from changing the icon in the top-level menu r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3198
56aaeff290b7cbe2b9efc43ef8a651049c3fe6b0: Bug 1482411 - Port bug 1371951 changes to extension-mac.css r=mixedpuppy
ExE Boss <3889017+ExE-Boss@users.noreply.github.com> - Fri, 10 Aug 2018 15:00:35 +0000 - rev 828630
Push 118685 by bmo:oriol-bugzilla@hotmail.com at Sun, 12 Aug 2018 12:21:52 +0000
Bug 1482411 - Port bug 1371951 changes to extension-mac.css r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D3112
68dbca6faa6e5d21684d73048cf7beb579acb7b5: Bug 1325814 - Support shadow DOM in menus.getTargetElement + test r=mixedpuppy
Rob Wu <rob@robwu.nl> - Wed, 08 Aug 2018 18:06:41 +0200 - rev 828560
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1325814 - Support shadow DOM in menus.getTargetElement + test r=mixedpuppy MozReview-Commit-ID: JzVM8wVpaeP
a7c2208c1f85a2d301d6a89a6c4c08ec43f60fa4: Bug 1325814 - Add tests for menus.getTargetElement API r=mixedpuppy
Rob Wu <rob@robwu.nl> - Sat, 04 Aug 2018 18:40:54 +0200 - rev 828559
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1325814 - Add tests for menus.getTargetElement API r=mixedpuppy The tests are split in two files: - browser_ext_menus_targetElement.js to test interaction with web pages via content scripts. - browser_ext_menus_targetElement_extension.js to test interaction with menus in extension processes. And browser_ext_menus_events.js was updated to recognize the new property. MozReview-Commit-ID: F0HEiNADRuM
e08c04702ab48c1fc5729dd09ce9ab5f3bcde08e: Bug 1325814 - Add extension API to find menu target r=mixedpuppy
Rob Wu <rob@robwu.nl> - Sat, 04 Aug 2018 18:09:49 +0200 - rev 828558
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1325814 - Add extension API to find menu target r=mixedpuppy - Add info.targetElementId to menus.onShown event. - Add info.targetElementId to menus.onClicked event. - Add menus.getTargetElement API that is available to all contexts, including content scripts, which allows extensions to get the DOM element for a given targetElementId. - Add new schema instead of re-using schemas/menus.json to avoid sending too much schema data (of the existing menus API) to content processes. MozReview-Commit-ID: 6Onf7jZlIho
f47fc4512dfb3975e15e6af96c1f9886a6863f9a: Bug 1325814 - Remove unnecessary schemas/menus_internal.json r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 03 Aug 2018 11:09:38 +0200 - rev 828557
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1325814 - Remove unnecessary schemas/menus_internal.json r=mixedpuppy This schema was inherited from Chromium (where it was an internal implementation detail. This schema only defined the OnClickData type, but was never actively used by our WebExtensions framework, because menus.json already defines the OnClickData type. Note: menus_internal.json specified the "menusInternal" namespace which we do indeed implement in parent/ext-menus.js (and use in child/ext-menus.js). However, none of the methods that we add to menusInternal are actually defined in the schema. This use of menusInternal was introduced in part 2 of bug 1333403 and works without problems because the API schemas are not being used to validate APIs as of part 2 of bug 1315575. The only significance of "menusInternal" is that the namespace is defined in browser/components/extensions/ext-browser.json, implemented in browser/components/extensions/parent/ext-menus.js and used by browser/components/extensions/child/ext-menus.js MozReview-Commit-ID: 2ACpn595QZQ
51d530820c10c71944b73decd7ba5f489d0a0245: Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm r=mixedpuppy
Rob Wu <rob@robwu.nl> - Thu, 02 Aug 2018 23:16:46 +0200 - rev 828556
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm r=mixedpuppy At its inception, ExtensionChild.jsm was meant to be used for the extension child process. Over time, this intent was not consistently followed, and in bug 1317697 this was fixed by splitting some logic in ExtensionChild.jsm off to ExtensionPageChild.jsm. Henceforth ExtensionChild.jsm handles logic that is common to all content processes, including web content and extension logic. Updated the comment at the top of the file to match this reality. MozReview-Commit-ID: 3cAd0FPj6Vz
2ee80881dcf39daa1fe5096ba6dce9ea2b994717: Bug 1480993 - Remove unused extensions.sidebar-button.shown pref from tests r=mixedpuppy
Rob Wu <rob@robwu.nl> - Thu, 09 Aug 2018 13:54:41 +0000 - rev 828502
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1480993 - Remove unused extensions.sidebar-button.shown pref from tests r=mixedpuppy This pref was removed in bug 1387081, when the sidebar-button started to be shown by default. I have also removed the end of the test that removed the button, since these were attempts to restore the default state. At the inception of the tests, the default state is to not show the button, but now the button is to be shown by default. Differential Revision: https://phabricator.services.mozilla.com/D2954
e57c44d5ec978b70bbfb0d44152b5625a5b8997a: Bug 1371951 - Make browser-style checkboxes and radio buttons handle style themselves. r=mixedpuppy, bwinton
ExE Boss <3889017+ExE-Boss@users.noreply.github.com> - Sat, 17 Feb 2018 17:00:00 +0100 - rev 828313
Push 118671 by bmo:mstriemer@mozilla.com at Fri, 10 Aug 2018 18:51:19 +0000
Bug 1371951 - Make browser-style checkboxes and radio buttons handle style themselves. r=mixedpuppy, bwinton This removes the requirement for browser-style checkboxes and radio buttons to be followed by a label since the reason why this was originally done no longer applies because bug 418833 made it possible for checkboxes and radio buttons to handle styling themselves rather than requiring a label::before element.
56a97a3eee824d1b5174d4ca075c080e8fbbc054: Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 Aug 2018 19:00:39 +0100 - rev 828225
Push 118651 by bmo:guptatrisha97@gmail.com at Fri, 10 Aug 2018 11:02:58 +0000
Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy MozReview-Commit-ID: 6C3H7wPK2v6
2acd741506c3dc7dbcc9a215749ee271de64189d: Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy draft
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 Aug 2018 19:00:39 +0100 - rev 827976
Push 118616 by bmo:ntim.bugs@gmail.com at Thu, 09 Aug 2018 18:09:15 +0000
Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy MozReview-Commit-ID: 6C3H7wPK2v6
6102716d52355d7a681bbe1bd2a9b44af0a1dc0a: Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy draft
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 Aug 2018 19:00:39 +0100 - rev 827975
Push 118615 by bmo:ntim.bugs@gmail.com at Thu, 09 Aug 2018 18:07:50 +0000
Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy MozReview-Commit-ID: 6C3H7wPK2v6
c0808d4f6c06d0d893be4c8282ccd7e65cb2f5f7: Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy draft
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 Aug 2018 19:00:39 +0100 - rev 827972
Push 118613 by bmo:ntim.bugs@gmail.com at Thu, 09 Aug 2018 18:04:11 +0000
Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy MozReview-Commit-ID: 6C3H7wPK2v6
dfc61659d0660b2c6e9694801208423ecc54dbe2: Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy draft
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 09 Aug 2018 19:00:39 +0100 - rev 827971
Push 118612 by bmo:ntim.bugs@gmail.com at Thu, 09 Aug 2018 18:01:17 +0000
Bug 1347207 - Add and fix tests for theme loading warnings. r=mixedpuppy MozReview-Commit-ID: 6C3H7wPK2v6
72dd828f24817614cd30c1156b99b58b73f9f5e7: Bug 1280370 - Remove unneeded DomainIsWildcard check r=mixedpuppy
Rob Wu <rob@robwu.nl> - Wed, 08 Aug 2018 18:56:53 +0200 - rev 827907
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1280370 - Remove unneeded DomainIsWildcard check r=mixedpuppy The DomainIsWildcard check is already covered by MatchesDomain.
d01b3ac48bdc327764b63c21400e6abb7d53cb85: Bug 1280370 - Allow any scheme in targetUrlPatterns r=mixedpuppy
Rob Wu <rob@robwu.nl> - Tue, 24 Jul 2018 17:26:23 +0200 - rev 827906
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1280370 - Allow any scheme in targetUrlPatterns r=mixedpuppy MozReview-Commit-ID: KupQIiAkz0h
0134a212426692593c68d6f40c718377f13e2087: Bug 1280370 - Properly parse MatchPattern for schemes with no authority r=mixedpuppy,zombie
Rob Wu <rob@robwu.nl> - Tue, 24 Jul 2018 16:35:45 +0200 - rev 827905
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1280370 - Properly parse MatchPattern for schemes with no authority r=mixedpuppy,zombie I found these schemes by enumerating all registered nsIProtocolHandler and checking whether they require a "//". The list of schemes in HOST_LOCATOR_SCHEMES only includes schemes that are known to Firefox. Any other scheme is parsed as if the separator is ":". For example, NetUtil.newURI("unknown-scheme://host/path") has its pathQueryRef member set to "//host/path". For the purpose of matching in MatchPattern, this unknown scheme has therefore no host and only a path. MozReview-Commit-ID: KGNRXGcZTZx
b6cb27b7a5791193f6fbae68cc338e20a767c34e: Bug 1280370 - Don't set MatchPattern::mMatchSubdomain if the scheme does not support hosts r=mixedpuppy,zombie
Rob Wu <rob@robwu.nl> - Tue, 24 Jul 2018 13:33:15 +0200 - rev 827904
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1280370 - Don't set MatchPattern::mMatchSubdomain if the scheme does not support hosts r=mixedpuppy,zombie Otherwise MatchPattern::Matches would always return false if the aExplicit flag is set to true, even if the match pattern is identical to the tested URL. MozReview-Commit-ID: FtdOgwrAkk8
587e951a256e672db6205e422b5ac5c26216773b: Bug 1280370 - Properly parse MatchPatterns with "data:" scheme r=mixedpuppy,zombie
Rob Wu <rob@robwu.nl> - Tue, 24 Jul 2018 11:43:02 +0200 - rev 827903
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1280370 - Properly parse MatchPatterns with "data:" scheme r=mixedpuppy,zombie The "data:" scheme is not followed by "//host". This patch fixes the parser so that "data:..." is expected instead of "data://...". MozReview-Commit-ID: 8TLVF3hdQ7H
1088432fc83e97e2bb96142793005a59a80015b4: Bug 1320462 - Support access keys in extension menus. r=mixedpuppy
Rob Wu <rob@robwu.nl> - Mon, 06 Aug 2018 16:58:21 +0200 - rev 827348
Push 118523 by bmo:alwu@mozilla.com at Tue, 07 Aug 2018 22:38:39 +0000
Bug 1320462 - Support access keys in extension menus. r=mixedpuppy MozReview-Commit-ID: GsLE3PwNeiC
8236a828c129df0743a66d75d5f9a8845d4246d4: Bug 1474562 - Enable ExtensionStorageIDB on Nightly. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 26 Jul 2018 19:28:19 +0200 - rev 826537
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1474562 - Enable ExtensionStorageIDB on Nightly. r=mixedpuppy MozReview-Commit-ID: 2YzrVdMSE4q
f6ec69871ae1f0c5899f97241fa960cfee9c5c8d: Bug 1476177 Fix platform matching in AMO metadata requests r=mixedpuppy
Andrew Swan <aswan@mozilla.com> - Wed, 01 Aug 2018 09:14:22 -0700 - rev 826159
Push 118251 by bmo:mh+mozilla@glandium.org at Fri, 03 Aug 2018 02:37:41 +0000
Bug 1476177 Fix platform matching in AMO metadata requests r=mixedpuppy MozReview-Commit-ID: EvjeXdCyLxi
65b6a2ecc1110716ad59602d2dae30ab510c8be4: Bug 1398542 - Add test coverage for video/audio context menus r=mixedpuppy
Rob Wu <rob@robwu.nl> - Wed, 01 Aug 2018 18:20:17 +0200 - rev 826081
Push 118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1398542 - Add test coverage for video/audio context menus r=mixedpuppy MozReview-Commit-ID: 22VB0Jltj56
8c730b4539291f85f279f6dcb24283c9187b791e: Bug 1473920 - Fix browser_ext_themes_ntp_colors_perwindow failures when running on Linux. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Mon, 30 Jul 2018 21:40:35 +0200 - rev 826077
Push 118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1473920 - Fix browser_ext_themes_ntp_colors_perwindow failures when running on Linux. r=mixedpuppy MozReview-Commit-ID: LxlmZ7xx06s
e880cb10c3f49b784c76ff853a57aea20956636b: Bug 1446956 - Test that activeTab is not granted for bookmarks menu r=mixedpuppy
Rob Wu <rob@robwu.nl> - Thu, 19 Jul 2018 16:35:22 +0200 - rev 825843
Push 118186 by bmo:bpostelnicu@mozilla.com at Thu, 02 Aug 2018 13:24:00 +0000
Bug 1446956 - Test that activeTab is not granted for bookmarks menu r=mixedpuppy This ensures that the check that was introduced by bug 1370499 still continues to work even though it was refactored by the previous commit. MozReview-Commit-ID: GdbIPA6vxIB
e6aa498748e8e66be64ec7adc18a590621747a0d: Bug 1446956 - Grant access to the clicked tab in menus.onClicked r=mixedpuppy
Rob Wu <rob@robwu.nl> - Wed, 18 Jul 2018 22:04:58 +0200 - rev 825842
Push 118186 by bmo:bpostelnicu@mozilla.com at Thu, 02 Aug 2018 13:24:00 +0000
Bug 1446956 - Grant access to the clicked tab in menus.onClicked r=mixedpuppy MozReview-Commit-ID: 3mVWOEcZFYn
d7aac87e2db54dc57b951e63079f053df49a50ef: Bug 1477015 - Select storage.local backend on startup when the extension is not migrating its data. r=aswan,mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 26 Jul 2018 13:53:22 +0200 - rev 825478
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1477015 - Select storage.local backend on startup when the extension is not migrating its data. r=aswan,mixedpuppy MozReview-Commit-ID: WzW2bFlYNg
3a4b606f79aea7836467edec5f83227163c781e3: Bug 1454627 - Fix timing issue in browser_ext_user_events.js r=mixedpuppy
Rob Wu <rob@robwu.nl> - Tue, 31 Jul 2018 16:58:41 +0200 - rev 825475
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1454627 - Fix timing issue in browser_ext_user_events.js r=mixedpuppy The hard-coded wait exists to avoid a test failure caused by a non-functional click event in an options browser. However, that still does not get rid of the intermittent failure. To really avoid the timing issue, check whether onclick was fired after supposedly triggering a click, and if not, wait and retry. MozReview-Commit-ID: 9eg6sz1s1e3
50114fce0886ee55f0c83a79bc2518df6e1150b2: Bug 1454627 - Run "onclick" event of menu with user input r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 27 Jul 2018 19:06:00 +0200 - rev 825474
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1454627 - Run "onclick" event of menu with user input r=mixedpuppy MozReview-Commit-ID: r1URJfOKUB
64e2944b635bd6d45a660c324f2d45cb62427018: Bug 1454627 - Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 27 Jul 2018 18:52:21 +0200 - rev 825473
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1454627 - Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy Re-enable the test that was disabled in bug 1381305 and fix the underlying issue that caused th intermittent failure in the first place. MozReview-Commit-ID: BL9wS2fogaf
38d9cbe6e3d20e9099807a00bf1335a8451a9764: Bug 1454627 - Fix timing issue in browser_ext_user_events.js r=mixedpuppy
Rob Wu <rob@robwu.nl> - Tue, 31 Jul 2018 16:58:41 +0200 - rev 825053
Push 118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1454627 - Fix timing issue in browser_ext_user_events.js r=mixedpuppy MozReview-Commit-ID: 9eg6sz1s1e3
44b38de7dc3d2e062e31035298e5ad99708d0138: Bug 1454627 - Run "onclick" event of menu with user input r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 27 Jul 2018 19:06:00 +0200 - rev 825052
Push 118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1454627 - Run "onclick" event of menu with user input r=mixedpuppy MozReview-Commit-ID: r1URJfOKUB
22de883763acb05328b556944169ce478e1d1a44: Bug 1454627 - Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy
Rob Wu <rob@robwu.nl> - Fri, 27 Jul 2018 18:52:21 +0200 - rev 825051
Push 118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1454627 - Re-enable browser_ext_user_events.js (bug 1381305) r=mixedpuppy Re-enable the test that was disabled in bug 1381305 and fix the underlying issue that caused th intermittent failure in the first place. MozReview-Commit-ID: BL9wS2fogaf
cc67a75b9160b20b8ae96f2f367c52249b22d21b: Bug 1446956 - Test that activeTab is not granted for bookmarks menu r=mixedpuppy
Rob Wu <rob@robwu.nl> - Thu, 19 Jul 2018 16:35:22 +0200 - rev 825050
Push 118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1446956 - Test that activeTab is not granted for bookmarks menu r=mixedpuppy This ensures that the check that was introduced by bug 1370499 still continues to work even though it was refactored by the previous commit. MozReview-Commit-ID: GdbIPA6vxIB
7e49d55f024004a169d872833e2562e65809da81: Bug 1446956 - Grant access to the clicked tab in menus.onClicked r=mixedpuppy
Rob Wu <rob@robwu.nl> - Wed, 18 Jul 2018 22:04:58 +0200 - rev 825049
Push 118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1446956 - Grant access to the clicked tab in menus.onClicked r=mixedpuppy MozReview-Commit-ID: 3mVWOEcZFYn
c2bbdbdddedc359308b8cec40b7fd7bcb7e2b40a: Bug 1321182 - Register click handler before starting click test in browser_ext_contextMenus.js. r=mixedpuppy, a=test-only draft
Rob Wu <rob@robwu.nl> - Fri, 20 Jul 2018 17:43:42 +0200 - rev 824937
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1321182 - Register click handler before starting click test in browser_ext_contextMenus.js. r=mixedpuppy, a=test-only MozReview-Commit-ID: FkOjNm7Tgd5
52dd0b769e22eb79c05bcf45462cf2564c654d32: Bug 1459404 - Ensure that ChildAPIManager can be garbage-collected. r=mixedpuppy a=lizzard draft
Rob Wu <rob@robwu.nl> - Tue, 17 Jul 2018 18:17:52 +0200 - rev 824929
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1459404 - Ensure that ChildAPIManager can be garbage-collected. r=mixedpuppy a=lizzard MozReview-Commit-ID: IEGq1mo4WWq