searching for reviewer(mfinkle)
c65b730187f6c387602d5e1b31ddbba59d6aadf6: Bug 1303008 - refactor Fennec Finder.jsm integration to always show the correct match count results in the findbar. r?mfinkle draft
Mike de Boer <mdeboer@mozilla.com> - Thu, 06 Oct 2016 21:08:49 +0200 - rev 421748
Push 31582 by mdeboer@mozilla.com at Thu, 06 Oct 2016 19:11:56 +0000
Bug 1303008 - refactor Fennec Finder.jsm integration to always show the correct match count results in the findbar. r?mfinkle MozReview-Commit-ID: 9Ox1Tu4Rkpl
ba419502cc29a7246dede673fb1e0fe46de49555: Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 21 Sep 2016 20:24:57 +0800 - rev 420121
Push 31098 by bmo:kuoe0@mozilla.com at Mon, 03 Oct 2016 10:10:09 +0000
Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle MozReview-Commit-ID: A9yXeADOA0Y
48a477d3305e1f3e18dc96cb4fef52103a3ba888: Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 21 Sep 2016 20:24:57 +0800 - rev 420084
Push 31085 by bmo:kuoe0@mozilla.com at Mon, 03 Oct 2016 08:27:53 +0000
Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle MozReview-Commit-ID: A9yXeADOA0Y
baf55c6bd9b2e99c6bf07dbbe758b279e5ffe376: Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 21 Sep 2016 20:24:57 +0800 - rev 419657
Push 30983 by bmo:kuoe0@mozilla.com at Fri, 30 Sep 2016 18:39:51 +0000
Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle MozReview-Commit-ID: A9yXeADOA0Y
bc89e43f8cfa0e8bf50462d592345def80151567: Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 21 Sep 2016 20:24:57 +0800 - rev 418943
Push 30808 by bmo:kuoe0@mozilla.com at Thu, 29 Sep 2016 10:21:27 +0000
Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle MozReview-Commit-ID: A9yXeADOA0Y
d69b954e04dbdc42508c1c180ea94a5d2cb8eb02: Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle draft
KuoE0 <kuoe0.tw@gmail.com> - Wed, 21 Sep 2016 20:24:57 +0800 - rev 418905
Push 30797 by bmo:kuoe0@mozilla.com at Thu, 29 Sep 2016 08:42:50 +0000
Bug 1305351 - Add ChromeCastDisplay for Presentation API. r?mfinkle MozReview-Commit-ID: A9yXeADOA0Y
4a2454585e72a98430f314a3ddc2b868aef23d4a: Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice
Fernando Jimenez <ferjmoreno@gmail.com> - Fri, 19 Aug 2016 15:14:53 +0200 - rev 403889
Push 27041 by gijskruitbosch@gmail.com at Mon, 22 Aug 2016 11:53:01 +0000
Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice MozReview-Commit-ID: C50fvuNJoGq
50e452ea5512332c66a86630fb92dc72dd69b35f: Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice draft
Fernando Jimenez <ferjmoreno@gmail.com> - Fri, 19 Aug 2016 15:14:53 +0200 - rev 403338
Push 26882 by bmo:lissyx+mozillians@lissyx.dyndns.org at Fri, 19 Aug 2016 14:50:04 +0000
Bug 1252570 - Remove mozPay. r=ehsan,mfinkle,fabrice MozReview-Commit-ID: C50fvuNJoGq
0985e72ae29f8830f196a01b076284873d2685dc: Bug 1282968 - Redash android_events_v1.experiments missing onboarding3-a. r=mfinkle draft
Chenxia Liu <liuche@mozilla.com> - Thu, 30 Jun 2016 17:20:00 -0700 - rev 383016
Push 21900 by cliu@mozilla.com at Fri, 01 Jul 2016 00:20:23 +0000
Bug 1282968 - Redash android_events_v1.experiments missing onboarding3-a. r=mfinkle MozReview-Commit-ID: FnUc4aRlYxr
d92c793bfa61b6715dd898f485d1aed9e9bb46fa: Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Fri, 18 Mar 2016 19:07:18 -0400 - rev 378848
Push 21011 by mak77@bonardo.net at Thu, 16 Jun 2016 13:40:45 +0000
Bug 1256415 - Replace FENNEC_GECKOAPP_STARTUP_ACTION histogram with UI telemetry. r=mfinkle a=ritu MozReview-Commit-ID: ElmELmp7baV
629e466407526e1697dc0438d5808293a020f0a7: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 378835
Push 21011 by mak77@bonardo.net at Thu, 16 Jun 2016 13:40:45 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu MozReview-Commit-ID: 9Et4AhCzAr9
9a4077c55f8be12165d91029b4560073e6c1f7d5: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 371659
Push 19358 by cliu@mozilla.com at Thu, 26 May 2016 21:42:05 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle a=ritu MozReview-Commit-ID: 9Et4AhCzAr9
8e724faf0734aabdb05020be65798a68f46ac354: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle a=lizzard
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 16:19:49 -0700 - rev 371636
Push 19358 by cliu@mozilla.com at Thu, 26 May 2016 21:42:05 +0000
Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle a=lizzard MozReview-Commit-ID: A24qXyNpWwk
69c440f932fefc197d59b0fc417bdddacd9dccf9: Bug 810981 - Part 4 - Test session store scroll position and zoom level handling. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 06 May 2016 18:44:42 +0200 - rev 368517
Push 18563 by mozilla@buttercookie.de at Wed, 18 May 2016 23:08:01 +0000
Bug 810981 - Part 4 - Test session store scroll position and zoom level handling. r=mfinkle MozReview-Commit-ID: 4jZ0ixoJmOO
9592159e653b121b420ae6c3280debfb63f90666: Bug 810981 - Part 3 - Recalculate zoom level before restoring to a different screen orientation. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 22:53:34 +0200 - rev 368516
Push 18563 by mozilla@buttercookie.de at Wed, 18 May 2016 23:08:01 +0000
Bug 810981 - Part 3 - Recalculate zoom level before restoring to a different screen orientation. r=mfinkle On pages that aren't "width=device-width" or similar, Gecko adjusts the resolution when the display dimensions change because the device has been rotated. The session store needs to do something similar when restoring a page if the device orientation has changed since the moment the tab state was captured. Therefore we now include the width of the browser window in the saved zoom data and use it to scale the zoom level as necessary when restoring a tab. MozReview-Commit-ID: LBbEquO1bZ9
84ffc4bc0bc4327681e08bac741acc37e3aee48f: Bug 810981 - Part 2 - Save the current zoom level when scrolling. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 22:58:46 +0200 - rev 368515
Push 18563 by mozilla@buttercookie.de at Wed, 18 May 2016 23:08:01 +0000
Bug 810981 - Part 2 - Save the current zoom level when scrolling. r=mfinkle Since we're now recording the scroll position in the session data, it makes sense to store the zoom level as well. This necessitates moving the scroll position restoring to the "pageshow" event, because - restoring the scroll position needs to happen after restoring the zoom level - and the zoom level cannot be restored after the "load" event, because at that point the restored zoom level will get overwritten by the native code setting its own initial zoom level. MozReview-Commit-ID: 6NtYqc8pm3N
6c11b6debb397488bb2f35f5bb77204b405ff219: Bug 810981 - Part 1 - Record current scroll position in mobile session store. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 22:24:16 +0200 - rev 368514
Push 18563 by mozilla@buttercookie.de at Wed, 18 May 2016 23:08:01 +0000
Bug 810981 - Part 1 - Record current scroll position in mobile session store. r=mfinkle This copies the approach we've taken for form data saving and applies it to recording the current scroll position of the page, too. MozReview-Commit-ID: C0lBxzHav7Z
f15a0c2d0178fc4396ef16f3a54a0f95e82e31ad: Bug 1261617 - Add UITelemetry for search counts. r=mfinkle
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 May 2016 17:23:48 -0700 - rev 367545
Push 18267 by chevobbe.nicolas@gmail.com at Mon, 16 May 2016 20:51:50 +0000
Bug 1261617 - Add UITelemetry for search counts. r=mfinkle I largerly kept this patch the same as Finkle's initial revision except that I don't include the engine identifiers due to bug 1272166. MozReview-Commit-ID: 84672CDOOVX
27b537f766f732beaecbeb5843a25d385b31977c: Bug 905223 - Part 3 - Move the session parsing in front of the layout initialisation. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 20:54:57 +0200 - rev 367530
Push 18257 by mozilla@buttercookie.de at Mon, 16 May 2016 19:42:18 +0000
Bug 905223 - Part 3 - Move the session parsing in front of the layout initialisation. r=mfinkle Since we're doing this in background now anyway, we might as well start doing it slightly earlier and run in parallel to parts of the layout setup, so we don't bump immediately into the the following, preexisting bit of background initialisation. MozReview-Commit-ID: UJwhCQmcEa
87a993da26375bb9aec5d5bf98786bfdae298f5c: Bug 905223 - Part 2 - Move session data parsing into a background thread. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 22:36:46 +0200 - rev 367529
Push 18257 by mozilla@buttercookie.de at Mon, 16 May 2016 19:42:18 +0000
Bug 905223 - Part 2 - Move session data parsing into a background thread. r=mfinkle Parsing the session store JSON data to restore the last session's tabs is both - computationally relatively expensive - involving disk I/O therefore, we shouldn't be doing it on the main thread. To make sure the session data is actually ready, subsequent code running from a different thread that needs to access it (sending the session restore string to Gecko, the Recent Tabs panel reading the "tabs from last time") waits on a CountDownLatch which is released once the relevant data has been processed. MozReview-Commit-ID: EYf1fdglIrA
9a129a0ffbaafc5d775e4f10300f05f0f78a4d78: Bug 905223 - Part 1 Factor out external URL calculation. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 20:08:58 +0200 - rev 367528
Push 18257 by mozilla@buttercookie.de at Mon, 16 May 2016 19:42:18 +0000
Bug 905223 - Part 1 Factor out external URL calculation. r=mfinkle For session data parsing, we need to know whether we were invoked with an external URL or not. Since we want to move session data parsing forward to an earlier point in time, but also continue needing that external URL info during initialize() as well, we'll factor out those calculations into their own functions which can then be called from both places. MozReview-Commit-ID: HFlT8uxC9yz
756a52ca69281cf127abcae61ee71e9a063f52b6: Bug 905223 - Part 0 - Add target API annotations to get rid of errors in Android Studio. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 22:29:03 +0200 - rev 367527
Push 18257 by mozilla@buttercookie.de at Mon, 16 May 2016 19:42:18 +0000
Bug 905223 - Part 0 - Add target API annotations to get rid of errors in Android Studio. r=mfinkle Android Studio doesn't recognise our version guards and is consequentially always showing two errors in GeckoApp, which makes it more difficult to spot when you've introduced an actual error. MozReview-Commit-ID: LpNIwHOhEWE
b5630f6467981f49f3fe84350706071d44cd6ace: Bug 905223 - Part 3 - Move the session parsing in front of the layout initialisation. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 20:54:57 +0200 - rev 367523
Push 18255 by mozilla@buttercookie.de at Mon, 16 May 2016 19:40:39 +0000
Bug 905223 - Part 3 - Move the session parsing in front of the layout initialisation. r=mfinkle Since we're doing this in background now anyway, we might as well start doing it slightly earlier and run in parallel to parts of the layout setup, so we don't bump immediately into the the following, preexisting bit of background initialisation. MozReview-Commit-ID: UJwhCQmcEa
31c0522256c73da00e306307d04cfb26e5b240d3: Bug 905223 - Part 2 - Move session data parsing into a background thread. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 22:36:46 +0200 - rev 367522
Push 18255 by mozilla@buttercookie.de at Mon, 16 May 2016 19:40:39 +0000
Bug 905223 - Part 2 - Move session data parsing into a background thread. r=mfinkle Parsing the session store JSON data to restore the last session's tabs is both - computationally relatively expensive - involving disk I/O therefore, we shouldn't be doing it on the main thread. To make sure the session data is actually ready, subsequent code running from a different thread that needs to access it (sending the session restore string to Gecko, the Recent Tabs panel reading the "tabs from last time") waits on a CountDownLatch which is released once the relevant data has been processed. MozReview-Commit-ID: EYf1fdglIrA
4cb01d522b64df2308bec9162d6901abafaf7a3a: Bug 905223 - Part 1 Factor out external URL calculation. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 20:08:58 +0200 - rev 367521
Push 18255 by mozilla@buttercookie.de at Mon, 16 May 2016 19:40:39 +0000
Bug 905223 - Part 1 Factor out external URL calculation. r=mfinkle For session data parsing, we need to know whether we were invoked with an external URL or not. Since we want to move session data parsing forward to an earlier point in time, but also continue needing that external URL info during initialize() as well, we'll factor out those calculations into their own functions which can then be called from both places. MozReview-Commit-ID: HFlT8uxC9yz
c24c2e2c3e4cf205c9c1088d0973aae7e2c6877b: Bug 905223 - Part 0 - Add target API annotations to get rid of errors in Android Studio. r=mfinkle draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 23 Apr 2016 22:29:03 +0200 - rev 367520
Push 18255 by mozilla@buttercookie.de at Mon, 16 May 2016 19:40:39 +0000
Bug 905223 - Part 0 - Add target API annotations to get rid of errors in Android Studio. r=mfinkle AS doesn't recognise our version guards and is consequentially always showing two errors in GeckoApp, which makes it more difficult to spot when you've introduced an actual error. MozReview-Commit-ID: LpNIwHOhEWE
77c63ad35ec1150400e5bf672043c97f161b9bdd: Bug 1261617 - Add UITelemetry for search counts. r=mfinkle draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 May 2016 17:23:48 -0700 - rev 366596
Push 18025 by michael.l.comella@gmail.com at Fri, 13 May 2016 00:07:27 +0000
Bug 1261617 - Add UITelemetry for search counts. r=mfinkle I largerly kept this patch the same as Finkle's initial revision except that I don't include the engine identifiers due to bug 1272166. MozReview-Commit-ID: 84672CDOOVX
e62b981d0cbe620420b0c6fb7af38a07be913afb: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 366361
Push 17962 by ttromey@mozilla.com at Thu, 12 May 2016 15:11:34 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle MozReview-Commit-ID: 9Et4AhCzAr9
7a5515c87deabfabd4a1af7ffc1804ed90294359: Bug 1261617 - Add UITelemetry for search counts. r=mfinkle draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 May 2016 17:23:48 -0700 - rev 366123
Push 17899 by michael.l.comella@gmail.com at Thu, 12 May 2016 00:27:17 +0000
Bug 1261617 - Add UITelemetry for search counts. r=mfinkle I largerly kept this patch the same as Finkle's initial revision except that I don't include the engine identifiers due to bug 1272166. MozReview-Commit-ID: 84672CDOOVX
5aed6f8b309c00ff8f63cef5b0434841ce62f282: Bug 1261617 - Add UITelemetry for search counts. r=mfinkle draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 11 May 2016 17:23:48 -0700 - rev 366122
Push 17898 by michael.l.comella@gmail.com at Thu, 12 May 2016 00:26:22 +0000
Bug 1261617 - Add UITelemetry for search counts. r=mfinkle MozReview-Commit-ID: 84672CDOOVX
80a7b17a5e3fb4c64574e1a21a4f9007c0538fed: Bug 1268104 - Consolidate telemetry logging in UITelemetry.js. r=mfinkle,gfritzsche draft
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 18:08:54 -0400 - rev 366018
Push 17887 by mleibovic@mozilla.com at Wed, 11 May 2016 22:09:24 +0000
Bug 1268104 - Consolidate telemetry logging in UITelemetry.js. r=mfinkle,gfritzsche MozReview-Commit-ID: Hn2vOMJCSOb
b901745bd6ae2b26690491be9cbe8020d85a2931: Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle draft
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 11 May 2016 11:40:49 -0400 - rev 365934
Push 17847 by mleibovic@mozilla.com at Wed, 11 May 2016 15:41:21 +0000
Bug 1267837 - Update grid item telemetry to indicate whether an item is pinned. r=mfinkle MozReview-Commit-ID: 9Et4AhCzAr9
52749e84bf25fb6aed91ab1339b74cc0e7aae5e7: Bug 1266163 - Replace FENNEC_READER_VIEW_BUTTON histogram with UI telemetry. r=mfinkle,barbara
Margaret Leibovic <margaret.leibovic@gmail.com> - Wed, 20 Apr 2016 15:22:46 -0400 - rev 364673
Push 17536 by mleibovic@mozilla.com at Sat, 07 May 2016 20:44:13 +0000
Bug 1266163 - Replace FENNEC_READER_VIEW_BUTTON histogram with UI telemetry. r=mfinkle,barbara MozReview-Commit-ID: 1guxvXp6loC
1f70bee0d12e24e17ad593a3735a93fa42f36a02: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 364456
Push 17464 by gszorc@mozilla.com at Fri, 06 May 2016 18:06:07 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
46461a324ccabd3404469ac116db690d73ef249d: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle draft
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 363978
Push 17354 by bmo:eitan@monotonous.org at Thu, 05 May 2016 22:51:09 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
123a7cac7ce9603ae051be855e4e6a48e6f4a41c: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 16:19:49 -0700 - rev 363467
Push 17210 by gijskruitbosch@gmail.com at Wed, 04 May 2016 19:35:29 +0000
Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle MozReview-Commit-ID: A24qXyNpWwk
7beb6f0c01a825be22d06f54d8fd276c9601f9fe: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle draft
Chenxia Liu <liuche@mozilla.com> - Tue, 03 May 2016 16:19:49 -0700 - rev 363440
Push 17199 by cliu@mozilla.com at Wed, 04 May 2016 17:54:13 +0000
Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle MozReview-Commit-ID: A24qXyNpWwk
cdec576dad5ec4b802db9f820b3baa0cd4585fe0: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 363174
Push 17124 by cykesiopka.bmo@gmail.com at Wed, 04 May 2016 04:32:33 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r=mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
1f51d38aa4997a2f3c1545dfe0950f209e6949f5: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r?mfinkle draft
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 363101
Push 17097 by bmo:eitan@monotonous.org at Tue, 03 May 2016 23:38:20 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r?mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
45d5529952654a4677993d85e67f5dd4024ee076: Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r?mfinkle draft
Eitan Isaacson <eitan@monotonous.org> - Mon, 02 May 2016 14:02:16 -0700 - rev 362648
Push 17005 by bmo:eitan@monotonous.org at Mon, 02 May 2016 21:09:58 +0000
Bug 1019425 - Activate accessibility when both accessibilty and explore by touch are enabled. r?mfinkle This simplifies some old code. We get rid of a whitelist of services, and rely on the face that accessibility and explore by touch is enabled to enter our internal accessibility mode. The whitelist methode held 2 assumptions that are not true anymore: 1. There are some non-accessibility accessibility service apps in the wild that read notifications. In later Android versions this has been made into a non-a11y use case with NotificationListenerService. So the cases of non-a11y accessibility services has shrunk. 2. Not all screen readers (Gingerbread TalkBack, for example) supported explore by touch. Today, we exclusively support accessibility services that use explore by touch, and we should not activate our accessibility mode in any other case. MozReview-Commit-ID: LMeCedoIGbb
0ee49a42aee51d7234cac1ee9d799393b3754d85: Bug 1260758 - Add distribution field to Fennec core ping. r=mfinkle, r=mkaply, a=lizzard
Michael Comella <michael.l.comella@gmail.com> - Wed, 13 Apr 2016 15:31:36 -0500 - rev 357574
Push 16807 by mleibovic@mozilla.com at Fri, 29 Apr 2016 00:55:34 +0000
Bug 1260758 - Add distribution field to Fennec core ping. r=mfinkle, r=mkaply, a=lizzard
111c29e1b1c35ede047c1b153683706de8ce2737: Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mfinkle draft
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 28 Apr 2016 15:27:35 -0700 - rev 357481
Push 16805 by gkruglov@mozilla.com at Fri, 29 Apr 2016 00:19:03 +0000
Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mfinkle MozReview-Commit-ID: IC3lmO8cUBa
53f45fc51b96d24e943d63afe52a45a4102ad482: Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mfinkle draft
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 28 Apr 2016 17:18:05 -0700 - rev 357480
Push 16805 by gkruglov@mozilla.com at Fri, 29 Apr 2016 00:19:03 +0000
Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mfinkle - specifying states, events and transition side-effects explicitely makes this code easier to read/maintain - move bunch of network state helper methods into NetworkUtils - ensure to update both network state (up/down/unknown), as well as connection type/subtype every time we need to update network state -- this should fix the buggy behaviour when we'd miss certain network state transitions - tests for the FSM transition matrix, and everything in the NetworkUtils MozReview-Commit-ID: LvrfHyFdkpB
8f66676687378b7337d15e4cb11ed0325bc18dc3: Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mfinkle draft
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 28 Apr 2016 15:27:35 -0700 - rev 357458
Push 16800 by gkruglov@mozilla.com at Thu, 28 Apr 2016 22:29:52 +0000
Bug 1236130 - Part 2: Only use cache for tabs when network state is "down" r=mfinkle MozReview-Commit-ID: IC3lmO8cUBa
06e7e8865bd2f946d2d48d6c5091d4ce05bdd17c: Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mfinkle draft
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 28 Apr 2016 15:26:53 -0700 - rev 357457
Push 16800 by gkruglov@mozilla.com at Thu, 28 Apr 2016 22:29:52 +0000
Bug 1236130 - Part 1: Use an explicit state machine to control GeckoNetworkManager r=mfinkle - specifying states, events and transition side-effects explicitely makes this code easier to read/maintain - move bunch of network state helper methods into NetworkUtils - ensure to update both network state (up/down/unknown), as well as connection type/subtype every time we need to update network state -- this should fix the buggy behaviour when we'd miss certain network state transitions - tests for the FSM transition matrix, and everything in the NetworkUtils MozReview-Commit-ID: LvrfHyFdkpB
fd0c48012a8c4ef60c045623ae229da4c59daed2: Bug 1259127 - Content notifications: Add "Read now" action. r?grisha,mfinkle draft
Sebastian Kaspari <s.kaspari@gmail.com> - Tue, 26 Apr 2016 14:42:51 +0200 - rev 357408
Push 16765 by s.kaspari@gmail.com at Thu, 28 Apr 2016 15:58:16 +0000
Bug 1259127 - Content notifications: Add "Read now" action. r?grisha,mfinkle This patch adds a "Read now" action to content notifications. Clicking the button will behave like clicking the notification. However it will send a different telemetry extra ("content_update_read_now" instead of "content_update"). MozReview-Commit-ID: 4O24xBhjVF4
ee66f2755acfb968f2906d3fb9ac2184b79f999e: Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Apr 2016 17:51:57 +0200 - rev 357260
Push 16745 by ahunt@mozilla.com at Thu, 28 Apr 2016 11:26:07 +0000
Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle r=sebastian The number of recent successive crashes is now tracked wholly within Java, so we can remove the old Gecko pref and the associated reset code. MozReview-Commit-ID: 7bR9wqJsLoi
ec981b82951f17c3cae8e48f5f7ad7d87049de90: Bug 1263110 - Part 2 - Implement crash loop detection in Java. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 19 Apr 2016 13:51:06 +0200 - rev 357259
Push 16745 by ahunt@mozilla.com at Thu, 28 Apr 2016 11:26:07 +0000
Bug 1263110 - Part 2 - Implement crash loop detection in Java. r=mfinkle r=sebastian Bug 701092 originally implemented some functionality to detect successive crashes and then turn off session restore for the next start, however that functionality got lost when parts of the startup session restore code were moved to Java. This patch re-implements this functionality within the Java UI. Unlike the previous implementation, we don't reset the crash counter in onPause(), because often enough onPause() will execute even after a crash. Instead, we check in onResume() whether our last foreground activity cycle crashed or not. To avoid cross-process writes and reads to shared preferences, the crash reporter no longer sets the relevant flags in GeckoApp's shared prefs directly, but instead writes an empty CRASHED file to the Mozilla directory as a flag, which is then checked for by the main process during startup. Alternative solutions considered were: - Using Context.MODE_MULTI_PROCESS for accessing the shared prefs. Works, but forces the shared preferences to always be re-read from storage and is also deprecated from API 23 onwards. - Using a ContentProvider for managing the cross-process shared prefs as suggested in Google's documentation. Seems somewhat over-engineered for this use case. - Sending a broadcast from the crash reporter to signal the main process, so it can update the relevant shared prefs from the correct process. Doesn't work reliably immediately after crashing - sometimes the broadcast never arrives. - Setting the crash flags directly in the crash handling functions in GeckoAppShell. Could work even when not building the crash reporter, however doesn't work easily for native crashes, because those are handled internally by Gecko without going through the Java crash handling code. MozReview-Commit-ID: 6g7AmnJhoQk
b7d44db6027d6f6e8f3dcac1b0307c24c48164cb: Bug 1263110 - Part 1 - Move crash reporter settings into their own shared pref. r=mfinkle r=sebastian
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 18 Apr 2016 18:56:28 +0200 - rev 357258
Push 16745 by ahunt@mozilla.com at Thu, 28 Apr 2016 11:26:07 +0000
Bug 1263110 - Part 1 - Move crash reporter settings into their own shared pref. r=mfinkle r=sebastian The crash reporter runs in its own process but uses GeckoApp's shared prefs both to store its own settings and to signal to the main process that it has crashed, which can be somewhat problematic because each process might fail to notice settings changes made by the other process. As the simple solution of enabling Context.MODE_MULTI_PROCESS for accessing the shared prefs is now deprecated, we'll devise an alternative solution instead. In Part 1 we move the settings that are used exclusively by the crash reporter into a separate shared prefs instance. MozReview-Commit-ID: 1QWBAL2Xcn2
a39c8987e95a9bc690302327c1cfb7dd3144ddfc: Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle,sebastian draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 09 Apr 2016 17:51:57 +0200 - rev 356906
Push 16637 by mozilla@buttercookie.de at Wed, 27 Apr 2016 13:50:52 +0000
Bug 1263110 - Part 3 - Remove the remains of the old crash loop detection. r=mfinkle,sebastian The number of recent successive crashes is now tracked wholly within Java, so we can remove the old Gecko pref and the associated reset code. MozReview-Commit-ID: 7bR9wqJsLoi