searching for reviewer(mcomella)
e7f6528b3a3e532531735365c63d662970c578b2: Bug 1450447 - Start using notification channels. r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 06 Jul 2018 13:51:06 +0300 - rev 814984
Push 115394 by plingurar@mozilla.com at Fri, 06 Jul 2018 14:06:51 +0000
Bug 1450447 - Start using notification channels. r?mcomella Made all the notifications within the app to use notification channel for devices with API26 and higher. Removed conditionallyNotifyEOL() from BrowserApp.java as that method isn't used anymore. Also removed the strings used in this method. MozReview-Commit-ID: CVmpitNsS66
6a892dedd32d3707a3b7543f3623f6990e9c1cf2: Bug 1450447 - Start using notification channels. r?mcomella draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 29 Jun 2018 16:50:17 +0300 - rev 812475
Push 114565 by bmo:andrei.a.lazar@softvision.ro at Fri, 29 Jun 2018 13:50:54 +0000
Bug 1450447 - Start using notification channels. r?mcomella Made all the notifications within the app to use notification channel for devices with API26 and higher. MozReview-Commit-ID: CVmpitNsS66
9b93e0e2bb93a13eda0422650c694e66921430f3: Bug 1450447 - Start using notification channels. r?mcomella draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 29 Jun 2018 16:33:21 +0300 - rev 812473
Push 114563 by bmo:andrei.a.lazar@softvision.ro at Fri, 29 Jun 2018 13:36:29 +0000
Bug 1450447 - Start using notification channels. r?mcomella Made all the notifications within the app to use notification channel for devices with API26 and higher. MozReview-Commit-ID: CVmpitNsS66
41e0ce725a3b540d6a991eaec5ee101d05baf790: Bug 1457078 - Package default theme icon on Android. r=mcomella, a=RyanVM
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 22:33:25 +0100 - rev 806215
Push 112844 by maglione.k@gmail.com at Fri, 08 Jun 2018 22:18:59 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella, a=RyanVM MozReview-Commit-ID: 5ewrG6aszUj
55923d75814212a1e137e17fe90962bdc5bfcd99: Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella, a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 24 May 2018 14:09:22 +0300 - rev 806152
Push 112844 by maglione.k@gmail.com at Fri, 08 Jun 2018 22:18:59 +0000
Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella, a=RyanVM Bug details: The problem stemmed from the now called GeckoPreferences.trySwitchToHeader(int id) which could be called with an invalid id, constant with the same value as the id of the last available setting. (GeckoPreferenceFragment().getHeader() would return valid ids only for preference screens that are launched directly. Otherwise it would return: -1) By chance the id for the last available setting - vendor was not set and so Android saw it with an invalid header id: -1. GeckoPreferences.trySwitchToHeader(int id) would just switch to showing the vendor setting because that is what he has been instructed to whenever the user tried to access other settings than the ones which can be launched directly. Cleaned the code a bit: - renamed GeckoPreferences.switchToHeader(..) to trySwitchToHeader(..) as it won't always perform that action - removed the call to activity.showBreadCrumbs(..) as in my tests it didn't have any effect and the documentation says "This will normally be called for you". Tested on An Android 8 tablet, on an Android 8 phone, on an Android 5.0.1 phone and all works ok. MozReview-Commit-ID: 2sbfcuRHgZd
3607d8d3561b254246d7a9f7298ee3fafd89c28f: Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella, a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 May 2018 13:03:44 +0300 - rev 806151
Push 112844 by maglione.k@gmail.com at Fri, 08 Jun 2018 22:18:59 +0000
Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella, a=RyanVM The ActionBar's title will always be updated with the title of the visiting PreferenceScreen. MozReview-Commit-ID: b5MyrSaWFC
b75e6bb295a948cda358d42f96a0b8c95db8655d: Bug 1459420 - HLS Player doesn't use the centralized Proxy Selector r=mcomella
Igor Oliveira <igt0@torproject.org> - Mon, 04 Jun 2018 05:15:00 +0300 - rev 804540
Push 112407 by bmo:ntim.bugs@gmail.com at Wed, 06 Jun 2018 09:28:54 +0000
Bug 1459420 - HLS Player doesn't use the centralized Proxy Selector r=mcomella GeckoHlsPlayer uses the default http ExoPlayer handler, called DefaultHttpDataSource. It uses URL::openConnection instead of the Firefox ProxySelector. This patch updates the ExoPlayer DefaultHttpDataSource to use the ProxySelector.
df3e0250b27571e8bbb8d36a19ecf19d9650dc61: Bug 1457078 - Package default theme icon on Android. r=mcomella
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 22:33:25 +0100 - rev 804121
Push 112312 by bmo:standard8@mozilla.com at Tue, 05 Jun 2018 16:07:56 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: 5ewrG6aszUj
fc040acc00af17b8d8101090739867461f4d843b: Bug 1457078 - Package default theme icon on Android. r=mcomella
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 21:37:54 +0100 - rev 804118
Push 112312 by bmo:standard8@mozilla.com at Tue, 05 Jun 2018 16:07:56 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: I2ojxjgMzk1
658e4bfa162061b5f85dfc654d22d30d840905d7: Bug 1457078 - Package default theme icon on Android. r=mcomella draft
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 22:33:25 +0100 - rev 803828
Push 112201 by bmo:ntim.bugs@gmail.com at Mon, 04 Jun 2018 21:34:23 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: 5ewrG6aszUj
3a9bc9de6b2417f576699a447771fbf768430184: Bug 1457078 - Package default theme icon on Android. r=mcomella draft
Tim Nguyen <ntim.bugs@gmail.com> - Mon, 04 Jun 2018 21:37:54 +0100 - rev 803790
Push 112185 by bmo:ntim.bugs@gmail.com at Mon, 04 Jun 2018 20:38:38 +0000
Bug 1457078 - Package default theme icon on Android. r=mcomella MozReview-Commit-ID: I2ojxjgMzk1
276a007b27f2892d39152efa194832b0f95907b4: Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 24 May 2018 14:09:22 +0300 - rev 800232
Push 111299 by dgottwald@mozilla.com at Sat, 26 May 2018 10:53:05 +0000
Bug 1462594 - Allow accessing all Settings menus on tablets; r=mcomella Bug details: The problem stemmed from the now called GeckoPreferences.trySwitchToHeader(int id) which could be called with an invalid id, constant with the same value as the id of the last available setting. (GeckoPreferenceFragment().getHeader() would return valid ids only for preference screens that are launched directly. Otherwise it would return: -1) By chance the id for the last available setting - vendor was not set and so Android saw it with an invalid header id: -1. GeckoPreferences.trySwitchToHeader(int id) would just switch to showing the vendor setting because that is what he has been instructed to whenever the user tried to access other settings than the ones which can be launched directly. Cleaned the code a bit: - renamed GeckoPreferences.switchToHeader(..) to trySwitchToHeader(..) as it won't always perform that action - removed the call to activity.showBreadCrumbs(..) as in my tests it didn't have any effect and the documentation says "This will normally be called for you". Tested on An Android 8 tablet, on an Android 8 phone, on an Android 5.0.1 phone and all works ok. MozReview-Commit-ID: 2sbfcuRHgZd
a25b2c7238f46770d612f2a2cb2f8731e31261ee: Bug 1459089 - Don't use OS Locale when resistFingerprinting is enabled. When the OS Locale is used, it leaks the OS language in the HTTP Accept-Language header. r=mcomella
Igor Oliveira <igt0@torproject.org> - Thu, 03 May 2018 18:28:00 +0300 - rev 798602
Push 110803 by bmo:gl@mozilla.com at Wed, 23 May 2018 06:00:40 +0000
Bug 1459089 - Don't use OS Locale when resistFingerprinting is enabled. When the OS Locale is used, it leaks the OS language in the HTTP Accept-Language header. r=mcomella
3f3064a1dfed148a1f80ddb6c3c2c07a9400ec9d: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 01:05:47 -0400 - rev 798049
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Made QR string consistent with respect to other url related strings MozReview-Commit-ID: 432jaONccer
6afab2248a4deb2e00e5d5fa2bb280d954566809: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 00:52:41 -0400 - rev 798048
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Added localization notes and more verbose strings for non-visual users. MozReview-Commit-ID: FiOcDJrgRIy
291f380e8167d4245c3e24fe6375968e02fb635e: Bug 1411198 - Unlabeled voice input button. r=mcomella
s37syed <shah@shahsyed.me> - Mon, 14 May 2018 21:35:34 -0400 - rev 798047
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Added contentDescription strings for QR Code and Voice Input MozReview-Commit-ID: 6tpoewhPxev
de4e1b2221d7f35bd5c3fa1ea8134451f0d7a38f: Bug 1454686 - Remove Lint error suppression for unused strings; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:59:56 +0300 - rev 798043
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1454686 - Remove Lint error suppression for unused strings; r=mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: IhtTS8rHLwz
d21bb52a99dce11eddb59a480275a75edd5277d7: Bug 1454686 - Respond to changes in the new preference state state; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:54:13 +0300 - rev 798042
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1454686 - Respond to changes in the new preference state state; r=mcomella Because Mma cannot work if Health Report is disabled by the user (Settings - Privacy) we will treat toggling Health Report on/off the same as we treat toggling the new preference from Settings - Notifications. Toggling Health Report on will inform about the need to start LeanPlum (useful if the user did not explicitly stopped LP notifications but only Health Report which in turn disabled LeanPlum also) but there are other checks made afterwards (BrowserAp() is informed about this which calls GeckoPreferences.isMmaAvailable(..)) to decide if LP can and should be enabled. Toggling any of these preferences will trigger an event caught by BrowserApp which can either - immediately initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) MozReview-Commit-ID: 1SmhN0NucWW ***
c6586abb677359e0a876a6d26d897af84149c67b: Bug 1454686 - Small refactoring of Mma related methods; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:55:38 +0300 - rev 798041
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1454686 - Small refactoring of Mma related methods; r=mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering if Mma is available are checked - GeckoPreferences.isMmaAvailableAndEnabled() Added only one place from where the availability of the LP experiments should be checked as that currently involves two checks - MmaDelegate.isMmaExperimentEnabled(..) Also renamed isMmaEnabled() from MmaDelegate() and initSwitchboard from BrowserApp() to better express what those methods do. MozReview-Commit-ID: BCJqM9b5JbW ***
84312c7af401068076933a2928043be3167571ee: Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:45:01 +0300 - rev 798040
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r=mcomella According to current LP documentation there are no SDK APIs to allow users to fully stop LP: events reporting and message displaying there. After extensive testing and investigations I think I found the least intrusive way to offer that. We will use internal methods but which are public so I hope they will be supported in the future also. Nevertheless we will need to maintain this in regards to future SDK updates. MozReview-Commit-ID: Ke3HGAyCqVA ***
a371b3bb0cd60bbd82374a32bc8749230209ac6c: Bug 1454686 - Add a new preference under Settings - Notifications; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 798039
Push 110660 by dgottwald@mozilla.com at Tue, 22 May 2018 10:22:26 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r=mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
519ed4003be448d60e719c13c40dfcb1adbb30c7: Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:59:56 +0300 - rev 796364
Push 110233 by plingurar@mozilla.com at Thu, 17 May 2018 16:13:02 +0000
Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: IhtTS8rHLwz
931172a14560c053eb2d36743d90da6decc28912: Bug 1454686 - Respond to changes in the new preference state state; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:54:13 +0300 - rev 796363
Push 110233 by plingurar@mozilla.com at Thu, 17 May 2018 16:13:02 +0000
Bug 1454686 - Respond to changes in the new preference state state; r?mcomella Because Mma cannot work if Health Report is disabled by the user (Settings - Privacy) we will treat toggling Health Report on/off the same as we treat toggling the new preference from Settings - Notifications. Toggling Health Report on will inform about the need to start LeanPlum (useful if the user did not explicitly stopped LP notifications but only Health Report which in turn disabled LeanPlum also) but there are other checks made afterwards (BrowserAp() is informed about this which calls GeckoPreferences.isMmaAvailable(..)) to decide if LP can and should be enabled. Toggling any of these preferences will trigger an event caught by BrowserApp which can either - immediately initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) MozReview-Commit-ID: 1SmhN0NucWW ***
636c57538894de8191c23f305c33daf7a0cf7d5b: Bug 1454686 - Small refactoring of Mma related methods; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:55:38 +0300 - rev 796362
Push 110233 by plingurar@mozilla.com at Thu, 17 May 2018 16:13:02 +0000
Bug 1454686 - Small refactoring of Mma related methods; r?mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering if Mma is available are checked - GeckoPreferences.isMmaAvailableAndEnabled() Added only one place from where the availability of the LP experiments should be checked as that currently involves two checks - MmaDelegate.isMmaExperimentEnabled(..) Also renamed isMmaEnabled() from MmaDelegate() and initSwitchboard from BrowserApp() to better express what those methods do. MozReview-Commit-ID: BCJqM9b5JbW ***
4387d5e3e55cb85be5aac735ceabb80f7aedc7cf: Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 17 May 2018 18:45:01 +0300 - rev 796361
Push 110233 by plingurar@mozilla.com at Thu, 17 May 2018 16:13:02 +0000
Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella According to current LP documentation there are no SDK APIs to allow users to fully stop LP: events reporting and message displaying there. After extensive testing and investigations I think I found the least intrusive way to offer that. We will use internal methods but which are public so I hope they will be supported in the future also. Nevertheless we will need to maintain this in regards to future SDK updates. MozReview-Commit-ID: Ke3HGAyCqVA ***
a5e61e421ead96184b64af53d70a2ade90e5991d: Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 796360
Push 110233 by plingurar@mozilla.com at Thu, 17 May 2018 16:13:02 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
e5ecf6627dfd203a2d6e3f764811fb132fe2126a: Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 15 May 2018 13:03:44 +0300 - rev 796266
Push 110198 by bmo:rcaliman@mozilla.com at Thu, 17 May 2018 12:04:52 +0000
Bug 1434603 - Settings Header not changed when visiting sub-menus on Oreo; r=mcomella The ActionBar's title will always be updated with the title of the visiting PreferenceScreen. MozReview-Commit-ID: b5MyrSaWFC
0271d03ce8a35263bd87c9fd02e93b8fd195d431: Bug 1411198 - Unlabeled voice input button. r=mcomella draft
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 01:05:47 -0400 - rev 796182
Push 110172 by bmo:shah@shahsyed.me at Thu, 17 May 2018 05:06:23 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Made QR string consistent with respect to other url related strings MozReview-Commit-ID: 432jaONccer
b012c7ba7643ca8b3d5eb31705dcc7a51d993e85: Bug 1411198 - Unlabeled voice input button. r=mcomella draft
s37syed <shah@shahsyed.me> - Thu, 17 May 2018 00:52:41 -0400 - rev 796179
Push 110170 by bmo:shah@shahsyed.me at Thu, 17 May 2018 04:56:21 +0000
Bug 1411198 - Unlabeled voice input button. r=mcomella Added localization notes and more verbose strings for non-visual users. MozReview-Commit-ID: FiOcDJrgRIy
0a130e211be31ab51e5be3bcef14c5a595b697ae: Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:59:56 +0300 - rev 795678
Push 110049 by plingurar@mozilla.com at Wed, 16 May 2018 13:00:32 +0000
Bug 1454686 - Remove Lint error suppression for unused strings; r?mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: IhtTS8rHLwz
1e827fb6d0582d25614c46565241a505a9912c9e: Bug 1454686 - Respond to changes in the new preference state state; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:54:13 +0300 - rev 795676
Push 110047 by plingurar@mozilla.com at Wed, 16 May 2018 12:57:34 +0000
Bug 1454686 - Respond to changes in the new preference state state; r?mcomella Because Mma cannot work if Health Report is disabled by the user (Settings - Privacy) we will treat toggling Health Report on/off the same as we treat toggling the new preference from Settings - Notifications. Toggling Health Report on will inform about the need to start LeanPlum (useful if the user did not explicitly stopped LP notifications but only Health Report which in turn disabled LeanPlum also) but there are other checks made afterwards (BrowserAp() is informed about this which calls GeckoPreferences.isMmaAvailable(..)) to decide if LP can and should be enabled. Toggling any of these preferences will trigger an event caught by BrowserApp which can either - immediately initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) MozReview-Commit-ID: 1SmhN0NucWW ***
166543755637c0021690e107eb72f278ce00b9c4: Bug 1454686 - Small refactoring of Mma related methods; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 15:13:35 +0300 - rev 795670
Push 110042 by plingurar@mozilla.com at Wed, 16 May 2018 12:15:52 +0000
Bug 1454686 - Small refactoring of Mma related methods; r?mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering MmaIsAvailable are checked. Added only one place from where the availability of the LP experiments should be checked as that currently involves two checks. Also renamed isMmaEnabled() from MmaDelagate() and initSwitchboard from BrowserApp() to better express what those methods do. MozReview-Commit-ID: BCJqM9b5JbW ***
1cf4bce6e7e6580f82ac4f052e964560b57687e5: Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 13:22:43 +0300 - rev 795669
Push 110042 by plingurar@mozilla.com at Wed, 16 May 2018 12:15:52 +0000
Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella According to current LP documentation there are no SDK APIs to allow users to fully stop LP: events reporting and message displaying there. After extensive testing and investigations I think I found the least intrusive way to offer that. We will use internal methods but which are public so I hope they will be supported in the future also. Nevertheless we will need to maintain this in regards to future SDK updates. MozReview-Commit-ID: Ke3HGAyCqVA ***
7e64db8d502c58c3109ed631fd76f82cf38edde4: Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 795668
Push 110042 by plingurar@mozilla.com at Wed, 16 May 2018 12:15:52 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
82acea5e590fc6ce2a4eb520ee9d29396fd991f3: Bug 1454686 - Part 3 - Small refactoring regarding Mma methods; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 14:00:49 +0300 - rev 795604
Push 110037 by plingurar@mozilla.com at Wed, 16 May 2018 11:07:51 +0000
Bug 1454686 - Part 3 - Small refactoring regarding Mma methods; r?mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering MmaIsAvailable are checked. Added only one place from where the availability of the LP experiments should be checked as that currently involves two checks. Also renamed isMmaEnabled() from MmaDelagate() and initSwitchboard from BrowserApp() to better express what those methods do. MozReview-Commit-ID: BCJqM9b5JbW ***
63ed218ff701dc0743786b58879221faa9478e36: Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 13:22:43 +0300 - rev 795601
Push 110034 by plingurar@mozilla.com at Wed, 16 May 2018 10:25:00 +0000
Bug 1454686 - MmaLeanPlumImp().stop() will now stop LP, stop showing messages and allow restart in same app session; r?mcomella According to current LP documentation there are no SDK APIs to allow users to fully stop LP: events reporting and message displaying there. After extensive testing and investigations I think I found the least intrusive way to offer that. We will use internal methods but which are public so I hope they will be supported in the future also. Nevertheless we will need to maintain this in regards to future SDK updates. MozReview-Commit-ID: Ke3HGAyCqVA ***
440b35d1e9474c43bc03eb449378ce79da0ba5e2: Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 795600
Push 110034 by plingurar@mozilla.com at Wed, 16 May 2018 10:25:00 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
8983c8f783afa7ecda5036d54c70da3b2aa98b81: Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 16 May 2018 11:49:35 +0300 - rev 795598
Push 110032 by plingurar@mozilla.com at Wed, 16 May 2018 09:46:02 +0000
Bug 1454686 - Add a new preference under Settings - Notifications; r?mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
ebcbcffb286fb946bd5d5dc82be5e086a14d3616: Bug 1318046 - Allow inputting years for "date" and "datetime" html input types; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 04 May 2018 15:03:03 +0300 - rev 792444
Push 109110 by kgupta@mozilla.com at Tue, 08 May 2018 12:47:39 +0000
Bug 1318046 - Allow inputting years for "date" and "datetime" html input types; r=mcomella For "date" I switched to using platform's DatePicker in place of our custom DateTimePicker, change that will also ensure future feature compatibility. For "datetime" and "datetime-local" I've kept using our DateTimePicker but which will now offer spinners for selecting all fields. MozReview-Commit-ID: 2oOORFH6OJ6
d1f8638fcf2bd16c12faaa6500e0c80a64e4c07b: Bug 1459632 - Update Notifications settings summary; r=mcomella
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 18:11:48 +0300 - rev 792443
Push 109110 by kgupta@mozilla.com at Tue, 08 May 2018 12:47:39 +0000
Bug 1459632 - Update Notifications settings summary; r=mcomella MozReview-Commit-ID: 4CqGnyx9qt1
2f47728728a657f094dfc0ae418e3bb453cd19e4: Bug 1454686 - Part 1 - Add a new preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 08 May 2018 12:18:44 +0300 - rev 792373
Push 109094 by plingurar@mozilla.com at Tue, 08 May 2018 09:20:24 +0000
Bug 1454686 - Part 1 - Add a new preference under Settings - Notifications; r?mcomella The behavior of this new preference is dynamic in that: - it will be hidden if LeanPlum is not available for the device - it will be toggled off and disabled if Health Report is disabled by the user MozReview-Commit-ID: 1x9zZukyygr ***
e96739c74544127a73627ec5d9e3907e3e75445b: Bug 1454686 - Part 1 - Add a preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 16:16:29 +0300 - rev 792364
Push 109092 by plingurar@mozilla.com at Tue, 08 May 2018 09:05:25 +0000
Bug 1454686 - Part 1 - Add a preference under Settings - Notifications; r?mcomella MozReview-Commit-ID: 1x9zZukyygr
ed84fd5ca68d3a2dbbd60dd0b2e228e4981ec798: Bug 1454686 - Part 5 - Remove Lint error suppression for unused strings; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 17:42:28 +0300 - rev 792050
Push 108972 by plingurar@mozilla.com at Mon, 07 May 2018 14:43:11 +0000
Bug 1454686 - Part 5 - Remove Lint error suppression for unused strings; r?mcomella Strings needed for this feature were added in a separate bug - 1445798 which were causing Lint errors. When this feature will land there will be no need for the suppression. MozReview-Commit-ID: cUuIQQMhhk
345e23fa6c0700aa7130cd45479b9f519535b5b5: Bug 1454686 - Part 4 - Respond to changes in the new preference state state; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 17:25:16 +0300 - rev 792044
Push 108968 by plingurar@mozilla.com at Mon, 07 May 2018 14:25:58 +0000
Bug 1454686 - Part 4 - Respond to changes in the new preference state state; r?mcomella Because Mma cannot work if Health Report is disabled by the user (Settings - Privacy) we will treat toggling Health Report on/off the same as we treat toggling the new preference from Settings - Notifications. Toggling Health Report on will inform about the need to start LeanPlum (useful if the user did not explicitly stopped LP notifications but only Health Report which in turn disabled LeanPlum also) but there are other checks made afterwards to decide if LP can and should be enabled. Toggling any of these preferences will trigger an event caught by BrowserApp which can either - immediately initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) MozReview-Commit-ID: 1SmhN0NucWW
fba2858f87f560295ec1b0434156c38d463ebbba: Bug 1454686 - Part 3 - Small refactoring: extract isMmaEnabled and renamed initSwitchboard; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 16:44:35 +0300 - rev 792038
Push 108963 by plingurar@mozilla.com at Mon, 07 May 2018 13:45:42 +0000
Bug 1454686 - Part 3 - Small refactoring: extract isMmaEnabled and renamed initSwitchboard; r?mcomella With the adding of the new preference that Mma depends on we need to have only one place where all the conditions for considering MmaIsAvailable are checked. Also renamed initSwitchboard from BrowserApp() to better express that this method is also responsible for starting Mma - Leanplum. MozReview-Commit-ID: BCJqM9b5JbW
bfed4f78b18906ad12f1b7180808f71a70d08db1: Bug 1454686 - Part 1 - Add a preference under Settings - Notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 07 May 2018 16:16:29 +0300 - rev 792034
Push 108959 by plingurar@mozilla.com at Mon, 07 May 2018 13:18:37 +0000
Bug 1454686 - Part 1 - Add a preference under Settings - Notifications; r?mcomella MozReview-Commit-ID: 1x9zZukyygr
bd60840b26cb0b47d40af1a7ec1c7a6f83482b68: Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r=mcomella
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 04 May 2018 16:10:17 +0300 - rev 791783
Push 108899 by bmo:emilio@crisal.io at Sat, 05 May 2018 11:07:57 +0000
Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r=mcomella On Android 7.0.0, the OS would start the StumblerService and without having given fennec the location permission the intent and scan enabled checks would've been skipped - which ensure that the Stumbler Service does not run in unadequate scenarios. MozReview-Commit-ID: AGU67ytE4ff
982391c87ea54a34789e8baccdd3532cd696d5cf: Bug 1453691 - create a Fennec system addon to spoof the UA string as Chrome for Google Search and Facebook. r?rhelmer, r?mcomella draft
Thomas Wisniewski <wisniewskit@gmail.com> - Wed, 25 Apr 2018 20:23:45 -0400 - rev 791713
Push 108882 by wisniewskit@gmail.com at Fri, 04 May 2018 23:07:16 +0000
Bug 1453691 - create a Fennec system addon to spoof the UA string as Chrome for Google Search and Facebook. r?rhelmer, r?mcomella mcomella, could you please take a look at the extension code here to see if it passes muster? It's basically just overriding the Fennec UA string to a Chrome one for Google Search and Facebook specifically. It uses a tablet or phone UA string according to the device being used. It also generates a UA string based on the Firefox version number plus four, and adds in a hint that it's actually Firefox, not Chrome. rhelmer, could you please take a look at the non-extension-specific code here and let me know if it looks reasonable? I basically pulled in code removed in FlyWeb-removal bug 1374574 to re-enable built in Fennec system addons, and added the necessary code from bug 1440789 to ensure the list of built_in_addons.json is actually generated on Fennec so the addon is loaded. MozReview-Commit-ID: FFwhvvAqffs
4c6ac48ef6a1f2a66a4c665a792344ebc30667d4: Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r?mcomella draft
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 04 May 2018 16:10:17 +0300 - rev 791445
Push 108816 by vbaicu@mozilla.com at Fri, 04 May 2018 13:11:19 +0000
Bug 1425669 - Move StumblerService location permission check after the intent&scan enabled checks. r?mcomella On Android 7.0.0, the OS would start the StumblerService and without having given fennec the location permission the intent and scan enabled checks would've been skipped - which ensure that the Stumbler Service does not run in unadequate scenarios. MozReview-Commit-ID: AGU67ytE4ff
746102cdbd656ad4ea057640074b9a83dec561bf: Bug 1454686 - Allow users to stop and start LeanPlum and it's notifications; r?mcomella draft
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 03 May 2018 13:40:34 +0300 - rev 791060
Push 108673 by plingurar@mozilla.com at Thu, 03 May 2018 10:44:41 +0000
Bug 1454686 - Allow users to stop and start LeanPlum and it's notifications; r?mcomella Added a new SwitchPreference in the Notifications Settings screen that uses the Strings from bug #1445798 That new toggle will only be displayed if LeanPlum is available. Behaviour handled in GeckoPreferences. When the user toggles the feature an event is triggered and catched by BrowserApp which can either - initialize LeanPlum (if the toggle was off LP is not running) as it would normally do when the app first starts - stop LeanPlum reporting to servers, flush the per-session available messages and resets the LP started status so that it can be restarted in the same app session (like if the user toggles the feature again) Renamed stop() from MmaDelegate.java to make it clear that that method only stops tracking events to the server (method only called before when user disabled Health Report) but the already downloaded messages continue to be triggered and added 2 new appropriately named methods MmaDelegate.haveMessagesToDisplay() and MmaDelegate.stopShowingSessionMessages() to allow checking if the there have been messages downloaded for this session and to allow flushing them to avoid displaying them being displayed in the current session when the initially set conditions are met. When the app starts it now also check for the status of this notification setting and doesn't start LeanPlum if LP notifications are off as that has the potential to skew the data because the user doesn't get tipped anymore about the cool features we offer. Modified the description for Settings-Notification as Andreas suggested, removed the lint suppression for unused strings added in bug 1445798. MozReview-Commit-ID: HQuyZ5owLhW ***