searching for reviewer(masayuki)
ae7dc05bee296f01c98e9b6d166ab308ea286690: Bug 1484118 - Remove the XPCOM component registration for nsTransactionManager; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 23 Aug 2018 09:36:59 -0400 - rev 831065
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1484118 - Remove the XPCOM component registration for nsTransactionManager; r=masayuki
971943621f6e52daa0e94e48c3d846567978ff26: Bug 1484371 - make *enter/*leave events uncomposed, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 22 Aug 2018 16:08:17 +0300 - rev 830802
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1484371 - make *enter/*leave events uncomposed, r=masayuki
1ddc33b770571cc057246bcfabe0fb5d3d732145: Bug 1476914 - Add fuzzy-if on Bug 1443902's reftests for Android. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 21 Aug 2018 09:29:29 +0000 - rev 830729
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1476914 - Add fuzzy-if on Bug 1443902's reftests for Android. r=masayuki Android's reftest of Bug 1443902 is failed rarely (Bug 1476914, Bug 1475049 Bug 1477502 and Bug 1476129) due to "image comparison, max difference: 1, number of differing pixels: 1". But I don't know why difference is 1 and I think that this might be reftest framework for Android or Android emulator issue. So I would like to add fuzzy-if as workaround. Differential Revision: https://phabricator.services.mozilla.com/D3859
798a3e869e24ed01213be05e536c46b73fc9904f: Bug 1484602 - Don't reuse variables in WillDeleteSelection. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 21 Aug 2018 06:54:47 +0000 - rev 830502
Push 118839 by mixedpuppy@gmail.com at Tue, 21 Aug 2018 18:59:46 +0000
Bug 1484602 - Don't reuse variables in WillDeleteSelection. r=masayuki HTMLEditRules::WillDeleteSelection is complex since some variables is reused. So I would like to clean up this to use block scope and EditorDOMPoint before fixing bug 685799. Differential Revision: https://phabricator.services.mozilla.com/D3761
9576c19562ae2a1cd9a623dddea8e66428c477f9: Bug 1484612 - Remove EditSubActionInfo.bOrdered due to unused. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 20 Aug 2018 12:23:56 +0000 - rev 830468
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484612 - Remove EditSubActionInfo.bOrdered due to unused. r=masayuki RemoveList doesn't use aListType parameter, but c-c still call this method. So I keep aListType parameter even if unused. Differential Revision: https://phabricator.services.mozilla.com/D3762
7de9496d9640c757f486c8fe80e0679ed78d3cf2: Bug 1483434 - Allow nullptr parameter for PriorVisibleNode and NextVisibleNode. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 14 Aug 2018 18:26:46 +0900 - rev 829627
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483434 - Allow nullptr parameter for PriorVisibleNode and NextVisibleNode. r=masayuki Summary: Sometimes the caller of PriorVisibleNode or NextVisibleNode doesn't use outVisNode and/or outvisOffset. But both methods require all parameters and it don't allow nullptr. It is complex whether parameter is used or unused. So I would like to allow nullptr. Also, this methods can change to const method, so I will change some methods to const method too for this change. Reviewers: masayuki Tags: #secure-revision Bug #: 1483434 Differential Revision: https://phabricator.services.mozilla.com/D3387
147cb3ed71f8dc1f24653b4486cecc54c52ad5a1: Bug 1464251 - SplitNodeDeepWithTransaction might create orphan node. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 09 Aug 2018 08:22:50 +0000 - rev 828704
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1464251 - SplitNodeDeepWithTransaction might create orphan node. r=masayuki SplitStyleAbovePoint calls SplitNodeDeepWithTransaction repeatedly. If SplitNodeDeepWithTransaction creates orphan node like this test case, this crash occurs. So we should check whether node becomes orphan node. Differential Revision: https://phabricator.services.mozilla.com/D1993
8d41c10d3162c06f504490d4ea615e5889b0c73a: Bug 1478604 - Fix RepaintSelectionRunner so that it does something for non-presShell impls. r=masayuki
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 07 Aug 2018 12:55:21 +0000 - rev 827358
Push 118523 by bmo:alwu@mozilla.com at Tue, 07 Aug 2018 22:38:39 +0000
Bug 1478604 - Fix RepaintSelectionRunner so that it does something for non-presShell impls. r=masayuki The regressing bug made RepaintSelectionRunner do nothing for any nsISelectionListener that wasn't a PresShell. Differential Revision: https://phabricator.services.mozilla.com/D2846
e771995f99a7eb1ed1b3fd9316a0ec494511c245: Bug 1480699 - Use IPDL's promise instead in PRemoteSpellcheckEngine. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 31 Jul 2018 16:36:43 +0900 - rev 826950
Push 118420 by bschouten@mozilla.com at Mon, 06 Aug 2018 14:19:46 +0000
Bug 1480699 - Use IPDL's promise instead in PRemoteSpellcheckEngine. r=masayuki Summary: When implementing async call for PRemoteSpellcheckEngine, IPDL doesn't support Promise. But now, IPDL supports it, so I should convert to it to avoid unexpected leak. And SetDictionary supports empty string as parameter to clear dictionary. So SetDictionaryFromList should support empty string to clear it to remove SetDictionary sync call. Reviewers: masayuki Tags: #secure-revision Bug #: 1480699 Differential Revision: https://phabricator.services.mozilla.com/D2714
013481de4c5f20107b837e204e7cbd08ab6369e5: Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r=masayuki a=lizzard draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 Jul 2018 14:17:50 +0900 - rev 824920
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r=masayuki a=lizzard Spellchecker of <input> element is off by default, however, if it's in a contenteditable element, spellchecker is on by default. When turning off contenteditable, we have to update spellcheck status if focused editor is in this contenteditable. MozReview-Commit-ID: 6Y9mUWTIWRn
f9542916a0bb4d55873991ef42ad2ae1fe5feef3: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki a=lizzard draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 824919
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki a=lizzard When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
2ea858939f3e69e9e90b84fffe7af0239500b094: Bug 1479383 - Use const method for some GetEditorRoot methods. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jul 2018 10:35:43 +0000 - rev 824704
Push 117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1479383 - Use const method for some GetEditorRoot methods. r=masayuki Some methods to get editor root etc has unnecessary refcounting and it isn't const method. So we should remove unnecessary refcounting and change to const method. Differential Revision: https://phabricator.services.mozilla.com/D2499
86df0a5cc49aeb1d5cd1fd9943803359ea656d92: Bug 1477917 - Part 2. Use AString instead of wstring in spellchecker. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 26 Jul 2018 03:13:51 +0000 - rev 823283
Push 117637 by felipc@gmail.com at Fri, 27 Jul 2018 01:14:51 +0000
Bug 1477917 - Part 2. Use AString instead of wstring in spellchecker. r=masayuki The language parameter of mozIPersonalDictionary is unused, so we should remove this from parameter. Then, no one uses mLanguage member of mozHunspell now. Differential Revision: https://phabricator.services.mozilla.com/D2349
b7439662fa8f10c4dc640242c40194c734ab1c39: Bug 1477917 - Part 1. Remove unused methods for spellchecker. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 26 Jul 2018 03:09:14 +0000 - rev 823282
Push 117637 by felipc@gmail.com at Fri, 27 Jul 2018 01:14:51 +0000
Bug 1477917 - Part 1. Remove unused methods for spellchecker. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D2348
978445460a4a5937c7903db3987a420523483b3e: Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 822733
Push 117459 by rwood@mozilla.com at Wed, 25 Jul 2018 20:28:10 +0000
Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
a1ea7c9a777550a731466c8eb203f11b16dda981: Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 822571
Push 117402 by jdescottes@mozilla.com at Wed, 25 Jul 2018 13:32:04 +0000
Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
cf4e80fd48e4b7ec4c0a482bc3e7107ea8f53bbe: Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821868
Push 117204 by jdescottes@mozilla.com at Tue, 24 Jul 2018 04:55:14 +0000
Bug 1443923 - part5: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
0bc82dd8d8370d0d5b8dbd55e3343bd7b7701336: Bug 358033 - Part 2. Add test. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Jul 2018 02:46:24 +0000 - rev 821476
Push 117107 by dgottwald@mozilla.com at Mon, 23 Jul 2018 12:36:09 +0000
Bug 358033 - Part 2. Add test. r=masayuki Differential Revision: https://phabricator.services.mozilla.com/D2260
69f61d0f8f814df5c36100891c722bce164266bb: Bug 358033 - Part 1. Restore direction of Selection. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 23 Jul 2018 02:44:42 +0000 - rev 821475
Push 117107 by dgottwald@mozilla.com at Mon, 23 Jul 2018 12:36:09 +0000
Bug 358033 - Part 1. Restore direction of Selection. r=masayuki SelectionState doesn't save and restore current selection's direction. So the direction of selection is always default after undoing. So we should restore direction of selection. Differential Revision: https://phabricator.services.mozilla.com/D2259
7c7ec0aebcfdf5e1c7a13837ea9100c8b680d1d5: Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821452
Push 117098 by jdescottes@mozilla.com at Mon, 23 Jul 2018 10:19:47 +0000
Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
7ce3ca23623f23ca67581a733d87681a4deccb2e: Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821430
Push 117090 by jdescottes@mozilla.com at Mon, 23 Jul 2018 09:05:06 +0000
Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
23dae494136336d0318a4a05192cd0cf4d6d0220: Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821426
Push 117088 by jdescottes@mozilla.com at Mon, 23 Jul 2018 08:52:56 +0000
Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
dd59b933aa5350a1ca6f56d42dd11cba355e6cc1: Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821418
Push 117085 by jdescottes@mozilla.com at Mon, 23 Jul 2018 06:59:13 +0000
Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
0ac70397c093ac2b17ae87ecc64a49323c4fbcc8: Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 20 Jul 2018 11:01:43 +0200 - rev 821036
Push 116997 by jdescottes@mozilla.com at Fri, 20 Jul 2018 19:56:29 +0000
Bug 1443923 - part8: Emit chrome-only event customelementdefined for DevTools;r=masayuki MozReview-Commit-ID: GCFhhpVj5VS
7692346c4515d94e12966f22f2278a9c2b7946b9: Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r=masayuki
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 10:44:00 +1000 - rev 819644
Push 116603 by bmo:rcaliman@mozilla.com at Wed, 18 Jul 2018 09:50:41 +0000
Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r=masayuki MozReview-Commit-ID: JN6GVPTZNg2
13a9c08692f96117439f57e40c17c78c5b278618: Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r?masayuki draft
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 10:44:00 +1000 - rev 819550
Push 116578 by xquan@mozilla.com at Wed, 18 Jul 2018 04:06:19 +0000
Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r?masayuki MozReview-Commit-ID: JN6GVPTZNg2
4389a41617201b7b891718cf60e1fa22d0aa473a: Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r?masayuki draft
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 10:44:00 +1000 - rev 819504
Push 116569 by xquan@mozilla.com at Wed, 18 Jul 2018 00:44:34 +0000
Bug 1476477 - Replace nsAutoCString with nsCString for local result variables in windows widget. r?masayuki MozReview-Commit-ID: JN6GVPTZNg2
f1cce2949d239dcec78955bc9f3c729321104148: Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:22:08 +0900 - rev 817047
Push 115942 by bmo:emalysz@mozilla.com at Wed, 11 Jul 2018 22:22:50 +0000
Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r=masayuki mozEnglishWordUtils should be deXPCOM since it isn't used from script, then get rid of mozISpellI18NUtil that is unused. MozReview-Commit-ID: JpRuWfu3uYx
b68d9811ac08d81701c63259926de07917791592: Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:21:28 +0900 - rev 817046
Push 115942 by bmo:emalysz@mozilla.com at Wed, 11 Jul 2018 22:22:50 +0000
Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil. r=masayuki Some methods in mozISpellI18NUtil are unused now. MozReview-Commit-ID: Ku9FojuJW3T
91eb438b6af05c6fbdab79c1beee2198fa49d90c: Bug 1469759 - Part 2. Get rid of mozISpellI18NManager. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:21:04 +0900 - rev 817045
Push 115942 by bmo:emalysz@mozilla.com at Wed, 11 Jul 2018 22:22:50 +0000
Bug 1469759 - Part 2. Get rid of mozISpellI18NManager. r=masayuki No one uses mozISpellI18NManager, so we should get rid of this interface. MozReview-Commit-ID: 7f0Cy3tHnt1
c40c74e6f3478a90f6756addb97de4fb1a64cb91: Bug 1469759 - Part 1. Use mozEnglishWordUtils directly. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:20:39 +0900 - rev 817044
Push 115942 by bmo:emalysz@mozilla.com at Wed, 11 Jul 2018 22:22:50 +0000
Bug 1469759 - Part 1. Use mozEnglishWordUtils directly. r=masayuki mozISpellI18NManager is only used to get mozISpellI18NUtil. And mozISpellI18NUtil is only implemented on mozEnglishWordUtils. So we should create an instance of mozEnglishWordUtils instead of using mozISpellI18NManager. MozReview-Commit-ID: FmCuMAMmH9C
476d6df5099909088d6101067e73b76b1d765aa4: Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 Jul 2018 14:17:50 +0900 - rev 816854
Push 115850 by bmo:tvijiala@mozilla.com at Wed, 11 Jul 2018 10:05:08 +0000
Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r=masayuki Spellchecker of <input> element is off by default, however, if it's in a contenteditable element, spellchecker is on by default. When turning off contenteditable, we have to update spellcheck status if focused editor is in this contenteditable. MozReview-Commit-ID: 6Y9mUWTIWRn
0cda6f01b04a18af552f2254b95f6c0257e9f637: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 816853
Push 115850 by bmo:tvijiala@mozilla.com at Wed, 11 Jul 2018 10:05:08 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
fe2c2572dac496d7935af8673eaea61a4983b24b: Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:22:08 +0900 - rev 816411
Push 115836 by bmo:m_kato@ga2.so-net.ne.jp at Wed, 11 Jul 2018 07:12:16 +0000
Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r?masayuki mozEnglishWordUtils should be deXPCOM since it isn't used from script, then get rid of mozISpellI18NUtil that is unused. MozReview-Commit-ID: JpRuWfu3uYx
149847a68bd8512bf97dc3818d40bab80d92c33b: Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:21:28 +0900 - rev 816410
Push 115836 by bmo:m_kato@ga2.so-net.ne.jp at Wed, 11 Jul 2018 07:12:16 +0000
Bug 1469759 - Part 3. Remove unused methods of mozISpellI18NUtil. r?masayuki Some methods in mozISpellI18NUtil are unused now. MozReview-Commit-ID: Ku9FojuJW3T
7131d59a2fd607494600cc3f51ca40c0024760d7: Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 Jul 2018 14:17:50 +0900 - rev 816383
Push 115825 by bmo:m_kato@ga2.so-net.ne.jp at Wed, 11 Jul 2018 04:24:36 +0000
Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki Spellchecker of <input> element is off by default, however, if it's in a contenteditable element, spellchecker is on by default. When turning off contenteditable, we have to update spellcheck status if focused editor is in this contenteditable. MozReview-Commit-ID: 6Y9mUWTIWRn
4c31558d3481dbd0d0f842fafc73120eb04cbd91: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 815978
Push 115703 by bmo:balbeza@mozilla.com at Tue, 10 Jul 2018 12:19:42 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
760a7bde38632baabcd5caacacbd67021a3e8d27: Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 Jul 2018 14:17:50 +0900 - rev 815885
Push 115681 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 10 Jul 2018 07:59:38 +0000
Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki It is depends on editing host whether spellcheck is turned on. Input element's default is off, but contenteditable's default is on. When turning off contenteditable, we have to update spellcheck status if focused editor is in this contenteditable. MozReview-Commit-ID: 6Y9mUWTIWRn
b4b53bfc9a18f30f1076a324950af0a1220a22c4: Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 10 Jul 2018 14:17:50 +0900 - rev 815884
Push 115680 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 10 Jul 2018 07:39:00 +0000
Bug 1443902 - Part 2. Update spellcheck status on focused element after turning off contenteditable. r?masayuki Spellcheck default is different when using contenteditable or input element. When turning off contenteditable, we should check whether focused editor turns on spellchecker. MozReview-Commit-ID: 6Y9mUWTIWRn
9d90c12b3c93e4dfd95095ce29a26e5fdd83f952: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 815883
Push 115680 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 10 Jul 2018 07:39:00 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
45853b30dd6b750493fd7440333e71889a40e93b: Bug 1472887, focusin/out should be composed, and mark chrome event target chain items as chrome, r=masayuki
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 09 Jul 2018 17:40:01 +0300 - rev 815838
Push 115662 by maglione.k@gmail.com at Tue, 10 Jul 2018 03:45:13 +0000
Bug 1472887, focusin/out should be composed, and mark chrome event target chain items as chrome, r=masayuki
773c06bb22cf2da24fd11be9be8d7b0376da3e36: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 815829
Push 115657 by bmo:m_kato@ga2.so-net.ne.jp at Tue, 10 Jul 2018 01:47:08 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r=masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
5cb7c7d51aa7df3e29339a37f8c8d23e605f4ce3: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 815545
Push 115543 by bmo:m_kato@ga2.so-net.ne.jp at Mon, 09 Jul 2018 09:41:08 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r?masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
95b4d0bb412f352343afb84255840ae4b5edb944: Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 09 Jul 2018 16:53:47 +0900 - rev 815536
Push 115536 by bmo:m_kato@ga2.so-net.ne.jp at Mon, 09 Jul 2018 08:22:49 +0000
Bug 1443902 - Reinitilize selection after destroying nsIEditingSession. r?masayuki When setting contenteditable to false, editing session destroys HTMLEditor. Destroying HTMLEditor means that selection visibility is reset by FinalizeSelection. So after calling TearDownEditorOnWindow on nsHTMLDocument, we should initialize selection visibility if current focus is text control that has editor. MozReview-Commit-ID: 4V8kZtOtKO3
dc93e28f1f7cc935ce7480edebb29f919dd917f9: Bug 1372276 - Part 6: Remove <menuitem> HTML element support; r?bz,hsivonen,froydnj,dietrich,masayuki draft
Gordon P. Hemsley <gphemsley@gmail.com> - Sat, 29 Jul 2017 03:43:08 -0400 - rev 815282
Push 115484 by bmo:gphemsley@gphemsley.org at Sat, 07 Jul 2018 03:31:44 +0000
Bug 1372276 - Part 6: Remove <menuitem> HTML element support; r?bz,hsivonen,froydnj,dietrich,masayuki MozReview-Commit-ID: 7NoVi79eco4
8516908f03b3ebece77524b60cb0c78c32a5eb7a: Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:22:08 +0900 - rev 814786
Push 115343 by bmo:m_kato@ga2.so-net.ne.jp at Fri, 06 Jul 2018 07:41:34 +0000
Bug 1469759 - Part 4. Get rid of mozISpellI18NUtil. r?masayuki mozEnglishWordUtils should be deXPCOM since it isn't used from script, then get rid of mozISpellI18NUtil that is unused. MozReview-Commit-ID: JpRuWfu3uYx
8bef5812c3ffa8d16e044649816fc103a9b7de13: Bug 1469759 - Part 3. Remove unused method of mozISpellI18NUtil. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:21:28 +0900 - rev 814785
Push 115343 by bmo:m_kato@ga2.so-net.ne.jp at Fri, 06 Jul 2018 07:41:34 +0000
Bug 1469759 - Part 3. Remove unused method of mozISpellI18NUtil. r?masayuki Some methods in mozISpellI18NUtil are unused now. MozReview-Commit-ID: Ku9FojuJW3T
160ace2fbd752c12923a59576bb2273f5bf74030: Bug 1469759 - Part 2. Get rid of mozISpellI18NManager. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:21:04 +0900 - rev 814784
Push 115343 by bmo:m_kato@ga2.so-net.ne.jp at Fri, 06 Jul 2018 07:41:34 +0000
Bug 1469759 - Part 2. Get rid of mozISpellI18NManager. r?masayuki No one uses mozISpellI18NManager, so we should get rid of this interface. MozReview-Commit-ID: 7f0Cy3tHnt1
cde8a836239cc8ff001ce191a50a4cad5eeddf3d: Bug 1469759 - Part 1. Use mozEnglishWordUtils directly. r?masayuki draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 02 Jul 2018 11:20:39 +0900 - rev 814783
Push 115343 by bmo:m_kato@ga2.so-net.ne.jp at Fri, 06 Jul 2018 07:41:34 +0000
Bug 1469759 - Part 1. Use mozEnglishWordUtils directly. r?masayuki mozISpellI18NManager is only used to get mozISpellI18NUtil. And mozISpellI18NUtil is only implemented on mozEnglishWordUtils. So we should create an instance of mozEnglishWordUtils instead of using mozISpellI18NManager. MozReview-Commit-ID: FmCuMAMmH9C
6ce77b24d18e988ed4daf727bd40f0ae7583df32: Bug 1405897 - Move assertion before setting resizer attribute. r=masayuki
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 29 Jun 2018 04:47:21 +0000 - rev 812434
Push 114542 by jdescottes@mozilla.com at Fri, 29 Jun 2018 10:33:35 +0000
Bug 1405897 - Move assertion before setting resizer attribute. r=masayuki This assertion was added by review comment of bug 1487945. Since mutation event handler of this test case hides resizer, this case hits this assertion. Although 4th parameter of SetAttr can control mutation event, if this event isn't fired, another test case (layout/base/tests/test_bug558663.html) becomes failure. So we should move the assertion before setting resizer attribute. Differential Revision: https://phabricator.services.mozilla.com/D1854