searching for reviewer(mak)
5412e9ef6314e378952186b398966a77b24edb7e: Bug 1480049 - Remove nsIAnnotationService::getPageAnnotation. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 23 Aug 2018 09:59:50 +0000 - rev 831005
Push
118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1480049 - Remove nsIAnnotationService::getPageAnnotation. r=mak
This changes the meta data cache in DownloadHistory to store a copy of the meta data throughout the session, to avoid the need for async lookups when updating the UI.
Differential Revision:
https://phabricator.services.mozilla.com/D2597
42e2eeaca65d313926e962b6583d52d4bcab6d15: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 828187
Push
118647 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 06:14:44 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant C++ functions are updated to take a typed enum. JavaScript
calls are unaffected but they will throw if the string argument does not
correspond to one of the known entries in the C++ enum. The existing whitelists
and blacklists of annotations are also generated from the YAML file and all
duplicate code related to them has been consolidated. Once written out to the
.extra file the annotations are converted in string form and are no different
than the existing ones.
All existing annotations have been included in the list (and some obsolete ones
have been removed) and all call sites have been updated including tests where
appropriate.
7eda7d950dc5b0c18f299622f775e20ca3515093: Bug 1473026, use cell coordinates for comparing tree icons rather than the selection region, r=mak
Neil Deakin <neil@mozilla.com> - Tue, 07 Aug 2018 09:32:07 -0400 - rev 827916
Push
118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1473026, use cell coordinates for comparing tree icons rather than the selection region, r=mak
36642e9b970a0fd70fe765485195f8a1c556d4e7: Bug 1480541 - Remove em-dash from search string dropdown text when the search query is empty. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 08 Aug 2018 19:52:59 +0000 - rev 827892
Push
118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1480541 - Remove em-dash from search string dropdown text when the search query is empty. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2898
9d267b4bd26889fe936dff2c7b05d3b9415ccb44: Bug 1480503 - Create API for setting text (keyword) in and focusing on the awesomebar. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 08 Aug 2018 19:45:52 +0000 - rev 827891
Push
118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1480503 - Create API for setting text (keyword) in and focusing on the awesomebar. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2895
7645fd7dc1a4da14cb59c065f1589e6fb29cf497: Bug 1481319 - Include prefix when matching bookmark keywords. r=mak
Matt Brubeck <mbrubeck@mozilla.com> - Tue, 07 Aug 2018 17:47:46 +0000 - rev 827368
Push
118523 by bmo:alwu@mozilla.com at Tue, 07 Aug 2018 22:38:39 +0000
Bug 1481319 - Include prefix when matching bookmark keywords. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2804
4073ae1a277ff00d40609dd62afc5cc60a705a10: Bug 1478823: Start loading the default favicon as soon as the head element is complete. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 07 Aug 2018 12:42:15 +0000 - rev 827350
Push
118523 by bmo:alwu@mozilla.com at Tue, 07 Aug 2018 22:38:39 +0000
Bug 1478823: Start loading the default favicon as soon as the head element is complete. r=mak
We have to potentially add the root favicon both after the head element completes and when the page finishes loading in the case that there was no head element.
Differential Revision:
https://phabricator.services.mozilla.com/D2803
1ca603c55983418563957eff6d88883d44393636: Bug 1480158 - The profile manager no longer updates the profile name after a rename. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 06 Aug 2018 13:17:38 +0100 - rev 827228
Push
118502 by bmo:mstriemer@mozilla.com at Tue, 07 Aug 2018 16:39:48 +0000
Bug 1480158 - The profile manager no longer updates the profile name after a rename. r=mak
741a654c2f4c183a14c717f3367828f5003078e5: Bug 1478823: Start loading the default favicon as soon as the head element is complete. r=mak
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 03 Aug 2018 21:24:28 +0000 - rev 826792
Push
118386 by bmo:so61pi.re@gmail.com at Sun, 05 Aug 2018 09:56:44 +0000
Bug 1478823: Start loading the default favicon as soon as the head element is complete. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2613
1e9ecba54e7b1e6ee614e323ece9c98c373311a9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826469
Push
118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant functions are updated to take a typed enum (in C++) and an
integer constant (in JavaScript). A JavaScript wrapper around the crash
reporter service is provided to hold the constants. The existing whitelists
and blacklists of annotations are also generated from the YAML file and the
existing duplicate code has been consolidated. Once written out to the .extra
file the annotations are converted in string form and are no different than
the existing ones.
All existing annotations have been included (and some obsolete ones removed)
and all call sites have been updated including tests.
86471a18672fb8b1c7edf27076f5e2964e2389f9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 826463
Push
118333 by bmo:snorp@snorp.net at Fri, 03 Aug 2018 20:42:37 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
This introduces the machinery needed to generate crash annotations from a YAML
file. The relevant functions are updated to take a typed enum (in C++) and an
integer constant (in JavaScript). A JavaScript wrapper around the crash
reporter service is provided to hold the constants. The existing whitelists
and blacklists of annotations are also generated from the YAML file and the
existing duplicate code has been consolidated. Once written out to the .extra
file the annotations are converted in string form and are no different than
the existing ones.
All existing annotations have been included (and some obsolete ones removed)
and all call sites have been updated including tests.
616e64b6948580ad8c67e54540dbee8111750a69: Bug 1478918 - Inflate outgoing records and notify observers outside the bookmarks mirror's merge transaction. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Thu, 02 Aug 2018 16:41:35 +0000 - rev 826089
Push
118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1478918 - Inflate outgoing records and notify observers outside the bookmarks mirror's merge transaction. r=mak
Neither of these should block the main Places connection from writing
to the database. `itemsToUpload` stores a snapshot of the local items,
so we don't need to keep a transaction open when we read from this
table to inflate records.
`noteObserverChanges` did this to ensure we passed the correct params
to the observers, in case the database changed between merging and
notifying, but this is already racy.
This patch also adds a forgotten `AFTER DELETE` trigger to update
the global Sync change counter for successfully uploaded tombstones.
Differential Revision:
https://phabricator.services.mozilla.com/D2454
fde7e80c27a764a0b28ca79615515f8da70471cf: Bug 1479722 - Remove nsIAnnotationService::setPageAnnotation and removePageAnnotation. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 01 Aug 2018 09:47:24 +0000 - rev 825480
Push
118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1479722 - Remove nsIAnnotationService::setPageAnnotation and removePageAnnotation. r=mak
Depends on D2582
Differential Revision:
https://phabricator.services.mozilla.com/D2583
26c498b422ebbb46156d2cac048d6441c2715631: Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 01 Aug 2018 10:13:59 +0000 - rev 825479
Push
118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
MozReview-Commit-ID: HeO3Mm5Dibo
Differential Revision:
https://phabricator.services.mozilla.com/D2582
baff5ef35b0dd4d3f11e4b8ad1d375ad1cb06479: Bug 1478265 - Add a Places maintenance task to clean up duplicate URLs. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Wed, 01 Aug 2018 06:53:13 +0000 - rev 825326
Push
118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1478265 - Add a Places maintenance task to clean up duplicate URLs. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2351
150241c71d9d812a8bd96b59043421441ff3897f: Bug 1478265 - Add a Places maintenance task to clean up duplicate URLs. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Wed, 01 Aug 2018 04:55:56 +0000 - rev 825321
Push
118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1478265 - Add a Places maintenance task to clean up duplicate URLs. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2351
b0f3063dad92adf2c8703c4fde9c84d661eb2732: Bug 1479764 - Remove nsIAnnotationObserver and annotation notifications. r=mak,lina
Mark Banner <standard8@mozilla.com> - Tue, 31 Jul 2018 21:34:42 +0000 - rev 825312
Push
118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1479764 - Remove nsIAnnotationObserver and annotation notifications. r=mak,lina
MozReview-Commit-ID: I9nNefvgch9
Differential Revision:
https://phabricator.services.mozilla.com/D2565
fe84937092e9e91e121c79b18a911b6cda109ba5: Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r=mak
Mark Striemer <mstriemer@mozilla.com> - Fri, 27 Jul 2018 17:13:55 -0500 - rev 825061
Push
118030 by bmo:sfoster@mozilla.com at Tue, 31 Jul 2018 23:35:13 +0000
Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r=mak
MozReview-Commit-ID: F8zhbb4l7J8
db7a4be05d8f51ae46f0f2e5d81b2a7ba97cb17a: Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu
draft
Dão Gottwald <dao@mozilla.com> - Thu, 26 Jul 2018 19:17:13 +0300 - rev 824989
Push
118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1470394 - Increase bookmark panel width to provide enough area for text in other localizations. r=mak a=ritu
1a33a2a195220441b64e900d815d7d1786e641ca: Bug 1470887 - Preserve exactly autofilled values in the urlbar, and don't call losslessDecodeURI on them. r=mak a=lizzard
draft
Drew Willcoxon <adw@mozilla.com> - Fri, 20 Jul 2018 17:08:29 +0000 - rev 824948
Push
118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1470887 - Preserve exactly autofilled values in the urlbar, and don't call losslessDecodeURI on them. r=mak a=lizzard
Differential Revision:
https://phabricator.services.mozilla.com/D2256
b2360af9510ebfd8812095d0a7298158e8d94c0a: Bug 1476674 - Fix crash in nsNavHistory::RecalculateOriginFrecencyStats r=mak a=lizzard
draft
Drew Willcoxon <adw@mozilla.com> - Thu, 19 Jul 2018 17:15:02 +0000 - rev 824926
Push
118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1476674 - Fix crash in nsNavHistory::RecalculateOriginFrecencyStats r=mak a=lizzard
Differential Revision:
https://phabricator.services.mozilla.com/D2232
39327053019c217d0419cf5b7a2b1af15abb5115: Bug 1474755 - Change autofill threshold calculation to multiply the standard deviation by a constant, which is stored in prefs. r=mak a=lizzard
draft
Drew Willcoxon <adw@mozilla.com> - Thu, 19 Jul 2018 17:44:18 +0000 - rev 824922
Push
118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1474755 - Change autofill threshold calculation to multiply the standard deviation by a constant, which is stored in prefs. r=mak a=lizzard
Differential Revision:
https://phabricator.services.mozilla.com/D2233
7aa62bab6783eef4d37635e0728f9689a7e00458: Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 31 Jul 2018 11:40:55 +0000 - rev 824724
Push
117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1479053 - Remove unused/unnecessary methods from nsIAnnotationService. r=mak
MozReview-Commit-ID: I9qq71RLXYH
Depends on D2473
Differential Revision:
https://phabricator.services.mozilla.com/D2474
1b3eff02c54fe2d0a126a9176815ad8541680155: Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 31 Jul 2018 11:40:52 +0000 - rev 824723
Push
117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1479053 - Remove nsIAnnotationObserver::onPageAnnotationSet/Removed. r=mak
MozReview-Commit-ID: JkUhtuV1fvU
Differential Revision:
https://phabricator.services.mozilla.com/D2473
bc2f6a85b93f882ef9683f3d4f95dc8b1c942b29: Bug 1468980 - Remove nsIDownloadHistory.idl. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 15:24:53 +0100 - rev 824709
Push
117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1468980 - Remove nsIDownloadHistory.idl. r=mak
MozReview-Commit-ID: IDHmOmJRJfe
e48757a556f88b075f860f98c27f22f3e0db06ff: Bug 1468980 - Change downloads code to save downloads via the new async history API. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 11:35:27 +0100 - rev 824708
Push
117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1468980 - Change downloads code to save downloads via the new async history API. r=mak
MozReview-Commit-ID: BeKPtVH43RF
3c7eadf5e1ce2fab428e779ebdc8befb88dddbb1: Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 07:34:35 +0100 - rev 824707
Push
117996 by bmo:emalysz@mozilla.com at Tue, 31 Jul 2018 19:30:35 +0000
Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r=mak
MozReview-Commit-ID: 9pobdfHodcG
f43018b0a8c9a3bb8f54ad1b94730261240e9b82: Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r?mak
draft
Mark Striemer <mstriemer@mozilla.com> - Fri, 27 Jul 2018 17:13:55 -0500 - rev 824678
Push
117976 by bmo:mstriemer@mozilla.com at Tue, 31 Jul 2018 16:28:05 +0000
Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r?mak
MozReview-Commit-ID: F8zhbb4l7J8
6db44bb95a0f5c26c047404037a1fa74f5a86f1a: Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
draft
Mark Striemer <mstriemer@mozilla.com> - Fri, 27 Jul 2018 17:13:55 -0500 - rev 824674
Push
117974 by bmo:mstriemer@mozilla.com at Tue, 31 Jul 2018 16:24:37 +0000
Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
MozReview-Commit-ID: F8zhbb4l7J8
c3b99983344fa998358d59ef8d8087dbc28f7481: Bug 1479380 - update bugzilla component in moz.build file for toolkit/components/downloads to 'Toolkit :: Downloads API'. r=mak
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 30 Jul 2018 12:39:00 +0300 - rev 824357
Push
117877 by bmo:rbartlensky@mozilla.com at Mon, 30 Jul 2018 17:02:50 +0000
Bug 1479380 - update bugzilla component in moz.build file for toolkit/components/downloads to 'Toolkit :: Downloads API'. r=mak
MozReview-Commit-ID: FPI90yZmSo5
b68a81d7cc4b567f0745d9e48d55e7865d6f4e2b: Bug 1468980 - Remove nsIDownloadHistory.idl. r?mak
draft
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 15:24:53 +0100 - rev 824281
Push
117858 by bmo:standard8@mozilla.com at Mon, 30 Jul 2018 15:00:24 +0000
Bug 1468980 - Remove nsIDownloadHistory.idl. r?mak
MozReview-Commit-ID: IDHmOmJRJfe
d688631bb7ddd039f1292b6f41188611a742abf0: Bug 1468980 - Change downloads code to save downloads via the new async history API. r?mak
draft
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 11:35:27 +0100 - rev 824280
Push
117858 by bmo:standard8@mozilla.com at Mon, 30 Jul 2018 15:00:24 +0000
Bug 1468980 - Change downloads code to save downloads via the new async history API. r?mak
MozReview-Commit-ID: BeKPtVH43RF
2959dc8f936b87b9176fbc5317bb34b0ccee1267: Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r?mak
draft
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 07:34:35 +0100 - rev 824279
Push
117858 by bmo:standard8@mozilla.com at Mon, 30 Jul 2018 15:00:24 +0000
Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r?mak
MozReview-Commit-ID: 9pobdfHodcG
abb13d9d1febb795f24fbac5c52f1eaf4784a591: Bug 1479380 - update bugzilla component in moz.build file for toolkit/components/downloads to 'Toolkit :: Downloads API'. r?mak
draft
Sebastian Hengst <archaeopteryx@coole-files.de> - Mon, 30 Jul 2018 12:39:00 +0300 - rev 824187
Push
117837 by bmo:aryx.bugmail@gmx-topmail.de at Mon, 30 Jul 2018 09:42:15 +0000
Bug 1479380 - update bugzilla component in moz.build file for toolkit/components/downloads to 'Toolkit :: Downloads API'. r?mak
MozReview-Commit-ID: FPI90yZmSo5
6b6ded8230f14b205a20b16cc4251ccb7f8e34f3: Bug 1465458 - Fix launching downloads without a file extension on Windows. r=mak, a=RyanVM
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 26 Jun 2018 15:27:36 +0100 - rev 823920
Push
117822 by mwoodrow@mozilla.com at Mon, 30 Jul 2018 00:10:01 +0000
Bug 1465458 - Fix launching downloads without a file extension on Windows. r=mak, a=RyanVM
MozReview-Commit-ID: 6VYjHM46gZx
abfa418aed59ff1bb89d02b8b145f07d44dabab4: Bug 1472435 - Ensure the `itemsToMerge` view in the bookmarks mirror ignores duplicate URLs. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Fri, 27 Jul 2018 08:18:44 +0000 - rev 823709
Push
117769 by bmo:jaws@mozilla.com at Fri, 27 Jul 2018 22:56:13 +0000
Bug 1472435 - Ensure the `itemsToMerge` view in the bookmarks mirror ignores duplicate URLs. r=mak
If `moz_places` has duplicate rows for the same URL, joining on the URL
and hash includes the same item multiple times in `itemsToMerge`. This
causes constraint errors when we try to record observer notifications
for an item that we already saw.
Differential Revision:
https://phabricator.services.mozilla.com/D2350
407712756e4d5fcb17ffc66826c4059f14ffe230: Bug 1478922 - Stage bookmark tags to upload in a separate table instead of using a subquery. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Fri, 27 Jul 2018 14:14:38 +0000 - rev 823708
Push
117769 by bmo:jaws@mozilla.com at Fri, 27 Jul 2018 22:56:13 +0000
Bug 1478922 - Stage bookmark tags to upload in a separate table instead of using a subquery. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2455
bcf377e36d7ddabfbe616ac68de708c246b1bef5: Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
draft
Mark Striemer <mstriemer@mozilla.com> - Fri, 27 Jul 2018 17:13:55 -0500 - rev 823692
Push
117765 by bmo:mstriemer@mozilla.com at Fri, 27 Jul 2018 22:16:10 +0000
Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
MozReview-Commit-ID: F8zhbb4l7J8
350f4aa618f3fc711c81de17150105093f1e6af4: Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
draft
Mark Striemer <mstriemer@mozilla.com> - Fri, 27 Jul 2018 17:13:55 -0500 - rev 823671
Push
117764 by bmo:mstriemer@mozilla.com at Fri, 27 Jul 2018 22:14:20 +0000
Bug 1478042 - Check if there's a window in History menu for hidden tabs r?mak
MozReview-Commit-ID: F8zhbb4l7J8
e96d78ee15d9abdacd7245710f12e6c557614590: Bug 1468980 - Remove nsIDownloadHistory.idl. r?mak
draft
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 15:24:53 +0100 - rev 823564
Push
117724 by bmo:standard8@mozilla.com at Fri, 27 Jul 2018 16:04:31 +0000
Bug 1468980 - Remove nsIDownloadHistory.idl. r?mak
MozReview-Commit-ID: IDHmOmJRJfe
3301d9eaef1dd09d93af0b14deabd3d197819dd3: Bug 1468980 - Change downloads code to save downloads via the new async history API. r?mak
draft
Mark Banner <standard8@mozilla.com> - Fri, 27 Jul 2018 11:35:27 +0100 - rev 823563
Push
117724 by bmo:standard8@mozilla.com at Fri, 27 Jul 2018 16:04:31 +0000
Bug 1468980 - Change downloads code to save downloads via the new async history API. r?mak
MozReview-Commit-ID: BeKPtVH43RF
8211738fd8deb61a9502e436e82f911f9aa8d1b6: Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r?mak
draft
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 07:34:35 +0100 - rev 823562
Push
117724 by bmo:standard8@mozilla.com at Fri, 27 Jul 2018 16:04:31 +0000
Bug 1468980 - Add an annotations parameter to PlacesUtils.history.update to retrieve any annotations. r?mak
MozReview-Commit-ID: 9pobdfHodcG
c334bde84123fc1dd40312cf3c8e00501064e49e: Bug 1358443 - remove reflows from adjustHeight itself, r=mak,florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 26 Jul 2018 13:17:41 +0000 - rev 823314
Push
117637 by felipc@gmail.com at Fri, 27 Jul 2018 01:14:51 +0000
Bug 1358443 - remove reflows from adjustHeight itself, r=mak,florian
This goes back to relying on rows being the same height.
Places where we replace the popup will likely not use the richlistbox,
and we no longer have code that changes the height or exceeds the maximum
number of visible children with a scrollbar, so we should be OK.
To determine the padding on the richlistbox and the height of the initial
row, I've used a promiseDocumentFlushed callback. It's possible this causes
flicker the first time the popup opens. I can't see any, but it's quite
possible I'm missing something.
Differential Revision:
https://phabricator.services.mozilla.com/D2242
0ce819c0a08153a533805a0c347f9cd298bf5b9a: Bug 1358443 - remove reflows from adjustHeight itself, r=mak,florian
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 25 Jul 2018 15:35:01 +0000 - rev 822814
Push
117477 by bmo:sfoster@mozilla.com at Thu, 26 Jul 2018 00:31:55 +0000
Bug 1358443 - remove reflows from adjustHeight itself, r=mak,florian
This goes back to relying on rows being the same height.
Places where we replace the popup will likely not use the richlistbox,
and we no longer have code that changes the height or exceeds the maximum
number of visible children with a scrollbar, so we should be OK.
To determine the padding on the richlistbox and the height of the initial
row, I've used a promiseDocumentFlushed callback. It's possible this causes
flicker the first time the popup opens. I can't see any, but it's quite
possible I'm missing something.
Differential Revision:
https://phabricator.services.mozilla.com/D2242
da4ff0f7bff51632758a9081d4ad3b6fb1be0823: Bug 1462135 - Replace PlacesUtils.getCharsetForURI with PU.history.fetch with an option to fetch annotations. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 24 Jul 2018 16:41:22 +0000 - rev 822226
Push
117316 by bgrinstead@mozilla.com at Tue, 24 Jul 2018 22:25:31 +0000
Bug 1462135 - Replace PlacesUtils.getCharsetForURI with PU.history.fetch with an option to fetch annotations. r=mak
This also avoids us doing main thread sync io.
MozReview-Commit-ID: KR0p7eeu1sj
Differential Revision:
https://phabricator.services.mozilla.com/D2117
79426f83650f78d8d4b6f8ad8832112e2637ac18: Bug 1477246 - Remove horizontal padding from bookmark panel bottom buttons. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 20 Jul 2018 15:16:57 +0200 - rev 822200
Push
117316 by bgrinstead@mozilla.com at Tue, 24 Jul 2018 22:25:31 +0000
Bug 1477246 - Remove horizontal padding from bookmark panel bottom buttons. r=mak
MozReview-Commit-ID: BQcMPddyylI
2085de844b42d13cece57080f48fad7fb4ac3f83: Bug 1477250 - Set a min-width on editBookmarkPanelBottomButtons instead of editBookmarkPanelBottomContent. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 20 Jul 2018 15:25:03 +0200 - rev 822199
Push
117316 by bgrinstead@mozilla.com at Tue, 24 Jul 2018 22:25:31 +0000
Bug 1477250 - Set a min-width on editBookmarkPanelBottomButtons instead of editBookmarkPanelBottomContent. r=mak
MozReview-Commit-ID: 5KorvtKn3ZW
22005ac8d9b286975b3d207862571a70b67c62b7: Bug 1470887 - Preserve exactly autofilled values in the urlbar, and don't call losslessDecodeURI on them. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 20 Jul 2018 17:08:29 +0000 - rev 821142
Push
117018 by bmo:sfoster@mozilla.com at Sat, 21 Jul 2018 04:05:10 +0000
Bug 1470887 - Preserve exactly autofilled values in the urlbar, and don't call losslessDecodeURI on them. r=mak
Differential Revision:
https://phabricator.services.mozilla.com/D2256
ab6c2651f8eff6b2846ee89732089c9ca62f6a13: Bug 1476901 - Stop ever hiding editBookmarkPanelContent and editBookmarkPanelBottomButtons in the bookmark panel. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 19 Jul 2018 13:43:30 +0200 - rev 821106
Push
117018 by bmo:sfoster@mozilla.com at Sat, 21 Jul 2018 04:05:10 +0000
Bug 1476901 - Stop ever hiding editBookmarkPanelContent and editBookmarkPanelBottomButtons in the bookmark panel. r=mak
MozReview-Commit-ID: CwfHapJicIG
e63d612abd2bfe7032def744dd29290db177475b: Bug 1477250 - Set a min-width on editBookmarkPanelBottomButtons instead of editBookmarkPanelBottomContent. r?mak
draft
Dão Gottwald <dao@mozilla.com> - Fri, 20 Jul 2018 15:25:03 +0200 - rev 820830
Push
116950 by dgottwald@mozilla.com at Fri, 20 Jul 2018 13:25:48 +0000
Bug 1477250 - Set a min-width on editBookmarkPanelBottomButtons instead of editBookmarkPanelBottomContent. r?mak
MozReview-Commit-ID: 5KorvtKn3ZW