searching for reviewer(kaku)
13270722741bb78779bf7d47e78bf9f4c4ff0e12: Bug 1414825. Use a shutdown observer to release the gfx resources of ImageBitmaps. r=kaku,nical
Timothy Nikkel <tnikkel@gmail.com> - Mon, 22 Jan 2018 21:38:45 -0600 - rev 723423
Push 96421 by bmo:gps@mozilla.com at Tue, 23 Jan 2018 05:59:40 +0000
Bug 1414825. Use a shutdown observer to release the gfx resources of ImageBitmaps. r=kaku,nical
1b13a12e07ac595f6d8dbea4c115ccc10f45475a: Bug 1394702 - rewrite test_seek_out_of_range.html to be more robust. r=kaku
JW Wang <jwwang@mozilla.com> - Tue, 09 Jan 2018 17:35:07 +0800 - rev 718742
Push 95044 by bmo:ttromey@mozilla.com at Wed, 10 Jan 2018 21:17:24 +0000
Bug 1394702 - rewrite test_seek_out_of_range.html to be more robust. r=kaku See comment 20 for the root cause. We wait for both 'seeked' and 'ended' events to fire to make sure playback has reached the end before calling play(). MozReview-Commit-ID: 55NEmqyDuSI
afb1b6f44c253a47fb896c0509aa0c2c95c53522: Bug 1428684 - reduce the chance of UAF when changing states of MDSM. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 08 Jan 2018 11:41:59 +0800 - rev 717627
Push 94740 by bmo:gasolin@mozilla.com at Tue, 09 Jan 2018 09:59:05 +0000
Bug 1428684 - reduce the chance of UAF when changing states of MDSM. r=kaku SetState() will delete the current state object and UAF will happen if members are accessed after this call. However, sometimes it is not obvious if SetState() is called indirectly as we do in MaybeFinishSeek(). To make it less error-prone, we will keep the old state object alive for a bit longer and set mMaster to null to catch potential UAF. MozReview-Commit-ID: Aqxj92ETjti
f9d423919e3fe6e34eaff1b4603398e66eaa594e: Bug 1427934. P3 - check v.ended before calling callSeekToNextFrame(). r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:25:51 +0800 - rev 715938
Push 94292 by hikezoe@mozilla.com at Thu, 04 Jan 2018 22:06:10 +0000
Bug 1427934. P3 - check v.ended before calling callSeekToNextFrame(). r=kaku v.ended is set to true before the 'ended' event is fired. Then we can simplify the code by asserting seekToNextFrame() should never be rejected. MozReview-Commit-ID: 5fB2QuboU0I
7dc54aff9e7e3ba29ed7b25e2a5f67e13644e950: Bug 1427934. P2 - disable dormant. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:19:44 +0800 - rev 715937
Push 94292 by hikezoe@mozilla.com at Thu, 04 Jan 2018 22:06:10 +0000
Bug 1427934. P2 - disable dormant. r=kaku This makes tests run slightly faster. MozReview-Commit-ID: 9gsrgEw4kx5
cc5d3268e179468b44000799b0e8889c4a03d080: Bug 1427934. P1 - make logging less verbose. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:18:19 +0800 - rev 715936
Push 94292 by hikezoe@mozilla.com at Thu, 04 Jan 2018 22:06:10 +0000
Bug 1427934. P1 - make logging less verbose. r=kaku MozReview-Commit-ID: J1zxpmxLzy1
584b1ba07318219abdaaba01530171d33536e74a: Bug 1427934. P3 - check v.ended before calling callSeekToNextFrame(). r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:25:51 +0800 - rev 715843
Push 94287 by bmo:hikezoe@mozilla.com at Thu, 04 Jan 2018 21:37:30 +0000
Bug 1427934. P3 - check v.ended before calling callSeekToNextFrame(). r=kaku v.ended is set to true before the 'ended' event is fired. Then we can simplify the code by asserting seekToNextFrame() should never be rejected. MozReview-Commit-ID: 5fB2QuboU0I
f6ad3ada1068563c4409f881fcf0c5732030d502: Bug 1427934. P2 - disable dormant. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:19:44 +0800 - rev 715842
Push 94287 by bmo:hikezoe@mozilla.com at Thu, 04 Jan 2018 21:37:30 +0000
Bug 1427934. P2 - disable dormant. r=kaku This makes tests run slightly faster. MozReview-Commit-ID: 9gsrgEw4kx5
191b1802e9287db6120248cfa1bc26accf66974e: Bug 1427934. P1 - make logging less verbose. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 04 Jan 2018 11:18:19 +0800 - rev 715841
Push 94287 by bmo:hikezoe@mozilla.com at Thu, 04 Jan 2018 21:37:30 +0000
Bug 1427934. P1 - make logging less verbose. r=kaku MozReview-Commit-ID: J1zxpmxLzy1
8d22eba3f47a259c4ec009df250c683ad3fa1ac3: Bug 1404187 - group timeout messages for MediaTestManager. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 29 Sep 2017 11:25:31 +0800 - rev 672565
Push 82275 by hikezoe@mozilla.com at Fri, 29 Sep 2017 10:42:45 +0000
Bug 1404187 - group timeout messages for MediaTestManager. r=kaku So different test timeouts from the same test case will fall under the same bug. MozReview-Commit-ID: LDstAhOpkYK
f9e527aa4ba5d497880de2a677c51b8ee6e27e63: Bug 1401366. P2 - bail out Observe() if not subcribed per comment 2. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 20 Sep 2017 17:51:10 +0800 - rev 667914
Push 80878 by bmo:eoger@fastmail.com at Wed, 20 Sep 2017 21:41:57 +0000
Bug 1401366. P2 - bail out Observe() if not subcribed per comment 2. r=kaku MozReview-Commit-ID: 4LEBD3g0OwX
0848279b2b72c10e8ae6b3cfcdff2e97355dc593: Bug 1401366. P1 - format HTMLMediaElement::ShutdownObserver. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 20 Sep 2017 17:46:34 +0800 - rev 667913
Push 80878 by bmo:eoger@fastmail.com at Wed, 20 Sep 2017 21:41:57 +0000
Bug 1401366. P1 - format HTMLMediaElement::ShutdownObserver. r=kaku MozReview-Commit-ID: K9ZYTedgUjC
4c879d5173d1f32f83fa2e3d943cd7409f360590: Bug 1388665 - remove BufferingState::DispatchDecodeTasksIfNeeded(). r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 09 Aug 2017 16:56:41 +0800 - rev 643993
Push 73283 by bmo:emilio+bugs@crisal.io at Thu, 10 Aug 2017 10:09:45 +0000
Bug 1388665 - remove BufferingState::DispatchDecodeTasksIfNeeded(). r=kaku We will dispatch decoding tasks in Handle{Audio,Video}Decoded() instead. See comment 0 for the rationale. MozReview-Commit-ID: 9trJYoMfzJH
42d64afd61ab3804625db4768fdd437aead6b4db: Bug 1385748. P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 31 Jul 2017 10:21:43 +0800 - rev 618351
Push 71309 by bmo:dakatsuka@mozilla.com at Mon, 31 Jul 2017 09:52:54 +0000
Bug 1385748. P3 - MediaDecoder::mNextState doesn't need to be a canonical for it has no mirrors. r=kaku MozReview-Commit-ID: HiiPcKK08az
47380ed038da6c9d87bf2b12e46a1c73958606d0: Bug 1385748. P2 - remove MDSM::mNextPlayState. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 31 Jul 2017 10:17:36 +0800 - rev 618350
Push 71309 by bmo:dakatsuka@mozilla.com at Mon, 31 Jul 2017 09:52:54 +0000
Bug 1385748. P2 - remove MDSM::mNextPlayState. r=kaku Following P1, mNextPlayState is no longer used. MozReview-Commit-ID: 5ABEYMQ5G9l
f76639bd1c36351ad856a3ee8fce4c2f3c3dcfca: Bug 1385748. P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 31 Jul 2017 10:15:47 +0800 - rev 618349
Push 71309 by bmo:dakatsuka@mozilla.com at Mon, 31 Jul 2017 09:52:54 +0000
Bug 1385748. P1 - remove MDSM::IsLogicallyPlaying() which has no callers at all. r=kaku MozReview-Commit-ID: IfpzTMVtgf6
a9cb889906077ef445d3ef14dd0978f33228cc0b: Bug 1384836 - rename MediaDecoderReaderWrapper to ReaderProxy. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 27 Jul 2017 14:49:57 +0800 - rev 617406
Push 71048 by bmo:emilio+bugs@crisal.io at Fri, 28 Jul 2017 12:58:45 +0000
Bug 1384836 - rename MediaDecoderReaderWrapper to ReaderProxy. r=kaku MozReview-Commit-ID: 7WeNblTnTCG
48875368bb686c108ee1ed1215a901522e231528: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=jwwang,kaku
bechen <bechen@mozilla.com> - Thu, 13 Jul 2017 18:18:04 +0800 - rev 609102
Push 68502 by bmo:emilio+bugs@crisal.io at Fri, 14 Jul 2017 20:08:47 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=jwwang,kaku MozReview-Commit-ID: 4zjOoSAYild
bb26ab0cce2d1ce1f2d6c94078b6d2ba0a20fbea: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Fri, 14 Jul 2017 18:13:27 +0800 - rev 608948
Push 68455 by bechen@mozilla.com at Fri, 14 Jul 2017 10:39:57 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
a8d1525b2f17ea8549f737673cf757f744118ccf: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Thu, 13 Jul 2017 18:18:04 +0800 - rev 608705
Push 68378 by bechen@mozilla.com at Fri, 14 Jul 2017 02:33:17 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
4c77cc0ece77fdb1de24521fe12dae8c94f78113: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Fri, 07 Jul 2017 16:57:08 +0800 - rev 605267
Push 67345 by bechen@mozilla.com at Fri, 07 Jul 2017 09:11:15 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
627576f460c81383e2f3e80bcb596c19a333f117: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Thu, 06 Jul 2017 13:39:16 +0800 - rev 604581
Push 67131 by bechen@mozilla.com at Thu, 06 Jul 2017 05:39:53 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
33c6d709446f6bb261d3b2c09f44be2955091d05: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Thu, 06 Jul 2017 10:57:42 +0800 - rev 604526
Push 67112 by bechen@mozilla.com at Thu, 06 Jul 2017 02:58:14 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
0dba08db744076bcd56b5ce7ffa89883fc84a95b: Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang draft
bechen <bechen@mozilla.com> - Wed, 21 Jun 2017 16:17:24 +0800 - rev 597981
Push 65103 by bechen@mozilla.com at Wed, 21 Jun 2017 08:18:50 +0000
Bug 1374189 - new testcase to count the total frame when "skip-to-next-key-frame.enabled" is false. r=kaku, jwwang MozReview-Commit-ID: 4zjOoSAYild
d7ee40333fc1eb6cfe76ac006e171e484929ec8c: Bug 1373589 - Remove MediaResourceCallback::NotifyDecodeError which has no callers at all. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 16 Jun 2017 17:36:30 +0800 - rev 596526
Push 64675 by mak77@bonardo.net at Mon, 19 Jun 2017 12:08:05 +0000
Bug 1373589 - Remove MediaResourceCallback::NotifyDecodeError which has no callers at all. r=kaku MozReview-Commit-ID: D2xqWHIiRBv
97877fd398adf74bb68de31e4f5b10bd0c2c11a9: Bug 1371515. P5 - remove mIsShutdown which is not read at all. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:47:53 +0800 - rev 592515
Push 63424 by mdeboer@mozilla.com at Mon, 12 Jun 2017 11:12:47 +0000
Bug 1371515. P5 - remove mIsShutdown which is not read at all. r=kaku MozReview-Commit-ID: H8MZSoG9wCV
9a840c89892e0e4f1d2a3d2f6d741d02fd17f206: Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:45:20 +0800 - rev 592514
Push 63424 by mdeboer@mozilla.com at Mon, 12 Jun 2017 11:12:47 +0000
Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r=kaku MozReview-Commit-ID: AVWtCVFflho
6266b3ba9d2356c9521e2bdaaf305b37ba58ac89: Bug 1371515. P3 - remove IsShutdown() which now has no callers. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:43:51 +0800 - rev 592513
Push 63424 by mdeboer@mozilla.com at Mon, 12 Jun 2017 11:12:47 +0000
Bug 1371515. P3 - remove IsShutdown() which now has no callers. r=kaku MozReview-Commit-ID: Te3F7WJ8iF
a12ce07a8154626a61eb958088e4569116ed23bc: Bug 1371515. P2 - remove the check from DecodeError(). r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:42:59 +0800 - rev 592512
Push 63424 by mdeboer@mozilla.com at Mon, 12 Jun 2017 11:12:47 +0000
Bug 1371515. P2 - remove the check from DecodeError(). r=kaku The same reason as P1. ShutdownState::Enter() disconnects callbacks to prevent DecodeError() from being called during shutdown. MozReview-Commit-ID: EFZiE2zkcUZ
e10c8efbb0fe265a2fe251e92e5f09c497f1bc10: Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r=kaku
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:41:20 +0800 - rev 592511
Push 63424 by mdeboer@mozilla.com at Mon, 12 Jun 2017 11:12:47 +0000
Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r=kaku MozReview-Commit-ID: 5V7xCGCsh5j
d4d5a96778919dbed1206242f83d5b7ed0c95439: Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:47:53 +0800 - rev 592378
Push 63361 by jwwang@mozilla.com at Mon, 12 Jun 2017 06:07:22 +0000
Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku MozReview-Commit-ID: H8MZSoG9wCV
82e9b2bed4f8e3021197e192903f35fddea4c10f: Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:45:20 +0800 - rev 592377
Push 63361 by jwwang@mozilla.com at Mon, 12 Jun 2017 06:07:22 +0000
Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku MozReview-Commit-ID: AVWtCVFflho
452f9268047dd454ebc04e4521e7e7fb7d272fb8: Bug 1371515. P3 - remove IsShutdown() which now has no callers. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:43:51 +0800 - rev 592376
Push 63361 by jwwang@mozilla.com at Mon, 12 Jun 2017 06:07:22 +0000
Bug 1371515. P3 - remove IsShutdown() which now has no callers. r?kaku MozReview-Commit-ID: Te3F7WJ8iF
5fc407af0182334e0ad5d94d294e91a8c8ca1987: Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:41:20 +0800 - rev 592374
Push 63361 by jwwang@mozilla.com at Mon, 12 Jun 2017 06:07:22 +0000
Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r?kaku MozReview-Commit-ID: 5V7xCGCsh5j
d0e09a3807383d7ae23000806cc1c6a3ebb238bf: Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:47:53 +0800 - rev 592333
Push 63342 by jwwang@mozilla.com at Mon, 12 Jun 2017 03:09:28 +0000
Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku MozReview-Commit-ID: H8MZSoG9wCV
5608e0636df2417d4a65cd6085c4dc82b6772d65: Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:45:20 +0800 - rev 592332
Push 63342 by jwwang@mozilla.com at Mon, 12 Jun 2017 03:09:28 +0000
Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku MozReview-Commit-ID: AVWtCVFflho
71da73f5a6a36605c08414bf7c750309ac9231b8: Bug 1371515. P3 - remove IsShutdown() which now has no callers. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:43:51 +0800 - rev 592331
Push 63342 by jwwang@mozilla.com at Mon, 12 Jun 2017 03:09:28 +0000
Bug 1371515. P3 - remove IsShutdown() which now has no callers. r?kaku MozReview-Commit-ID: Te3F7WJ8iF
898e25fb2c289a8eb9cce7c6f1c8bdf4defae728: Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:47:53 +0800 - rev 591504
Push 63063 by jwwang@mozilla.com at Fri, 09 Jun 2017 03:55:15 +0000
Bug 1371515. P5 - remove mIsShutdown which is not read at all. r?kaku MozReview-Commit-ID: H8MZSoG9wCV
0a070d0942c8f4d9e9139c17518f68c15f93403f: Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:45:20 +0800 - rev 591503
Push 63063 by jwwang@mozilla.com at Fri, 09 Jun 2017 03:55:15 +0000
Bug 1371515. P4 - remove CanonicalIsShutdown() which has no callers at all. r?kaku MozReview-Commit-ID: AVWtCVFflho
98931436137fbcf9d4e74f843342094f6c5c0a51: Bug 1371515. P3 - remove IsShutdown() which now has not callers. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:43:51 +0800 - rev 591502
Push 63063 by jwwang@mozilla.com at Fri, 09 Jun 2017 03:55:15 +0000
Bug 1371515. P3 - remove IsShutdown() which now has not callers. r?kaku MozReview-Commit-ID: Te3F7WJ8iF
b6449e3cc0060e9b11b2a0625da80886b6172acd: Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r?kaku draft
JW Wang <jwwang@mozilla.com> - Fri, 09 Jun 2017 11:41:20 +0800 - rev 591500
Push 63063 by jwwang@mozilla.com at Fri, 09 Jun 2017 03:55:15 +0000
Bug 1371515. P1 - remove the |IsShutdown()| check from Seek() which is already handled by ShutdownState. r?kaku MozReview-Commit-ID: 5V7xCGCsh5j
6e9e40efea3995e0472fd64507b2ee2b4f76d481: Bug 1370130 - dormant timeout should take precedence over preload='metadata'. r=kaku
JW Wang <jwwang@mozilla.com> - Mon, 05 Jun 2017 10:38:43 +0800 - rev 589037
Push 62230 by bmo:jyavenard@mozilla.com at Mon, 05 Jun 2017 14:10:47 +0000
Bug 1370130 - dormant timeout should take precedence over preload='metadata'. r=kaku We don't want to enter dormant when preload is 'metadata' if the timeout is negative (dormant is disabled). MozReview-Commit-ID: 4KGAmtkZpH5
1a663796db277e7ef3fdfaadaf562149a19d08eb: Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r?kaku draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 01 Jun 2017 16:07:27 +0200 - rev 588363
Push 62016 by bmo:jyavenard@mozilla.com at Fri, 02 Jun 2017 19:17:13 +0000
Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r?kaku When seeking, we go to the first IDR prior the seek target. However, if the MP4 sample table is invalid the frame returned may not be an IDR. It is an error for that frame to not be a keyframe, so we do want to have way to detect them through logging. Change assertion to a soft assertion for that purpose. MozReview-Commit-ID: EMgwRo1mYMp
5fe1447e3756f8db5b698f1327c2231316a705aa: Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r=kaku
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 01 Jun 2017 16:07:27 +0200 - rev 588275
Push 61982 by bmo:flyinggrub@gmail.com at Fri, 02 Jun 2017 13:39:34 +0000
Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r=kaku When seeking, we go to the first IDR prior the seek target. However, if the MP4 sample table is invalid the frame returned may not be an IDR. It is an error for that frame to not be a keyframe, so we do want to have way to detect them through logging. Change assertion to a soft assertion for that purpose. MozReview-Commit-ID: EMgwRo1mYMp
cfe5dcdaa5ae95f4dcbdd9be7a94ba87dccd7ecf: Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r?kaku draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 01 Jun 2017 16:07:27 +0200 - rev 587663
Push 61780 by bmo:jyavenard@mozilla.com at Thu, 01 Jun 2017 14:08:01 +0000
Bug 1369382: Don't make hard assertion that the queued sample is a keyframe. r?kaku When seeking, we go to the first IDR prior the seek target. However, if the MP4 sample table is invalid the frame returned may not be an IDR. It is an error for that frame to not be a keyframe, so we do want to have way to detect them through logging. Change assertion to a soft assertion for that purpose. MozReview-Commit-ID: EMgwRo1mYMp
8c8ef6237a35d91123f8df7ae7b371e0fd447f0e: Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r?kaku draft
JW Wang <jwwang@mozilla.com> - Wed, 17 May 2017 16:04:33 +0800 - rev 580251
Push 59480 by jwwang@mozilla.com at Thu, 18 May 2017 08:50:54 +0000
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r?kaku MozReview-Commit-ID: BcPwBTmXMZS
31019513efd1f3b8995a1ce398dfa46115b73077: Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r?kaku draft
JW Wang <jwwang@mozilla.com> - Wed, 17 May 2017 16:00:46 +0800 - rev 580250
Push 59480 by jwwang@mozilla.com at Thu, 18 May 2017 08:50:54 +0000
Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r?kaku The current call flow ensures decoding metadata only happens at most once and therefore EnqueueLoadedMetadataEvent() will only be called at most once. We don't need the mSentLoadedMetadataEvent flag. MozReview-Commit-ID: E95jtRrKupw
bc73a476b2707fc18c6f713d7947939dfc9bb86e: Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 17 May 2017 16:04:33 +0800 - rev 580079
Push 59443 by bmo:mh+mozilla@glandium.org at Thu, 18 May 2017 05:52:08 +0000
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r=kaku MozReview-Commit-ID: BcPwBTmXMZS
3e859332938cdea7a217543129d7f1285a5dd42b: Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r=kaku
JW Wang <jwwang@mozilla.com> - Wed, 17 May 2017 16:00:46 +0800 - rev 580078
Push 59443 by bmo:mh+mozilla@glandium.org at Thu, 18 May 2017 05:52:08 +0000
Bug 1365520. P1 - remove MDSM::mSentLoadedMetadataEvent and MDSM::EnqueueLoadedMetadataEvent(). r=kaku The current call flow ensures decoding metadata only happens at most once and therefore EnqueueLoadedMetadataEvent() will only be called at most once. We don't need the mSentLoadedMetadataEvent flag. MozReview-Commit-ID: E95jtRrKupw
e22403a78c92a7ae7b330296b2b4568a0e888a98: Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r?kaku draft
JW Wang <jwwang@mozilla.com> - Wed, 17 May 2017 16:04:33 +0800 - rev 579931
Push 59413 by jwwang@mozilla.com at Thu, 18 May 2017 02:21:29 +0000
Bug 1365520. P2 - remove mMetadataTags for we can pass |aMetadata->mTags| without storing it. r?kaku MozReview-Commit-ID: BcPwBTmXMZS