searching for reviewer(jwatt)
3de16fbc247bc1ca28ec12a776e468630407ea9e: Bug 1461706: Sync disabled state of number control regardless of appearance. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Aug 2018 13:06:18 +0200 - rev 830782
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1461706: Sync disabled state of number control regardless of appearance. r=jwatt I noticed this bug while fixing bug 1478069, but it goes back way earlier. Differential Revision: https://phabricator.services.mozilla.com/D3867
c217209a3b0494d4c4e6718aa6474221681aa660: Bug 1429298 - Part 5: Implement BuildPath for offset-path. r=jwatt
Boris Chiou <boris.chiou@gmail.com> - Wed, 22 Aug 2018 01:21:45 +0000 - rev 830739
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1429298 - Part 5: Implement BuildPath for offset-path. r=jwatt Implement one variant of BuildPath to accept nsTArray<StylePathCommand>, which is used by <offset-path> (and clip-path in the future). Depends on D3922 Differential Revision: https://phabricator.services.mozilla.com/D2967
96671e2dceadcdaedea6394516fa3e73f769af3b: Bug 1429298 - Part 5: Implement BuildPath for offset-path. r=jwatt
Boris Chiou <boris.chiou@gmail.com> - Tue, 21 Aug 2018 13:59:15 -0700 - rev 830693
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1429298 - Part 5: Implement BuildPath for offset-path. r=jwatt Implement one variant of BuildPath to accept nsTArray<StylePathCommand>, which is used by <offset-path> (and clip-path in the future). Differential Revision: https://phabricator.services.mozilla.com/D2967
ced9b3994cf4316a57e1777bb3738cc350a1196d: Bug 1478391: Autogenerate StyleAppearance. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 25 Jul 2018 15:03:45 +0200 - rev 823171
Push 117601 by rwood@mozilla.com at Thu, 26 Jul 2018 19:33:14 +0000
Bug 1478391: Autogenerate StyleAppearance. r=jwatt This builds on bug 1428676 and introduces StyleAppearance, which replaces the NS_THEME_* constants. Really sorry for the size of the patch. There's a non-trivial change in the gtk theme, which I submitted separately as bug 1478385. Differential Revision: https://phabricator.services.mozilla.com/D2361 MozReview-Commit-ID: DiSmMWK7Krp
431278284777cb2f594054248ab4f0347144e9c9: Bug 1477197: Remove unused UpdateStyleSheet argument. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Jul 2018 11:35:42 +0200 - rev 820982
Push 116993 by maglione.k@gmail.com at Fri, 20 Jul 2018 18:58:06 +0000
Bug 1477197: Remove unused UpdateStyleSheet argument. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D2262 MozReview-Commit-ID: IJufidwDrtc
f636c29f8df145e160e53cc6039c933a0067234d: Bug 1476470: Remove dead code from nsStyleUtil. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 Jul 2018 09:50:09 +0000 - rev 820471
Push 116842 by bmo:johannes.willbold@rub.de at Thu, 19 Jul 2018 17:09:05 +0000
Bug 1476470: Remove dead code from nsStyleUtil. r=jwatt This is dead since we started serializing the relevant stuff with Servo. Differential Revision: https://phabricator.services.mozilla.com/D2208
3e50073ec5908662e4c0c69784a73b9bf3b14c73: Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Jun 2018 13:30:37 +0200 - rev 809946
Push 113843 by bmo:emilio@crisal.io at Sun, 24 Jun 2018 05:10:47 +0000
Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt This fixes a MathML-disabled reftest with the previous patch. The reftest assumes the sheet is not loaded, so let's just do that. This effectively preserves behavior. MozReview-Commit-ID: KrR4pHslycz
b31f62139f60537f99c213afe20992c4926a1123: Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Jun 2018 13:30:37 +0200 - rev 809902
Push 113842 by bmo:emilio@crisal.io at Sun, 24 Jun 2018 03:07:22 +0000
Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt This fixes a MathML-disabled reftest with the previous patch. The reftest assumes the sheet is not loaded, so let's just do that. This effectively preserves behavior. MozReview-Commit-ID: KrR4pHslycz
ed54cee980b5deaa1a5f03889a3c55388ec9dbce: Bug 1470494 - Configure 'mark occurrences' preferences in generated Eclipse CDT project. r=jwatt draft
Botond Ballo <botond@mozilla.com> - Fri, 22 Jun 2018 13:08:03 -0400 - rev 809699
Push 113770 by bballo@mozilla.com at Fri, 22 Jun 2018 18:38:11 +0000
Bug 1470494 - Configure 'mark occurrences' preferences in generated Eclipse CDT project. r=jwatt MozReview-Commit-ID: HqiQyfYnPi7
eba64650c338905f9420808e6d023621e0cd4e34: Bug 1470494 - Configure indexer in generated Eclipse CDT project to automatically update the index. r=jwatt draft
Botond Ballo <botond@mozilla.com> - Fri, 22 Jun 2018 13:07:41 -0400 - rev 809698
Push 113770 by bballo@mozilla.com at Fri, 22 Jun 2018 18:38:11 +0000
Bug 1470494 - Configure indexer in generated Eclipse CDT project to automatically update the index. r=jwatt MozReview-Commit-ID: G0yX1ei7rII
55740f35314d338d8ff2544ade47387d51df5018: Bug 1469176: Load svg.css upfront. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Jun 2018 12:47:11 +0200 - rev 809601
Push 113724 by bmo:mstriemer@mozilla.com at Fri, 22 Jun 2018 14:48:42 +0000
Bug 1469176: Load svg.css upfront. r=jwatt Test Plan: Covered by existing tests. Reviewers: jwatt Reviewed By: jwatt Bug #: 1469176 Differential Revision: https://phabricator.services.mozilla.com/D1762
2f021346cef93d6614b67d51fac6e4663c313a50: Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Jun 2018 13:30:37 +0200 - rev 809576
Push 113710 by bmo:emilio@crisal.io at Fri, 22 Jun 2018 11:59:04 +0000
Bug 1470163: Don't load mathml/svg.css if MathML/SVG is disabled. r=jwatt This fixes a MathML-disabled reftest with the previous patch. The reftest assumes the sheet is not loaded, so let's just do that. This effectively preserves behavior. MozReview-Commit-ID: KrR4pHslycz
3ae38da1b767a9af6f67bdaa329769f92f69a657: Load svg.css upfront. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jun 2018 12:10:08 +0200 - rev 809571
Push 113710 by bmo:emilio@crisal.io at Fri, 22 Jun 2018 11:59:04 +0000
Load svg.css upfront. r=jwatt MozReview-Commit-ID: 7Ag9DxtTbEj
2a08d1f91ebf2b5b1fd27a9cb179e1421fa4fada: Load svg.css upfront. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jun 2018 12:10:08 +0200 - rev 809435
Push 113676 by bmo:emilio@crisal.io at Fri, 22 Jun 2018 03:46:37 +0000
Load svg.css upfront. r=jwatt MozReview-Commit-ID: 7Ag9DxtTbEj
e11d483958b2bfcf284488023a2ab7552e8dd5f5: Load svg.css upfront. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jun 2018 12:10:08 +0200 - rev 809298
Push 113621 by bmo:emilio@crisal.io at Thu, 21 Jun 2018 18:13:09 +0000
Load svg.css upfront. r=jwatt MozReview-Commit-ID: 7Ag9DxtTbEj
f5b8b5dbf6787ffe5317cec0aecd00dc1d95845d: Bug 1470105: Fix a typo in stylesheet cloning. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jun 2018 12:31:10 +0200 - rev 809237
Push 113595 by bmo:emilio@crisal.io at Thu, 21 Jun 2018 14:28:59 +0000
Bug 1470105: Fix a typo in stylesheet cloning. r=jwatt Summary: Just something I noticed while writing unrelated code. Reviewers: jwatt Bug #: 1470105 Differential Revision: https://phabricator.services.mozilla.com/D1747 MozReview-Commit-ID: 7KMTT9Kmdwc
49215116732ea11b633ce0e1200f8e7189ab0864: Load svg.css upfront. r=jwatt draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jun 2018 12:10:08 +0200 - rev 809206
Push 113579 by bmo:emilio@crisal.io at Thu, 21 Jun 2018 13:28:38 +0000
Load svg.css upfront. r=jwatt MozReview-Commit-ID: 7Ag9DxtTbEj
705644bd3788e039c147373182fa7fd19fec0e6d: Bug 1469244: Remove stale servo/components/{servo,nonzero} directories. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Jun 2018 10:54:35 +0200 - rev 808137
Push 113285 by bmo:gl@mozilla.com at Mon, 18 Jun 2018 13:50:26 +0000
Bug 1469244: Remove stale servo/components/{servo,nonzero} directories. r=jwatt Summary: Looks like I missed this in bug 1464834. Test Plan: Not part of the build, so no tests. Reviewers: jwatt Subscribers: heycam, xidorn Bug #: 1469244 Differential Revision: https://phabricator.services.mozilla.com/D1679 MozReview-Commit-ID: Bx14lTv6GDD
ceec781c0e837ddfbb19a4979ffbb009dfc5edd4: Bug 1453795 - SVG - Initialize member fields in classes/ structures. r=jwatt
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 16 Jun 2018 13:54:44 +0300 - rev 808054
Push 113261 by bmo:hikezoe@mozilla.com at Sun, 17 Jun 2018 21:35:06 +0000
Bug 1453795 - SVG - Initialize member fields in classes/ structures. r=jwatt
794b0773629492b6267973937a6a1d4f79d26538: Bug 1466332 - Add a reftest version of the @font-face descriptor matching tests from WPT's at-font-face-font-matching.html, as the WPT version does not currently run reliably. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Mon, 04 Jun 2018 09:45:50 +0100 - rev 803600
Push 112163 by rwood@mozilla.com at Mon, 04 Jun 2018 18:04:02 +0000
Bug 1466332 - Add a reftest version of the @font-face descriptor matching tests from WPT's at-font-face-font-matching.html, as the WPT version does not currently run reliably. r=jwatt
fa5724780fe76d6ccbbd08d978342a1db6a43d49: Bug 1466332 - patch 3 - Update StyleDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Sun, 03 Jun 2018 21:33:53 +0100 - rev 803479
Push 112122 by bmo:hsivonen@hsivonen.fi at Mon, 04 Jun 2018 10:01:17 +0000
Bug 1466332 - patch 3 - Update StyleDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
68e78883a0312d5e1be05b8c2319b33653640467: Bug 1466332 - patch 2 - Update WeightDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Sun, 03 Jun 2018 21:33:47 +0100 - rev 803478
Push 112122 by bmo:hsivonen@hsivonen.fi at Mon, 04 Jun 2018 10:01:17 +0000
Bug 1466332 - patch 2 - Update WeightDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
b33f95eb174a4acb571400a187359b8f7a1c6d01: Bug 1466332 - patch 1 - Update StretchDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Sun, 03 Jun 2018 21:33:42 +0100 - rev 803477
Push 112122 by bmo:hsivonen@hsivonen.fi at Mon, 04 Jun 2018 10:01:17 +0000
Bug 1466332 - patch 1 - Update StretchDistance function to more closely follow CSS4 Fonts algorithm. r=jwatt
b7688ef14e3ae06221387df0820affe16f9b98a1: Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Thu, 24 May 2018 14:44:09 +0100 - rev 803229
Push 112049 by bmo:emilio@crisal.io at Sat, 02 Jun 2018 07:46:09 +0000
Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt
9eabcc7a5eae3a16644bf06b5b0211e093251d66: Bug 1464400 - Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 25 May 2018 14:07:57 +0100 - rev 803105
Push 112028 by bmo:dharvey@mozilla.com at Fri, 01 Jun 2018 21:45:23 +0000
Bug 1464400 - Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt
f8dbb1d2d07cb5645d8370b1f766b21da538d392: Bug 1464400 - Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 25 May 2018 14:07:57 +0100 - rev 802875
Push 111985 by bmo:emilio@crisal.io at Fri, 01 Jun 2018 15:50:16 +0000
Bug 1464400 - Keep track of CSS generics when resolving to actual font families and faces, and expose as a new CSSGeneric attribute on InspectorFontFace. r=jwatt
36687c035662d43b744ddb1ead29e65d139fae66: Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Thu, 24 May 2018 14:44:09 +0100 - rev 802874
Push 111985 by bmo:emilio@crisal.io at Fri, 01 Jun 2018 15:50:16 +0000
Bug 1463115 - Try to skip irrelevant (collapsed/trimmed) whitespace when collecting used font faces for devtools inspector. r=jwatt
b225eb1f628ffe02b2c90ecc4723b7f606db64b4: Bug 1443092 - Crashtest. r=jwatt, a=test-only
Botond Ballo <botond@mozilla.com> - Fri, 09 Mar 2018 17:32:50 -0500 - rev 802245
Push 111850 by bmo:tom@mozilla.com at Thu, 31 May 2018 16:41:37 +0000
Bug 1443092 - Crashtest. r=jwatt, a=test-only
5ca94fe53b3cb94aad078c4f9ac5e92afdaaa225: Bug 1443092 - Crashtest. r=jwatt, a=test-only
Botond Ballo <botond@mozilla.com> - Fri, 09 Mar 2018 17:32:50 -0500 - rev 801546
Push 111693 by bmo:khudson@mozilla.com at Wed, 30 May 2018 15:07:47 +0000
Bug 1443092 - Crashtest. r=jwatt, a=test-only
24cfa380890604a502afaa388bee7e6587407fd2: Bug 1443092 - Crashtest. r=jwatt
Botond Ballo <botond@mozilla.com> - Fri, 09 Mar 2018 17:32:50 -0500 - rev 799528
Push 111091 by bmo:gl@mozilla.com at Thu, 24 May 2018 21:01:02 +0000
Bug 1443092 - Crashtest. r=jwatt
357d9f00469d5276138a918a64142ac6b158ab79: Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt, a=RyanVM
Jonathan Kew <jkew@mozilla.com> - Thu, 17 May 2018 14:44:37 +0100 - rev 797217
Push 110422 by bmo:khudson@mozilla.com at Fri, 18 May 2018 18:23:40 +0000
Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt, a=RyanVM
cd0ebdad3e8ba6d06f62595fb0adb3c02989637a: Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Thu, 17 May 2018 14:44:37 +0100 - rev 796572
Push 110279 by bmo:gl@mozilla.com at Thu, 17 May 2018 19:42:48 +0000
Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt
4d6aa78bf59d45b9468c38540d1e9c4f3d65838b: Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Thu, 17 May 2018 14:44:37 +0100 - rev 796550
Push 110279 by bmo:gl@mozilla.com at Thu, 17 May 2018 19:42:48 +0000
Bug 1460858 - Fix serialization/deserialization of SlantStyle for the Android startupCache, to ensure proper styled face selection. r=jwatt
e8770707cd40bf407bb1f7cdb4bcc5c2691ae5fa: Bug 1460764 - patch 2 - Include variationSettings in the gfxFontStyle hash value. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 15 May 2018 14:59:26 +0100 - rev 795376
Push 109953 by rwood@mozilla.com at Tue, 15 May 2018 18:48:56 +0000
Bug 1460764 - patch 2 - Include variationSettings in the gfxFontStyle hash value. r=jwatt
609bb1830bd00d88616f677c41c4ff04f998949d: Bug 1460764 - patch 1 - Avoid undefined behavior in gfxFontStyle::Hash() when sizeAdjust is -1.0f. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 15 May 2018 14:59:26 +0100 - rev 795375
Push 109953 by rwood@mozilla.com at Tue, 15 May 2018 18:48:56 +0000
Bug 1460764 - patch 1 - Avoid undefined behavior in gfxFontStyle::Hash() when sizeAdjust is -1.0f. r=jwatt
711990fd66aa72f2f42793c278666990d5b4a566: Bug 1457417 - Work around Core Text mishandling of 'opsz' axis when set to the font's default, by adjusting to a fractionally-different setting. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 15 May 2018 14:59:26 +0100 - rev 795374
Push 109953 by rwood@mozilla.com at Tue, 15 May 2018 18:48:56 +0000
Bug 1457417 - Work around Core Text mishandling of 'opsz' axis when set to the font's default, by adjusting to a fractionally-different setting. r=jwatt
7a875278bca9b33d147343cc377a205a71b39af2: Bug 1458301 - Remove failure annotations for WPT tests that now pass, due to improved font fallback choices. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 15 May 2018 14:59:25 +0100 - rev 795373
Push 109953 by rwood@mozilla.com at Tue, 15 May 2018 18:48:56 +0000
Bug 1458301 - Remove failure annotations for WPT tests that now pass, due to improved font fallback choices. r=jwatt
62be2b3915b4f37a6920fa5177d9602ae036a767: Bug 1458301 - Unify font face selection methods to consistently use WeightStyleStretchDistance to evaluate the closeness of an available resource to a requested style. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 15 May 2018 14:59:25 +0100 - rev 795372
Push 109953 by rwood@mozilla.com at Tue, 15 May 2018 18:48:56 +0000
Bug 1458301 - Unify font face selection methods to consistently use WeightStyleStretchDistance to evaluate the closeness of an available resource to a requested style. r=jwatt
3d0b8735586f3a6ef3179b60da1900ed0e7f2834: Bug 1422226 - Don't build display lists for NONDISPLAY content. r=jwatt
Robert Longson <longsonr@gmail.com> - Sun, 13 May 2018 19:16:26 +0100 - rev 794614
Push 109731 by bmo:mantaroh@gmail.com at Mon, 14 May 2018 00:23:03 +0000
Bug 1422226 - Don't build display lists for NONDISPLAY content. r=jwatt
1819372b068a4c8bdc85b7b440e0a51dbd2b59ee: Bug 1460543 - Check for null (default) style parameter in gfxDWriteFontEntry::CreateFontFace before dereferencing it. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Thu, 10 May 2018 14:45:19 +0100 - rev 793848
Push 109516 by bmo:mstriemer@mozilla.com at Thu, 10 May 2018 21:27:42 +0000
Bug 1460543 - Check for null (default) style parameter in gfxDWriteFontEntry::CreateFontFace before dereferencing it. r=jwatt
18cf597d218bce788f581545819a3907e16d5884: Bug 1458004 - Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Wed, 09 May 2018 13:49:24 +0100 - rev 793122
Push 109284 by rwood@mozilla.com at Wed, 09 May 2018 14:35:07 +0000
Bug 1458004 - Link font-style values italic / oblique to the appropriate variation-font axes or synthetic styling. r=jwatt
2eb5810dad5b0e400f1906d46784f8c15ef4d0db: Bug 1318947: More diagnostic information when snapshot comparison fails. r=jwatt
Milan Sreckovic <milan@mozilla.com> - Fri, 04 May 2018 09:42:00 +0300 - rev 791756
Push 108894 by bmo:gl@mozilla.com at Sat, 05 May 2018 04:24:07 +0000
Bug 1318947: More diagnostic information when snapshot comparison fails. r=jwatt
f9c96567050b556a8e63d5c879dc77ea6b7a6f9d: Bug 1459158 - Don't apply variation values from CSS font-weight/font-stretch properties if the font's variation axes appear to use a non-CSS-like scale. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 04 May 2018 17:36:01 +0100 - rev 791571
Push 108842 by bmo:gl@mozilla.com at Fri, 04 May 2018 17:13:12 +0000
Bug 1459158 - Don't apply variation values from CSS font-weight/font-stretch properties if the font's variation axes appear to use a non-CSS-like scale. r=jwatt
f7fcc3bea1391e344f0539810b212d8b51a050eb: Bug 1459163 - When variation fonts are disabled, gfxFontEntry::GetVariationsForStyle should just return without attempting to map CSS properties to variation axes. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 04 May 2018 17:35:38 +0100 - rev 791570
Push 108842 by bmo:gl@mozilla.com at Fri, 04 May 2018 17:13:12 +0000
Bug 1459163 - When variation fonts are disabled, gfxFontEntry::GetVariationsForStyle should just return without attempting to map CSS properties to variation axes. r=jwatt
24583a2f0c84ca8a8fd08d8ce88fa7717d7c2a9d: Bug 1449605 - part 2 - Rename gfxFontEntry::IsBold() to SupportsBold() and make it smarter about variable fonts, to avoid inappropriate use of synthetic-bold effect. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Fri, 04 May 2018 10:19:55 +0100 - rev 791539
Push 108842 by bmo:gl@mozilla.com at Fri, 04 May 2018 17:13:12 +0000
Bug 1449605 - part 2 - Rename gfxFontEntry::IsBold() to SupportsBold() and make it smarter about variable fonts, to avoid inappropriate use of synthetic-bold effect. r=jwatt
7faed86e281517ca8edee7adcac488a81d90433e: Bug 1458158 - Correct the weight-difference factor in CalcStyleMatch to favor closer weights, not further ones. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 01 May 2018 15:56:04 +0100 - rev 790661
Push 108547 by bmo:gl@mozilla.com at Wed, 02 May 2018 14:56:17 +0000
Bug 1458158 - Correct the weight-difference factor in CalcStyleMatch to favor closer weights, not further ones. r=jwatt
74b436c29aa163c01461818f746425201b4c0701: Bug 1458158 - Testcase for rendering Arabic characters when styled with an extra-bold weight of Arial. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 01 May 2018 15:55:06 +0100 - rev 790660
Push 108547 by bmo:gl@mozilla.com at Wed, 02 May 2018 14:56:17 +0000
Bug 1458158 - Testcase for rendering Arabic characters when styled with an extra-bold weight of Arial. r=jwatt
ab355ea017aa7e641a0b17d4b21fa86beb3aa207: Bug 1441598 - Part 2: When cancelling a print make sure the DialogOpened message has been sent. r=jwatt, a=ritu
Bob Owen <bobowencode@gmail.com> - Sun, 04 Mar 2018 18:43:33 +0000 - rev 790422
Push 108516 by bmo:jlorenzo@mozilla.com at Wed, 02 May 2018 09:32:32 +0000
Bug 1441598 - Part 2: When cancelling a print make sure the DialogOpened message has been sent. r=jwatt, a=ritu
085ee122efa6002bf3db4652b1021b9c00629055: Bug 1441598 - Don't try and send messages to PrintProgressDialogChild when printing is complete. r=jwatt, a=ritu
Bob Owen <bobowencode@gmail.com> - Mon, 05 Mar 2018 08:22:14 +0000 - rev 790421
Push 108516 by bmo:jlorenzo@mozilla.com at Wed, 02 May 2018 09:32:32 +0000
Bug 1441598 - Don't try and send messages to PrintProgressDialogChild when printing is complete. r=jwatt, a=ritu
a4096171bfdbea9956e8afd4d74ac0b7c89506b1: Bug 1449605 - part 1 - Rearrange thebes font code so that the decision whether to apply synthetic-bold is deferred until actually instantiating a font, not made during the font-matching process. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 01 May 2018 10:30:50 +0100 - rev 790173
Push 108439 by rwood@mozilla.com at Tue, 01 May 2018 15:43:29 +0000
Bug 1449605 - part 1 - Rearrange thebes font code so that the decision whether to apply synthetic-bold is deferred until actually instantiating a font, not made during the font-matching process. r=jwatt This rearranges how synthetic-bold use is determined in the font selection & rendering code. Previously, we would decide during the font-selection algorithm whether we need to apply synthetic-bold to the chosen face, and then pass that decision through the fontgroup (storing it in the FamilyFace entries of the mFonts array there) down to the actual rendering code that instantiates fonts from the faces (font entries) we've selected. That became a problem for variation fonts because in the case of a user font, we may not have downloaded the resource yet, so we just have a "user font container" entry, which carries the descriptors from the @font-face rule and will fetch the actual resource when needed. But in the case of a @font-face rule without a weight descriptor, we don't actually know at font-selection time whether the face will support "true" bold (via a variation axis) or not, so we can't reliably make the right decision about applying synthetic bold. So we now defer that decision until we actually instantiate a platform font object to shape/measure/draw text. At that point, we have the requested style and we also have the real font resource, so we can easily determine whether fake-bold is required. (This patch should not result in any visible behavior change; that will come in a second patch now that the architecture supports it.)