searching for reviewer(jdescottes)
86e6704908fde59a926376f6e42161d749e80765: Bug 1477600 - Part 2: Implement remove/reload button. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 14 Aug 2018 10:35:43 +0900 - rev 829892
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1477600 - Part 2: Implement remove/reload button. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3272
1889060c3412b13d3f75685a96002e6c9ac7f559: Bug 1477600 - Part 1: Support installing temporary extension. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Tue, 14 Aug 2018 10:30:11 +0900 - rev 829891
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1477600 - Part 1: Support installing temporary extension. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3271
f523b181c03f11aa78373eec6bcfd5ec5e2ec5bc: Bug 1483730 - Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 17 Aug 2018 06:58:42 +0900 - rev 829882
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1483730 - Return null from getFileForAdb if the adb file doesn't exit. r=jdescottes Summary: Depends on D3463 Reviewers: jdescottes Reviewed By: jdescottes Bug #: 1483730 Differential Revision: https://phabricator.services.mozilla.com/D3464
248f68b88c186f23650b4147c8e38005dd546710: Bug 1483730 - Call nsIFile.exists method. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 17 Aug 2018 06:56:52 +0900 - rev 829881
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1483730 - Call nsIFile.exists method. r=jdescottes Reviewers: jdescottes Reviewed By: jdescottes Bug #: 1483730 Differential Revision: https://phabricator.services.mozilla.com/D3463
fa0a81fe2da6ad958c1c1dc910e58afb1ba3c6b5: Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:42:07 -0700 - rev 829788
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes MozReview-Commit-ID: AeqTRlwXQRL
7f6bb6c2bc018d3a25a877f62e79ed103661ea7b: Bug 1479524 - Remove unused appId filter. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:41:48 -0700 - rev 829787
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1479524 - Remove unused appId filter. r=jdescottes MozReview-Commit-ID: FwIX9dQ4c83
0f25b95e97408a4dfcb5ff223c130cec304c6d5e: Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 27 Jul 2018 02:05:14 -0700 - rev 829786
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes MozReview-Commit-ID: AXOd0i4NOjH
5d6965e5700a8fb2e00b652a49153bbad09ee175: Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:57 -0400 - rev 829624
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes Design https://mozilla.invisionapp.com/d/main#/console/12408235/300479943/preview
62fcbe25665cde98d2f87a9b4a1c9e189628c45e: Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 15 Aug 2018 17:27:57 -0400 - rev 829591
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes Design https://mozilla.invisionapp.com/d/main#/console/12408235/300479943/preview
51fedae0567e4fe24765681ab881bb76fa3315fc: Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes draft
Gabriel Luong <gabriel.luong@gmail.com> - Tue, 14 Aug 2018 17:54:55 -0400 - rev 829223
Push 118750 by bmo:gl@mozilla.com at Tue, 14 Aug 2018 21:55:43 +0000
Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes Design https://mozilla.invisionapp.com/d/main#/console/12408235/300479943/preview MozReview-Commit-ID: K1vIjMc685u
e4f165c26370def0a21c0d7bf36a41bcf055ff53: Bug 1481699 - Merge two if statements for 'start-server' into a single one. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 13 Aug 2018 06:12:55 +0900 - rev 829002
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1481699 - Merge two if statements for 'start-server' into a single one. r=jdescottes And fix some log messages.
09baf4d80d60b193f3dd432a7d5947895daee30c: Bug 1473917 - Show #shadow-root in breadcrumbs. r=jdescottes
Belén Albeza <balbeza@mozilla.com> - Fri, 10 Aug 2018 10:55:41 +0000 - rev 828993
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1473917 - Show #shadow-root in breadcrumbs. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3017
0ff9a32425870a1e7e21bc933a0052cb53617459: Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:42:07 -0700 - rev 828964
Push 118734 by bmo:poirot.alex@gmail.com at Tue, 14 Aug 2018 14:53:41 +0000
Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes MozReview-Commit-ID: AeqTRlwXQRL
720e2d5dc1a63776c2890d65909c72d1b81004f2: Bug 1479524 - Remove unused appId filter. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:41:48 -0700 - rev 828963
Push 118734 by bmo:poirot.alex@gmail.com at Tue, 14 Aug 2018 14:53:41 +0000
Bug 1479524 - Remove unused appId filter. r=jdescottes MozReview-Commit-ID: FwIX9dQ4c83
5d6e043af66874e2dc4ba9626f9daf357e958078: Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 27 Jul 2018 02:05:14 -0700 - rev 828962
Push 118734 by bmo:poirot.alex@gmail.com at Tue, 14 Aug 2018 14:53:41 +0000
Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes MozReview-Commit-ID: AXOd0i4NOjH
6e9c55809a0a75768d847b70de90cd24672746a6: Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:42:07 -0700 - rev 828812
Push 118711 by bmo:poirot.alex@gmail.com at Mon, 13 Aug 2018 19:44:30 +0000
Bug 1479524 - Lazy load network-monitor.js dependencies. r=jdescottes MozReview-Commit-ID: AeqTRlwXQRL
81a6e4474540bfe8b902386dd7a810d8217789dc: Bug 1479524 - Remove unused appId filter. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 02 Aug 2018 11:41:48 -0700 - rev 828811
Push 118711 by bmo:poirot.alex@gmail.com at Mon, 13 Aug 2018 19:44:30 +0000
Bug 1479524 - Remove unused appId filter. r=jdescottes MozReview-Commit-ID: FwIX9dQ4c83
20c9c522e41b8e5e14b8782bae2057cd07e31dd6: Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes draft
Alexandre Poirot <poirot.alex@gmail.com> - Fri, 27 Jul 2018 02:05:14 -0700 - rev 828810
Push 118711 by bmo:poirot.alex@gmail.com at Mon, 13 Aug 2018 19:44:30 +0000
Bug 1479524 - Always use message manager with NetworkMonitorActor. r=jdescottes MozReview-Commit-ID: AXOd0i4NOjH
784bc6605eebd2bb1ba447a1f58a81ad6acbf688: Bug 1481699 - Send host:kill command through TCP socket instead of spawning a new adb process with 'kill-server'. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 13 Aug 2018 06:12:55 +0900 - rev 828761
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1481699 - Send host:kill command through TCP socket instead of spawning a new adb process with 'kill-server'. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3170
4e70c4d1dfc30b07f31e3315eb50eb3e93715b5a: Bug 1481699 - Do not process any further data after we started shutting down the ADB server. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 13 Aug 2018 06:08:34 +0900 - rev 828760
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1481699 - Do not process any further data after we started shutting down the ADB server. r=jdescottes In the genuine adb binary, when it received 'host:kill' command, it exits the server process soon [1]. Whereas, in our mock adb.py which is based on SocketServer.TCPServer in python, when we call SocketServer.TCPServer.shutdown() in the case of 'kill-server' command, the server process doesn't exit soon since the shutdown() function just sets a flag [2] and serve_forever() polls it [3] every |poll_interval| seconds, |poll_interval| is 0.5 seconds by default. Thus it's possible that new incoming requests are processed during polling. This is the real cause of the race condition that the adb server still keeps alive when 'adb kill-server' finished. So we don't need to the workaround for the race condition. [1] https://android.googlesource.com/platform/system/core/+/4039051d6ddb02324204930fb86d9d0fe405b3fb/adb/adb.cpp#1049 [2] https://github.com/python/cpython/blob/65b5ef02ec1f44e3a19b689a1ecf73d01c82161b/Lib/socketserver.py#L248 [3] https://docs.python.org/2/library/socketserver.html#SocketServer.BaseServer.serve_forever Differential Revision: https://phabricator.services.mozilla.com/D3169
147066d870a2457ca7bc1bb870e99783290526db: Bug 1481699 - Send back 'OKAY' to the client when the adb server received 'kill-server' command. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 13 Aug 2018 06:08:34 +0900 - rev 828759
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1481699 - Send back 'OKAY' to the client when the adb server received 'kill-server' command. r=jdescottes Because the genuine adb binary does it [1]. And doing it before shutdown thread is created to make sure it's sent to the client. [1] https://android.googlesource.com/platform/system/core/+/4039051d6ddb02324204930fb86d9d0fe405b3fb/adb/adb.cpp#1055 Differential Revision: https://phabricator.services.mozilla.com/D3168
671ad07b1645783c470c7417ab6e8cee4c7ccdb0: Bug 1481699 - Rename ADBServer to ADBRequestHandler. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 13 Aug 2018 06:08:33 +0900 - rev 828758
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1481699 - Rename ADBServer to ADBRequestHandler. r=jdescottes Since it's actually a child of SocketServer.BaseRequestHandler. Differential Revision: https://phabricator.services.mozilla.com/D3167
b7941dfa029aa597b9a1e165bceb10c418f00c7b: Bug 1482090 - Instanciate Debugger API in the same global as DevTools modules. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 13 Aug 2018 12:47:40 +0000 - rev 828743
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1482090 - Instanciate Debugger API in the same global as DevTools modules. r=jdescottes MozReview-Commit-ID: LS6t5CFSVom Differential Revision: https://phabricator.services.mozilla.com/D3006
f4bbda249beed3143907a74c0683c87c9a9a692b: Bug 1477598 - Part 4: Add a listener to detect updating the extensions. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 10 Aug 2018 17:04:32 +0900 - rev 828697
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1477598 - Part 4: Add a listener to detect updating the extensions. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3090
7e20f49730d2f249fa382479ec2a58f33bf91373: Bug 1477598 - Part 3: Implement inspection action. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 10 Aug 2018 16:40:46 +0900 - rev 828696
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1477598 - Part 3: Implement inspection action. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3087
72e1e5b24aaa8de32c254d19b68b70412414819d: Bug 1477598 - Part 2: Implement UI for extensions. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 10 Aug 2018 16:04:47 +0900 - rev 828695
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1477598 - Part 2: Implement UI for extensions. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3084
a6ccfdee5d73e4acb85fdbfee7d78007ef659b82: Bug 1477598 - Part 1: Implement a mechanism to dispatch extensions. r=jdescottes
Daisuke Akatsuka <dakatsuka@mozilla.com> - Fri, 10 Aug 2018 15:56:05 +0900 - rev 828694
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1477598 - Part 1: Implement a mechanism to dispatch extensions. r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D3083
cdf012ff7ba6081ad4fd170498ea84f64c75f7f2: Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes draft
Gabriel Luong <gabriel.luong@gmail.com> - Sat, 11 Aug 2018 16:17:29 -0400 - rev 828623
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1467572 - Part 18: Show an onboarding tooltip for the setting menu button in RDM. r=jdescottes Design https://mozilla.invisionapp.com/d/main#/console/12408235/300479943/preview MozReview-Commit-ID: 8EjwUFA4cHn
32ad5fef292ac00aaf5049c4ceceb5d93f173809: Bug 1481691 - Unpack files only if the devtools-adb-extension versionis mismatch or there are no unpacked files. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:57:21 +0900 - rev 828535
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Unpack files only if the devtools-adb-extension versionis mismatch or there are no unpacked files. r=jdescottes getManifestFromUnpacked() and isUnpacked() are mostly the same as they are in binary-manager.js [1] in the adbhelper addon. A big difference is that the manifest.json copied from the extension is the manifest.json for the devtools-adb-extension itself, not manifest.json(s) in a subdirectory for each platforms (e.g. linux/manifest.json). Due to the verion check in each xpcshell test needs to use a different version for the test extension, otherwise subsequent tests will use unpacked files in the first test case, thus the ADB mock won't be used at all. [1] https://github.com/mozilla/adbhelper/blob/0821424b6b895645560089a134054b35b6649ff8/binary-manager.js
4c351951fd428b1a57297e261ee0de06ea86a643: Bug 1481691 - Rename extractBinary to extractFiles and make it return a boolean instead of path string. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828534
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Rename extractBinary to extractFiles and make it return a boolean instead of path string. r=jdescottes In the next patch, we will extract manifest.json in the extension into the profile directory. And returning a boolean will make getFileForBinary() simple with the extension version check which will be also introduced in the next patch.
e73c07a618a7b130e65601ba4cc1507a9f77616d: Bug 1481691 - Drop |sync| argument from kill() and stop(). r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828533
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Drop |sync| argument from kill() and stop(). r=jdescottes We've been using them as synchrous mode only.
70b0f635cc4d871e36a01bb6e5c328f77239e572: Bug 1481691 - Use Promise instead of PromiseUtils. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828532
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Use Promise instead of PromiseUtils. r=jdescottes
fa083919718a87778ac4a8507ffd41c103861ec8: Bug 1481691 - Drop code for FirefoxOS. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828530
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Drop code for FirefoxOS. r=jdescottes
0d6fb76b026b0fe301683a5b2b96b82fe4fb7e46: Bug 1481691 - Drop code and comments for older versions of Firefox. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828529
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Drop code and comments for older versions of Firefox. r=jdescottes
59dae312f47b3d0fdba8ea29225299023ca4532f: Bug 1481691 - Replace console.log and console.debug with dumpn. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:21 +0900 - rev 828528
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Replace console.log and console.debug with dumpn. r=jdescottes
0d9b9292981566dfeff99bcb4b5a00a61b47136f: Bug 1481691 - Add a preference for the devtools-adb-extension id. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 10 Aug 2018 16:32:20 +0900 - rev 828527
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481691 - Add a preference for the devtools-adb-extension id. r=jdescottes
e4db2e54dad664d4316b82e15c17608af3575b27: Bug 1469054 - Skip some test cases in test_adb.js on Windows. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 15:43:44 +0900 - rev 828078
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Skip some test cases in test_adb.js on Windows. r=jdescottes On Windows testNoTargetBinaries fails since we don't remove extracted binaries in the profile directory when the extension is removed. The original adbhelper addon doesn't remove them either, so this problem has been underlying originally. We will fix it in a later bug. Also on Windows, testStartAndStop and testTrackDevices fail. That's because, I guess, the adb mock (adb.py) isn't launched properly. I will handle it once after I take a windows laptop back. MozReview-Commit-ID: 15wo1S0pX37
d241949106e88ef4313aa66e069ee94660bb27ee: Bug 1469054 - Make check() in adb-running-checker fail if a certain period of time elapsed. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 15:43:44 +0900 - rev 828077
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Make check() in adb-running-checker fail if a certain period of time elapsed. r=jdescottes On MacOSX connecting to a port which is not started listening gets stuck (bug 1481963), to avoid the stuck, we make forcibly the function fail. MozReview-Commit-ID: COVplVPx3vA
6a40296e9ca90d09af8135d3e82442bc7d57791d: Bug 1469054 - Make sure the ADB server is ready to listen from clients when we call adb.start(). r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 15:43:39 +0900 - rev 828076
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Make sure the ADB server is ready to listen from clients when we call adb.start(). r=jdescottes There is a race condition that when we adb.start() finishes, i.e. the ADB server is launched, the ADB server is not ready to listen from clients yet. To avoid this race condition in adb.start() function, we do wait until the server gets ready. MozReview-Commit-ID: EfSLA9uvhI9
610d28f29e34288cf1019673d49860f394a248d0: Bug 1469054 - Make sure that the adb.py sends all data. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:57 +0900 - rev 828075
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Make sure that the adb.py sends all data. r=jdescottes It seems that, on chaos mode, we can't receive whole data set at once, i.e. sending data will be split into some chunks, so the adb mock should check the sent data length and if there remains still data which has to be sent, we have to continue sending the rest of the data. MozReview-Commit-ID: 5jeEH8KpNNW
41da6d248ce3b76937b5e334ad7c02fb3d86d427: Bug 1469054 - ESLint: lint fix for adb-device.js. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828074
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: lint fix for adb-device.js. r=jdescottes MozReview-Commit-ID: AYvHsiirrtt
7651e7eeb149e120ae92dc8e21b81209a4236527: Bug 1469054 - Adapt device.js in the adbhelper addon into devtools. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828073
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Adapt device.js in the adbhelper addon into devtools. r=jdescottes The diff; --- /home/hiro/adbhelper/device.js 2018-07-19 06:18:41.613011481 +0900 +++ devtools/shared/adb/adb-device.js 2018-08-06 10:18:38.808496752 +0900 @@ -4,9 +4,7 @@ "use strict"; -const { ConnectionManager } = - require("./devtools-require")("devtools/shared/client/connection-manager"); -const adb = require("./adb"); +const { ADB } = require("devtools/shared/adb/adb"); /** * A Device instance is created and registered with the Devices module whenever @@ -21,34 +19,18 @@ function Device(id) { } Device.prototype = { - /** - * DEPRECATED: This is specific to how we connect to Firefox OS. Use cases - * that interact with other kinds of devices should likely use the more - * general |forwardPort| method directly. - */ - connect(remotePort) { - let port = ConnectionManager.getFreeTCPPort(); - let local = "tcp:" + port; - let remote = "localfilesystem:/data/local/debugger-socket"; - if (remotePort) { - remote = "tcp:" + remotePort; - } - return adb.forwardPort(local, remote) - .then(() => port); - }, - type: "adb", - shell: adb.shell.bind(adb), - forwardPort: adb.forwardPort.bind(adb), - push: adb.push.bind(adb), - pull: adb.pull.bind(adb), - reboot: adb.reboot.bind(adb), - rebootRecovery: adb.rebootRecovery.bind(adb), - rebootBootloader: adb.rebootBootloader.bind(adb), + shell: ADB.shell.bind(ADB), + forwardPort: ADB.forwardPort.bind(ADB), + push: ADB.push.bind(ADB), + pull: ADB.pull.bind(ADB), + reboot: ADB.reboot.bind(ADB), + rebootRecovery: ADB.rebootRecovery.bind(ADB), + rebootBootloader: ADB.rebootBootloader.bind(ADB), isRoot() { - return adb.shell("id").then(stdout => { + return ADB.shell("id").then(stdout => { if (stdout) { let uid = stdout.match(/uid=(\d+)/)[1]; return uid == "0"; @@ -58,7 +40,7 @@ Device.prototype = { }, summonRoot() { - return adb.root(); + return ADB.root(); }, getModel() { MozReview-Commit-ID: FlbKPm6VDs5
081d9ef214de6329208594aa96889b1015c8da26: Bug 1469054 - ESLint: lint fix for adb-scanner.js. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828072
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: lint fix for adb-scanner.js. r=jdescottes MozReview-Commit-ID: 9riT60wVuCe
1de410c3efb3d9888725864789687f05232a51c9: Bug 1469054 - Adapt scanner.js in the adbhelper addon into devtools. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828071
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Adapt scanner.js in the adbhelper addon into devtools. r=jdescottes A big difference between them is ADBScanner object itself is exported instead of exporting unregister() method, since in the new about:debugging we have a toggle button to install the new adbhelper extension, so that we should observe uninstalling/installing the new adbhelper extension there, which means when the adbhelper is removed we have to unregister this scanner there. The diff; --- /home/hiro/adbhelper/scanner.js 2018-08-06 09:47:24.199685034 +0900 +++ devtools/shared/adb/adb-scanner.js 2018-08-06 11:52:05.423496900 +0900 @@ -2,19 +2,17 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -const { Cu } = require("chrome"); -const EventEmitter = - require("./devtools-require")("devtools/shared/event-emitter"); -const { Task } = Cu.import("resource://gre/modules/Task.jsm", {}); -const unload = require("./unload"); +"use strict"; + +const EventEmitter = require("devtools/shared/event-emitter"); const { ConnectionManager } = - require("./devtools-require")("devtools/shared/client/connection-manager"); + require("devtools/shared/client/connection-manager"); const { Devices } = - require("./devtools-import")("resource://devtools/shared/apps/Devices.jsm"); -const Runtimes = - require("./devtools-require")("devtools/client/webide/modules/runtimes"); + require("devtools/shared/apps/Devices.jsm"); +const { RuntimeTypes } = + require("devtools/client/webide/modules/runtime-types"); -let Scanner = { +const ADBScanner = { _runtimes: [], @@ -41,9 +39,9 @@ let Scanner = { return this._updatingPromise; } this._runtimes = []; - let promises = []; - for (let id of Devices.available()) { - let device = Devices.getByName(id); + const promises = []; + for (const id of Devices.available()) { + const device = Devices.getByName(id); promises.push(this._detectRuntimes(device)); } this._updatingPromise = Promise.all(promises); @@ -56,13 +54,13 @@ let Scanner = { return this._updatingPromise; }, - _detectRuntimes: Task.async(function* (device) { - let model = yield device.getModel(); - let detectedRuntimes = yield FirefoxOSRuntime.detect(device, model); + _detectRuntimes: async function(device) { + const model = await device.getModel(); + let detectedRuntimes = await FirefoxOSRuntime.detect(device, model); this._runtimes.push(...detectedRuntimes); - detectedRuntimes = yield FirefoxOnAndroidRuntime.detect(device, model); + detectedRuntimes = await FirefoxOnAndroidRuntime.detect(device, model); this._runtimes.push(...detectedRuntimes); - }), + }, scan() { return this._updateRuntimes(); @@ -74,7 +72,7 @@ let Scanner = { }; -EventEmitter.decorate(Scanner); +EventEmitter.decorate(ADBScanner); function Runtime(device, model, socketPath) { this.device = device; @@ -83,15 +81,15 @@ function Runtime(device, model, socketPa } Runtime.prototype = { - type: Runtimes.RuntimeTypes.USB, + type: RuntimeTypes.USB, connect(connection) { - let port = ConnectionManager.getFreeTCPPort(); - let local = "tcp:" + port; + const port = ConnectionManager.getFreeTCPPort(); + const local = "tcp:" + port; let remote; if (this._socketPath.startsWith("@")) { - remote = "localabstract:" + this._socketPath.substring(1); + remote = "localabstract:" + this._socketPath.substring(1); } else { - remote = "localfilesystem:" + this._socketPath; + remote = "localfilesystem:" + this._socketPath; } return this.device.forwardPort(local, remote).then(() => { connection.host = "localhost"; @@ -108,26 +106,26 @@ function FirefoxOSRuntime(device, model) Runtime.call(this, device, model, "/data/local/debugger-socket"); } -FirefoxOSRuntime.detect = Task.async(function* (device, model) { - let runtimes = []; - let query = "test -f /system/b2g/b2g; echo $?"; - let b2gExists = yield device.shell(query); +FirefoxOSRuntime.detect = async function(device, model) { + const runtimes = []; + const query = "test -f /system/b2g/b2g; echo $?"; + let b2gExists = await device.shell(query); // XXX: Sometimes we get an empty response back. Likely a bug in our shell // code in this add-on. // There are also some Android devices that do not have `test` installed. for (let attempts = 3; attempts > 0; attempts--) { - b2gExists = yield device.shell(query); + b2gExists = await device.shell(query); if (b2gExists.length == 3) { break; } } if (b2gExists === "0\r\n") { - let runtime = new FirefoxOSRuntime(device, model); + const runtime = new FirefoxOSRuntime(device, model); console.log("Found " + runtime.name); runtimes.push(runtime); } return runtimes; -}); +}; FirefoxOSRuntime.prototype = Object.create(Runtime.prototype); @@ -142,28 +140,29 @@ function FirefoxOnAndroidRuntime(device, } // This requires Unix socket support from Firefox for Android (35+) -FirefoxOnAndroidRuntime.detect = Task.async(function* (device, model) { - let runtimes = []; +FirefoxOnAndroidRuntime.detect = async function(device, model) { + const runtimes = []; // A matching entry looks like: - // 00000000: 00000002 00000000 00010000 0001 01 6551588 /data/data/org.mozilla.fennec/firefox-debugger-socket - let query = "cat /proc/net/unix"; - let rawSocketInfo = yield device.shell(query); + // 00000000: 00000002 00000000 00010000 0001 01 6551588 + // /data/data/org.mozilla.fennec/firefox-debugger-socket + const query = "cat /proc/net/unix"; + const rawSocketInfo = await device.shell(query); let socketInfos = rawSocketInfo.split(/\r?\n/); // Filter to lines with "firefox-debugger-socket" socketInfos = socketInfos.filter(l => l.includes("firefox-debugger-socket")); // It's possible to have multiple lines with the same path, so de-dupe them - let socketPaths = new Set(); - for (let socketInfo of socketInfos) { - let socketPath = socketInfo.split(" ").pop(); + const socketPaths = new Set(); + for (const socketInfo of socketInfos) { + const socketPath = socketInfo.split(" ").pop(); socketPaths.add(socketPath); } - for (let socketPath of socketPaths) { - let runtime = new FirefoxOnAndroidRuntime(device, model, socketPath); + for (const socketPath of socketPaths) { + const runtime = new FirefoxOnAndroidRuntime(device, model, socketPath); console.log("Found " + runtime.name); runtimes.push(runtime); } return runtimes; -}); +}; FirefoxOnAndroidRuntime.prototype = Object.create(Runtime.prototype); @@ -201,21 +200,4 @@ Object.defineProperty(FirefoxOnAndroidRu } }); -exports.register = function() { - // Only register our |Scanner| if the API exists - if (Runtimes && Runtimes.RuntimeScanners) { - // There may be an older ADB scanner registered by default - // If so, we must disable it to avoid duplicate runtimes - if (Runtimes.DeprecatedAdbScanner) { - Runtimes.RuntimeScanners.remove(Runtimes.DeprecatedAdbScanner); - unload(() => { - Runtimes.RuntimeScanners.add(Runtimes.DeprecatedAdbScanner); - }); - } - // Add our scanner - Runtimes.RuntimeScanners.add(Scanner); - unload(() => { - Runtimes.RuntimeScanners.remove(Scanner); - }); - } -}; +exports.ADBScanner = ADBScanner; MozReview-Commit-ID: 2PC1ochp19E
bee6212d1727d7d23f6ae4272fb22ccbe1437298: Bug 1469054 - Split Runtime.RuntimeTypes into a new file to import the RuntimeTypes in a file which is importing runtimes.js. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828070
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Split Runtime.RuntimeTypes into a new file to import the RuntimeTypes in a file which is importing runtimes.js. r=jdescottes MozReview-Commit-ID: LVfyW3aaSxU
3151ffa250c2bc1f9d0ddde322858a83e02e3885: Bug 1469054 - Add async annotation for adb.start(). r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828069
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - Add async annotation for adb.start(). r=jdescottes MozReview-Commit-ID: 534q7l33l7o
b497d03cf428df7a1c25404926173363d0fc0305: Bug 1469054 - ESLint: Add no-fallthrough annotation. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828068
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: Add no-fallthrough annotation. r=jdescottes MozReview-Commit-ID: 5tBviheMTTk
13135cde0d585be8dbe5be0de26610964f3921df: Bug 1469054 - ESLint: Use integer for the radix on parseInt. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828067
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: Use integer for the radix on parseInt. r=jdescottes I am not sure this had caused real issue though. MozReview-Commit-ID: ISSSJCYcpAm
888d90ad5f9349bb923f60afb104d785d9111b81: Bug 1469054 - ESLint: Drop function name. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:56 +0900 - rev 828066
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: Drop function name. r=jdescottes MozReview-Commit-ID: LsUzDI0fkVc
ce992f3fd9b038ef15e13442580a59c03e16b5c1: Bug 1469054 - ESLint: Drop 'a' prefix from argument names. r=jdescottes
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 14:27:55 +0900 - rev 828065
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1469054 - ESLint: Drop 'a' prefix from argument names. r=jdescottes MozReview-Commit-ID: J3v5NKglA2B