searching for reviewer(glandium)
a8facd78c24282a792310cb154aae29c531a116a: Bug 1480595 - make TimeStamp compilable for AArch64 Windows; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Thu, 23 Aug 2018 12:54:29 -0400 - rev 831087
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1480595 - make TimeStamp compilable for AArch64 Windows; r=glandium We don't have to check whether AArch64 systems have a stable counter; they are all specified to do so in the architecture reference manual.
600a005d36137445d8bb3af5f3ff77bd53a9cb81: Bug 1421501 - build integration for vendored msgpack r=glandium
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 831017
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1421501 - build integration for vendored msgpack r=glandium MozReview-Commit-ID: 4AKDbOU4aWx
7381597721d21d982d58cde35194fb89ab967773: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r=glandium
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 831016
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r=glandium MozReview-Commit-ID: 9vzQOuszf3p
d6acf727d697fb47deeee6e99dacede7f450d7ca: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830990
Push 118867 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 21:15:33 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
647006410891705aecd91b1a097efb818d97be13: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830989
Push 118867 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 21:15:33 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
820ea20ac530242d6799e209f601364221847329: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830980
Push 118863 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 14:20:59 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
87d1beb9154c58819cc4f9b126284641b07d7792: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830979
Push 118863 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 14:20:59 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
63e4b76a672ea1f48210e4483c12d6249d8b75dc: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830975
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
03c839d1bb85ccd8a98844e31892f3f51abfd4da: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830974
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
6d30bac7078b1c9eb2e16ed7702204b8d41fc43e: Bug 1483761 - Enable clang's -Wtautological-overlap-compare warning. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Tue, 14 Aug 2018 22:39:03 -0700 - rev 830966
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1483761 - Enable clang's -Wtautological-overlap-compare warning. r=glandium -Wtautological-overlap-compare is an opt-in warning added in clang 3.5. It warns about overlapping comparisons that are always true or false, such as: if (x > 4 || x < 10) {} // warning! always true int b = x < 2 && x > 5; // warning! always false return x > 4 || x < 10; // warning! always true https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-overlap-compare There are currently no -Wtautological-overlap-compare warnings in mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D3477
f41a14a1b4de976d7a36094644195847007f9b35: Bug 1483761 - Enable clang's -Wshadow-field-in-constructor warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Mon, 20 Aug 2018 10:10:57 -0700 - rev 830965
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1483761 - Enable clang's -Wshadow-field-in-constructor warnings. r=glandium This opt-in warning catches bugs where a constructor modifies a constructor parameter that shadows member variable name. The code probably intended to change the member variable value, not the paramter. There are currently no -Wshadow-field-in-constructor warnings in mozilla-central. https://clang.llvm.org/docs/DiagnosticsReference.html#wshadow-field-in-constructor-modified Differential Revision: https://phabricator.services.mozilla.com/D3822
36f6bab3d669cef41b9b2089e9081af388ce1c2b: Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Tue, 14 Aug 2018 23:03:52 -0700 - rev 830964
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium -Wfloat-overflow-conversion detects when a constant floating point value is converted to an integer type and will overflow the target type. https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-overflow-conversion -Wfloat-zero-conversion detects when a non-zero floating point value is converted to a zero integer value. https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-zero-conversion There are currently no -Wfloat-overlap-conversion warnings in mozilla-central. There is one -Wfloat-zero-conversion warning in a webrtc test. It doesn't block enabling this check because the webrtc tests are not compiled with warnings-as-errors. media/webrtc/trunk/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc:255:54 [-Wfloat-zero-conversion] implicit conversion from 'const float' to 'int' changes non-zero value from 0.045000002 to 0 We can't enable all -Wfloat-conversion warnings (for any implicit conversion of a floating-point number into an integer) because there are currently over 1400 warnings. I spot checked a few of these -Wfloat-conversion warnings. I didn't find any obvious bugs, but there is some suspicious code, such as implicit conversions of floats to bools. Differential Revision: https://phabricator.services.mozilla.com/D3476
f9a890fba236bdcd13e72cbede68c9d6755f3b78: Bug 1483761 - Enable clang's -Wc++2a-compat warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Wed, 15 Aug 2018 10:02:07 -0700 - rev 830963
Push 118861 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 11:42:47 +0000
Bug 1483761 - Enable clang's -Wc++2a-compat warnings. r=glandium Warn about C++ constructs whose meaning change in C++2a. https://clang.llvm.org/docs/DiagnosticsReference.html#wc-2a-compat So far the only -Wc++2a-compat check that I know of is for valid pre-C++2a code that inadvertently parses as C++2a's new <=> "spaceship" comparison operator. `f<&A::operator<=>();` is an example of a warning reported for a real project on GitHub. That code can be rewritten as `f< &operator<= >();`. There are currently no -Wc++2a-compat warnings in mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D3478
f3453ca890f9f72a0cc2cd64ea76d180fb5053ad: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830926
Push 118860 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 10:44:40 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
21d2cf5cdfea9fd8aeb3e8bdca33fab445b1c17e: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830925
Push 118860 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 10:44:40 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
577ffed9f102439db47afebcef95bbaaa2e04c93: Bug 1483835: Default to clang-cl and lld-link in local Windows builds. r=glandium
David Major <dmajor@mozilla.com> - Tue, 21 Aug 2018 11:30:16 -0400 - rev 830555
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1483835: Default to clang-cl and lld-link in local Windows builds. r=glandium
1b533762e9cb4faf2b1c2d9fa58418c71dd9729d: Bug 1483835: Default to clang-cl and lld-link in local Windows builds. r=glandium
David Major <dmajor@mozilla.com> - Tue, 21 Aug 2018 09:34:33 -0400 - rev 830543
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1483835: Default to clang-cl and lld-link in local Windows builds. r=glandium
e7769815af8a4a23eafb3afb73516db3a0ff1a2e: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830536
Push 118846 by bmo:rhelmer@mozilla.com at Wed, 22 Aug 2018 05:24:26 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
8423d5a59a894c7fd18cf4130ec5050887ae09d0: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830535
Push 118846 by bmo:rhelmer@mozilla.com at Wed, 22 Aug 2018 05:24:26 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
00d2f22172280f51eb1a2734a1847f8955782b78: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 830528
Push 118840 by bmo:rhelmer@mozilla.com at Tue, 21 Aug 2018 19:27:12 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
4187693dbc0deea22df4b442e6ad91291781e073: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 830527
Push 118840 by bmo:rhelmer@mozilla.com at Tue, 21 Aug 2018 19:27:12 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
542197624ba293765e206322c3e828242d2fd875: Bug 1481978 - Change IPC CloseSuperfluousFds to prevent accidentally heap-allocating closures. r=glandium
Jed Davis <jld@mozilla.com> - Wed, 15 Aug 2018 19:08:40 -0600 - rev 829602
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1481978 - Change IPC CloseSuperfluousFds to prevent accidentally heap-allocating closures. r=glandium Closures are nice but -- as pointed out in bug 1481978 comment #2 -- it's a footgun to take a std::function argument in a context where heap allocation isn't safe. Fortunately, non-capturing closures convert to C function pointers, so a C-style interface with a void* context can still be relatively ergonomic.
e7b659d978e1a945a3de7859d6196e48d9422557: Bug 1479878 Add a --skip-revert option to build-clang.py r=glandium
Tom Ritter <tom@mozilla.com> - Wed, 15 Aug 2018 06:13:14 +0000 - rev 829429
Push 118781 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 02:46:06 +0000
Bug 1479878 Add a --skip-revert option to build-clang.py r=glandium Differential Revision: https://phabricator.services.mozilla.com/D2580
c9d65d413d0660beb01bea01c9eff47b00b0705d: Bug 1476147 - Use path.isfile() instead of patch.exists() in which(). r=glandium
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Aug 2018 06:15:57 +0000 - rev 829421
Push 118781 by ktomlinson@mozilla.com at Thu, 16 Aug 2018 02:46:06 +0000
Bug 1476147 - Use path.isfile() instead of patch.exists() in which(). r=glandium This excludes directories, and returns true only if it's an executable file. Differential Revision: https://phabricator.services.mozilla.com/D3366
1d19aafac723d10e67d9027cd5f819256b0b9097: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 829385
Push 118772 by bmo:rhelmer@mozilla.com at Wed, 15 Aug 2018 16:37:48 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
cdf6e8e589cf352672b049a504724049dabf3542: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 829384
Push 118772 by bmo:rhelmer@mozilla.com at Wed, 15 Aug 2018 16:37:48 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
f4f927b56bd863a521b4796a7300857a1913ab12: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 828484
Push 118682 by bmo:rhelmer@mozilla.com at Sat, 11 Aug 2018 17:30:57 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
4a3d469f29328355b95b94354e87443e92342e2a: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 828483
Push 118682 by bmo:rhelmer@mozilla.com at Sat, 11 Aug 2018 17:30:57 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
3ac8d850f0faebbdf39d679c28a387277d0d7e8a: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 828478
Push 118681 by bmo:rhelmer@mozilla.com at Sat, 11 Aug 2018 00:23:33 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
5bd801f1a7546e036308ed22862d14088f413a46: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 828477
Push 118681 by bmo:rhelmer@mozilla.com at Sat, 11 Aug 2018 00:23:33 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r?glandium MozReview-Commit-ID: 9vzQOuszf3p
3eedd03d342313ca9c68c1003a9b3498396f2fc1: Bug 1421501 - build integration for vendored msgpack r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 828211
Push 118648 by bmo:rhelmer@mozilla.com at Fri, 10 Aug 2018 06:19:51 +0000
Bug 1421501 - build integration for vendored msgpack r?glandium MozReview-Commit-ID: 4AKDbOU4aWx
128d4fc69af01a9836f5e6adc4c45278511f0a83: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c/commit/2c4f2b890ef1546fc022d270d11e657f6fc8022f r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 828210
Push 118648 by bmo:rhelmer@mozilla.com at Fri, 10 Aug 2018 06:19:51 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c/commit/2c4f2b890ef1546fc022d270d11e657f6fc8022f r?glandium MozReview-Commit-ID: 9vzQOuszf3p
e34be89b405912d1e9e71e04baffa8a12af52558: Bug 1421501 - vendor msgpack 3.0.1 r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 828146
Push 118646 by bmo:rhelmer@mozilla.com at Fri, 10 Aug 2018 05:54:47 +0000
Bug 1421501 - vendor msgpack 3.0.1 r?glandium MozReview-Commit-ID: 9vzQOuszf3p
e6005ad883098b389cfacaf2ac85d85ced0bbbc1: Bug 1479599 Recognize webextensions in packager r=glandium
Andrew Swan <aswan@mozilla.com> - Tue, 31 Jul 2018 21:51:02 -0700 - rev 828100
Push 118627 by bmo:jhirsch@mozilla.com at Thu, 09 Aug 2018 21:47:59 +0000
Bug 1479599 Recognize webextensions in packager r=glandium MozReview-Commit-ID: KethvfCTf6G
3708d61a50e2ddfb5a01c2e52e4ddb7bbd9020d3: Bug 1421501 - vendor msgpack 3.0.1 r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 828044
Push 118620 by bmo:rhelmer@mozilla.com at Thu, 09 Aug 2018 19:04:41 +0000
Bug 1421501 - vendor msgpack 3.0.1 r?glandium MozReview-Commit-ID: 9vzQOuszf3p
20bf59c86755a04bd756728d9169589d585ac393: Bug 1481097 - mfbt: Assert we're compiling with gcc 6.1 or later. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Sat, 21 Jul 2018 23:45:41 -0700 - rev 827502
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1481097 - mfbt: Assert we're compiling with gcc 6.1 or later. r=glandium Firefox currently requires gcc 6.1 or later (as of bug 1444274). MozReview-Commit-ID: CaJwpUgntxn
fb78f8aa0fa19a2d4f8d9b9aa3ccfe49b9790254: Bug 1421501 - vendor msgpack 3.0.1 r?glandium draft
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 827392
Push 118527 by bmo:rhelmer@mozilla.com at Wed, 08 Aug 2018 00:15:40 +0000
Bug 1421501 - vendor msgpack 3.0.1 r?glandium MozReview-Commit-ID: 9vzQOuszf3p
62cb37da55c3812b166205ca7c0de2878a6ccab7: Bug 1481097 - mfbt: Assert we're compiling with gcc 6.1 or later. r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 21 Jul 2018 23:45:41 -0700 - rev 826868
Push 118399 by cpeterson@mozilla.com at Sun, 05 Aug 2018 22:49:36 +0000
Bug 1481097 - mfbt: Assert we're compiling with gcc 6.1 or later. r?glandium Firefox currently requires gcc 6.1 or later (as of bug 1444274). MozReview-Commit-ID: CaJwpUgntxn
c6d07c3eec16e02846db3abadd7844c4fa4c4c13: Bug 1480553 - part 3 - add mappings for aarch64 in Windows configure paths; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Thu, 02 Aug 2018 21:40:40 -0400 - rev 826225
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1480553 - part 3 - add mappings for aarch64 in Windows configure paths; r=glandium We need to add mappings for target.cpu to MSVC's arm64 name for determining various paths, and we need to add an extra case to get_vc_paths so the compiler can find all the necessary DLLs.
d87760979a3eccce946f59ade6a145251c04a8ba: Bug 1480553 - part 2 - add a case for aarch64* when setting MIDL_FLAGS; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Thu, 02 Aug 2018 21:40:40 -0400 - rev 826224
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1480553 - part 2 - add a case for aarch64* when setting MIDL_FLAGS; r=glandium
4dbeee9501bdd367b73d353075a98521015238a4: Bug 1480553 - part 1 - add Windows-specific aarch64 macro detection; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Thu, 02 Aug 2018 21:40:40 -0400 - rev 826223
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1480553 - part 1 - add Windows-specific aarch64 macro detection; r=glandium MSVC doesn't define __aarch64__, but uses its own symbol instead.
e1f22d19eb6933f2ffc3dc9b78b0cf66d8648474: Bug 1444141 - part 4 - make the JS engine depend on Rust; r=chmanchester,glandium,jorendorff
Nathan Froyd <froydnj@mozilla.com> - Thu, 02 Aug 2018 11:00:21 -0500 - rev 825942
Push 118215 by bmo:mtigley@mozilla.com at Thu, 02 Aug 2018 18:26:57 +0000
Bug 1444141 - part 4 - make the JS engine depend on Rust; r=chmanchester,glandium,jorendorff The Rust dependency in Firefox has been limited to Firefox builds by virtue of having the Rust check in a Firefox-specific location, toolkit/moz.configure. For JS to start depending on Rust, we need to move that check to a location where a standalone JS engine build will pick up the Rust check.
0c617268ad37a5a89f7134956095c9037fa85b21: Bug 1480315 - Fix coredump caused by getenv. r=glandium
Changqing Li <changqing.li@windriver.com> - Wed, 01 Aug 2018 20:49:00 +0300 - rev 825888
Push 118196 by bmo:dharvey@mozilla.com at Thu, 02 Aug 2018 15:27:37 +0000
Bug 1480315 - Fix coredump caused by getenv. r=glandium
fbca460d249abf40f8aa9ec1403196823911f7db: Bug 1478561 - Bump OOM hook rustc version check to check for greater than 1.30.0-alpha. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Mon, 30 Jul 2018 16:46:20 -0700 - rev 825303
Push 118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1478561 - Bump OOM hook rustc version check to check for greater than 1.30.0-alpha. r=glandium MozReview-Commit-ID: ESiK7tqHMT0
c43d2dbaf59e73747f25a2d8c5bcd68c28e5cadf: Bug 1451891 - Fix race conditions in __wrap_dlerror. r=glandium a=pascalc draft
Jim Chen <nchen@mozilla.com> - Wed, 25 Jul 2018 13:59:30 -0400 - rev 825026
Push 118017 by bmo:edilee@mozilla.com at Tue, 31 Jul 2018 21:53:17 +0000
Bug 1451891 - Fix race conditions in __wrap_dlerror. r=glandium a=pascalc __wrap_dlerror uses a single pointer for all threads, which means one thread could get the dlerror result from another thread. Normally this wouldn't cause crashes. However, because dlerror results come from a per-thread buffer, if a thread exits and our saved dlerror result came from that thread, the saved pointer could then refer to invalid memory. The proper way to fix this is to use TLS and have a per-thread pointer for __wrap_dlerror. However, instead of using up a TLS slot, this patch keeps the single pointer for custom messages, and fallback to per-thread dlerror call for system messages. While the race condition still exists, I think the risk is acceptable. Even when races occur, they should no longer cause crashes. MozReview-Commit-ID: 4hGksidjiVz
831832b245ac408c901cb41e4076fb70509a6077: Bug 1478560 - Fix the compiling error of the struct nsXPTCVariant. r=glandium
qiaopengcheng <qiaopengcheng-hf@loongson.cn> - Fri, 27 Jul 2018 17:28:25 +0800 - rev 824536
Push 117936 by nnethercote@mozilla.com at Tue, 31 Jul 2018 06:49:53 +0000
Bug 1478560 - Fix the compiling error of the struct nsXPTCVariant. r=glandium
c95b51e4a9966c0668dc0f0424c286c6b981f4ca: Bug 1451891 - Fix race conditions in __wrap_dlerror; r=glandium
Jim Chen <nchen@mozilla.com> - Wed, 25 Jul 2018 13:59:30 -0400 - rev 823277
Push 117637 by felipc@gmail.com at Fri, 27 Jul 2018 01:14:51 +0000
Bug 1451891 - Fix race conditions in __wrap_dlerror; r=glandium __wrap_dlerror uses a single pointer for all threads, which means one thread could get the dlerror result from another thread. Normally this wouldn't cause crashes. However, because dlerror results come from a per-thread buffer, if a thread exits and our saved dlerror result came from that thread, the saved pointer could then refer to invalid memory. The proper way to fix this is to use TLS and have a per-thread pointer for __wrap_dlerror. However, instead of using up a TLS slot, this patch keeps the single pointer for custom messages, and fallback to per-thread dlerror call for system messages. While the race condition still exists, I think the risk is acceptable. Even when races occur, they should no longer cause crashes. MozReview-Commit-ID: 4hGksidjiVz
4a8c948386952cc801a93d60f0eee6c161bd1105: Bug 1473266 - Remove in-tree newline_if_not_empty. r=Yoric,glandium
Tooru Fujisawa <arai_a@mac.com> - Thu, 26 Jul 2018 15:24:06 +0900 - rev 823039
Push 117560 by rwood@mozilla.com at Thu, 26 Jul 2018 14:25:44 +0000
Bug 1473266 - Remove in-tree newline_if_not_empty. r=Yoric,glandium
a4bbbad45aeeb4279d1000ddfd16fab3781e809a: Bug 1451891 - Fix race conditions in __wrap_dlerror; r?glandium draft
Jim Chen <nchen@mozilla.com> - Wed, 25 Jul 2018 13:59:30 -0400 - rev 822682
Push 117443 by bmo:nchen@mozilla.com at Wed, 25 Jul 2018 18:01:42 +0000
Bug 1451891 - Fix race conditions in __wrap_dlerror; r?glandium __wrap_dlerror uses a single pointer for all threads, which means one thread could get the dlerror result from another thread. Normally this wouldn't cause crashes. However, because dlerror results come from a per-thread buffer, if a thread exits and our saved dlerror result came from that thread, the saved pointer could then refer to invalid memory. The proper way to fix this is to use TLS and have a per-thread pointer for __wrap_dlerror. However, instead of using up a TLS slot, this patch keeps the single pointer for custom messages, and fallback to per-thread dlerror call for system messages. While the race condition still exists, I think the risk is acceptable. Even when races occur, they should no longer cause crashes. MozReview-Commit-ID: 4hGksidjiVz
3d633edc1c27d1d966095b050b8da9f497df3961: Bug 1476098 - Add Google and Mozilla API keys to ASan Nightly. r=glandium
Christian Holler <choller@mozilla.com> - Sat, 21 Jul 2018 11:49:54 +0200 - rev 822461
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1476098 - Add Google and Mozilla API keys to ASan Nightly. r=glandium MozReview-Commit-ID: AAQWWiHeLB0