searching for reviewer(gerald)
b2814d1bbbd7fc10f79c32daeaf67b4c6d527e7a: Bug 1484306 Part 4 - Use FunctionTypeTraits to yield better error message if aPredicate's signature is wrong. r=gerald
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Aug 2018 17:02:58 -0700 - rev 830084
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484306 Part 4 - Use FunctionTypeTraits to yield better error message if aPredicate's signature is wrong. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D3684
75ea1b10a4372754e6c6762c1512a617654c642e: Bug 1409664 - P8. Make explicit shutdown of TaskQueue optional. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 07 Jun 2018 14:46:28 +0200 - rev 813720
Push 114985 by bschouten@mozilla.com at Tue, 03 Jul 2018 20:32:46 +0000
Bug 1409664 - P8. Make explicit shutdown of TaskQueue optional. r=gerald Summary: With this change TaskQueue no longer requires an explicit call to BeginShutdown(). The taskqueue will automatically shutdown once it's now longer referenced. Depends on D1620 Tags: #secure-revision Bug #: 1409664 Differential Revision: https://phabricator.services.mozilla.com/D1621
779fdf8781bdee1776714a49a20e7fad44045b16: Bug 1409664 - P7. Remove unused TaskQueue method. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 07 Jun 2018 14:26:11 +0200 - rev 813719
Push 114985 by bschouten@mozilla.com at Tue, 03 Jul 2018 20:32:46 +0000
Bug 1409664 - P7. Remove unused TaskQueue method. r=gerald Summary: Depends on D1619 Tags: #secure-revision Bug #: 1409664 Differential Revision: https://phabricator.services.mozilla.com/D1620
3d039520dd5abfc686a47ec447624ee4f3072156: Bug 1468241 - P1. Add MozPromise::CreateAndResolveOrReject method r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 20 Jun 2018 22:14:05 +0000 - rev 809355
Push 113651 by kgupta@mozilla.com at Thu, 21 Jun 2018 22:29:49 +0000
Bug 1468241 - P1. Add MozPromise::CreateAndResolveOrReject method r=gerald Useful when using promise chaining in combination with MozPromise::ResolveOrRejectValue parameter. MozReview-Commit-ID: F8qMh7yFnHQ Differential Revision: https://phabricator.services.mozilla.com/D1726
89621cbb333ac9adf6ae538694b37e70f1da5f88: Bug 1468268 - Refactor test cases for contain:paint. r=gerald draft
Yusuf Sermet <ysermet@mozilla.com> - Mon, 11 Jun 2018 16:59:58 -0700 - rev 806785
Push 112958 by bmo:ysermet@mozilla.com at Tue, 12 Jun 2018 00:00:29 +0000
Bug 1468268 - Refactor test cases for contain:paint. r=gerald MozReview-Commit-ID: JQReiQLjNAb
83f865afba050de072c57aee10920af07c9d8d43: Bug 1450607 - P3. Remove unused argument. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 802283
Push 111850 by bmo:tom@mozilla.com at Thu, 31 May 2018 16:41:37 +0000
Bug 1450607 - P3. Remove unused argument. r=gerald, a=RyanVM MozReview-Commit-ID: 6NU9BLJi6kl
27ec43a60a397c61b9951e1398aaeed2bcf96934: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 802282
Push 111850 by bmo:tom@mozilla.com at Thu, 31 May 2018 16:41:37 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald, a=RyanVM Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
fa1d57969fadfed1811b2a18efdd5c127f3ab893: Bug 1450607 - P1. Fix constness. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 802281
Push 111850 by bmo:tom@mozilla.com at Thu, 31 May 2018 16:41:37 +0000
Bug 1450607 - P1. Fix constness. r=gerald, a=RyanVM MozReview-Commit-ID: CeftB0qmzTf
ccf0bb5b140d41cc8f17d7bffe854d7ccee5a3b1: Bug 1450607 - P3. Remove unused argument. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 801604
Push 111693 by bmo:khudson@mozilla.com at Wed, 30 May 2018 15:07:47 +0000
Bug 1450607 - P3. Remove unused argument. r=gerald, a=RyanVM MozReview-Commit-ID: 6NU9BLJi6kl
befed261c0ec350c1420b44f752ab603c757147e: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 801603
Push 111693 by bmo:khudson@mozilla.com at Wed, 30 May 2018 15:07:47 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald, a=RyanVM Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
83e5c99c142fe675abc35b6a5118f84161f50331: Bug 1450607 - P1. Fix constness. r=gerald, a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 801602
Push 111693 by bmo:khudson@mozilla.com at Wed, 30 May 2018 15:07:47 +0000
Bug 1450607 - P1. Fix constness. r=gerald, a=RyanVM MozReview-Commit-ID: CeftB0qmzTf
10631b9e6cbdf417ae61348141fedf13aa9c0a8d: Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r=gerald
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 14:08:01 +1000 - rev 800871
Push 111507 by jhofmann@mozilla.com at Tue, 29 May 2018 12:13:25 +0000
Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r=gerald MozReview-Commit-ID: JPN7i5z5IeX
02f1c16d83afc65364a01b61a3f500b5ce390c38: Bug 1464967 - Part 1: Make nsLineBox::BreakTypeToString static. r=gerald
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 14:06:50 +1000 - rev 800870
Push 111507 by jhofmann@mozilla.com at Tue, 29 May 2018 12:13:25 +0000
Bug 1464967 - Part 1: Make nsLineBox::BreakTypeToString static. r=gerald MozReview-Commit-ID: L97yf6oCXlq
f79ea1a6633dc7a3716b8a9f4716fc7ba3fe0e2e: Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r=gerald
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 12:39:22 +1000 - rev 800863
Push 111507 by jhofmann@mozilla.com at Tue, 29 May 2018 12:13:25 +0000
Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r=gerald MozReview-Commit-ID: 4xPXJkys1so
047a215997a22ed13854134045d5095bb679f0d4: Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r?gerald draft
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 14:08:01 +1000 - rev 800763
Push 111474 by bmo:cam@mcc.id.au at Tue, 29 May 2018 04:19:42 +0000
Bug 1464967 - Part 2: Fix nsReflowStatus dumping when REALLY_NOISY_REFLOW is defined. r?gerald MozReview-Commit-ID: JPN7i5z5IeX
d57045cdc695a8d8568be976f321601f186cf782: Bug 1464967 - Part 1: Make nsLineBox::BreakTypeToString static. r?gerald draft
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 14:06:50 +1000 - rev 800762
Push 111474 by bmo:cam@mcc.id.au at Tue, 29 May 2018 04:19:42 +0000
Bug 1464967 - Part 1: Make nsLineBox::BreakTypeToString static. r?gerald MozReview-Commit-ID: L97yf6oCXlq
7534e44dbdb7cefeb3631afd03889a4810b745e3: Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r?gerald draft
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 12:39:22 +1000 - rev 800746
Push 111463 by bmo:cam@mcc.id.au at Tue, 29 May 2018 02:39:58 +0000
Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r?gerald MozReview-Commit-ID: 4xPXJkys1so
4910a4fb7db608be3f2e7e56cf852e7f250cc737: Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r?gerald draft
Cameron McCormack <cam@mcc.id.au> - Tue, 29 May 2018 11:17:11 +1000 - rev 800736
Push 111457 by bmo:cam@mcc.id.au at Tue, 29 May 2018 01:21:50 +0000
Bug 1464947 - Fix ReflowInput::DisplayInitFrameTypeExit display type logging. r?gerald MozReview-Commit-ID: DIEV24ocBzr
4688aa455ae38eb0d359d96a925c5344376c398b: Bug 1450607 - P3. Remove unused argument. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 799811
Push 111169 by bmo:standard8@mozilla.com at Fri, 25 May 2018 11:31:37 +0000
Bug 1450607 - P3. Remove unused argument. r=gerald MozReview-Commit-ID: 6NU9BLJi6kl
2fce9c07ec2b56edc7ba969eea94287566d2c33e: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799810
Push 111169 by bmo:standard8@mozilla.com at Fri, 25 May 2018 11:31:37 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r=gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
0ef665046a0627777f04209b363a25a94f73bf43: Bug 1450607 - P1. Fix constness. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 799809
Push 111169 by bmo:standard8@mozilla.com at Fri, 25 May 2018 11:31:37 +0000
Bug 1450607 - P1. Fix constness. r=gerald MozReview-Commit-ID: CeftB0qmzTf
005f72e96205c7fc7e0673b2a7c35f58d20c8ff3: Bug 1450607 - P3. Remove unused argument. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 799732
Push 111154 by bmo:jyavenard@mozilla.com at Fri, 25 May 2018 08:51:22 +0000
Bug 1450607 - P3. Remove unused argument. r?gerald MozReview-Commit-ID: 6NU9BLJi6kl
dd64226413578ea272dbd65460c848f32653b8c7: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799731
Push 111154 by bmo:jyavenard@mozilla.com at Fri, 25 May 2018 08:51:22 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
7a553c97a4c902e03e4244afdc67b674b982e023: Bug 1450607 - P1. Fix constness. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 799730
Push 111154 by bmo:jyavenard@mozilla.com at Fri, 25 May 2018 08:51:22 +0000
Bug 1450607 - P1. Fix constness. r?gerald MozReview-Commit-ID: CeftB0qmzTf
1c1ef76da2130f6dff0254bd36f647008bde5fef: Bug 1450607 - P3. Remove unused argument. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 799386
Push 111030 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 15:49:44 +0000
Bug 1450607 - P3. Remove unused argument. r?gerald MozReview-Commit-ID: 6NU9BLJi6kl
9535c73ed77f3959b78e61ae90ce9c74ad7ba232: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799385
Push 111030 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 15:49:44 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
9e555e52eba1b8c473fb90aaa11036c25fb2bdda: Bug 1450607 - P1. Fix constness. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 799384
Push 111030 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 15:49:44 +0000
Bug 1450607 - P1. Fix constness. r?gerald MozReview-Commit-ID: CeftB0qmzTf
56876db86ac56adfbe3fb7494bb46da5aa3e81af: Bug 1450607 - P3. Remove unused argument. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 17:38:02 +0200 - rev 799369
Push 111029 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 15:41:26 +0000
Bug 1450607 - P3. Remove unused argument. r?gerald MozReview-Commit-ID: 6NU9BLJi6kl
1abf5fd6722bd0dbf51f1decd9fcb225357a5ba7: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799368
Push 111029 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 15:41:26 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
dfbacfd4f7c0fdbb834c6375d2445f6a840b816e: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799312
Push 111001 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 12:48:35 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource to be used before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
f654b4c149e6f4b52a6589cfeb8fee9ea1b746d5: Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799307
Push 110999 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 12:43:35 +0000
Bug 1450607 - P2. Synchronously seek to prepare for resuming following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
15518ef4813e80c8c77efa732c7488a33e5a9985: Bug 1450607 - P2. Synchronously seek when resuming will be needed following stop request. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 24 May 2018 14:36:58 +0200 - rev 799306
Push 110998 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 12:40:26 +0000
Bug 1450607 - P2. Synchronously seek when resuming will be needed following stop request. r?gerald Bug 1415090 attempted to remove the need to access from the MediaResource members of MediaCacheStream from the main thread. However, by doing so the logic flow for resuming the channel changed from a synchronous access to an asynchronous one. This changed some assumptions and allowed the ChannelMediaResource before the Seek call completed. For now, re-add a cross thread access to the MediaCacheStream. A more elegant fix will be worked on in bug 1464045 MozReview-Commit-ID: 2xBTjDEqrkI
ae5315bd356496b1c85d8790456c2e93294a09e7: Bug 1450607 - P1. Fix constness. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 May 2018 21:27:31 +0200 - rev 799305
Push 110998 by bmo:jyavenard@mozilla.com at Thu, 24 May 2018 12:40:26 +0000
Bug 1450607 - P1. Fix constness. r?gerald MozReview-Commit-ID: CeftB0qmzTf
dcbdde8d683c1f2aedbdc1f484e3d1eaa9eaa3f5: Bug 1457137 - Move instead of copying strings returned from various GetDebugInfo functions for HTMLMediaElement::MozDumpDebugInfo. r=gerald
Paul Adenot <paul@paul.cx> - Thu, 26 Apr 2018 15:57:39 +0200 - rev 789298
Push 108245 by bmo:jkt@mozilla.com at Fri, 27 Apr 2018 23:26:32 +0000
Bug 1457137 - Move instead of copying strings returned from various GetDebugInfo functions for HTMLMediaElement::MozDumpDebugInfo. r=gerald MozReview-Commit-ID: LbZ0cWe7yb0
bc4e557f6e9463235102f00da052050fa8921c46: Bug 1457137 - Move instead of copying strings returned from various GetDebugInfo functions for HTMLMediaElement::MozDumpDebugInfo. r?jya,gerald draft
Paul Adenot <paul@paul.cx> - Thu, 26 Apr 2018 15:57:39 +0200 - rev 788996
Push 108127 by paul@paul.cx at Fri, 27 Apr 2018 09:57:10 +0000
Bug 1457137 - Move instead of copying strings returned from various GetDebugInfo functions for HTMLMediaElement::MozDumpDebugInfo. r?jya,gerald MozReview-Commit-ID: LbZ0cWe7yb0
19f68300761ed2d550be280215da2103fa39a629: Bug 1445220 - Removed 'version' variable declaration as it was unused r=gerald
cubouyaka <victor.fontaine95@gmail.com> - Wed, 11 Apr 2018 16:05:40 +0200 - rev 788548
Push 108008 by rwood@mozilla.com at Thu, 26 Apr 2018 16:13:41 +0000
Bug 1445220 - Removed 'version' variable declaration as it was unused r=gerald
b49bd215b26e8831015572770ff8ec7dc91e4dad: Bug 1454052 - make MakeScopeExit a MOZ_MUST_USE function; r=gerald
Nathan Froyd <froydnj@mozilla.com> - Wed, 18 Apr 2018 12:14:18 -0400 - rev 784496
Push 106951 by bmo:emilio@crisal.io at Wed, 18 Apr 2018 17:52:44 +0000
Bug 1454052 - make MakeScopeExit a MOZ_MUST_USE function; r=gerald Otherwise, one can do thinkos like: MakeScopeExit(...); and the scope exiting function will execute much earlier than the intended: auto guard = MakeScopeExit(...);
6a53c90b362b4eb2243e07592ef4aff23ef6166f: Bug 1453672 - Make MediaRawDataWriter's allocation methods MOZ_MUST_USE. r=gerald
Nathan Froyd <froydnj@gmail.com> - Thu, 12 Apr 2018 07:29:00 -0400 - rev 781972
Push 106461 by bmo:mratcliffe@mozilla.com at Fri, 13 Apr 2018 23:37:27 +0000
Bug 1453672 - Make MediaRawDataWriter's allocation methods MOZ_MUST_USE. r=gerald The documentation says that the boolean return values from these methods must be checked. We might as well make the compiler check these things for us.
aa7373395767f7a58d5272067b6fd7770a9df2db: Bug 1453437 - return UniquePtr from MediaRawData::CreateWriter; r=gerald
Nathan Froyd <froydnj@mozilla.com> - Thu, 12 Apr 2018 15:28:21 -0400 - rev 781377
Push 106285 by bmo:mstriemer@mozilla.com at Thu, 12 Apr 2018 21:31:34 +0000
Bug 1453437 - return UniquePtr from MediaRawData::CreateWriter; r=gerald Returning UniquePtr is nicer than returning raw pointers, and has the nice side effect of forcing us to clean up the uses of nsAutoPtr that were hanging about.
a2217ad18058ac7c3167c4a39028fc4fb1e18e31: Bug 1444125 - don't poison Maybe on construction; r=gerald
Nathan Froyd <froydnj@mozilla.com> - Tue, 10 Apr 2018 13:46:00 -0400 - rev 779908
Push 105907 by maglione.k@gmail.com at Tue, 10 Apr 2018 20:24:34 +0000
Bug 1444125 - don't poison Maybe on construction; r=gerald This behavior is pretty heavy-handed and degrades performance.
84c72a259b96bf116456351fbd8361cce50ef9c2: Bug 1444125 - work harder to generate good code for Maybe poisoning; r=gerald
Nathan Froyd <froydnj@mozilla.com> - Tue, 10 Apr 2018 13:46:00 -0400 - rev 779907
Push 105907 by maglione.k@gmail.com at Tue, 10 Apr 2018 20:24:34 +0000
Bug 1444125 - work harder to generate good code for Maybe poisoning; r=gerald
8e0de009a63f8e4c05e16926d3dddbb1b63167e0: Bug 1446931 - P2. Refactor code flow in Benchmark. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 30 Mar 2018 11:00:50 +0200 - rev 777427
Push 105205 by felipc@gmail.com at Wed, 04 Apr 2018 18:48:30 +0000
Bug 1446931 - P2. Refactor code flow in Benchmark. r=gerald The code relied on a flag to be set to simply abort. However, that made the code workflow hard to read. We split each runs so that there's no ambiguity. MozReview-Commit-ID: LI7pL5p69zu
13b8bb0d5cc6d241af2b2fa64eabf94c4e137973: Bug 1446931 - P1. Handle errors in Benchmark. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 29 Mar 2018 22:11:06 +0200 - rev 777426
Push 105205 by felipc@gmail.com at Wed, 04 Apr 2018 18:48:30 +0000
Bug 1446931 - P1. Handle errors in Benchmark. r=gerald Benchmark had never been intended to be able to process invalid content. However over time Benchmark class has been used extensively by the fuzzing team. As such, it became necessary to handle errors of all kind. MozReview-Commit-ID: E0YulHuoiq2
3e34c4008c267a502b1dc9dabde733571a19ddc0: Bug 1446931 - P2. Refactor code flow in Benchmark. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 30 Mar 2018 11:00:50 +0200 - rev 775130
Push 104625 by bmo:jyavenard@mozilla.com at Fri, 30 Mar 2018 09:02:05 +0000
Bug 1446931 - P2. Refactor code flow in Benchmark. r?gerald The code relied on a flag to be set to simply abort. However, that made the code workflow hard to read. We split each runs so that there's no ambiguity. MozReview-Commit-ID: LI7pL5p69zu
02341f357898d359f7a8003addcddbf2e44c3c88: Bug 1446931 - P1. Handle errors in Benchmark. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 29 Mar 2018 22:11:06 +0200 - rev 775129
Push 104625 by bmo:jyavenard@mozilla.com at Fri, 30 Mar 2018 09:02:05 +0000
Bug 1446931 - P1. Handle errors in Benchmark. r?gerald Benchmark had never been intended to be able to process invalid content. However over time Benchmark class has been used extensively by the fuzzing team. As such, it became necessary to handle errors of all kind. MozReview-Commit-ID: E0YulHuoiq2
3709f5d31aebca91b914c2dc6ea3a083e1dee86c: Bug 1446931 - Handle errors in Benchmark. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 29 Mar 2018 22:11:06 +0200 - rev 774921
Push 104558 by bmo:jyavenard@mozilla.com at Thu, 29 Mar 2018 20:19:24 +0000
Bug 1446931 - Handle errors in Benchmark. r?gerald Benchmark had never been intended to be able to process invalid content. However over time Benchmark class has been used extensively by the fuzzing team. As such, it became necessary to handle errors of all kind. MozReview-Commit-ID: E0YulHuoiq2
8648837d2c655981b18b65791c5fbacb27bf606a: Bug 1446931 - Handle errors in Benchmark. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 29 Mar 2018 22:11:06 +0200 - rev 774920
Push 104557 by bmo:jyavenard@mozilla.com at Thu, 29 Mar 2018 20:11:44 +0000
Bug 1446931 - Handle errors in Benchmark. r?gerald Benchmark had never been intended to be able to process invalid content. However over time Benchmark class has been used extensively by the fuzzing team. As such, it became necessary to handle errors of all kind. MozReview-Commit-ID: E0YulHuoiq2
aff1318be50a9ad35a9dba3198f599dccf725dc3: Bug 1447124 - Use int64_t for SaferMultDiv. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 27 Mar 2018 11:27:08 +0200 - rev 773533
Push 104248 by xquan@mozilla.com at Wed, 28 Mar 2018 01:26:22 +0000
Bug 1447124 - Use int64_t for SaferMultDiv. r=gerald This prevent potential division by zero should the cast on the argument cause an overflow. We still limit the mul and div arguments to INT64_MAX. MozReview-Commit-ID: gHkv6m4zq0
e94142b7afbda68b1b4b396aa4cbfd5f89bebf8e: Bug 1448031 - make various audio/video/media constructors explicit; r=gerald
Nathan Froyd <froydnj@mozilla.com> - Tue, 27 Mar 2018 10:51:32 -0400 - rev 773320
Push 104217 by bmo:snorp@snorp.net at Tue, 27 Mar 2018 21:33:43 +0000
Bug 1448031 - make various audio/video/media constructors explicit; r=gerald Attempting to stand up the static analysis for Android builds revealed that we weren't being explicit enough.
b8c8f311af323172372f28da521f99cf58d2e468: Bug 1447124 - Use int64_t for SaferMultDiv. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 27 Mar 2018 11:27:08 +0200 - rev 773101
Push 104122 by bmo:jyavenard@mozilla.com at Tue, 27 Mar 2018 10:43:12 +0000
Bug 1447124 - Use int64_t for SaferMultDiv. r?gerald This prevent potential division by zero should the cast on the argument cause an overflow. We still limit the mul and div arguments to INT64_MAX. MozReview-Commit-ID: gHkv6m4zq0