searching for reviewer(froydnj)
3ad8c54c6dc8978a3317544bea487cef8860db50: Bug 1457092 - Disable codepaths forbidden by pledge() when being sandboxed on OpenBSD. r=froydnj
Landry Breuil <landry@openbsd.org> - Wed, 22 Aug 2018 05:29:00 -0400 - rev 831086
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1457092 - Disable codepaths forbidden by pledge() when being sandboxed on OpenBSD. r=froydnj
1481de9f7a9b49100872a2ad9f5991eed75e68d3: Bug 1421501 - disable PrioEncoder on Android until libprio supports it r?froydnj draft
Robert Helmer <rhelmer@mozilla.com> - Thu, 23 Aug 2018 07:59:44 -0700 - rev 830983
Push 118865 by bmo:rhelmer@mozilla.com at Thu, 23 Aug 2018 18:42:40 +0000
Bug 1421501 - disable PrioEncoder on Android until libprio supports it r?froydnj This is tracked upstream at https://github.com/mozilla/libprio/issues/15 MozReview-Commit-ID: L5VWKdEitfB
47149b145d5799b924aa9416c761aab210b4507c: Bug 1483865: Make NotStackAllocated assertion a bit safer. r=froydnj
Kris Maglione <maglione.k@gmail.com> - Thu, 16 Aug 2018 11:35:50 -0700 - rev 830853
Push 118857 by bmo:mtigley@mozilla.com at Thu, 23 Aug 2018 04:55:06 +0000
Bug 1483865: Make NotStackAllocated assertion a bit safer. r=froydnj This assertion was always meant to be a best-effort thing to catch obvious errors, but the cases where the assumptions it makes fail have been growing. I could remove it entirely, but I'd be happier keeping at least some basic sanity checks. This compromise continues allowing any address below the first argument pointer, and extends the assertion to also allow anything more than 2KiB above it. We could probably get away with stretching that to at least 4KiB, but 2 seems safer, and likely enough to catch the obvious cases. Differential Revision: https://phabricator.services.mozilla.com/D3542
a5f51c76930c49160bf5e909301d8e7f1a83e379: Bug 1483865: Make NotStackAllocated assertion a bit safer. r=froydnj
Kris Maglione <maglione.k@gmail.com> - Thu, 16 Aug 2018 11:35:50 -0700 - rev 830845
Push 118857 by bmo:mtigley@mozilla.com at Thu, 23 Aug 2018 04:55:06 +0000
Bug 1483865: Make NotStackAllocated assertion a bit safer. r=froydnj This assertion was always meant to be a best-effort thing to catch obvious errors, but the cases where the assumptions it makes fail have been growing. I could remove it entirely, but I'd be happier keeping at least some basic sanity checks. This compromise continues allowing any address below the first argument pointer, and extends the assertion to also allow anything more than 2KiB above it. We could probably get away with stretching that to at least 4KiB, but 2 seems safer, and likely enough to catch the obvious cases. Differential Revision: https://phabricator.services.mozilla.com/D3542
568230ce860e86538ee9d567fdd6fcec46142c8d: Bug 1411736 - Convert xpcshellConstantsPP.js to FINAL_TARGET_PP_FILES. r=firefox-build-system-reviewers,froydnj
Chris Manchester <cmanchester@mozilla.com> - Tue, 21 Aug 2018 14:58:39 +0000 - rev 830673
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1411736 - Convert xpcshellConstantsPP.js to FINAL_TARGET_PP_FILES. r=firefox-build-system-reviewers,froydnj Differential Revision: https://phabricator.services.mozilla.com/D3855
8ffadc97369cb92c41b1ded0c2a559f0d3a30c08: Bug 1484846: Expose a unique hash for the application install directory. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 21 Aug 2018 14:53:03 +0000 - rev 830665
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484846: Expose a unique hash for the application install directory. r=froydnj Profile-per-install uses a hash of the install directory to identify different installs of Firefox. This exposes the existing cityhash generated hash from nsXREDirProvider and makes it available on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D3852
8c6a05c61d397cc70412052f36670b2c452c1ec1: Bug 1484535 - Allow C++ files to check MOZ_SYSTEM_ICU. r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Tue, 21 Aug 2018 16:02:00 +0300 - rev 830650
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484535 - Allow C++ files to check MOZ_SYSTEM_ICU. r=froydnj
737a89a8edb7d9b46215d8688ac18275e38dde34: Bug 1484888 - Apply upstream patch that fixes a clang crash with stack overflow on PGO + LTO on Linux. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 21 Aug 2018 09:59:00 +0900 - rev 830649
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484888 - Apply upstream patch that fixes a clang crash with stack overflow on PGO + LTO on Linux. r=froydnj For some reason, clang 6 crashes with a stack overflow on PGO + LTO on Linux 64 bits. Clang 7 doesn't, but has other problems. After some bisecting, I found the following: - r322684 is the first revision that is broken on the release_60 branch. - that revision is a cherry pick of r322313 from trunk, which is similarly broken. - trunk was fixed by r322325, which, funnily enough, predates when r322313 was cherry-picked. While the change from r322325 is relatively large, mixing multiple different changes in a single commit, there also haven't been significant changes to the same file on trunk since (one macro name change, one documentation change, and a change related to debug info), which would tend to indicate the change is not going to break anything, or at least not more than upgrading to clang 7 would. The exact part that fixes the issue could probably be found in this large commit, but I didn't feel like digging into it further considering the above.
9ea6a90f3b135c69b0ba68d34d96c14ed35a2759: Bug 1485072: Remove some unnecessary (on-by-default) LDFLAGS from Windows builds. r=froydnj
David Major <dmajor@mozilla.com> - Tue, 21 Aug 2018 17:16:45 -0400 - rev 830641
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1485072: Remove some unnecessary (on-by-default) LDFLAGS from Windows builds. r=froydnj -DEBUGTYPE:CV, -NXCOMPAT, and -DYNAMICBASE are on by default in both link.exe and lld-link.
3fb9a0ab83ad40c164edb8c1e79de459a584a12b: Bug 1483778 - Skip LTO during the profile-generate phase of PGO. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 10:35:32 +0900 - rev 830640
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1483778 - Skip LTO during the profile-generate phase of PGO. r=froydnj When both LTO and PGO are enabled, there is no point LTO'ing during the first phase of PGO.
08d82015e170d4e618918db0d219f2abf5eb8ea0: Bug 1478969 - Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 27 Jul 2018 01:26:20 +0100 - rev 830629
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1478969 - Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj
8049cc4321284827bd54a40893bc529eba1b7b11: Bug 1481350 - Don't try to handle messages sent to child-allocated browsers, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 21 Aug 2018 00:54:40 +0000 - rev 830589
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1481350 - Don't try to handle messages sent to child-allocated browsers, r=froydnj.
93e52a1e5d88d169fca83b1f8e9f0eb78d809cc9: Bug 1478969 - Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 27 Jul 2018 01:26:20 +0100 - rev 830576
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1478969 - Don't apply RUSTFLAGS defined in mozconfig when building host Rust libraries and programs. r=froydnj
ec7da761af74dacb9a4172ac2e2a42de032bd4ef: Bug 1484844: Make nsINIParser mutable. r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Thu, 12 Oct 2017 14:20:57 -0700 - rev 830574
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1484844: Make nsINIParser mutable. r=froydnj In order to implement profile-per-install we need a mutable INI parser in early startup. The current one is implemented in JavaScript and thus not available. This makes the current read-only C++ INI parser mutable and removes the JavaScript implementation. It turns out that the two different implementations of nsIINIParserFactory and nsIINIParser behaved slightly differently but only in ways that the single test cared about so I've adjusted things a little to make it work. The existing C++ implementation did not do validity checks on arguments, this adds that making empty sections and values illegal. Differential Revision: https://phabricator.services.mozilla.com/D3851
d6d71f8bede06f31c8a5c28ecf1e3c29deb3234d: Bug 1485034: Ignore compile_commands.json files in tree; r=froydnj
Benjamin Bouvier <benj@benj.me> - Tue, 21 Aug 2018 16:54:44 +0200 - rev 830556
Push 118847 by bmo:hskupin@gmail.com at Wed, 22 Aug 2018 09:09:03 +0000
Bug 1485034: Ignore compile_commands.json files in tree; r=froydnj
dac6d9ce5eecf27103122c663356df17b1b67cbe: Bug 1484872 - Move LTO flags to python configure. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 09:05:27 +0900 - rev 830412
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484872 - Move LTO flags to python configure. r=froydnj
5a64b929a12201d978d98ede8e7a483b86a0d116: Bug 1484872 - Don't look for llvm-symbolizer for LTO builds. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 08:58:10 +0900 - rev 830411
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484872 - Don't look for llvm-symbolizer for LTO builds. r=froydnj Similar to bug 1478923.
c708ad4f9e5c569aaec93f965cbc66838998da3c: Bug 1484872 - Remove --enable-llvm-hacks. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 08:55:19 +0900 - rev 830410
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484872 - Remove --enable-llvm-hacks. r=froydnj It calls for cargo-culting its use when using clang, when it's specific to skipping one linker flags for sanitizers.
beae65bb45a9b7d6fbd42ed8b8bb9ec991abda8b: Bug 1484872 - Remove MOZ_CFLAGS_NSS. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 08:32:49 +0900 - rev 830409
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484872 - Remove MOZ_CFLAGS_NSS. r=froydnj It hasn't been used since bug 1295937.
f3c1b09b9477b6f03fc0ecce5568401d7161ce8b: Bug 1341222 - Fix building in-tree NSS against system NSPR. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 15 Aug 2018 11:17:34 +0900 - rev 830396
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1341222 - Fix building in-tree NSS against system NSPR. r=froydnj
b0a7377f4f600a81faf8951d374945dc7882c6f4: Bug 1341222 - Avoid m4 breaking the sed expressions that set NSPR_INCLUDE_DIR and NSPR_LIB_DIR. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 15 Aug 2018 11:15:20 +0900 - rev 830395
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1341222 - Avoid m4 breaking the sed expressions that set NSPR_INCLUDE_DIR and NSPR_LIB_DIR. r=froydnj
eb76188a858d82efa7b1854dcfc6d83a7f75d13f: Bug 1341222 - Allow !- and %-prefixed paths in include paths processed by gyp. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 15 Aug 2018 11:14:06 +0900 - rev 830394
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1341222 - Allow !- and %-prefixed paths in include paths processed by gyp. r=froydnj
f9ba9a7a94d2b444ee3d00b327c170efa5036e4b: Bug 1484473 - Add a cbindgen version check. r=firefox-build-system-reviewers,froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Aug 2018 15:20:42 +0000 - rev 830378
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484473 - Add a cbindgen version check. r=firefox-build-system-reviewers,froydnj Differential Revision: https://phabricator.services.mozilla.com/D3718
ddb665c7fad04681b7c449509a1cea2ce9d84e02: Bug 1483937 - Still use GCC on MOZ_PGO builds that don't have FORCE_GCC. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 17 Aug 2018 06:49:16 +0900 - rev 830365
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1483937 - Still use GCC on MOZ_PGO builds that don't have FORCE_GCC. r=froydnj Yay for inconsistencies in jobs between beta and central.
c667f8f40c65b0810e3b23fe2d635f273acc6a3f: Bug 1455707: Remove CanShowProfileManager(). r=froydnj
Dave Townsend <dtownsend@oxymoronical.com> - Tue, 15 May 2018 10:43:55 -0700 - rev 830364
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1455707: Remove CanShowProfileManager(). r=froydnj MozReview-Commit-ID: IXDSW8suEBd
c66cc808862f6c77361be44b38e78e86b4aa7c69: Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 17 Aug 2018 01:27:29 +0900 - rev 830348
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj
407f1b80fd8ad10a75e8444fd002fbdf17084c46: Bug 1484191 - Suppress warning C4819 in TestMimeType.cpp. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 17 Aug 2018 03:18:15 +0900 - rev 830347
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484191 - Suppress warning C4819 in TestMimeType.cpp. r=froydnj
1ef81d07bc5b94f6ff37954c204da264ee16e6b6: Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 17 Aug 2018 01:27:29 +0900 - rev 830338
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484184 - Remove now unused _RAISE macro check to deal with MSVC 2017 15.8. r=froydnj
2a42fd4df1bb5ef0b16baf1782016c47abd1af60: Bug 1484191 - Suppress warning C4819 in TestMimeType.cpp. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 17 Aug 2018 03:18:15 +0900 - rev 830337
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484191 - Suppress warning C4819 in TestMimeType.cpp. r=froydnj
ea2aeead3f94478cf4870681945cced6383eca81: Bug 1484437: Add cbindgen to the searchfox jobs. r=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 18 Aug 2018 16:04:31 +0200 - rev 830325
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1484437: Add cbindgen to the searchfox jobs. r=froydnj Otherwise they'll fail to build. This is a very similar patch to the one for bug 1480392. Differential Revision: https://phabricator.services.mozilla.com/D3690
fb3e5d2dd1d7c918fab39b3ef32908928eb299ec: Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 07 Aug 2018 11:58:36 +0900 - rev 829918
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1478576 - A mochitest for system font change notification. r=froydnj,jimm,karlt The test case in this patch fails without the proper fix in the first patch in this patch series. In this patch two new nsIDOMWindowUtils APIs are introduced to change the system font settins in tests. Currently the APIs work only on GTK+ platform. Also to work the test case properly we need to open a new XUL window because we don't propagate font changes into descendant documents yet (bug 1478212). MozReview-Commit-ID: 4OLxEkEuF8d
55c6badeeff2bc9a1442eefcd0d5fba7591874c8: Bug 1465800 Create an x64 MinGW-Clang Browser Build job r?froydnj draft
Tom Ritter <tom@mozilla.com> - Tue, 14 Aug 2018 16:15:56 -0500 - rev 829700
Push 118791 by bmo:tom@mozilla.com at Thu, 16 Aug 2018 15:46:35 +0000
Bug 1465800 Create an x64 MinGW-Clang Browser Build job r?froydnj MozReview-Commit-ID: 7TSCY52wTpR
85f7b7200eea172cc5cc1d4eb853cb5062a35baa: Bug 1482046 - mfbt: FunctionTypeTraits - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Wed, 15 Aug 2018 10:27:45 +0000 - rev 829667
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1482046 - mfbt: FunctionTypeTraits - r=froydnj FunctionTypeTraits< function type > makes it easier to inspect a function's return type, arity, and parameter types. It works with free functions, struct/class methods, function objects like non-generic lambdas and std::function. Differential Revision: https://phabricator.services.mozilla.com/D2998
48b8084995b1390b1f7b2214846ba19e2a55b6b2: Bug 1480631 - Switch Linux builds to clang. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 08 Aug 2018 07:04:28 +0900 - rev 829604
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1480631 - Switch Linux builds to clang. r=froydnj This change switches most CI builds to clang, with a few exceptions: - valgrind builds, until bug 1481670 is figured out. - PGO and nightly builds, until that's fully tested. - coverage builds, per bug 1471339 comment 17. - base toolchain builds, to keep some builds on GCC even when we're fully switched to clang. - any build that doesn't use build/unix/mozconfig.linux (e.g. probably all those driven by autospider.py, maybe others).
002de34fa751b8333784f0681615b809f42f31ef: Bug 1482547 - Suppress clang-cl warnings in media/mtransport/third-party/. r=froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 11 Aug 2018 06:08:07 +0900 - rev 829455
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1482547 - Suppress clang-cl warnings in media/mtransport/third-party/. r=froydnj
0d04a3f89940536d56cd5415a78316f0960e9f0a: Bug 1483123 - Apply miscompilation fix from clang upstream. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 14 Aug 2018 15:35:28 +0900 - rev 829341
Push 118765 by bmo:dharvey@mozilla.com at Wed, 15 Aug 2018 13:08:04 +0000
Bug 1483123 - Apply miscompilation fix from clang upstream. r=froydnj
e304b7dbfe42e8a2042c07e946a53415b1293d1d: Bug 1465800 Create an x64 MinGW-Clang Browser Build job r?froydnj draft
Tom Ritter <tom@mozilla.com> - Tue, 14 Aug 2018 16:15:56 -0500 - rev 829195
Push 118748 by bmo:tom@mozilla.com at Tue, 14 Aug 2018 21:16:21 +0000
Bug 1465800 Create an x64 MinGW-Clang Browser Build job r?froydnj MozReview-Commit-ID: 7TSCY52wTpR
dc70bcd78ca84c628ae0077bc0f9084d3db609dc: Bug 1481353 - Record refcount changes on a couple of stream classes, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 14 Aug 2018 00:42:19 +0000 - rev 829060
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1481353 - Record refcount changes on a couple of stream classes, r=froydnj.
51d56958d3d0016f38591a340eef901845cd2d7e: Bug 1482275 Part 1 - Trigger crashes in hanged replaying processes, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 14 Aug 2018 00:48:28 +0000 - rev 829056
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1482275 Part 1 - Trigger crashes in hanged replaying processes, r=froydnj.
0fc57261a269af5b3f787a48395c83ab558c3035: Bug 1483190 - Only enable LTO if the NDK is available. r=froydnj, a=RyanVM
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 14 Aug 2018 14:12:56 -0400 - rev 829049
Push 118744 by wisniewskit@gmail.com at Tue, 14 Aug 2018 20:11:46 +0000
Bug 1483190 - Only enable LTO if the NDK is available. r=froydnj, a=RyanVM
4ef0f163fdeb9afeddd87b37bfd987298c038542: Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. r=Nika,erahm,froydnj.
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 06 Jul 2018 10:44:43 +0300 - rev 829029
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. r=Nika,erahm,froydnj. Correctness improvements: * UTF errors are handled safely per spec instead of dangerously truncating strings. * There are fewer converter implementations. Performance improvements: * The old code did exact buffer length math, which meant doing UTF math twice on each input string (once for length calculation and another time for conversion). Exact length math is more complicated when handling errors properly, which the old code didn't do. The new code does UTF math on the string content only once (when converting) but risks allocating more than once. There are heuristics in place to lower the probability of reallocation in cases where the double math avoidance isn't enough of a saving to absorb an allocation and memcpy. * Previously, in UTF-16 <-> UTF-8 conversions, an ASCII prefix was optimized but a single non-ASCII code point pessimized the rest of the string. The new code tries to get back on the fast ASCII path. * UTF-16 to Latin1 conversion guarantees less about handling of out-of-range input to eliminate an operation from the inner loop on x86/x86_64. * When assigning to a pre-existing string, the new code tries to reuse the old buffer instead of first releasing the old buffer and then allocating a new one. * When reallocating from the new code, the memcpy covers only the data that is part of the logical length of the old string instead of memcpying the whole capacity. (For old callers old excess memcpy behavior is preserved due to bogus callers. See bug 1472113.) * UTF-8 strings in XPConnect that are in the Latin1 range are passed to SpiderMonkey as Latin1. New features: * Conversion between UTF-8 and Latin1 is added in order to enable faster future interop between Rust code (or otherwise UTF-8-using code) and text node and SpiderMonkey code that uses Latin1. MozReview-Commit-ID: JaJuExfILM9
d754118be3dbe31b2fb34ac16d03cdd605a7dbd7: Bug 1477755 - Measure TimeoutManager execution - r=farre,froydnj
Tarek Ziadé <tarek@mozilla.com> - Mon, 13 Aug 2018 17:09:56 +0200 - rev 828940
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1477755 - Measure TimeoutManager execution - r=farre,froydnj Tracks calls made through TimeoutManager and makes sure they are accounted for in the corresponding DocGroup MozReview-Commit-ID: IvcoBrrZVWp
cb8d7e42139e064c7c6caeef0001b5803fa971b5: Bug 1481009 Part 8 - Remove unused RecordReplayFatalError message, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Mon, 13 Aug 2018 20:48:31 +0000 - rev 828922
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1481009 Part 8 - Remove unused RecordReplayFatalError message, r=froydnj.
a3bd72355db187ec1f492127d117f6d5796ce802: Bug 1481009 Part 7 - Treat inaccessible memory regions after thread stacks as untracked, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Mon, 13 Aug 2018 20:48:14 +0000 - rev 828921
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1481009 Part 7 - Treat inaccessible memory regions after thread stacks as untracked, r=froydnj.
41d3f63a86da3ac2a57c46afc40a99ab411539df: Bug 1481009 Part 6 - Cleanly shutdown middleman processes after a recording/replaying child crashes, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Mon, 13 Aug 2018 20:47:49 +0000 - rev 828920
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1481009 Part 6 - Cleanly shutdown middleman processes after a recording/replaying child crashes, r=froydnj.
305a6de8a4579c3a2546d693a927f143e4c4e906: Bug 1481009 Part 5 - Generate a minidump when reporting a fatal record/replay error, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Mon, 13 Aug 2018 20:47:35 +0000 - rev 828919
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1481009 Part 5 - Generate a minidump when reporting a fatal record/replay error, r=froydnj.
d605332894bff2a8eee8667463e35b76e0f2f791: Bug 1481009 Part 4 - Add redirection for crash reporter code, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Mon, 13 Aug 2018 20:47:05 +0000 - rev 828918
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1481009 Part 4 - Add redirection for crash reporter code, r=froydnj.
681777ca2f49d42264c11c24c10b346f7913a744: Bug 1480006 - Enable LTO on Android CI builds. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 10 Aug 2018 14:55:30 +0900 - rev 828914
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1480006 - Enable LTO on Android CI builds. r=froydnj
4c784d8df2efd300970cfad12da0d370506c41c7: Bug 1482011 - Make Bench_Cpp_MozHashSet more idiomatic. r=froydnj
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 14 Aug 2018 08:52:38 +1000 - rev 828913
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482011 - Make Bench_Cpp_MozHashSet more idiomatic. r=froydnj I discovered there are some shortcut methods for some common operations.
783e7599b5c2512066cfcae30cfff438d1ecba58: Bug 1480004 - Normalize optimization level passed to the linker when doing LTO with clang. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 10 Aug 2018 14:51:28 +0900 - rev 828911
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1480004 - Normalize optimization level passed to the linker when doing LTO with clang. r=froydnj