searching for reviewer(fitzgen)
4204e7eaa385eb5aa8ea0aa57cf20c588019882b: Bug 1475228 - Make synchronous compile APIs take SourceBufferHolders exclusively r=jandem r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 17 Jul 2018 14:30:22 +0100 - rev 825535
Push 118129 by jhofmann@mozilla.com at Wed, 01 Aug 2018 22:38:13 +0000
Bug 1475228 - Make synchronous compile APIs take SourceBufferHolders exclusively r=jandem r=fitzgen
b2d18ea619ecfdaa34fbb1dde59502d77162fcf0: Bug 1475228 - Fix rust bindings following JS::Evaluate signature change r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 30 Jul 2018 11:14:03 +0100 - rev 824338
Push 117877 by bmo:rbartlensky@mozilla.com at Mon, 30 Jul 2018 17:02:50 +0000
Bug 1475228 - Fix rust bindings following JS::Evaluate signature change r=fitzgen
70c285e729d9e06c05a169ac94940a69e91574f2: Bug 1207696 Part 10f - Coordinate with snapshot mechanism in JS helper threads, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 14:48:27 +0000 - rev 821773
Push 117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1207696 Part 10f - Coordinate with snapshot mechanism in JS helper threads, r=fitzgen.
ab53a96c3b3027d3a8d467c16df1d60182c61bc6: Bug 1207696 Part 5k - Don't generate debugger runnables on GC events, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 14:39:48 +0000 - rev 821763
Push 117191 by maglione.k@gmail.com at Tue, 24 Jul 2018 02:14:48 +0000
Bug 1207696 Part 5k - Don't generate debugger runnables on GC events, r=fitzgen.
99479560fb28b06474e61a365685abada9c1446d: Bug 1207696 Part 4f - Don't record JS mutexes, r=fitzgen.
Brian Hackett <bhackett1024@gmail.com> - Sat, 21 Jul 2018 14:24:48 +0000 - rev 821257
Push 117048 by bmo:ksaini@mozilla.com at Sun, 22 Jul 2018 10:49:35 +0000
Bug 1207696 Part 4f - Don't record JS mutexes, r=fitzgen.
1544d0ec5e6c3e4bec3ee2928d64bccaf7a59645: Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 20:32:55 -0700 - rev 818310
Push 116246 by bmo:tom@mozilla.com at Fri, 13 Jul 2018 20:48:08 +0000
Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
317eee299a24c5adc2e87dc27128e82eab145599: Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 20:32:55 -0700 - rev 806367
Push 112878 by rwood@mozilla.com at Sat, 09 Jun 2018 14:26:04 +0000
Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
1e833c6a3ba2a4d592868fd2167e94c1cb933004: Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
Steve Fink <sfink@mozilla.com> - Tue, 05 Jun 2018 20:32:55 -0700 - rev 806361
Push 112878 by rwood@mozilla.com at Sat, 09 Jun 2018 14:26:04 +0000
Bug 1467248 - Make the spidermonkey jobs labeled debug be debug builds, r=fitzgen
ee68c73f661babf8bbbf499387e8f044b434ed38: Bug 1465163 - Some UbiNode changes for same-compartment realms. r=fitzgen
Jan de Mooij <jdemooij@mozilla.com> - Fri, 01 Jun 2018 19:23:06 +0200 - rev 803109
Push 112028 by bmo:dharvey@mozilla.com at Fri, 01 Jun 2018 21:45:23 +0000
Bug 1465163 - Some UbiNode changes for same-compartment realms. r=fitzgen
27f44af915f74d0c8dbaf65cc9b5e18d38287e59: Bug 1463723 - Remove ubi::Census' pointer to the atoms zone r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 24 May 2018 09:40:46 +0100 - rev 799286
Push 110991 by rwood@mozilla.com at Thu, 24 May 2018 12:11:32 +0000
Bug 1463723 - Remove ubi::Census' pointer to the atoms zone r=fitzgen
fc3a8ce00c3f7025871140e1275d6920d92d13db: Bug 1458029 - Baldr: update wasm frame stack format string to match WebAssembly Web API spec (r=yury,bbouvier,fitzgen)
Luke Wagner <luke@mozilla.com> - Tue, 08 May 2018 13:26:40 -0500 - rev 792831
Push 109197 by maglione.k@gmail.com at Tue, 08 May 2018 23:28:26 +0000
Bug 1458029 - Baldr: update wasm frame stack format string to match WebAssembly Web API spec (r=yury,bbouvier,fitzgen)
9b7418660fe23ccf235231f210608c3669b85ed3: Bug 1449189 - Don't lock in ~ExclusiveData (r=fitzgen)
Luke Wagner <luke@mozilla.com> - Fri, 30 Mar 2018 11:16:24 -0500 - rev 775232
Push 104663 by bmo:cmanchester@mozilla.com at Fri, 30 Mar 2018 17:16:27 +0000
Bug 1449189 - Don't lock in ~ExclusiveData (r=fitzgen)
10b30b796dbf89e0cf054ea37cace173702d93c6: Bug 1438121: Add jit-test async-livecache.js. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 09 Mar 2018 16:47:58 -0800 - rev 765919
Push 102180 by maglione.k@gmail.com at Sun, 11 Mar 2018 04:18:22 +0000
Bug 1438121: Add jit-test async-livecache.js. r=fitzgen MozReview-Commit-ID: Jbe1GMPGwKj
1057c4246ffaae3b24a9b3493ac2d6cff9e33cec: Bug 1438121: Final Part 6: Omitted doc fix requested in review. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 09 Mar 2018 11:40:46 -0800 - rev 765854
Push 102163 by bmo:ato@sny.no at Sat, 10 Mar 2018 10:57:01 +0000
Bug 1438121: Final Part 6: Omitted doc fix requested in review. DONTBUILD r=fitzgen MozReview-Commit-ID: FXQM85VAnfA
88470a2d04a100c1efb3ffad0ae215fe7f8880b6: Bug 1438121: Final Part 5: Remove meaningless 'const' this qualifier from LiveSavedFrameCache::FramePtr::SetHasCachedMatcher::match. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 23:39:15 -0800 - rev 765853
Push 102163 by bmo:ato@sny.no at Sat, 10 Mar 2018 10:57:01 +0000
Bug 1438121: Final Part 5: Remove meaningless 'const' this qualifier from LiveSavedFrameCache::FramePtr::SetHasCachedMatcher::match. r=fitzgen MozReview-Commit-ID: kfcTilDEwK
bfc321ae89810ce708b0e15d6848a9a822b253f4: Bug 1438121: Final Part 4: Doc fixes for LiveSavedFrameCache. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Thu, 01 Mar 2018 23:22:02 -0800 - rev 765852
Push 102163 by bmo:ato@sny.no at Sat, 10 Mar 2018 10:57:01 +0000
Bug 1438121: Final Part 4: Doc fixes for LiveSavedFrameCache. DONTBUILD r=fitzgen MozReview-Commit-ID: 5672uZ4pC2E
449f9d9d664bb47a8f318bba7543c34e2363a4a3: Bug 1438121: Final Part 3: Make LiveSavedFrameCache::find pop invalid entries as part of the search. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Thu, 01 Mar 2018 23:14:45 -0800 - rev 765851
Push 102163 by bmo:ato@sny.no at Sat, 10 Mar 2018 10:57:01 +0000
Bug 1438121: Final Part 3: Make LiveSavedFrameCache::find pop invalid entries as part of the search. r=fitzgen Rather than searching from the beginning (old end) of the cache, LiveSameFrameCache::find can search from the young end of the cache, popping invalid stack entries as it goes. This means that the number of entries searched is related to the number of cached frames popped since the last stack capture, not the total number of entries in the cache. This also removes the need for iterators, iterator arithmetic, or any random access to the stack; the function simply uses the vector's 'back', 'popBack', 'empty', and 'clear' methods. MozReview-Commit-ID: DCFt0uhiqql
f54675bcf897379cd4f81cad3b80f812b9f2a903: Bug 1438121: Final Part 2: Fix interaction between async parents and the LiveSavedFrameCache in SavedStacks::insertFrames. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sat, 24 Feb 2018 15:39:43 -0800 - rev 765850
Push 102163 by bmo:ato@sny.no at Sat, 10 Mar 2018 10:57:01 +0000
Bug 1438121: Final Part 2: Fix interaction between async parents and the LiveSavedFrameCache in SavedStacks::insertFrames. r=fitzgen When capturing frames in an activation that had both 1) an async parent stack established by AutoSetAsyncStackForNewCalls and 2) SavedFrames cached in the activation's LiveSavedFramesCache, SavedStacks::insertFrames would supplant the SavedFrame chain from the cache with the async parent stack, causing frames to be dropped. The code also looked for frames in the wrong activation's LiveSavedFramesCache. The code assumed that only the parent of a frame whose hasCachedSavedFrame flag is set could be retrieved from the cache; this was pessimistic, as we can compare the cached and actual pc's, and potentially provide cache hits for the youngest frame with a flag set. MozReview-Commit-ID: 8tXTI43pjYr
018578db02247c7262593ef308c70961ace7c85e: Bug 1444081 - Shutdown the Parent JSRuntime instead of leaking it. r=fitzgen
Nicolas B. Pierron <nicolas.b.pierron@gmail.com> - Thu, 08 Mar 2018 14:14:41 +0000 - rev 765045
Push 101951 by bmo:mstriemer@mozilla.com at Thu, 08 Mar 2018 22:36:46 +0000
Bug 1444081 - Shutdown the Parent JSRuntime instead of leaking it. r=fitzgen
797239d1e7059c6e5f6fd394e261ea089b2325a9: Bug 1443592: Part 6: Remove hasCachedSavedFrame accessors from AbstractFramePtr. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 13:51:13 -0800 - rev 764881
Push 101881 by bmo:snorp@snorp.net at Thu, 08 Mar 2018 15:11:59 +0000
Bug 1443592: Part 6: Remove hasCachedSavedFrame accessors from AbstractFramePtr. r=fitzgen Some variants of AbstractFramePtr have a cached saved frame flag, and others don't, but the whole point of LiveSavedFrameCache::FramePtr is that it represents a frame that does have a flag. Rather than one variant of FramePtr that is an AbstractFramePtr (restricted to certain variants), flatten out the two enums into one, and make FramePtr the sole authority on which sorts of frames we have, and how to access their flags. This means there is no need for hasCachedSavedFrame accessors on AbstractFramePtr, just on the individual concrete frame types. MozReview-Commit-ID: BRVdfqOqBsG
c8eff45d0955decbbf82df66a67d1639e986396d: Bug 1443592: Part 5: Move LiveSavedFrameCache::getFramePtr to FramePtr::create. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 13:33:52 -0800 - rev 764880
Push 101881 by bmo:snorp@snorp.net at Thu, 08 Mar 2018 15:11:59 +0000
Bug 1443592: Part 5: Move LiveSavedFrameCache::getFramePtr to FramePtr::create. r=fitzgen MozReview-Commit-ID: EZHdkBeMGnm
269e77f6b1e5878062f9b4a5e12533cc20da01d0: Bug 1443592: Part 3: Change LiveSavedFrameCache::find to take a FramePtr, not a FrameIter. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 11:42:36 -0800 - rev 764878
Push 101881 by bmo:snorp@snorp.net at Thu, 08 Mar 2018 15:11:59 +0000
Bug 1443592: Part 3: Change LiveSavedFrameCache::find to take a FramePtr, not a FrameIter. r=fitzgen This obviates dynamic checks in find about the state of the iterator, since they're covered by the fact that we were able to obtain a FramePtr at all. This does mean that we have to pass the pc separately. But that's symmetrical with the insert method, so it's okay. MozReview-Commit-ID: FgsDjHB2il4
1790490874a09b2da5731945e629e6b708ce9f5f: Bug 1443592: Part 2: Move hasCachedSavedFrame flag access from FrameIter to LiveSavedFrameCache::FramePtr. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Tue, 06 Mar 2018 11:28:53 -0800 - rev 764877
Push 101881 by bmo:snorp@snorp.net at Thu, 08 Mar 2018 15:11:59 +0000
Bug 1443592: Part 2: Move hasCachedSavedFrame flag access from FrameIter to LiveSavedFrameCache::FramePtr. r=fitzgen Instead of using FrameIter::hasCachedSavedFrame, the code should instead try to construct a FramePtr via LiveSavedFrameCache::getFramePtr, which returns a Maybe<FramePtr>. If that is Some, then we know the frame at hand actually has a flag, and we can test and set it. Since the existing FrameIter::hasCachedSavedFrame screens out all wasm frames, we change LiveSavedFrameCache::getFramePtr to do the same. However, the existing behavior was incorrect, since wasm::DebugFrame does carry the flag; we'll fix that in a later patch. FrameIter::hasCachedSavedFrame asserted that jsJitFrame().isIonScripted(); this is tested by isPhysicalIonFrame(), so that case is already covered. MozReview-Commit-ID: 92wCc71s4nU
faa2dd792d1cfdc83004c048a7bb9e41c388fb04: Bug 1443592: Part 1: Introduce opaque LiveSavedFrameCache::Key type for cache keys. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Mon, 05 Mar 2018 18:03:56 -0800 - rev 764876
Push 101881 by bmo:snorp@snorp.net at Thu, 08 Mar 2018 15:11:59 +0000
Bug 1443592: Part 1: Introduce opaque LiveSavedFrameCache::Key type for cache keys. r=fitzgen By design, the LiveSavedFrameCache holds the addresses of both live and dead stack frames. This change wraps those addresses in an opaque type that can only be compared for equality with other such values, and provides no interface to retrieve the underlying pointer, ensuring statically that we will not accidentally use a cache key to access memory. MozReview-Commit-ID: 9Wom5gFVQls
bc9778de0b084afaaca48cd5d27d84fc8d259348: Bug 1438121: Part 13: Make LiveSavedFrameCache::Entry's members const. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 23:56:26 -0800 - rev 763491
Push 101472 by bmo:nchen@mozilla.com at Tue, 06 Mar 2018 05:06:18 +0000
Bug 1438121: Part 13: Make LiveSavedFrameCache::Entry's members const. r=fitzgen MozReview-Commit-ID: GbJhE9nylaa
61ca8af8e31332158c4307c8277282d27012d46e: Bug 1411415 - r=bz r=fitzgen
Kannan Vijayan <kvijayan@mozilla.com> - Mon, 05 Mar 2018 19:27:02 -0500 - rev 763489
Push 101472 by bmo:nchen@mozilla.com at Tue, 06 Mar 2018 05:06:18 +0000
Bug 1411415 - r=bz r=fitzgen
f72fd25e822fc7c8f625a0b6f659a7aaee4d4a41: Bug 1438121: Part 3: Add shell tests for implicit async stacks. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 16:22:32 -0800 - rev 763466
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 3: Add shell tests for implicit async stacks. r=fitzgen MozReview-Commit-ID: BfPPrvEGSgg
4ca86bbdc4090adb24956c783e1b42fd495e0f1f: Bug 1438121: Part 2: Define the 'bindToAsyncStack' JS shell testing function. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 15:43:20 -0800 - rev 763465
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 2: Define the 'bindToAsyncStack' JS shell testing function. r=fitzgen See JS_FN documentation for details. MozReview-Commit-ID: 6WUaGfdwogX
6f555aced81dac6cde601db7ca6589e42efe5f57: Bug 1438121: Part 1: Add job dispatch primitive to shell. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 14:06:05 -0800 - rev 763464
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 1: Add job dispatch primitive to shell. r=fitzgen See JS_FN documentation for details. MozReview-Commit-ID: 8ZLyOX85qqh
03528c9063b3647f70324b120a951a8cdf470d4f: Bug 1438121: Part 5: Don't propagate the 'hasCachedSavedFrame_' bit from the RematerializedFrame to the BaselineFrame. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 23 Feb 2018 22:28:56 -0800 - rev 763463
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 5: Don't propagate the 'hasCachedSavedFrame_' bit from the RematerializedFrame to the BaselineFrame. r=fitzgen When capturing the JavaScript stack as a chain of SavedFrames, the hasCachedSavedFrame flag on a frame indicates that the frame has an entry in the LiveSavedFrameCache, which may hand us the SavedFrame for a previously captured remainder of the stack, letting us stop the stack walk early. The LiveSavedFrameCache uses AbstractFramePtr and jit::CommonFrameLayout* values as keys. A RematerializedFrame uses an AbstractFramePtr as its key, but the BaselineFrame we build from it has a jit::CommonFrameLayout* as its key; the two keys are unequal. It's valuable to be able to assert that, if a frame has its hasCachedSavedFrame flag set, then it must have an entry in the cache; to allow that, converting a RematerializedFrame to a BaselineFrame must clear the flag, since the BaselineFrame's key is not present. We could instead fix up the cache entry's key, and carry over the flag, but it's simpler to just let the cache get repopulated as needed. MozReview-Commit-ID: 612daDJ1R4w
182dc936ca731074c7a332768c8123efffe79951: Bug 1438121: Part 12: Make LiveSavedFrameCache::getFramePtr's parameter const. r=fitzgen
Jim Blandy <jimb@mozilla.com> - Fri, 02 Mar 2018 00:05:27 -0800 - rev 763462
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 12: Make LiveSavedFrameCache::getFramePtr's parameter const. r=fitzgen MozReview-Commit-ID: K4JAFidKNzJ
7d93207d01801b99e5a4464145f61a02e98b701f: Bug 1438121: Part 8: AutoSetAsyncStackForNewCalls doc fix. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sun, 25 Feb 2018 23:33:54 -0800 - rev 763461
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 8: AutoSetAsyncStackForNewCalls doc fix. DONTBUILD r=fitzgen MozReview-Commit-ID: JwIM2EAmPZY
8fd9c1479159335e4d4e9d71e2bf99d1d62b8ba7: Bug 1438121: Part 6: Improve comments for js::LiveSavedFrameCache. DONTBUILD r=fitzgen
Jim Blandy <jimb@mozilla.com> - Sat, 24 Feb 2018 13:57:41 -0800 - rev 763460
Push 101458 by bmo:rbarker@mozilla.com at Mon, 05 Mar 2018 23:59:13 +0000
Bug 1438121: Part 6: Improve comments for js::LiveSavedFrameCache. DONTBUILD r=fitzgen MozReview-Commit-ID: C4W5cgwdNtv
4e681b986b5cdd36dbb8b50c232b8b5d4db8e4f3: Bug 1440816: Part 1 - Set readPrincipals callback on JS context. r=fitzgen
Kris Maglione <maglione.k@gmail.com> - Fri, 23 Feb 2018 17:20:32 -0800 - rev 762461
Push 101169 by luca.greco@alcacoop.it at Fri, 02 Mar 2018 12:32:00 +0000
Bug 1440816: Part 1 - Set readPrincipals callback on JS context. r=fitzgen MozReview-Commit-ID: L9SQ5tiHkl5
ddd23271dd7833cbe7bf10a90e4ae8457ff80843: Bug 1438121 - Use async/await instead of Task.jsm in test_memory_allocations_01.html. r=fitzgen draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 14 Feb 2018 01:43:46 -0800 - rev 754947
Push 99069 by bmo:poirot.alex@gmail.com at Wed, 14 Feb 2018 18:05:24 +0000
Bug 1438121 - Use async/await instead of Task.jsm in test_memory_allocations_01.html. r=fitzgen MozReview-Commit-ID: mzUtaDjhOk
8335e1d7b14054ce8b1ecc77d9fc7a1c39880f4d: Bug 1404787 - Fix symbols visibility. r=fitzgen, a=lizzard
Philip Chimento <philip.chimento@gmail.com> - Tue, 31 Oct 2017 08:37:36 -0700 - rev 718048
Push 94831 by mozilla@kaply.com at Tue, 09 Jan 2018 21:23:29 +0000
Bug 1404787 - Fix symbols visibility. r=fitzgen, a=lizzard
134e8f9868a1019310e43f6092aef8dbce090c6e: Bug 1428075 - Remove non-rooted saved frame iterators r=fitzgen
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 05 Jan 2018 10:42:16 +0000 - rev 716580
Push 94465 by bmo:edilee@mozilla.com at Fri, 05 Jan 2018 23:34:55 +0000
Bug 1428075 - Remove non-rooted saved frame iterators r=fitzgen
cfce78c33f60e67a6c2068002e38721047eb3ba8: Bug 1414871 - when linking the rust JS bindings, include libmozglue; r=fitzgen
Alex Gaynor <agaynor@mozilla.com> - Fri, 10 Nov 2017 15:10:43 -0500 - rev 696717
Push 88770 by bmo:emilio@crisal.io at Sat, 11 Nov 2017 01:20:46 +0000
Bug 1414871 - when linking the rust JS bindings, include libmozglue; r=fitzgen MozReview-Commit-ID: LOiJUWbsyiJ
452e3df2169ec6e66e21cfd4c84ec6ad01f1f593: Bug 1414871 - when linking the rust JS bindings, include libmozglue; r?fitzgen draft
Alex Gaynor <agaynor@mozilla.com> - Fri, 10 Nov 2017 15:10:43 -0500 - rev 696502
Push 88739 by bmo:agaynor@mozilla.com at Fri, 10 Nov 2017 20:11:06 +0000
Bug 1414871 - when linking the rust JS bindings, include libmozglue; r?fitzgen MozReview-Commit-ID: LOiJUWbsyiJ
1dfd453ab88ef611b953e881267af7fa3e9f4177: Bug 1411450 - Switch devtools CoreDump.proto to the LITE_RUNTIME. r=fitzgen
Francois Marier <francois@mozilla.com> - Thu, 26 Oct 2017 16:12:51 -0700 - rev 692603
Push 87552 by bmo:standard8@mozilla.com at Fri, 03 Nov 2017 10:21:12 +0000
Bug 1411450 - Switch devtools CoreDump.proto to the LITE_RUNTIME. r=fitzgen The "lite" runtime allows us to pull in a lot less of the protocol buffers library: https://developers.google.com/protocol-buffers/docs/proto#options MozReview-Commit-ID: 2m41fqa9j09
3c31593ee859097c8629b875f81754646308e9dd: Bug 1411450 - Switch devtools CoreDump.proto to the LITE_RUNTIME. r?fitzgen draft
Francois Marier <francois@mozilla.com> - Thu, 26 Oct 2017 16:12:51 -0700 - rev 689807
Push 87108 by fmarier@mozilla.com at Tue, 31 Oct 2017 23:13:27 +0000
Bug 1411450 - Switch devtools CoreDump.proto to the LITE_RUNTIME. r?fitzgen The "lite" runtime allows us to pull in a lot less of the protocol buffers library: https://developers.google.com/protocol-buffers/docs/proto#options MozReview-Commit-ID: 2m41fqa9j09
a124f4901430f6db74cfc7fe3b07957a1c691b40: Bug 638054 - Remove or fix tests outside JS using watch/unwatch. r=bz,fitzgen
Tom Schuster <evilpies@gmail.com> - Tue, 24 Oct 2017 20:48:14 +0200 - rev 685608
Push 85992 by asasaki@mozilla.com at Tue, 24 Oct 2017 22:34:33 +0000
Bug 638054 - Remove or fix tests outside JS using watch/unwatch. r=bz,fitzgen
aca83df2ce2ea49465468a5ae3bd617fdff95dc6: Bug 1385461 - Upgrade to the latest version of the protobuf library. r=dimi,fitzgen,glandium,mattwoodrow,mossop
Francois Marier <francois@mozilla.com> - Wed, 18 Oct 2017 15:02:05 -0700 - rev 685359
Push 85895 by stransky@redhat.com at Tue, 24 Oct 2017 11:17:42 +0000
Bug 1385461 - Upgrade to the latest version of the protobuf library. r=dimi,fitzgen,glandium,mattwoodrow,mossop The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The LOGLEVEL_ERROR hack in m-c-changes.patch from bug 1024774 and bug 1320179 was replaced by a NOGDI define in moz.build as suggested by upstream: https://github.com/google/protobuf/pull/3745/files#r144915445 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
b0b157e829aaa6d4f55cb04c03b82cb0ab522512: Bug 1407750 - use mozilla::KnownNotNull to improve placement new in ExclusiveData; r=fitzgen
Nathan Froyd <froydnj@mozilla.com> - Thu, 19 Oct 2017 12:35:03 -0400 - rev 683646
Push 85417 by wisniewskit@gmail.com at Thu, 19 Oct 2017 23:47:04 +0000
Bug 1407750 - use mozilla::KnownNotNull to improve placement new in ExclusiveData; r=fitzgen Using KnownNotNull here avoids the necessary null checks that come along with placement new.
51f34cd1388263ca63149f1cc5787aa1d1200411: Bug 1385461 - Upgrade to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi,glandium draft
Francois Marier <francois@mozilla.com> - Wed, 18 Oct 2017 15:02:05 -0700 - rev 683519
Push 85402 by fmarier@mozilla.com at Thu, 19 Oct 2017 21:21:03 +0000
Bug 1385461 - Upgrade to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi,glandium The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The LOGLEVEL_ERROR hack in m-c-changes.patch from bug 1024774 and bug 1320179 was replaced by a NOGDI define in moz.build as suggested by upstream: https://github.com/google/protobuf/pull/3745/files#r144915445 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
88c4af1d92d0c2fe1a167758512e26cceb174495: Bug 1409441 part 1 - Inline ActivationEntryMonitor constructor/destructor. r=fitzgen
Jan de Mooij <jdemooij@mozilla.com> - Wed, 18 Oct 2017 17:11:41 +0100 - rev 682952
Push 85209 by kgupta@mozilla.com at Thu, 19 Oct 2017 02:25:44 +0000
Bug 1409441 part 1 - Inline ActivationEntryMonitor constructor/destructor. r=fitzgen
be4dbdf496018c8c75e446e92be5dc7a5416ab4a: Bug 1385461 - Upgrade to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi,glandium draft
Francois Marier <francois@mozilla.com> - Tue, 17 Oct 2017 16:05:48 -0700 - rev 681970
Push 84962 by fmarier@mozilla.com at Tue, 17 Oct 2017 23:07:03 +0000
Bug 1385461 - Upgrade to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi,glandium The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
ff9a5fb232080c93ef5dc6806625981ebaa62e53: Bug 1385461 - Update to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi draft
Francois Marier <francois@mozilla.com> - Fri, 13 Oct 2017 16:04:22 -0700 - rev 680399
Push 84493 by fmarier@mozilla.com at Fri, 13 Oct 2017 23:58:48 +0000
Bug 1385461 - Update to the latest version of the protobuf library. r?mossop,mattwoodrow,fitzgen,dimi The tarball that was imported is the 3.4.1 release: https://github.com/google/protobuf/releases/tag/v3.4.1 https://github.com/google/protobuf/releases/download/v3.4.1/protobuf-cpp-3.4.1.tar.gz This drops all of the customizations that are no longer needed, which includes a few issues that were fixed upstream: - r512.patch from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/r512.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/io/zero_copy_stream_impl.cc#L43 - vs2013.patch, also from bug 892856: https://searchfox.org/mozilla-central/rev/bab9dbe9c4ef71f71fb07e53b701fb2dfde277d9/toolkit/components/protobuf/vs2013.patch https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/wire_format_lite_inl.h#L39 - sparc64 fixes in m-c-changes.patch from bug 1275204: https://hg.mozilla.org/integration/mozilla-inbound/rev/21d692e82582 https://github.com/google/protobuf/blob/b04e5cba356212e4e8c66c61bbe0c3a20537c5b9/src/google/protobuf/stubs/platform_macros.h#L68 The other customizations that were dropped came from bug 1024774. The patch for OpenBSD/32-bit will likely be fixed upstream in a future release: https://github.com/google/protobuf/pull/3747#issuecomment-336581244 Upgrading the protobuf library also required re-generating all of the existing .pb.h and pb.cc files (they are neither forward nor backward-compatible) and making adjustments to the build config to make it compile (and silence warnings). text_format.cc can now be compiled as part of UNIFIED_SOURCES. MozReview-Commit-ID: 7F2IqFmwQnN
68efec9794dc1f438cb9fe9bb8a669dd8212350e: Bug 1404787 - Fix symbols visibility. r=fitzgen
Philip Chimento <philip.chimento@gmail.com> - Mon, 02 Oct 2017 22:20:33 -0700 - rev 674588
Push 82896 by bmo:gl@mozilla.com at Wed, 04 Oct 2017 02:57:37 +0000
Bug 1404787 - Fix symbols visibility. r=fitzgen
5e41366119a29f7c3328416b4029e34c2f48ba74: Bug 1404787 - Fix symbols visibility. r=fitzgen
Philip Chimento <philip.chimento@gmail.com> - Sun, 01 Oct 2017 23:02:25 -0700 - rev 673977
Push 82680 by bmo:mozilla@hocat.ca at Tue, 03 Oct 2017 00:21:34 +0000
Bug 1404787 - Fix symbols visibility. r=fitzgen