searching for reviewer(ehsan)
251360ecbedff5fbaa014cd859a4fbd9914d4233: Bug 1482950 - Use the correct 3rdparty check in tracking annotations. r=dimi,Ehsan,mayhemer!,ehsan!
Francois Marier <francois@mozilla.com> - Mon, 20 Aug 2018 23:53:45 +0000 - rev 830466
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482950 - Use the correct 3rdparty check in tracking annotations. r=dimi,Ehsan,mayhemer!,ehsan! The mIsTrackingResource flag on nsIHttpChannel was split into two separate flags depending on whether or not the resource is third-party. The correct flag will be set by the channel classifier. Similarly, a new function was introduced, GetIsThirdPartyTrackingResource(), for those consumers (like TP) who only care about third-party trackers. The existing function, GetIsTracking(), will continue to look at both first-party and third-party trackers (the behavior since first party tracking was added to annotations in bug 1476324). The OverrideTrackingResource() function now allows nsHTMLDocument to override both mIsFirstPartyTrackingResource and mIsThirdPartyTrackingResource, but since this function is a little dangerous and only has a single user, I added an assert to make future callers think twice about using it to opt out of tracking annotations. Currently, only the default storage restrictions need to look at first-party trackers so every other consumer has been moved to mIsThirdPartyTrackingResource or GetIsThirdPartyTrackingResource(). This effectively reverts the third-party checks added in bug 1476715 and replaces them with the more complicated check that was added in bug 1108017. It follows the approach that Ehsan initially suggested in bug 1476715. It also reverts the changes in the expected values of the tracking annotation test since these were, in hindsight, a warning about this regression. Depends on D3722 Differential Revision: https://phabricator.services.mozilla.com/D3723
0e95533b40e12ec879aa6fcfd0c1c735c42f443a: Bug 1482950 - Improve tracking annotation test. r=Ehsan!
Francois Marier <francois@mozilla.com> - Mon, 20 Aug 2018 14:08:15 +0000 - rev 830457
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1482950 - Improve tracking annotation test. r=Ehsan! A new parameter is introduced to makeConnection in order to specify the topWindowURI. This will be useful in future tests, but it also highlights the fact that we do set this in all of the existing tests. Finally, I also added a number of comments and explicit parameter setting in order to make the test more readily understandable. Depends on D3720 Differential Revision: https://phabricator.services.mozilla.com/D3721
16daef3a89a23e7805469b25c21cc31f5dade193: Bug 1471947, bug 1471948 - Enable Shadow DOM and Custom Elements in release builds, r=ehsan, emilio
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 17 Aug 2018 03:39:02 +0300 - rev 829893
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1471947, bug 1471948 - Enable Shadow DOM and Custom Elements in release builds, r=ehsan, emilio
9b17b83509fdf49c722bb9956bd85730b46dc353: Bug 1471947, bug 1471948 - Enable Shadow DOM and Custom Elements in release builds, r=ehsan, emilio
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 16 Aug 2018 15:30:54 +0300 - rev 829772
Push 118795 by xquan@mozilla.com at Thu, 16 Aug 2018 22:58:08 +0000
Bug 1471947, bug 1471948 - Enable Shadow DOM and Custom Elements in release builds, r=ehsan, emilio
e70b1d7ba1ebeb23000e6c1a97dafafd6b79a324: Bug 1480780 - Merge the privacy.3rdpartystorage.enabled pref with the network.cookie.cookieBehavior pref; r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 10 Aug 2018 15:55:22 -0400 - rev 828890
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1480780 - Merge the privacy.3rdpartystorage.enabled pref with the network.cookie.cookieBehavior pref; r=ehsan This patch introduces a new cookie behavior policy called BEHAVIOR_REJECT_TRACKER. It also makes it possible to override that behavior with cookie permissions similar to other cookie behaviors.
54fe148fced876aeb78488afdc2faf6de8c4a401: Bug 1481231 - Add words to en-US dictionary. r=Ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Tue, 07 Aug 2018 08:13:32 +0700 - rev 828576
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481231 - Add words to en-US dictionary. r=Ehsan
3398b4fe1bcf27955e0a2e24afc5cfe6afc1f367: Bug 1481231 - Add words to en-US dictionary. r=Ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Tue, 07 Aug 2018 08:13:32 +0700 - rev 828545
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1481231 - Add words to en-US dictionary. r=Ehsan
6dfec7088c60115e1f7e6ca1e05a3c8de0752dd6: Bug 1480131 - AntiTrackingCommon::IsFirstPartyStorageAccessGrantFor() should not grant permission to sub-sub-iframe channels; r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 10 Aug 2018 14:55:27 -0400 - rev 828487
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1480131 - AntiTrackingCommon::IsFirstPartyStorageAccessGrantFor() should not grant permission to sub-sub-iframe channels; r=ehsan
dd81b3a3070a4e19449a8a748a8a92e108cd7311: Bug 1477961 - Add words to en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Fri, 27 Jul 2018 06:59:07 +0700 - rev 823674
Push 117765 by bmo:mstriemer@mozilla.com at Fri, 27 Jul 2018 22:16:10 +0000
Bug 1477961 - Add words to en-US dictionary. r=ehsan
5389bb094bc4f903f00d0ccfa01f96f181a9ac4e: Bug 1467797 - libmar isn't thirdparty code, remove it from the thirdparty list r=Ehsan
Sylvestre Ledru <sledru@mozilla.com> - Fri, 08 Jun 2018 16:35:46 +0200 - rev 822803
Push 117477 by bmo:sfoster@mozilla.com at Thu, 26 Jul 2018 00:31:55 +0000
Bug 1467797 - libmar isn't thirdparty code, remove it from the thirdparty list r=Ehsan MozReview-Commit-ID: OJZJJJvZ8Y
291c6c44928dd74693c48cfa9ba7ec907e409a11: Bug 1476314: Fix errors reported by infer in toolkit/*. r=Ehsan
Robert Bartlensky <rbartlensky@mozilla.com> - Mon, 23 Jul 2018 23:38:46 +0000 - rev 822465
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1476314: Fix errors reported by infer in toolkit/*. r=Ehsan Differential Revision: https://phabricator.services.mozilla.com/D2266
cfb544de8a72831a08e5f847ffae486d1f4d2a21: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 821962
Push 117233 by mratcliffe@mozilla.com at Tue, 24 Jul 2018 12:39:00 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r=Ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
8b5693e79dfd980f754bf04c06f1e1f6da5514fe: Bug 1476849 - Add words to en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Mon, 23 Jul 2018 13:31:26 +0700 - rev 821910
Push 117222 by bmo:igoldan@mozilla.com at Tue, 24 Jul 2018 09:45:34 +0000
Bug 1476849 - Add words to en-US dictionary. r=ehsan
0f1322e924e4305b45b772d5eafb339a178b9639: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 821858
Push 117203 by masayuki@d-toybox.com at Tue, 24 Jul 2018 04:52:22 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
6d47e0e50d95c7a1d0d72a4c6e88359d50700060: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 821436
Push 117094 by masayuki@d-toybox.com at Mon, 23 Jul 2018 09:52:42 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
050316e4ce307723688630e8003197322fa28f27: Bug 1477540 - Use RemoveLastElement instead of PopLastElement r?ehsan draft
Sylvestre Ledru <sledru@mozilla.com> - Sun, 22 Jul 2018 16:23:57 +0200 - rev 821279
Push 117049 by bmo:sledru@mozilla.com at Sun, 22 Jul 2018 14:25:35 +0000
Bug 1477540 - Use RemoveLastElement instead of PopLastElement r?ehsan The later is only interesting when the returned value is used MozReview-Commit-ID: 8CF5HSkcttf
20f8e61b78f5bbda8e2819ce07162f56271b9cf3: Bug 1207696 Part 4a - Make recording optional in mozilla::RefCounted, r=ehsan.
Brian Hackett <bhackett1024@gmail.com> - Sat, 21 Jul 2018 14:21:39 +0000 - rev 821254
Push 117048 by bmo:ksaini@mozilla.com at Sun, 22 Jul 2018 10:49:35 +0000
Bug 1207696 Part 4a - Make recording optional in mozilla::RefCounted, r=ehsan.
ff3c10d0cc05d15ec0e3e2d7c4d95c6dd860f0d1: Bug 1464890 - Use integers instead of raw pointer values as PRemoteSpellCheck IDs, r=ehsan.
Brian Hackett <bhackett1024@gmail.com> - Fri, 20 Jul 2018 23:57:26 +0000 - rev 821210
Push 117036 by mozilla@noorenberghe.ca at Sun, 22 Jul 2018 05:15:14 +0000
Bug 1464890 - Use integers instead of raw pointer values as PRemoteSpellCheck IDs, r=ehsan.
f64b875c168c1c6e55f6d3659139fd1f825f800c: Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan draft
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 17:27:49 +0100 - rev 820765
Push 116931 by bmo:rbartlensky@mozilla.com at Fri, 20 Jul 2018 12:16:15 +0000
Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan MozReview-Commit-ID: DUVbLo6f4G6
cffb19ef5bbb19f5c44e4bc30486496be879da90: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 820697
Push 116899 by masayuki@d-toybox.com at Fri, 20 Jul 2018 04:37:45 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
47b3297877fa9a63d33443f70fbb518659a8ced0: Bug 1476314: Fix errors reported by infer in toolkit/*. r=Ehsan
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 17:27:49 +0100 - rev 820591
Push 116887 by bmo:bbirtles@mozilla.com at Fri, 20 Jul 2018 01:05:51 +0000
Bug 1476314: Fix errors reported by infer in toolkit/*. r=Ehsan MozReview-Commit-ID: DUVbLo6f4G6
6bfb8fdddafbb2be51d0b0192bb7b93dba4719c7: Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan draft
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 17:27:49 +0100 - rev 820427
Push 116823 by bmo:rbartlensky@mozilla.com at Thu, 19 Jul 2018 14:54:27 +0000
Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan MozReview-Commit-ID: DUVbLo6f4G6
2465926fc6f815cda4b250ac9ce092593fe495cc: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 820217
Push 116753 by masayuki@d-toybox.com at Thu, 19 Jul 2018 06:22:48 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
1b81fd5d2002a208552fcfa4aac65a4871614eed: Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 3 - annotate top-level channels, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 18 Jul 2018 15:44:55 +0200 - rev 819806
Push 116674 by rwood@mozilla.com at Wed, 18 Jul 2018 17:50:11 +0000
Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 3 - annotate top-level channels, r=ehsan
2272ac475d49d4911948f7eb782a48ca0054b4db: Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 2 - tests, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 18 Jul 2018 15:44:55 +0200 - rev 819805
Push 116674 by rwood@mozilla.com at Wed, 18 Jul 2018 17:50:11 +0000
Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 2 - tests, r=ehsan
48dbdb55cabecb167d115a5d121bef6cdf005cf1: Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 1 - window.open() from top-level, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 18 Jul 2018 15:44:55 +0200 - rev 819804
Push 116674 by rwood@mozilla.com at Wed, 18 Jul 2018 17:50:11 +0000
Bug 1476324 - Storage activation via window.open(URL) applies across top-level domains - part 1 - window.open() from top-level, r=ehsan
b4dc5b34fe6ff80861abb665455c2d72dfb00eb8: Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 18 Jul 2018 00:30:05 +0900 - rev 819596
Push 116590 by masayuki@d-toybox.com at Wed, 18 Jul 2018 07:00:04 +0000
Bug 1476294 - Make HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams r?ehsan This is remaining part of bug 1450882. I forgot to update HTMLEditorDocumentCommands.cpp when I work on the bug. This patch makes HTMLEditorDocumentCommands.cpp use non-virtual methods of nsCommandParams instead of virtual methods of nsICommandParams. MozReview-Commit-ID: 12AjXbeYNOa
28acc72e0fe797f7573c17d6bd0d8bdc3dd2fe22: Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan draft
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 17:27:49 +0100 - rev 819330
Push 116513 by bmo:rbartlensky@mozilla.com at Tue, 17 Jul 2018 16:29:12 +0000
Bug 1476314: Fix errors reported by infer in toolkit/*. r?ehsan MozReview-Commit-ID: DUVbLo6f4G6
de078de9ee987f4931f40ac8d5d9e8633a14748a: Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 19:01:53 +0900 - rev 818426
Push 116267 by bmo:prathikshaprasadsuman@gmail.com at Sat, 14 Jul 2018 00:43:27 +0000
Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r=Ehsan Some callers of PLDHashTable::Search() use const_cast, some others are not const methods due to non-const PLDHashTable::Search(). This patch removes const_cast from the former and mark some methods of the latter const. MozReview-Commit-ID: C8ayoi7mXc1
9f8a3c2f65288f91b94223b69c63da6612ebee55: Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 16:56:29 +0900 - rev 818425
Push 116267 by bmo:prathikshaprasadsuman@gmail.com at Sat, 14 Jul 2018 00:43:27 +0000
Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r=Ehsan PLDHashTable::Search() does not modify any members. So, this method and methods called by it should be marked as const. MozReview-Commit-ID: 6g4jrYK1j9E
16b902cbcf267b741a51cec650b072a9b3034d89: Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r=Ehsan
Mike de Boer <mdeboer@mozilla.com> - Fri, 13 Jul 2018 13:25:02 +0200 - rev 818422
Push 116267 by bmo:prathikshaprasadsuman@gmail.com at Sat, 14 Jul 2018 00:43:27 +0000
Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r=Ehsan MozReview-Commit-ID: S6dvbV5Q5d
42710463f05b212ed5af32f0526f607ba492a905: Bug 1475236 - Expiration time for the anti-tracking permission should be controllable via pref, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 19:19:26 +0200 - rev 817941
Push 116224 by bmo:gl@mozilla.com at Fri, 13 Jul 2018 18:29:22 +0000
Bug 1475236 - Expiration time for the anti-tracking permission should be controllable via pref, r=ehsan
dee1945e42d44fa5d963356a94aec2a95104a208: Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 19:01:53 +0900 - rev 817736
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r?ehsan Some callers of PLDHashTable::Search() use const_cast, some others are not const methods due to non-const PLDHashTable::Search(). This patch removes const_cast from the former and mark some methods of the latter const. MozReview-Commit-ID: C8ayoi7mXc1
b32f7a1e75bb7d39a934847ff556692d30fbbdae: Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 13 Jul 2018 16:56:29 +0900 - rev 817735
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1475461 - part 1: Mark PLDHashTable::Search() and called by it as const r?ehsan PLDHashTable::Search() does not modify any members. So, this method and methods called by it should be marked as const. MozReview-Commit-ID: 6g4jrYK1j9E
fd398d689bff3e1a5a2ab3ba762a2eb4236cea1f: Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 20:04:21 +0900 - rev 817731
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan nsICommandParams is implemented only by nsCommandParams. So, all C++ users can treat all instances of nsICommandParams as nsCommandParams. Therefore, this patch makes all set/get value calls use non-virtual methods and all constructors directly create nsCommandParams instance. MozReview-Commit-ID: CscgK0gKp5g
61e78a2937e58bb1d9fbc4218a35d1875c242cb1: Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:48:43 +0900 - rev 817730
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan nsCommandParams is used internally but accessed via nsICommandParams. For such internal users, nsCommandParams should have non-virtual methods to get/set values. The new method names are similar to Preferences API for consistency with it. MozReview-Commit-ID: FJwWMFzV9w
b88ed9efd16d2ead93396c66eaf205295b3f923d: Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:04:46 +0900 - rev 817729
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r?ehsan nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat char. However, this makes their callers complicated. So, they should be rewritten as treating nsACString. MozReview-Commit-ID: DWO9veSyzyG
6d93793b56508954b74bf467396e43efcf9d8f9a: Bug 1450882 - part 1: Make nsICommandParams builtinclass r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 16:50:44 +0900 - rev 817728
Push 116152 by masayuki@d-toybox.com at Fri, 13 Jul 2018 11:42:50 +0000
Bug 1450882 - part 1: Make nsICommandParams builtinclass r?ehsan nsICommandParams is not implemented with JS. Therefore, we can make it builtinclass. MozReview-Commit-ID: Gutw79akyaJ
83aecdb2656b372b7b7bb35014f9f35e22043872: Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r?ehsan draft bug-1463860
Mike de Boer <mdeboer@mozilla.com> - Fri, 13 Jul 2018 13:25:02 +0200 - rev 817725
Push 116149 by mdeboer@mozilla.com at Fri, 13 Jul 2018 11:25:45 +0000
Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r?ehsan MozReview-Commit-ID: S6dvbV5Q5d
bbca8d90968e7c82f084e89385509bfde123e9ff: Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 3 - image cache, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 12:02:19 +0200 - rev 817721
Push 116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 3 - image cache, r=ehsan
aedfdb400cc1cb899af9bb189a7e34da7160773a: Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 2 - subresources, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 12:02:19 +0200 - rev 817720
Push 116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 2 - subresources, r=ehsan
36b513077735f95a2e60d8e829edcc9fa6a9bfaf: Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 1 - tests, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 12:02:19 +0200 - rev 817719
Push 116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1475189 - Block storage access in tracking sub-resources when not in iframes - part 1 - tests, r=ehsan
620bc27fbb62bd6f59646b023d105ecfd6087271: Bug 1474812 - No needs to store granted storage access in nsILoadInfo and in the inner window, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Jul 2018 12:02:19 +0200 - rev 817718
Push 116148 by bmo:ntim.bugs@gmail.com at Fri, 13 Jul 2018 11:20:56 +0000
Bug 1474812 - No needs to store granted storage access in nsILoadInfo and in the inner window, r=ehsan
da50b3158af37d5b3dacd133fd302ea639767fd1: Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 20:04:21 +0900 - rev 817644
Push 116140 by dgottwald@mozilla.com at Fri, 13 Jul 2018 10:03:29 +0000
Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r=Ehsan nsICommandParams is implemented only by nsCommandParams. So, all C++ users can treat all instances of nsICommandParams as nsCommandParams. Therefore, this patch makes all set/get value calls use non-virtual methods and all constructors directly create nsCommandParams instance. MozReview-Commit-ID: CscgK0gKp5g
da27408845b366b1547d27539f23cd25936c4980: Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:48:43 +0900 - rev 817643
Push 116140 by dgottwald@mozilla.com at Fri, 13 Jul 2018 10:03:29 +0000
Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r=Ehsan nsCommandParams is used internally but accessed via nsICommandParams. For such internal users, nsCommandParams should have non-virtual methods to get/set values. The new method names are similar to Preferences API for consistency with it. MozReview-Commit-ID: FJwWMFzV9w
cc00b4d8d55784d343ae3779ad7ad4223543b0c9: Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:04:46 +0900 - rev 817642
Push 116140 by dgottwald@mozilla.com at Fri, 13 Jul 2018 10:03:29 +0000
Bug 1450882 - part 2: Make nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat nsACString instead of char r=Ehsan nsICommandParams::GetCStringValue() and nsICommandParams::SetCStringValue() treat char. However, this makes their callers complicated. So, they should be rewritten as treating nsACString. MozReview-Commit-ID: DWO9veSyzyG
1a9c6868329019bd23b15c4eafb44cc00edf225e: Bug 1450882 - part 1: Make nsICommandParams builtinclass r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 16:50:44 +0900 - rev 817641
Push 116140 by dgottwald@mozilla.com at Fri, 13 Jul 2018 10:03:29 +0000
Bug 1450882 - part 1: Make nsICommandParams builtinclass r=Ehsan nsICommandParams is not implemented with JS. Therefore, we can make it builtinclass. MozReview-Commit-ID: Gutw79akyaJ
c4a35489d5260947294fb388d2f56877d704755d: Bug 1474651 - Grant storage access to 3rd party, tracking resource on window.open(), r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 11 Jul 2018 12:38:47 +0200 - rev 817393
Push 116059 by dholbert@mozilla.com at Thu, 12 Jul 2018 16:48:41 +0000
Bug 1474651 - Grant storage access to 3rd party, tracking resource on window.open(), r=ehsan
f2cdeaad8fbd3e280fe1bda7fbbf02f9f3edbae2: Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 20:04:21 +0900 - rev 817240
Push 115998 by masayuki@d-toybox.com at Thu, 12 Jul 2018 08:45:13 +0000
Bug 1450882 - part 4: Make C++ users of nsICommandParams use nsCommandParams directly r?ehsan nsICommandParams is implemented only by nsCommandParams. So, all C++ users can treat all instances of nsICommandParams as nsCommandParams. Therefore, this patch makes all set/get value calls use non-virtual methods and all constructors directly create nsCommandParams instance. MozReview-Commit-ID: CscgK0gKp5g
7e2bd4863d280bf822b22853fa469b08f68eddfc: Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 10 Jul 2018 18:48:43 +0900 - rev 817239
Push 115998 by masayuki@d-toybox.com at Thu, 12 Jul 2018 08:45:13 +0000
Bug 1450882 - part 3: Create non-virtual methods to nsCommandParams and expose its header r?ehsan nsCommandParams is used internally but accessed via nsICommandParams. For such internal users, nsCommandParams should have non-virtual methods to get/set values. The new method names are similar to Preferences API for consistency with it. MozReview-Commit-ID: FJwWMFzV9w