searching for reviewer(dholbert)
739bf37ecf82398f5ddcb59251ddf26bdb2bc899: Bug 1485581 - Makes nsImageFrame::GetMinISize and nsImageFrame::GetPrefISize "writing-mode responsive" r?dholbert draft default tip
Zhang Junzhi <zjz@zjz.name> - Fri, 24 Aug 2018 14:59:27 +0800 - rev 831146
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1485581 - Makes nsImageFrame::GetMinISize and nsImageFrame::GetPrefISize "writing-mode responsive" r?dholbert MozReview-Commit-ID: G3S4sfW6j9r
675288974991830a083a7d8d4f761fa8ab4db493: Bug 1485465 - Cleanup SVG mapped attribute parser. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 21:30:36 +0200 - rev 831078
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1485465 - Cleanup SVG mapped attribute parser. r=dholbert * Remove use counters since they're useless right now and I'm re-implementing them in bug 1425700 (I'll cleanup UseCounterFor and friends later). * Rename some stuff to be clearer (TakeDeclarationBlock instead of GetDeclarationBlock). * Don't allocate a new URLExtraData for each mapped attribute, cache them in the parser instead. CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D4006
56f2449400965d832609c3a658cd9281e7db10d6: Bug 1425700 - Cleanup SVG mapped attribute parser. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 21:30:36 +0200 - rev 831076
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1425700 - Cleanup SVG mapped attribute parser. r=dholbert * Remove use counters since they're useless right now and I'm re-implementing them in bug 1425700 (I'll cleanup UseCounterFor and friends later). * Rename some stuff to be clearer (TakeDeclarationBlock instead of GetDeclarationBlock). * Don't allocate a new URLExtraData for each mapped attribute, cache them in the parser instead. Differential Revision: https://phabricator.services.mozilla.com/D4006
4fca1f7a874da0e7824d4337c40f96462d5f1c03: Bug 1369941 - Provide more advice about how to write fuzzy() annotations on reftests. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 22 Aug 2018 02:14:06 +0000 - rev 830733
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1369941 - Provide more advice about how to write fuzzy() annotations on reftests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3940
5e7484d3b2e3ad6ec39e7af04601742a3ff7643e: Bug 1369941 - Remove ability to specify fuzzy()/fuzzy-if() in reftest manifests without ranges. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 22 Aug 2018 02:14:03 +0000 - rev 830732
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1369941 - Remove ability to specify fuzzy()/fuzzy-if() in reftest manifests without ranges. r=dholbert I'm removing this no-longer-used feature because it promotes a behavior (using the default 0 minimum) that means we never see reports of unexpected passes when the bugs are fixed, and thus aren't protected from the bugs regressing again. Differential Revision: https://phabricator.services.mozilla.com/D3566
6d8d234a983ae65eee63239a8536dd24428f6db1: Bug 1484559 - Ensure that the scroll frame deregister its refresh driver observers (mAsyncScroll & mAsyncSmoothMSDScroll) before it's destroyed. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 21 Aug 2018 14:55:22 +0200 - rev 830519
Push 118839 by mixedpuppy@gmail.com at Tue, 21 Aug 2018 18:59:46 +0000
Bug 1484559 - Ensure that the scroll frame deregister its refresh driver observers (mAsyncScroll & mAsyncSmoothMSDScroll) before it's destroyed. r=dholbert
bdbea15cf0ba472eb2f2ee2c968f74d903091519: Bug 1469741 part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert
Xidorn Quan <me@upsuper.org> - Mon, 20 Aug 2018 18:50:33 +0000 - rev 830389
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1469741 part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert Depends on D3578 The 16px and 8px in this patch are chosen rather arbitrary. We used to have a minimum width of 16px for scrollbar, which comes from `scrollbarbutton` rule in `xulscrollbars.css`. But that rule got removed in https://hg.mozilla.org/mozilla-central/rev/76149510c0f0 as part of bug 1475033. Differential Revision: https://phabricator.services.mozilla.com/D3579
5477aa895b6c983f52325a3841571f4c4ba8f7f6: Bug 1397768 part 1: Make 'display: flex/grid' in a button take up all the available space. r=dholbert
Mihir Iyer <miyer@mozilla.com> - Fri, 17 Aug 2018 07:36:50 -0700 - rev 830117
Push 118817 by bmo:ntim.bugs@gmail.com at Mon, 20 Aug 2018 09:00:50 +0000
Bug 1397768 part 1: Make 'display: flex/grid' in a button take up all the available space. r=dholbert
b107fee86cbae4bc30815c89a2590bb052dd57c8: Bug 1483808 - Make webkit device-pixel-ratio media queries a proper alias to resolution. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Aug 2018 21:25:37 +0000 - rev 830093
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483808 - Make webkit device-pixel-ratio media queries a proper alias to resolution. r=dholbert According to the spec: https://compat.spec.whatwg.org/#css-media-queries-webkit-device-pixel-ratio And to the Chromium implementation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/media_query_evaluator.cc?l=366&rcl=1d7328865bcf06a687aafc18ff95d55317030672 They're no different than resolution. In our implementation `resolution` does slightly different stuff. Given we still haven't shipped -webkit-device-pixel-ratio, making this match resolution looks better than the opposite. Differential Revision: https://phabricator.services.mozilla.com/D3588
c80952ce66dc0d7634983c24ef94035f20c12085: Bug 1483972 - Allow videocontrols to initialize without style r=jaws,dholbert!,jaws!
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 17 Aug 2018 20:43:46 +0000 - rev 830089
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483972 - Allow videocontrols to initialize without style r=jaws,dholbert!,jaws! This crash happens because nsVideoFrame didn't know what to do with two children in the UA Widget Shadow Root. The two children are both videocontrols, with the first one being the lingering DOM inserted by first constructor call that throws. The subsequent appendChild of the same element caused the videocontrols to be initialized again, since the previous run didn't return a widget instance to UAWidgetsChild. The fix here removes the throw statement added in https://hg.mozilla.org/mozilla-central/rev/dca187f7c72c#l3.15 , allowing the constructor to complete. Without this statement, we will rely on assertion in the test here https://hg.mozilla.org/mozilla-central/rev/4ddca5eb06c2#l2.18 to fail on slower platforms to ensure the stylesheet is loaded synchronously. An alternative fix would be to wrap up the contructor in a try catch block from UAWidgetsChild and make sure the DOM is cleaned up when the constructor throw. That however will hide the error thrown so I decided to remove the throw statement instead. Differential Revision: https://phabricator.services.mozilla.com/D3560
c7d40b7574ca1232500e08763889084bfb128592: Bug 1484306 Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Aug 2018 10:56:25 -0700 - rev 830083
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484306 Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3645
3b91ab5a0554cfd1f9aca2ca768a3605cf908cfe: Bug 1484306 Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Aug 2018 10:37:50 -0700 - rev 830082
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484306 Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock(). r=dholbert This API is similar to Vec::Split() in Rust. https://doc.rust-lang.org/std/vec/struct.Vec.html#method.split Differential Revision: https://phabricator.services.mozilla.com/D3644
82e6a73d898550923ba779aac4f5c39d4b04dc8d: Bug 1484306 Part 1 - Add nsFrameList::FrameLinkEnumerator::Find(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 14 Aug 2018 13:00:48 -0700 - rev 830081
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1484306 Part 1 - Add nsFrameList::FrameLinkEnumerator::Find(). r=dholbert Use it to implement FindFirstBlock() and FindFirstNonBlock(). This is a demonstration on how Find() is used. The usage of them will be overhauled in Part 2 and 3. Differential Revision: https://phabricator.services.mozilla.com/D3642
c56ddef04468e4b7fd99ae6452bbca093420a76e: Bug 1483211 - Make fieldset UA rule use min-inline-size instead of min-width. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Aug 2018 14:59:19 +0000 - rev 830015
Push 118809 by bmo:ntim.bugs@gmail.com at Sat, 18 Aug 2018 10:35:28 +0000
Bug 1483211 - Make fieldset UA rule use min-inline-size instead of min-width. r=dholbert Per https://github.com/whatwg/html/pull/3914 Differential Revision: https://phabricator.services.mozilla.com/D3486
cfecf5444baf6d15aca77461d9fc3daac59458e6: Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols> r=dholbert,smaug
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 27 Jun 2018 11:12:38 -0700 - rev 829671
Push 118788 by bmo:dharvey@mozilla.com at Thu, 16 Aug 2018 11:52:55 +0000
Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols> r=dholbert,smaug This prevents XBL binding from being attached, and create the Shadow Root to host controls to be created by the script. Shadow Root and the JS controls are lazily constructed when the controls attribute is set. Set nsVideoFrame as dynamic-leaf so it will ignore content child frames when the controls are XBL anonymous content, and handles child frames from controls in the Shadow DOM. The content nodes are still ignored since there is no <slot>s in our Shadow DOM. MozReview-Commit-ID: 3hk41iMa07n
809eca6fc4b705a51ddf3381ee20bad9864b06bc: Bug 1472843 - Implement justify-content:left/right/start/end, align-content:start/end, align-self:self-start/self-end for flexbox. r=dholbert
Mihir Iyer <miyer@mozilla.com> - Fri, 03 Aug 2018 07:56:32 -0700 - rev 829555
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1472843 - Implement justify-content:left/right/start/end, align-content:start/end, align-self:self-start/self-end for flexbox. r=dholbert This commit also removes some cases & warnings about unsupported values that have now been removed from the css alignment spec. Specifically: "justify-content:[last] baseline" and "align-self/align-content: left/right".
0bbf7aa0ab2e54adcd0f2234e77a4603b6c4dd2b: Bug 1482665 Part 5 - Remove nsDeviceContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Aug 2018 15:25:59 -0700 - rev 828904
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482665 Part 5 - Remove nsDeviceContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3158
ed67e5b2479a9d37ccfeeb5d215acb89e37c3c45: Bug 1482665 Part 4 - Remove nsDeviceContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 11 Aug 2018 15:17:50 -0700 - rev 828903
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482665 Part 4 - Remove nsDeviceContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3157
67c05f411b4867ed39c83a70226b527fadd9d3b0: Bug 1482665 Part 3 - Remove nsPresContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 Aug 2018 21:59:25 -0700 - rev 828902
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482665 Part 3 - Remove nsPresContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3156
f61b7e1a0216dc7e006526e266e0ab4bc7ef084d: Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 Aug 2018 21:46:23 -0700 - rev 828901
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3155
975fd6febbeabdaf741f859f7f8b60ef1b297480: Bug 1482665 Part 1 - Add constexpr to mozilla::AppUnitsPerCSSPixel() and mozilla::AppUnitsPerCSSInch(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 Aug 2018 21:53:41 -0700 - rev 828900
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1482665 Part 1 - Add constexpr to mozilla::AppUnitsPerCSSPixel() and mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3154
7717c47bd4ed667fa6dd0148f8653a2a57692754: Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert
Xidorn Quan <me@upsuper.org> - Mon, 13 Aug 2018 00:07:35 +0000 - rev 828703
Push 118697 by bmo:ntim.bugs@gmail.com at Mon, 13 Aug 2018 11:00:31 +0000
Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2817
be0650692abc58dd1cd19b0051df9b1b0f409e5d: Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Mon, 23 Jul 2018 11:04:50 -0700 - rev 828495
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert MozReview-Commit-ID: 2gRm0LOUTI6
b580e5b9f9e43851d654fc93c6777a655c875c62: Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Mon, 23 Jul 2018 11:04:50 -0700 - rev 828234
Push 118651 by bmo:guptatrisha97@gmail.com at Fri, 10 Aug 2018 11:02:58 +0000
Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert MozReview-Commit-ID: 2gRm0LOUTI6
e3a6f64071f2f1f82da639a7d09749839d5f053b: Bug 1369941: Replace single integers N in fuzzy() and fuzzy-if() with 0-N ranges. r=dholbert
L. David Baron <dbaron@dbaron.org> - Thu, 09 Aug 2018 20:10:21 +0000 - rev 828221
Push 118651 by bmo:guptatrisha97@gmail.com at Fri, 10 Aug 2018 11:02:58 +0000
Bug 1369941: Replace single integers N in fuzzy() and fuzzy-if() with 0-N ranges. r=dholbert This patch was written entirely by the following script: #!/bin/bash if [ ! -d "./.hg" ] then echo "Not in a source tree." 1>&2 exit 1 fi find . -regex '.*\(ref\|crash\)test.*\.list' | while read FILENAME do echo "Processing ${FILENAME}." # The following has four substitutions: # * The first one replaces the *first* argument to fuzzy() when it doesn't # have a - in it, by replacing it with an explicit 0-N range. # * The second one does the same for the *second* argument to fuzzy(). # * The third does the same for the *second* argument to fuzzy-if(). # * The fourth does the same for the *third* argument to fuzzy-if(). # # Note that this is using perl rather than sed because perl doesn't # support non-greedy matching, which is needed for the first argument to # fuzzy-if. perl -pi -e 's/(fuzzy\()([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy\([^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,)([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,[^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g' "${FILENAME}" done Differential Revision: https://phabricator.services.mozilla.com/D2974
ddfa5cc2ea30007e1a26c235ead93879c37d9b2b: Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert
Xidorn Quan <me@upsuper.org> - Wed, 08 Aug 2018 00:02:40 +0000 - rev 827526
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2817
6897f3935cc77f531ce4b1ac5f5b6febdb010c58: Bug 1479859 patch 4 - Test becoming a containing block for contain:paint only for those frames that support it. r=dholbert
L. David Baron <dbaron@dbaron.org> - Tue, 07 Aug 2018 15:02:08 -0700 - rev 827444
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1479859 patch 4 - Test becoming a containing block for contain:paint only for those frames that support it. r=dholbert This fixes the regression of three web-platform-test reftests: testing/web-platform/tests/css/css-contain/contain-paint-002.html testing/web-platform/tests/css/css-contain/contain-paint-011.html testing/web-platform/tests/css/css-contain/contain-paint-012.html that was caused by patch 1, but it's written on top of the code in patches 2 and 3 so it's easier to fix afterwards. Differential Revision: https://phabricator.services.mozilla.com/D2812
8e24328ba71484dd144b9d0d2fdd287a9327c1b4: Bug 1479859 patch 3 - Add an nsIFrame::IsFrameOfType bit to say whether frames support contain:layout and contain:paint. r=dholbert
L. David Baron <dbaron@dbaron.org> - Tue, 07 Aug 2018 15:02:07 -0700 - rev 827443
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1479859 patch 3 - Add an nsIFrame::IsFrameOfType bit to say whether frames support contain:layout and contain:paint. r=dholbert This is needed for patch 4. This is based both on the wording in the spec and the discussion in https://github.com/w3c/csswg-drafts/issues/2987, and also doesn't support them for nsMathMLContainerFrame, which is similar to inlines and ruby. Differential Revision: https://phabricator.services.mozilla.com/D2815
1510b4502e368b76b80dc7379f19307626be1c3e: Bug 1478550 - Adjust IsInnerTableStyle to fail for table captions. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Thu, 26 Jul 2018 14:09:52 -0700 - rev 827075
Push 118457 by bmo:rbarker@mozilla.com at Mon, 06 Aug 2018 23:14:39 +0000
Bug 1478550 - Adjust IsInnerTableStyle to fail for table captions. r=dholbert MozReview-Commit-ID: 6CK1XEYWsTl
f0edb2e07f56b63a19e2382593fccf9ae0d36cc8: Bug 1480946 - systemLanguage should be case insensitive r=dholbert
Robert Longson <longsonr@gmail.com> - Mon, 06 Aug 2018 21:47:20 +0100 - rev 827073
Push 118457 by bmo:rbarker@mozilla.com at Mon, 06 Aug 2018 23:14:39 +0000
Bug 1480946 - systemLanguage should be case insensitive r=dholbert
5947eab0392411a7d710225b0d2b635dcf550f0e: Bug 1479528: Move all the data-finding related stuff into a single function. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jul 2018 14:44:45 +0200 - rev 826241
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1479528: Move all the data-finding related stuff into a single function. r=dholbert To make it hopefully a bit easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D2564 MozReview-Commit-ID: 2LMf7IXM1kr
935ad68fc5db5270bd95b3f5ee37ad086b0b2626: Bug 1479528: Move the XBL binding loads a bit more away. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jul 2018 14:42:26 +0200 - rev 826240
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1479528: Move the XBL binding loads a bit more away. r=dholbert They're pretty ugly... Differential Revision: https://phabricator.services.mozilla.com/D2563 MozReview-Commit-ID: CUDUyfe9Bgp
cd23a7207dbbec30a3d1682d678ed76d73a6248b: Bug 1479528: Make the ShouldSuppressFrameIn* functions take references. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jul 2018 14:36:39 +0200 - rev 826239
Push 118275 by bmo:dharvey@mozilla.com at Fri, 03 Aug 2018 11:44:33 +0000
Bug 1479528: Make the ShouldSuppressFrameIn* functions take references. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2562 MozReview-Commit-ID: 8lcn1XW4aik
347512fd214e57f6b9b9468e59aba51188b6cc98: Bug 1473047 - Re-resolve row-gap percentages after intrinsic block size calculated. r=dholbert
Mihir Iyer <miyer@mozilla.com> - Tue, 24 Jul 2018 11:38:54 -0700 - rev 825320
Push 118072 by plingurar@mozilla.com at Wed, 01 Aug 2018 12:45:02 +0000
Bug 1473047 - Re-resolve row-gap percentages after intrinsic block size calculated. r=dholbert MozReview-Commit-ID: EHX1WFvqwr1
ca5ab353b5d8e35cb757098ff4bcce04269f2101: Bug 1470176 - Implement contain:size for fieldset objects. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Tue, 17 Jul 2018 13:14:39 -0700 - rev 823444
Push 117683 by dgottwald@mozilla.com at Fri, 27 Jul 2018 11:18:41 +0000
Bug 1470176 - Implement contain:size for fieldset objects. r=dholbert MozReview-Commit-ID: ImkclemDA9o
cddbe5dcda33356157c2bc9556622816d94bccfc: Bug 1477871 - Extract the construction of nsColumnSetFrame into a helper function. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Jul 2018 17:40:50 +0000 - rev 822938
Push 117537 by bmo:hskupin@gmail.com at Thu, 26 Jul 2018 12:55:33 +0000
Bug 1477871 - Extract the construction of nsColumnSetFrame into a helper function. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2312
ee7691f46e506db60d3a892024484f5080bc30ea: Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Wed, 25 Jul 2018 22:32:00 +1000 - rev 822834
Push 117479 by xquan@mozilla.com at Thu, 26 Jul 2018 00:48:20 +0000
Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert This attribute is added for the next commit that scrollcorner can be made transparent for non-top level scrollbars on GTK like scrollbar tracks. MozReview-Commit-ID: FCxvdUfL5Pf
f2bbf5569cccd5715432fac1768d636490016043: Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Wed, 25 Jul 2018 22:32:00 +1000 - rev 822831
Push 117478 by xquan@mozilla.com at Thu, 26 Jul 2018 00:42:28 +0000
Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert This attribute is added for the next commit that scrollcorner can be made transparent for non-top level scrollbars on GTK like scrollbar tracks. MozReview-Commit-ID: FCxvdUfL5Pf
3daf4818b56febff04ca3e6a505d2f799802b692: Bug 1478001: Gate testing the inaccessible values on the pref. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 24 Jul 2018 20:47:57 +0200 - rev 822675
Push 117440 by maglione.k@gmail.com at Wed, 25 Jul 2018 17:29:55 +0000
Bug 1478001: Gate testing the inaccessible values on the pref. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2332 MozReview-Commit-ID: AeQ4r8Yjs9J
62f4d1504b705ff0f43a0c92641fd1e428d91b2d: Bug 1471894 Part 3: Update expectation to pass for parts of a WPT test. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 24 Jul 2018 13:51:37 -0700 - rev 822612
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1471894 Part 3: Update expectation to pass for parts of a WPT test. r=dholbert MozReview-Commit-ID: K6nU6C76gZg
16989caa105538b382160c13cad8f1df0b41438d: Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 12 Jul 2018 11:55:32 -0700 - rev 822611
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu
b9a62b4744fe816f77672f6ca25a3335d114ac74: Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Jul 2018 16:52:33 -0700 - rev 822610
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg
c80e056d1c4aa51ca3541378b9344a0077872a6e: Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert draft
Xidorn Quan <me@upsuper.org> - Wed, 25 Jul 2018 22:32:00 +1000 - rev 822484
Push 117388 by xquan@mozilla.com at Wed, 25 Jul 2018 12:34:26 +0000
Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert MozReview-Commit-ID: FCxvdUfL5Pf
bce3c6ca2e19a87381564a4a3cae0c0896482159: Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 12 Jul 2018 11:55:32 -0700 - rev 822467
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu
6ab2fb71689916e17561195cc1581c4feb5e330f: Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Jul 2018 16:52:33 -0700 - rev 822466
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg
a20576472778d0a95794696082e7fce72b13634b: Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 12 Jul 2018 11:55:32 -0700 - rev 822459
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu
7342b2da7568dfd99ee2ba0f3219ef41bde2d07c: Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Jul 2018 16:52:33 -0700 - rev 822458
Push 117382 by bmo:rob@robwu.nl at Wed, 25 Jul 2018 11:45:57 +0000
Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg
b5b99243334103cbe6cf4cb1c89c0a2fc15653f9: Bug 1478138 - micro-optimize frame property lookup; r=dholbert
Nathan Froyd <froydnj@mozilla.com> - Tue, 24 Jul 2018 19:25:28 -0400 - rev 822365
Push 117352 by bmo:igoldan@mozilla.com at Wed, 25 Jul 2018 06:16:19 +0000
Bug 1478138 - micro-optimize frame property lookup; r=dholbert Once we've determined an index for the frame property, we don't need to pay the overhead of checking whether that index is in bounds for the array again on the next access. It would be nice if we could avoid that overhead for removal, too, but since there's no API for that, we'll just remove the overhead for accesses.
189749cc1e12d39a956c9973b40593242e9733ab: Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 12 Jul 2018 11:55:32 -0700 - rev 822228
Push 117316 by bgrinstead@mozilla.com at Tue, 24 Jul 2018 22:25:31 +0000
Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu
194afde62e6959c718bf9138135b559914d3442d: Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 11 Jul 2018 16:52:33 -0700 - rev 822227
Push 117316 by bgrinstead@mozilla.com at Tue, 24 Jul 2018 22:25:31 +0000
Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg