Bug 1485581 - Makes nsImageFrame::GetMinISize and nsImageFrame::GetPrefISize "writing-mode responsive" r?dholbert MozReview-Commit-ID: G3S4sfW6j9r

Bug 1485465 - Cleanup SVG mapped attribute parser. r=dholbert * Remove use counters since they're useless right now and I'm re-implementing them in bug 1425700 (I'll cleanup UseCounterFor and friends later). * Rename some stuff to be clearer (TakeDeclarationBlock instead of GetDeclarationBlock). * Don't allocate a new URLExtraData for each mapped attribute, cache them in the parser instead. CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D4006

Bug 1425700 - Cleanup SVG mapped attribute parser. r=dholbert * Remove use counters since they're useless right now and I'm re-implementing them in bug 1425700 (I'll cleanup UseCounterFor and friends later). * Rename some stuff to be clearer (TakeDeclarationBlock instead of GetDeclarationBlock). * Don't allocate a new URLExtraData for each mapped attribute, cache them in the parser instead. Differential Revision: https://phabricator.services.mozilla.com/D4006

Bug 1369941 - Provide more advice about how to write fuzzy() annotations on reftests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3940

Bug 1369941 - Remove ability to specify fuzzy()/fuzzy-if() in reftest manifests without ranges. r=dholbert I'm removing this no-longer-used feature because it promotes a behavior (using the default 0 minimum) that means we never see reports of unexpected passes when the bugs are fixed, and thus aren't protected from the bugs regressing again. Differential Revision: https://phabricator.services.mozilla.com/D3566

Bug 1484559 - Ensure that the scroll frame deregister its refresh driver observers (mAsyncScroll & mAsyncSmoothMSDScroll) before it's destroyed. r=dholbert

Bug 1469741 part 2 - Ensure scrollbar has a width even when it's not supported by the theme. r=dholbert Depends on D3578 The 16px and 8px in this patch are chosen rather arbitrary. We used to have a minimum width of 16px for scrollbar, which comes from `scrollbarbutton` rule in `xulscrollbars.css`. But that rule got removed in https://hg.mozilla.org/mozilla-central/rev/76149510c0f0 as part of bug 1475033. Differential Revision: https://phabricator.services.mozilla.com/D3579

Bug 1397768 part 1: Make 'display: flex/grid' in a button take up all the available space. r=dholbert

Bug 1483808 - Make webkit device-pixel-ratio media queries a proper alias to resolution. r=dholbert According to the spec: https://compat.spec.whatwg.org/#css-media-queries-webkit-device-pixel-ratio And to the Chromium implementation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/media_query_evaluator.cc?l=366&rcl=1d7328865bcf06a687aafc18ff95d55317030672 They're no different than resolution. In our implementation `resolution` does slightly different stuff. Given we still haven't shipped -webkit-device-pixel-ratio, making this match resolution looks better than the opposite. Differential Revision: https://phabricator.services.mozilla.com/D3588

Bug 1483972 - Allow videocontrols to initialize without style r=jaws,dholbert!,jaws! This crash happens because nsVideoFrame didn't know what to do with two children in the UA Widget Shadow Root. The two children are both videocontrols, with the first one being the lingering DOM inserted by first constructor call that throws. The subsequent appendChild of the same element caused the videocontrols to be initialized again, since the previous run didn't return a widget instance to UAWidgetsChild. The fix here removes the throw statement added in https://hg.mozilla.org/mozilla-central/rev/dca187f7c72c#l3.15 , allowing the constructor to complete. Without this statement, we will rely on assertion in the test here https://hg.mozilla.org/mozilla-central/rev/4ddca5eb06c2#l2.18 to fail on slower platforms to ensure the stylesheet is loaded synchronously. An alternative fix would be to wrap up the contructor in a try catch block from UAWidgetsChild and make sure the DOM is cleaned up when the constructor throw. That however will hide the error thrown so I decided to remove the throw statement instead. Differential Revision: https://phabricator.services.mozilla.com/D3560

Bug 1484306 Part 3 - Use nsFrameList::Split() to replace the usage of FindFirstBlock(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3645

Bug 1484306 Part 2 - Add nsFrameList::Split(), and use it to replace the usage of FindFirstNonBlock(). r=dholbert This API is similar to Vec::Split() in Rust. https://doc.rust-lang.org/std/vec/struct.Vec.html#method.split Differential Revision: https://phabricator.services.mozilla.com/D3644

Bug 1484306 Part 1 - Add nsFrameList::FrameLinkEnumerator::Find(). r=dholbert Use it to implement FindFirstBlock() and FindFirstNonBlock(). This is a demonstration on how Find() is used. The usage of them will be overhauled in Part 2 and 3. Differential Revision: https://phabricator.services.mozilla.com/D3642

Bug 1483211 - Make fieldset UA rule use min-inline-size instead of min-width. r=dholbert Per https://github.com/whatwg/html/pull/3914 Differential Revision: https://phabricator.services.mozilla.com/D3486

Bug 1431255 - Part II, Create a Shadow Root in HTMLMediaElement when enabled, skipping <xul:videocontrols> r=dholbert,smaug This prevents XBL binding from being attached, and create the Shadow Root to host controls to be created by the script. Shadow Root and the JS controls are lazily constructed when the controls attribute is set. Set nsVideoFrame as dynamic-leaf so it will ignore content child frames when the controls are XBL anonymous content, and handles child frames from controls in the Shadow DOM. The content nodes are still ignored since there is no <slot>s in our Shadow DOM. MozReview-Commit-ID: 3hk41iMa07n

Bug 1472843 - Implement justify-content:left/right/start/end, align-content:start/end, align-self:self-start/self-end for flexbox. r=dholbert This commit also removes some cases & warnings about unsupported values that have now been removed from the css alignment spec. Specifically: "justify-content:[last] baseline" and "align-self/align-content: left/right".

Bug 1482665 Part 5 - Remove nsDeviceContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3158

Bug 1482665 Part 4 - Remove nsDeviceContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3157

Bug 1482665 Part 3 - Remove nsPresContext::AppUnitsPerCSSInch() and replace it with mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3156

Bug 1482665 Part 2 - Remove nsPresContext::AppUnitsPerCSSPixel() and replace it with mozilla::AppUnitsPerCSSPixel(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3155

Bug 1482665 Part 1 - Add constexpr to mozilla::AppUnitsPerCSSPixel() and mozilla::AppUnitsPerCSSInch(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D3154

Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2817

Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert MozReview-Commit-ID: 2gRm0LOUTI6

Bug 1476495 - Treat overflow in contain:layout elements as ink overflow. r=dholbert MozReview-Commit-ID: 2gRm0LOUTI6

Bug 1369941: Replace single integers N in fuzzy() and fuzzy-if() with 0-N ranges. r=dholbert This patch was written entirely by the following script: #!/bin/bash if [ ! -d "./.hg" ] then echo "Not in a source tree." 1>&2 exit 1 fi find . -regex '.*\(ref\|crash\)test.*\.list' | while read FILENAME do echo "Processing ${FILENAME}." # The following has four substitutions: # * The first one replaces the *first* argument to fuzzy() when it doesn't # have a - in it, by replacing it with an explicit 0-N range. # * The second one does the same for the *second* argument to fuzzy(). # * The third does the same for the *second* argument to fuzzy-if(). # * The fourth does the same for the *third* argument to fuzzy-if(). # # Note that this is using perl rather than sed because perl doesn't # support non-greedy matching, which is needed for the first argument to # fuzzy-if. perl -pi -e 's/(fuzzy\()([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy\([^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,)([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,[^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g' "${FILENAME}" done Differential Revision: https://phabricator.services.mozilla.com/D2974

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant C++ functions are updated to take a typed enum. JavaScript calls are unaffected but they will throw if the string argument does not correspond to one of the known entries in the C++ enum. The existing whitelists and blacklists of annotations are also generated from the YAML file and all duplicate code related to them has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included in the list (and some obsolete ones have been removed) and all call sites have been updated including tests where appropriate.

Bug 1478178 - Sync the condition in ApplyFrameJustification as that in ComputeFrameJustification. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2817

Bug 1479859 patch 4 - Test becoming a containing block for contain:paint only for those frames that support it. r=dholbert This fixes the regression of three web-platform-test reftests: testing/web-platform/tests/css/css-contain/contain-paint-002.html testing/web-platform/tests/css/css-contain/contain-paint-011.html testing/web-platform/tests/css/css-contain/contain-paint-012.html that was caused by patch 1, but it's written on top of the code in patches 2 and 3 so it's easier to fix afterwards. Differential Revision: https://phabricator.services.mozilla.com/D2812

Bug 1479859 patch 3 - Add an nsIFrame::IsFrameOfType bit to say whether frames support contain:layout and contain:paint. r=dholbert This is needed for patch 4. This is based both on the wording in the spec and the discussion in https://github.com/w3c/csswg-drafts/issues/2987, and also doesn't support them for nsMathMLContainerFrame, which is similar to inlines and ruby. Differential Revision: https://phabricator.services.mozilla.com/D2815

Bug 1478550 - Adjust IsInnerTableStyle to fail for table captions. r=dholbert MozReview-Commit-ID: 6CK1XEYWsTl

Bug 1480946 - systemLanguage should be case insensitive r=dholbert

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.

Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.

Bug 1479528: Move all the data-finding related stuff into a single function. r=dholbert To make it hopefully a bit easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D2564 MozReview-Commit-ID: 2LMf7IXM1kr

Bug 1479528: Move the XBL binding loads a bit more away. r=dholbert They're pretty ugly... Differential Revision: https://phabricator.services.mozilla.com/D2563 MozReview-Commit-ID: CUDUyfe9Bgp

Bug 1479528: Make the ShouldSuppressFrameIn* functions take references. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2562 MozReview-Commit-ID: 8lcn1XW4aik

Bug 1473047 - Re-resolve row-gap percentages after intrinsic block size calculated. r=dholbert MozReview-Commit-ID: EHX1WFvqwr1

Bug 1470176 - Implement contain:size for fieldset objects. r=dholbert MozReview-Commit-ID: ImkclemDA9o

Bug 1477871 - Extract the construction of nsColumnSetFrame into a helper function. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2312

Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert This attribute is added for the next commit that scrollcorner can be made transparent for non-top level scrollbars on GTK like scrollbar tracks. MozReview-Commit-ID: FCxvdUfL5Pf

Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert This attribute is added for the next commit that scrollcorner can be made transparent for non-top level scrollbars on GTK like scrollbar tracks. MozReview-Commit-ID: FCxvdUfL5Pf

Bug 1478001: Gate testing the inaccessible values on the pref. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D2332 MozReview-Commit-ID: AeQ4r8Yjs9J

Bug 1471894 Part 3: Update expectation to pass for parts of a WPT test. r=dholbert MozReview-Commit-ID: K6nU6C76gZg

Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu

Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg

Bug 1464723 part 2 - Add root attribute for scrollcorner. r?dholbert MozReview-Commit-ID: FCxvdUfL5Pf

Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu

Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg

Bug 1471894 Part 2: Add a web-platform-test to check computed margin values on auto margin blocks. r=dholbert MozReview-Commit-ID: KbSZzhoX5mu

Bug 1471894 Part 1: Ensure that absolute positioned blocks with auto margins update their UsedMargin property. r=dholbert MozReview-Commit-ID: EFIQVvazkTg