searching for reviewer(dbaron)
a4eef4b8a3b0c8560d548ebf0a5ef2f2e17cbb23: Bug 488725: Don't position floats in a nowrap context until hitting a break opportunity. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Aug 2018 16:16:50 +0200 - rev 831074
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 488725: Don't position floats in a nowrap context until hitting a break opportunity. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D3900
975546ce7e13698d4e9a31aef70e89c8b2ded1e1: Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 23:29:22 +0000 - rev 831025
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats No reason to pass our own member as an argument. Differential Revision: https://phabricator.services.mozilla.com/D4000
6c3db80981da2613b3e58c4904dec3504b7476d8: Bug 1481951 part 2: Adjust reftest contain-layout-overflow-002.html to be clearer & have accurate expectations. r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 20 Aug 2018 12:43:14 -0700 - rev 830440
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1481951 part 2: Adjust reftest contain-layout-overflow-002.html to be clearer & have accurate expectations. r=dbaron This test is basically a copy of its -001 variant, with some "float:left" sprinkled around on contained descendants. Before this patch, this test had an additional arbitrary sizing difference as compared to the -001 version -- there's one element that arbitrarily has class "outer" in the -002 test whereas it has class "inner-lg" in the -001 version. These classes have different sizing characteristics, which makes a difference to whether scrollbars show up, because this element is not contained (though it is a layout container itself). This patch undoes this arbitrary difference and also adds a "float" class to make it easier to see which elements we've sprinkled float styling onto. Differential Revision: https://phabricator.services.mozilla.com/D3826
e47a225b907eb38f5f7f671e3296235ac0f26a46: Bug 1481951 part 1: Adjust contain-layout-overflow-* reftests to remove unused rule for nonexistent class "inner-md". r=dbaron
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 20 Aug 2018 12:45:06 -0700 - rev 830439
Push 118832 by bmo:ntim.bugs@gmail.com at Tue, 21 Aug 2018 13:33:17 +0000
Bug 1481951 part 1: Adjust contain-layout-overflow-* reftests to remove unused rule for nonexistent class "inner-md". r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D3825
e0ddd48b0a8f092c05f3d254e346407929b43f30: Bug 1460075 - Use 1px as the minimum column width. r=dbaron
Ting-Yu Lin <tlin@mozilla.com> - Mon, 13 Aug 2018 17:48:42 +0000 - rev 828932
Push 118727 by bmo:rbartlensky@mozilla.com at Tue, 14 Aug 2018 10:49:39 +0000
Bug 1460075 - Use 1px as the minimum column width. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D3140
9a6728f46269868c5f24f18c95cd2319b5b67a0a: Bug 1472919 - Establish stacking context, containing block, independent formatting context for contain:layout. r=dbaron
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Fri, 20 Jul 2018 10:57:22 -0700 - rev 828521
Push 118683 by bmo:gl@mozilla.com at Sat, 11 Aug 2018 20:18:50 +0000
Bug 1472919 - Establish stacking context, containing block, independent formatting context for contain:layout. r=dbaron MozReview-Commit-ID: H36HpePX29C
2a818faa9c1b717f8e47d77e6683b7b68ad9e3ec: Bug 1467541 - Add a test for opening the layout debugger. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Thu, 09 Aug 2018 10:53:01 +0300 - rev 827981
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1467541 - Add a test for opening the layout debugger. r=dbaron Summary: Reviewers: dbaron Reviewed By: dbaron Bug #: 1467541 Differential Revision: https://phabricator.services.mozilla.com/D2691
5ed009eaad1c07c0898aafb982eb0e39652b8dad: Bug 1467541 - Remove dead layout debug files. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Thu, 09 Aug 2018 10:52:54 +0300 - rev 827980
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1467541 - Remove dead layout debug files. r=dbaron Summary: No longer used since it stopped being built as an extension. Reviewers: dbaron Reviewed By: dbaron Bug #: 1467541 Differential Revision: https://phabricator.services.mozilla.com/D2663
db5198c10a4b0b3a0e837faef01931d60dd2fee1: Bug 1467541 - Package layout debugger in debug builds. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Thu, 09 Aug 2018 10:52:49 +0300 - rev 827979
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1467541 - Package layout debugger in debug builds. r=dbaron Reviewers: dbaron Reviewed By: dbaron Bug #: 1467541 Differential Revision: https://phabricator.services.mozilla.com/D2665
8fae317831c1181b33603699455c71dfe58e51f6: Bug 1481097 - layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. r=dbaron
Chris Peterson <cpeterson@mozilla.com> - Sat, 21 Jul 2018 23:48:16 -0700 - rev 827503
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1481097 - layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. r=dbaron This gcc 4.9.2 workaround (from bug 1273048) is no longer needed because Firefox for Android now uses clang instead of gcc (as of bug 1163171). The gcc bug was fixed in gcc 4.8.5 and 4.9.3: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64037 MozReview-Commit-ID: IAKONNSkqcz
114a3bb0d922d148b1d3605214a8e27bd71e9646: Bug 1481097 - layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. r?dbaron draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 21 Jul 2018 23:48:16 -0700 - rev 826870
Push 118399 by cpeterson@mozilla.com at Sun, 05 Aug 2018 22:49:36 +0000
Bug 1481097 - layout: Remove nsCSSPseudoElements workaround for gcc 4.9.2 bug. r?dbaron This gcc 4.9.2 workaround (from bug 1273048) is no longer needed because Firefox for Android now uses clang instead of gcc (as of bug 1163171). The gcc bug was fixed in gcc 4.8.5 and 4.9.3: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64037 MozReview-Commit-ID: IAKONNSkqcz
9c9b31d0ed536a7e694c0a5894dd843b605bc9f2: Bug 1478455 - Add overflow-wrap: normal for table to html.css. r=dbaron
Xidorn Quan <me@upsuper.org> - Thu, 02 Aug 2018 01:18:26 +0000 - rev 825792
Push 118170 by plingurar@mozilla.com at Thu, 02 Aug 2018 10:24:36 +0000
Bug 1478455 - Add overflow-wrap: normal for table to html.css. r=dbaron This would fix this bug as well as webcompat/web-bugs#17900. The argument for this to be a reasonable change is that, table cells can never shrink below the min intrinsic size, so overflow-wrap: break-word doesn't make any sense in table when it didn't affect intrinsic size. So this change basically revert the behavior of bug 1472386 for tables which seems to be the biggest problem so far. Differential Revision: https://phabricator.services.mozilla.com/D2638
a05794e5045319a1e7b879b5e662a970ddc0af11: Bug 1476437 - Correct original-text indexing when checking for explicit hyphens in text where auto-hyphenation is enabled. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:36 +0100 - rev 823820
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1476437 - Correct original-text indexing when checking for explicit hyphens in text where auto-hyphenation is enabled. r=dbaron
fbb04354c2cfa8f9c4e9649d6b5aea6d046fce44: Bug 1476437 - Further reftest for multi-line content with whitespace/explicit-hyphen/autohyphenation. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:30 +0100 - rev 823819
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1476437 - Further reftest for multi-line content with whitespace/explicit-hyphen/autohyphenation. r=dbaron
af1cdd4b96b3c5a698920c0c85ffb59a25d1a84f: Bug 1476437 - Reftest for interaction between whitespace collapsing, explicit hyphen, and auto-hyphenation. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:26 +0100 - rev 823818
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1476437 - Reftest for interaction between whitespace collapsing, explicit hyphen, and auto-hyphenation. r=dbaron
0f907558ec7fb75682b2accbf489f3a3b577fbb7: Bug 1478574 - Fix off-by-one error in marking explicit hyphens, so we don't introduce spurious pre-hyphen breaks. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:11 +0100 - rev 823817
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1478574 - Fix off-by-one error in marking explicit hyphens, so we don't introduce spurious pre-hyphen breaks. r=dbaron
5f98633a0e8ff67fd7a3c8bf6635903dcf4da2f1: Bug 1478574 - Reftest for interaction of explicit hyphen and auto-hyphenation in the same word. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:22:44 +0100 - rev 823816
Push 117797 by maglione.k@gmail.com at Sun, 29 Jul 2018 00:38:49 +0000
Bug 1478574 - Reftest for interaction of explicit hyphen and auto-hyphenation in the same word. r=dbaron
d8d3c9e7b8323246f21a8142571b99fc5f80b93b: Bug 1476437 - Correct original-text indexing when checking for explicit hyphens in text where auto-hyphenation is enabled. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:36 +0100 - rev 823757
Push 117779 by bmo:imanol@mozilla.com at Sat, 28 Jul 2018 10:35:42 +0000
Bug 1476437 - Correct original-text indexing when checking for explicit hyphens in text where auto-hyphenation is enabled. r=dbaron
280aff154491784a3b60d33dd2a890f6fb7c557c: Bug 1476437 - Further reftest for multi-line content with whitespace/explicit-hyphen/autohyphenation. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:30 +0100 - rev 823756
Push 117779 by bmo:imanol@mozilla.com at Sat, 28 Jul 2018 10:35:42 +0000
Bug 1476437 - Further reftest for multi-line content with whitespace/explicit-hyphen/autohyphenation. r=dbaron
e17db916959eee773c39a3aeae719c5012b2b043: Bug 1476437 - Reftest for interaction between whitespace collapsing, explicit hyphen, and auto-hyphenation. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:26 +0100 - rev 823755
Push 117779 by bmo:imanol@mozilla.com at Sat, 28 Jul 2018 10:35:42 +0000
Bug 1476437 - Reftest for interaction between whitespace collapsing, explicit hyphen, and auto-hyphenation. r=dbaron
144a3d2b7da90c29baa22d40f692a8fe011fae34: Bug 1478574 - Fix off-by-one error in marking explicit hyphens, so we don't introduce spurious pre-hyphen breaks. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:23:11 +0100 - rev 823754
Push 117779 by bmo:imanol@mozilla.com at Sat, 28 Jul 2018 10:35:42 +0000
Bug 1478574 - Fix off-by-one error in marking explicit hyphens, so we don't introduce spurious pre-hyphen breaks. r=dbaron
edb45de7ff9d0704cfaa84ab47788bf0d6d53b4d: Bug 1478574 - Reftest for interaction of explicit hyphen and auto-hyphenation in the same word. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sat, 28 Jul 2018 09:22:44 +0100 - rev 823753
Push 117779 by bmo:imanol@mozilla.com at Sat, 28 Jul 2018 10:35:42 +0000
Bug 1478574 - Reftest for interaction of explicit hyphen and auto-hyphenation in the same word. r=dbaron
028ea79c0322a541a51f0b89d14e367b297810d4: Bug 1474768: Fix nsInlineFrame::ReflowInlineFrame to properly detect whether we'll pull from a next-in-flow. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 21 Jul 2018 01:09:24 +0200 - rev 821217
Push 117036 by mozilla@noorenberghe.ca at Sun, 22 Jul 2018 05:15:14 +0000
Bug 1474768: Fix nsInlineFrame::ReflowInlineFrame to properly detect whether we'll pull from a next-in-flow. r=dbaron The key difference is checking the overflow lists from the next in flows, which is something that PullOneFrame does but ReflowInlineFrame didn't. MozReview-Commit-ID: I1JwOOeIBo9
61470c6169b5be7cd63a424c03ca3f1c424eccdb: Bug 1474768: Remove useless aIsComplete out-param. r=dbaron
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 21 Jul 2018 00:42:08 +0200 - rev 821216
Push 117036 by mozilla@noorenberghe.ca at Sun, 22 Jul 2018 05:15:14 +0000
Bug 1474768: Remove useless aIsComplete out-param. r=dbaron *aIsComplete == !theReturnedFrame. This is cleanup after bug 15999, technically :) MozReview-Commit-ID: L1ZVOxEZXce
d29652fbe483408bdf71dfcdde38bb40d5936138: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 820794
Push 116935 by jdescottes@mozilla.com at Fri, 20 Jul 2018 12:30:54 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
4894ad1626a229ea4287e4ab95c39c0230fb4523: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 820793
Push 116935 by jdescottes@mozilla.com at Fri, 20 Jul 2018 12:30:54 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
1f0f8ed5b376f01f155e8402f5582a25ae927f63: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 820792
Push 116935 by jdescottes@mozilla.com at Fri, 20 Jul 2018 12:30:54 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b
110ac69396f6d676a38720e572bcaa75b6efd1e6: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:24:10 +0100 - rev 820349
Push 116791 by bmo:rbartlensky@mozilla.com at Thu, 19 Jul 2018 12:43:15 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron MozReview-Commit-ID: 4xlmEZ4O8d
f56a9a4a666fc61e69ba537a69e3161b58083d02: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 820202
Push 116747 by gsquelart@mozilla.com at Thu, 19 Jul 2018 05:17:20 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
ec99f380c978c6d28135490401beb0bb54c8e2b3: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 820201
Push 116747 by gsquelart@mozilla.com at Thu, 19 Jul 2018 05:17:20 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
ee55a9ae7408e1f2603c1b2bc80ddcd8dbc837f0: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 820200
Push 116747 by gsquelart@mozilla.com at Thu, 19 Jul 2018 05:17:20 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b
1f88feb37c81e9ee2249a278656910038addd4b4: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 820093
Push 116721 by bmo:gsquelart@mozilla.com at Wed, 18 Jul 2018 21:40:10 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
75683abb8a395d6907c0d5cd7bdc49094626c2d7: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 820092
Push 116721 by bmo:gsquelart@mozilla.com at Wed, 18 Jul 2018 21:40:10 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
1843675b1d86d52771f3e4927cbb8991b2781a65: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 820091
Push 116721 by bmo:gsquelart@mozilla.com at Wed, 18 Jul 2018 21:40:10 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b
2b3b18d4f22d8e27de3d83eaed634039e9be37fa: Bug 1467688 - Make sure we invalidate for perspective changes even if the frame isn't otherwise transformed. r=dbaron, a=lizzard
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 02 Jul 2018 21:35:14 -0400 - rev 819975
Push 116707 by bmo:jaws@mozilla.com at Wed, 18 Jul 2018 20:27:08 +0000
Bug 1467688 - Make sure we invalidate for perspective changes even if the frame isn't otherwise transformed. r=dbaron, a=lizzard MozReview-Commit-ID: JQGb41kp76P
349cb73fa71a74d2cc866b2768de62ca80160dcf: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:24:10 +0100 - rev 819789
Push 116671 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 17:00:34 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron MozReview-Commit-ID: 4xlmEZ4O8d
6f640915f3cc3c3f49f964cd8741a523db6081f4: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:24:10 +0100 - rev 819788
Push 116670 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 16:55:54 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp r?dbaron MozReview-Commit-ID: 35yFxXV3JXG
a822214c81ee4a14333c2bf91c717f0a0e824c8e: Bug 1476646: Fix DEAD_STORE in DOMtoATK.cpp r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:40:17 +0100 - rev 819782
Push 116666 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 16:41:41 +0000
Bug 1476646: Fix DEAD_STORE in DOMtoATK.cpp r?dbaron MozReview-Commit-ID: 96QLS7GzjR5
310badc07f7039410a0ee355c2cd1f908b523a2a: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:32:58 +0100 - rev 819781
Push 116665 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 16:34:22 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron MozReview-Commit-ID: DcYZqzuS4FG
6047bc23399790a9e498146e8438c53b23223da9: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:24:10 +0100 - rev 819779
Push 116663 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 16:25:29 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron MozReview-Commit-ID: 8BO1dc2K8Gn
ab9e92a3fb3ae3a239da2a9a7e480d37e6dc12b5: Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron draft
Robert Bartlensky <rbartlensky@mozilla.com> - Wed, 18 Jul 2018 17:02:48 +0100 - rev 819776
Push 116660 by bmo:rbartlensky@mozilla.com at Wed, 18 Jul 2018 16:12:37 +0000
Bug 1476646: Fix DEAD_STORE error in accessible/atk/DOMtoATK.cpp. r?dbaron MozReview-Commit-ID: HZre7IcnjCw
e74179fba06626cf2398b622d80135743a66beac: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 819497
Push 116567 by gsquelart@mozilla.com at Wed, 18 Jul 2018 00:09:43 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
0ace95df00236540b544c06a644795475c7495b5: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 819496
Push 116567 by gsquelart@mozilla.com at Wed, 18 Jul 2018 00:09:43 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
d233b6bc426652eb540cd9e0ade9fe7e7474a8b7: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 819495
Push 116567 by gsquelart@mozilla.com at Wed, 18 Jul 2018 00:09:43 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b
a761975f398f8f0f3216bb0e3d2cc45b80db6c4b: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 819489
Push 116562 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 22:54:34 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
f18f789433074010a26778aeba8159625d7785df: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 819488
Push 116562 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 22:54:34 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
02432ef731867be475e05de87639eb492fbec307: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 819487
Push 116562 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 22:54:34 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b
3c5b71e350d67f353ae38543c86fa6414217ec10: Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 15:35:48 +1000 - rev 819280
Push 116489 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 13:37:35 +0000
Bug 1459937 - In DEBUG mode, verify that reparenting direction is correct - r=dbaron MozReview-Commit-ID: JPfg9YtBm6M
3b9b8f4b269a0526c15cb020fc7d536c016422d1: Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jul 2018 11:36:33 +1000 - rev 819279
Push 116489 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 13:37:35 +0000
Bug 1459937 - Mark pulled floats (from pulled lines) dirty - r=dbaron Similar to lines (see previous patch), floats from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first floats from the previous column they will not be reflowed as needed. MozReview-Commit-ID: KKrwtzeQMrI
5707e2d7ac2dd4b1c6c2804ad5f5cc388420ec6f: Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jul 2018 11:42:47 +1000 - rev 819278
Push 116489 by bmo:gsquelart@mozilla.com at Tue, 17 Jul 2018 13:37:35 +0000
Bug 1459937 - Mark pulled lines (from n-i-f or overflow) dirty - r=dbaron Lines pulled from next-in-flow or overflow frames have probably not been marked dirty (as ReflowInput hasn't dealt with them when it was constructed), so we need to mark them dirty for proper reflow. If we don't do that, and they don't fit in the current column, the next column will only mark its current children dirty, so when pulling back its first lines from the previous column they will not be reflowed as needed, which causes this bug. MozReview-Commit-ID: 8GFO1ZWuZ1b