searching for reviewer(bz)
6cd69a56e853b2f2f3ef42e1ef406030cfbc9c1f: Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen
James Willcox <snorp@snorp.net> - Fri, 03 Aug 2018 14:48:31 -0500 - rev 830803
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen MozReview-Commit-ID: IhVC9nU60fy
5ca6befe8b6f5d64addfd0145ad0ad423d4373b5: Bug 1483597 - Remove the unneeded GetRootElement() check in bug 1261536, r=bz
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 15 Aug 2018 09:28:32 -0700 - rev 829550
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1483597 - Remove the unneeded GetRootElement() check in bug 1261536, r=bz
376ec8be8307c9bf77ce1fee4c08f79aec3e7404: Bug 1480244: Follow-up: Re-add kungFuDeathGrip for mTabChildMessageManager. r=bz
Kris Maglione <maglione.k@gmail.com> - Wed, 15 Aug 2018 11:13:15 -0700 - rev 829540
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1480244: Follow-up: Re-add kungFuDeathGrip for mTabChildMessageManager. r=bz
0097284827171bc1214caecd658832f393cb8bde: Bug 1482170 - Remove <Add/Remove>BroadcastListenerFor on XULDocument webidl. r=bz
Brendan Dahl <bdahl@mozilla.com> - Thu, 09 Aug 2018 09:18:40 -0700 - rev 829465
Push 118782 by bmo:mtigley@mozilla.com at Thu, 16 Aug 2018 04:40:36 +0000
Bug 1482170 - Remove <Add/Remove>BroadcastListenerFor on XULDocument webidl. r=bz These methods are only ever used in tests and no longer need to be exposed. In test_bug445177.xul I tried to preserve more of the test, but everything after the call to addBroadcastListenerFor is dependent on that. MozReview-Commit-ID: C4vAxNir4O8
2844aaceec5f3ef74b4dac5359c38c568130c82e: Bug 1261536 - Create a synthetic document after the window is set - r=bz
Gerald Squelart <gsquelart@mozilla.com> - Tue, 14 Aug 2018 14:53:17 -0700 - rev 829244
Push 118755 by michael.l.comella@gmail.com at Wed, 15 Aug 2018 01:48:30 +0000
Bug 1261536 - Create a synthetic document after the window is set - r=bz
c7a263321e999b1806b8facd31177ca026a7a33f: Bug 1480244: Part 4 - Make child message managers non-global objects. r=bz
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:03:18 -0700 - rev 829171
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1480244: Part 4 - Make child message managers non-global objects. r=bz This is mostly self-explanatory. However, the patch also contains some minor changes to frame scripts which expect to be able to call message manager methods with a null target object, which stops working when they stop being global objects. MozReview-Commit-ID: HDT2RvK3F3L
2aac9238b59e5e7b1422d82d7f71e3a001465300: Bug 1480244: Part 1c - Rename TabChildGlobal to TabChildMessageManager. r=bz
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:04:23 -0700 - rev 829166
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1480244: Part 1c - Rename TabChildGlobal to TabChildMessageManager. r=bz MozReview-Commit-ID: ECtFjFV7dZa
6760912e7b0330c082654ed2c3039321150fde9b: Bug 1480244: Part 1b - Rename nsInProcessTabChildGlobal to InProcessTabChildMessageManager. r=bz
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:08:07 -0700 - rev 829165
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1480244: Part 1b - Rename nsInProcessTabChildGlobal to InProcessTabChildMessageManager. r=bz MozReview-Commit-ID: GgleVt1tXTG
bfd2f668e16cf0794f06e0349185c47a88a4f0b4: Bug 1480244: Part 1a - Rename ProcessGlobal to ContentProcessMessageManager. r=bz
Kris Maglione <maglione.k@gmail.com> - Thu, 02 Aug 2018 15:03:50 -0700 - rev 829164
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1480244: Part 1a - Rename ProcessGlobal to ContentProcessMessageManager. r=bz After these patches, these objects will no longer be globals, which would make their current names misleading. Parts 1a-1c give more appropriate names to the bindings which will cease to be globals. MozReview-Commit-ID: L8GolQaHnO5
823dbd89637cf9c0847de7957932220bcc6905a0: Bug 1472491: Part 1 - Add [ChromeOnly] wantUntrusted event listener option. r=bz
Kris Maglione <maglione.k@gmail.com> - Sun, 29 Jul 2018 18:51:00 -0700 - rev 829074
Push 118745 by maglione.k@gmail.com at Tue, 14 Aug 2018 20:34:55 +0000
Bug 1472491: Part 1 - Add [ChromeOnly] wantUntrusted event listener option. r=bz This is the same as the non-standard 4th addEventListener argument, but in a more standard place. Aside from being easier for readers to understand, this makes it much easier to define a set of DOM events an IPC actor needs to handle, without adding extra hacks to handle untrusted listeners. MozReview-Commit-ID: H6KxjSHtQrY
9345ad05c0c590d9dae02c0d2e3b9903fc92985f: Bug 1480843 - Avoid hazard by controlling order of operations so that we GC before using any GC heap pointers, r=bz
Steve Fink <sfink@mozilla.com> - Fri, 03 Aug 2018 10:47:21 -0700 - rev 828881
Push 118725 by jhofmann@mozilla.com at Tue, 14 Aug 2018 08:20:30 +0000
Bug 1480843 - Avoid hazard by controlling order of operations so that we GC before using any GC heap pointers, r=bz
5c9a4d66f5f3f8ff76b64824b8fbb66c310a7443: Bug 1472020 - Make AccessibleCaret a bit saner. r=bz,TYLin
"Emilio Cobos Álvarez" <emilio@crisal.io> - Mon, 13 Aug 2018 11:56:48 +0200 - rev 828748
Push 118704 by bmo:rcaliman@mozilla.com at Mon, 13 Aug 2018 16:58:07 +0000
Bug 1472020 - Make AccessibleCaret a bit saner. r=bz,TYLin Avoid processing anon content in nsCanvasFrame, then getting more anon content via AccessibleCaretEventHub::Init. Instead call Init before creating the custom content container. We could also throw a script runner at it I guess, but this prevents the reentrancy issue. Avoid cloning nodes during layout, just use the same node (already cloned in InsertAnonymousContent) instead. The RemoveChild in GetAnonymousContent to handle the reframes instead of cloning around is a bit hacky, but I don't think it's really worth extending PostDestroyData for this special case. Differential Revision: https://phabricator.services.mozilla.com/D1889
be076323bc70bf5d80261efe1504b4ae54497f98: Bug 1480244: Part 4 - Make child message managers non-global objects. r=bz draft
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:03:18 -0700 - rev 828432
Push 118679 by maglione.k@gmail.com at Fri, 10 Aug 2018 21:19:41 +0000
Bug 1480244: Part 4 - Make child message managers non-global objects. r=bz This is mostly self-explanatory. However, the patch also contains some minor changes to frame scripts which expect to be able to call message manager methods with a null target object, which stops working when they stop being global objects. MozReview-Commit-ID: HDT2RvK3F3L
e93e24a62aca9596f41e6d16045771177f38611c: Bug 1480244: Part 1c - Rename TabChildGlobal to TabChildMessageManager. r=bz draft
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:04:23 -0700 - rev 828427
Push 118679 by maglione.k@gmail.com at Fri, 10 Aug 2018 21:19:41 +0000
Bug 1480244: Part 1c - Rename TabChildGlobal to TabChildMessageManager. r=bz MozReview-Commit-ID: ECtFjFV7dZa
02a79251d27d575cf034d117ff046d1873e667e2: Bug 1480244: Part 1b - Rename nsInProcessTabChildGlobal to InProcessTabChildMessageManager. r?bz draft
Kris Maglione <maglione.k@gmail.com> - Fri, 10 Aug 2018 14:08:07 -0700 - rev 828426
Push 118679 by maglione.k@gmail.com at Fri, 10 Aug 2018 21:19:41 +0000
Bug 1480244: Part 1b - Rename nsInProcessTabChildGlobal to InProcessTabChildMessageManager. r?bz MozReview-Commit-ID: GgleVt1tXTG
7fc0798d582c20ac12bc6fc70f8adf0293c18e4b: Bug 1480244: Part 1a - Rename ProcessGlobal to ContentProcessMessageManager. r=bz draft
Kris Maglione <maglione.k@gmail.com> - Thu, 02 Aug 2018 15:03:50 -0700 - rev 828425
Push 118679 by maglione.k@gmail.com at Fri, 10 Aug 2018 21:19:41 +0000
Bug 1480244: Part 1a - Rename ProcessGlobal to ContentProcessMessageManager. r=bz After these patches, these objects will no longer be globals, which would make their current names misleading. Parts 1a-1c give more appropriate names to the bindings which will cease to be globals. MozReview-Commit-ID: L8GolQaHnO5
57b3bf1ab55270eec274b7cac8e44bd0b8355484: Bug 1472491: Add [ChromeOnly] wantUntrusted event listener option. r?bz draft
Kris Maglione <maglione.k@gmail.com> - Sun, 29 Jul 2018 18:51:00 -0700 - rev 828377
Push 118679 by maglione.k@gmail.com at Fri, 10 Aug 2018 21:19:41 +0000
Bug 1472491: Add [ChromeOnly] wantUntrusted event listener option. r?bz This is the same as the non-standard 4th addEventListener argument, but in a more standard place. Aside from being easier for readers to understand, this makes it much easier to define a set of DOM events an IPC actor needs to handle, without adding extra hacks to handle untrusted listeners. MozReview-Commit-ID: H6KxjSHtQrY
0d58330c8fbc730be0ea41f70e7db04e9b7ae2cf: Bug 1482002 - add nsCaseInsensitiveStringComparator default constructor r=bz
Paul Bone <pbone@mozilla.com> - Thu, 09 Aug 2018 14:37:30 +1000 - rev 828191
Push 118647 by bmo:gl@mozilla.com at Fri, 10 Aug 2018 06:14:44 +0000
Bug 1482002 - add nsCaseInsensitiveStringComparator default constructor r=bz
b0ec47e587d71b21697da7b762262ece6ad22020: Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen draft
James Willcox <snorp@snorp.net> - Fri, 03 Aug 2018 14:48:31 -0500 - rev 828055
Push 118624 by bmo:snorp@snorp.net at Thu, 09 Aug 2018 20:07:39 +0000
Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen MozReview-Commit-ID: IhVC9nU60fy
81cb351bae8945fd07e7b4753c9a4d91220df52f: Bug 1480678 part 12 - Do a CheckedUnwrap in AudioContext::DecodeAudioData to ensure we don't have a CCW. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Aug 2018 10:48:29 +0200 - rev 827986
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1480678 part 12 - Do a CheckedUnwrap in AudioContext::DecodeAudioData to ensure we don't have a CCW. r=bz Note that right now aBuffer.Obj() will never be a cross-compartment wrapper anyway, because that can only happen when we're calling a WebIDL constructor, and this is not a constructor.
27e04584ae0fb6ce64ad5ad2d90e09bf6c73da4f: Bug 1480678 part 11 - Wrap the typed array in the current compartment instead of entering its realm in WriteStructuredCloneImageData. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Aug 2018 10:48:29 +0200 - rev 827985
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1480678 part 11 - Wrap the typed array in the current compartment instead of entering its realm in WriteStructuredCloneImageData. r=bz This is also better security-wise: if we're writing the structured clone in some compartment that shouldn't have access to the underlying data of the ImageData, we shouldn't be giving that access here.
f189ec6420b67a91e26283d968329e728d97e211: Bug 1480678 part 10 - Remove unnecessary realm entering in TCPSocket::Send. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Aug 2018 10:48:29 +0200 - rev 827984
Push 118619 by bmo:mtigley@mozilla.com at Thu, 09 Aug 2018 18:23:03 +0000
Bug 1480678 part 10 - Remove unnecessary realm entering in TCPSocket::Send. r=bz
75783eff9dc424c69b444ed31aeeef6960535092: Bug 1473026, remove the now unused selectionRegion from TreeBoxObject, r=paolo,bz
Neil Deakin <neil@mozilla.com> - Tue, 07 Aug 2018 09:32:07 -0400 - rev 827917
Push 118602 by wisniewskit@gmail.com at Thu, 09 Aug 2018 14:58:37 +0000
Bug 1473026, remove the now unused selectionRegion from TreeBoxObject, r=paolo,bz
271ad78ecd803a2baf59be86975aad3084fa1bd9: Bug 1481286 - Move command dispatcher from XULDocument to Document. r=bz
Brendan Dahl <bdahl@mozilla.com> - Tue, 07 Aug 2018 09:29:14 -0700 - rev 827795
Push 118585 by bmo:gl@mozilla.com at Thu, 09 Aug 2018 06:54:14 +0000
Bug 1481286 - Move command dispatcher from XULDocument to Document. r=bz Allows non-XUL chrome privilege documents to also use the command dispatcher. The command dispatcher is created lazily since it will not always be used. Update test to reflect removal of the XUL attribute "commandDispatcher" from content privilege XUL. MozReview-Commit-ID: HUXMG9kx4ft
fc0dcbca21b57768a0bcd3aee60ed496318e9574: Bug 1481286 - Use a custom element to add/remove command updater. r=bz
Brendan Dahl <bdahl@mozilla.com> - Tue, 07 Aug 2018 09:01:54 -0700 - rev 827794
Push 118585 by bmo:gl@mozilla.com at Thu, 09 Aug 2018 06:54:14 +0000
Bug 1481286 - Use a custom element to add/remove command updater. r=bz Create a "commandset" custom element that performs the job of adding and removing command updaters that XULDocument use to do. Previously, the "commandupdater" attribute was allowed on any element, but in tree it is only every used on "commandset" elements. MozReview-Commit-ID: HUXMG9kx4ft
dc3ee665001f01a78281fdf2ccf8abf1c7852065: Bug 1481467 part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in XrayTraits::attachExpandoObject. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Aug 2018 15:14:02 +0200 - rev 827648
Push 118551 by bmo:mtigley@mozilla.com at Wed, 08 Aug 2018 15:37:58 +0000
Bug 1481467 part 3 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in XrayTraits::attachExpandoObject. r=bz Because XrayTraits::attachExpandoObject operates in the Xray target realm/compartment and we cannot use the Xray wrapper with JSAutoRealm, we pass the caller's global as exclusiveWrapperGlobal and use that. This also changes XrayWrapper<Base, Traits>::defineProperty to call ensureExpandoObject in the wrapper (instead of target) realm. This didn't matter before, because ensureExpandoObject immediately entered the target realm anyway.
8b38554d067fb3b071b19f630219a385ce6241b3: Bug 1481467 part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in JSXrayTraits::getOwnPropertyFromTargetIfSafe. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Aug 2018 15:12:16 +0200 - rev 827647
Push 118551 by bmo:mtigley@mozilla.com at Wed, 08 Aug 2018 15:37:58 +0000
Bug 1481467 part 2 - Use JSAutoRealm instead of JSAutoRealmAllowCCW in JSXrayTraits::getOwnPropertyFromTargetIfSafe. r=bz Because getOwnPropertyFromTargetIfSafe operates in the Xray target realm/compartment and we cannot use the Xray wrapper with JSAutoRealm, we pass the caller's global as wrapperGlobal and use that.
630049a9ac3b24ec0a141669937df372373a5d6f: Bug 1416328 - Part 2. Expose decoding attribute for img elements. r=bz,tnikkel
Andrew Osmond <aosmond@mozilla.com> - Wed, 08 Aug 2018 07:56:01 -0400 - rev 827573
Push 118551 by bmo:mtigley@mozilla.com at Wed, 08 Aug 2018 15:37:58 +0000
Bug 1416328 - Part 2. Expose decoding attribute for img elements. r=bz,tnikkel This adds support for HTMLImageElement's decoding attribute, as described by: https://github.com/whatwg/html/pull/3221 https://whatpr.org/html/3221/images.html#decoding-images It also exposes the same attribute on SVGImageElement, just as Blink has chosen to do so.
b3a5c5824ad80ae96997eb84a8d921372850a9fe: Bug 1451172, fallback to current global in FindAssociatedGlobal when nsIGlobalObject doesn't have JS object anymore, r=bz
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 08 Aug 2018 09:07:47 +0300 - rev 827556
Push 118551 by bmo:mtigley@mozilla.com at Wed, 08 Aug 2018 15:37:58 +0000
Bug 1451172, fallback to current global in FindAssociatedGlobal when nsIGlobalObject doesn't have JS object anymore, r=bz
4499e3d8db74476575db679105d7871f37296131: Bug 1479508 Part 3: Update test expectations. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 16:02:57 -0700 - rev 827537
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1479508 Part 3: Update test expectations. r=bz MozReview-Commit-ID: Haf4LTUwDOc
905043dccccb12d8bb7af14440e02bfdd8fd5e2a: Bug 1479508 Part 2: Change GetElementsWithGrid to use a more conservative traversal that skips subtrees without frames. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 15:33:06 -0700 - rev 827536
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1479508 Part 2: Change GetElementsWithGrid to use a more conservative traversal that skips subtrees without frames. r=bz MozReview-Commit-ID: 1hTQD8LoLQw
22e1e1559e3990e0cf9567c0dae87f861ffe9a3f: Bug 1479508 Part 1: Move devtools-specific function definitions in Element.webidl into a better-documented partial interface. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 11:52:21 -0700 - rev 827535
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1479508 Part 1: Move devtools-specific function definitions in Element.webidl into a better-documented partial interface. r=bz MozReview-Commit-ID: 6227lasylzN
ecda4eb7431ab8d606c51d00fc6e34b25100904c: Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r=bz,jmaher,aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 07 Aug 2018 14:03:21 -0700 - rev 827463
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r=bz,jmaher,aswan Loading SpecialPowers into frame scripts has side-effects, detailed in part 1, which are undesirable. The main side-effect that I'm trying to get rid of here is the force-enabling of permissive COWs in frame script scopes, which is blocking changes that I need to make elsewhere. But both that and the scope pollution it causes are likely to allow code to work when running in automation which fails in real world usage. This patch changes our special powers frame scripts to load specialpowers.js and specialpowersAPI.js as JSMs, which run in their own global, but define most of the same properties on our frame script globals. Most other callers still load those scripts via <script> tags or the subscript loader, and should ideally migrated in a follow-up. But even so, this patch still gives us a cleaner separation of the frame script and non-frame-script loading code. MozReview-Commit-ID: CR226gCDaGY
57e2128c54627239b50b70b0349d2fa93f88b4e2: Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Kris Maglione <maglione.k@gmail.com> - Tue, 07 Aug 2018 14:13:06 -0700 - rev 827462
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz Right now, a lot of test code relies on side-effects of SpecialPowers being loaded into frame script globals. In particular: - It forces permissive COWs from those scopes, which allows frame scripts to pass objects from those scopes to unprivileged content that they otherwise wouldn't. - It imports a bunch of helper modules and WebIDL globals which would otherwise not be available. Fortunately, this seems to only impact test code at this point. But there's a real down-the-road risk of it impacting shipping code, which ends up working in automation due to the side-effects of SpecialPowers, but failing in real world use. MozReview-Commit-ID: G27eSSOHymX
c53c7b0249ad3359fbc9f144f2cf9ca3b6386c59: Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r=bz,jmaher,aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 07 Aug 2018 14:03:21 -0700 - rev 827439
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r=bz,jmaher,aswan Loading SpecialPowers into frame scripts has side-effects, detailed in part 1, which are undesirable. The main side-effect that I'm trying to get rid of here is the force-enabling of permissive COWs in frame script scopes, which is blocking changes that I need to make elsewhere. But both that and the scope pollution it causes are likely to allow code to work when running in automation which fails in real world usage. This patch changes our special powers frame scripts to load specialpowers.js and specialpowersAPI.js as JSMs, which run in their own global, but define most of the same properties on our frame script globals. Most other callers still load those scripts via <script> tags or the subscript loader, and should ideally migrated in a follow-up. But even so, this patch still gives us a cleaner separation of the frame script and non-frame-script loading code. MozReview-Commit-ID: CR226gCDaGY
41bedc526dd6ec6b7e8c7be1c832ac60c81d6263: Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Kris Maglione <maglione.k@gmail.com> - Tue, 07 Aug 2018 14:13:06 -0700 - rev 827438
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz Right now, a lot of test code relies on side-effects of SpecialPowers being loaded into frame script globals. In particular: - It forces permissive COWs from those scopes, which allows frame scripts to pass objects from those scopes to unprivileged content that they otherwise wouldn't. - It imports a bunch of helper modules and WebIDL globals which would otherwise not be available. Fortunately, this seems to only impact test code at this point. But there's a real down-the-road risk of it impacting shipping code, which ends up working in automation due to the side-effects of SpecialPowers, but failing in real world use. MozReview-Commit-ID: G27eSSOHymX
e66e6bd82e3feffc432210642bd20d1479c58cf3: Bug 1441059 - Make nsILoadURIDelegate async to preserve the order of GeckoSession.loadUri() calls. r=snorp,bz
Dylan Roeh <droeh@mozilla.com> - Tue, 07 Aug 2018 13:42:07 -0500 - rev 827419
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1441059 - Make nsILoadURIDelegate async to preserve the order of GeckoSession.loadUri() calls. r=snorp,bz This alters nsILoadURIDelegate.loadURI() to return a Promise rather than spinning the event loop to synchronously return a boolean, and alters nsDocShell::InternalLoad to allow for those changes by re-calling itself if necessary based on the resolution of the promise.
e9d98e306b3c119f6ac435f5d805a5eae6a7b9f7: Bug 1481286 - Move command dispatcher from XULDocument to Document. r?bz draft
Brendan Dahl <bdahl@mozilla.com> - Tue, 07 Aug 2018 09:29:14 -0700 - rev 827281
Push 118504 by bmo:bdahl@mozilla.com at Tue, 07 Aug 2018 16:40:50 +0000
Bug 1481286 - Move command dispatcher from XULDocument to Document. r?bz Allows non-XUL chrome privilege documents to also use the command dispatcher. The command dispatcher is created lazily since it will not always be used. MozReview-Commit-ID: HUXMG9kx4ft
10b1e1d341cdbd9f3314f6e22b169ee96e69fc76: Bug 1481286 - Use a custom element to add/remove command updater. r?bz draft
Brendan Dahl <bdahl@mozilla.com> - Tue, 07 Aug 2018 09:01:54 -0700 - rev 827280
Push 118504 by bmo:bdahl@mozilla.com at Tue, 07 Aug 2018 16:40:50 +0000
Bug 1481286 - Use a custom element to add/remove command updater. r?bz Create a "commandset" custom element that performs the job of adding and removing command updaters that XULDocument use to do. Previously, the "commandupdater" attribute was allowed on any element, but in tree it is only every used on "commandset" elements. MozReview-Commit-ID: HUXMG9kx4ft
3f30b1a694972d96332c9165a6131cf400c68b44: Bug 1480678 part 7 - Use CallbackObject's callback global for realm entering in more places. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Aug 2018 14:06:44 +0200 - rev 827222
Push 118502 by bmo:mstriemer@mozilla.com at Tue, 07 Aug 2018 16:39:48 +0000
Bug 1480678 part 7 - Use CallbackObject's callback global for realm entering in more places. r=bz
0e079d9d66419da1281eeb6b6cb148899cc90e0b: Bug 1478359 - Use nsXPCWrappedJS's object global as nonCCWObject in nsFrameMessageManager::ReceiveMessage. r=bz
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Aug 2018 11:57:51 +0200 - rev 827189
Push 118488 by bmo:hsivonen@hsivonen.fi at Tue, 07 Aug 2018 12:28:14 +0000
Bug 1478359 - Use nsXPCWrappedJS's object global as nonCCWObject in nsFrameMessageManager::ReceiveMessage. r=bz
ca936adbc5650e7e06ace499d537fac25de46293: Bug 1469521 - Change storage of previous and next children in nsINode, r=bz
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 06 Aug 2018 22:29:27 +0300 - rev 827086
Push 118457 by bmo:rbarker@mozilla.com at Mon, 06 Aug 2018 23:14:39 +0000
Bug 1469521 - Change storage of previous and next children in nsINode, r=bz
6f054fef3e0bf001e5274d932b1811bd741ad8c4: Bug 1480206 - Move XULDocument popup attributes to Document. r=bz
Brendan Dahl <bdahl@mozilla.com> - Mon, 06 Aug 2018 10:52:53 -0700 - rev 827082
Push 118457 by bmo:rbarker@mozilla.com at Mon, 06 Aug 2018 23:14:39 +0000
Bug 1480206 - Move XULDocument popup attributes to Document. r=bz Allows top level non-XUL documents to share this code. Three tests had to be adjusted to account for the attributes being chrome only now and not available to content privilege XUL. In two tests, the values attributes are now simply undefined. The crashtest was converted to a chrome mochitest to preserve what it was testing. MozReview-Commit-ID: 99w9Ax4et3C
1fd314414cd44abca36f7c6085acc9105363b6df: Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r?bz,jmaher,aswan draft
Kris Maglione <maglione.k@gmail.com> - Sat, 04 Aug 2018 12:36:34 -0700 - rev 827018
Push 118440 by maglione.k@gmail.com at Mon, 06 Aug 2018 18:25:25 +0000
Bug 1481021: Part 2 - Stop loading SpecialPowers into frame script scopes. r?bz,jmaher,aswan Loading SpecialPowers into frame scripts has side-effects, detailed in part 1, which are undesirable. The main side-effect that I'm trying to get rid of here is the force-enabling of permissive COWs in frame script scopes, which is blocking changes that I need to make elsewhere. But both that and the scope pollution it causes are likely to allow code to work when running in automation which fails in real world usage. This patch changes our special powers frame scripts to load specialpowers.js and specialpowersAPI.js as JSMs, which run in their own global, but define most of the same properties on our frame script globals. Most other callers still load those scripts via <script> tags or the subscript loader, and should ideally migrated in a follow-up. But even so, this patch still gives us a cleaner separation of the frame script and non-frame-script loading code. MozReview-Commit-ID: CR226gCDaGY
7cc66d26198e3ce935ce6d080341fbf7358c98be: Bug 1480206 - Move XULDocument popup attributes to Document. r?bz draft
Brendan Dahl <bdahl@mozilla.com> - Mon, 06 Aug 2018 10:52:53 -0700 - rev 827017
Push 118439 by bmo:bdahl@mozilla.com at Mon, 06 Aug 2018 18:03:47 +0000
Bug 1480206 - Move XULDocument popup attributes to Document. r?bz Allows top level non-XUL documents to share this code. Three tests had to be adjusted to account for the attributes being chrome only now and not available to content privilege XUL. In two tests, the values attributes are now simply undefined. The crashtest was converted to a chrome mochitest to preserve what it was testing. MozReview-Commit-ID: 99w9Ax4et3C
5b0078e12a496878787a063b176b13cfddbdc8b5: Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen draft
James Willcox <snorp@snorp.net> - Fri, 03 Aug 2018 14:48:31 -0500 - rev 826961
Push 118423 by bmo:snorp@snorp.net at Mon, 06 Aug 2018 14:35:16 +0000
Bug 1480095 - Allow loading custom error pages via nsILoadURIDelegate r=esawin,bz,jchen MozReview-Commit-ID: IhVC9nU60fy
cba3360692b8089e5850d1c111a8f57697fa554b: Bug 1479508 Part 3: Update test expectations. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 16:02:57 -0700 - rev 826786
Push 118386 by bmo:so61pi.re@gmail.com at Sun, 05 Aug 2018 09:56:44 +0000
Bug 1479508 Part 3: Update test expectations. r=bz MozReview-Commit-ID: Haf4LTUwDOc
c42fa0ccd335bead0c5e5bcf98149f4b4754ad90: Bug 1479508 Part 2: Change GetElementsWithGrid to use a more conservative traversal that skips subtrees without frames. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 15:33:06 -0700 - rev 826785
Push 118386 by bmo:so61pi.re@gmail.com at Sun, 05 Aug 2018 09:56:44 +0000
Bug 1479508 Part 2: Change GetElementsWithGrid to use a more conservative traversal that skips subtrees without frames. r=bz MozReview-Commit-ID: 1hTQD8LoLQw
09d7d2f8fe4f1176c93fc3028821a5aec1177430: Bug 1479508 Part 1: Move devtools-specific function definitions in Element.webidl into a better-documented partial interface. r=bz
Brad Werth <bwerth@mozilla.com> - Wed, 01 Aug 2018 11:52:21 -0700 - rev 826784
Push 118386 by bmo:so61pi.re@gmail.com at Sun, 05 Aug 2018 09:56:44 +0000
Bug 1479508 Part 1: Move devtools-specific function definitions in Element.webidl into a better-documented partial interface. r=bz MozReview-Commit-ID: 6227lasylzN
887d3f33f6a575f0180b19296dd574e06f84eba4: Bug 1480244: Part 4 - Make child message managers non-global objects. r?bz draft
Kris Maglione <maglione.k@gmail.com> - Thu, 02 Aug 2018 17:44:43 -0700 - rev 826776
Push 118383 by maglione.k@gmail.com at Sat, 04 Aug 2018 23:40:13 +0000
Bug 1480244: Part 4 - Make child message managers non-global objects. r?bz This is mostly self-explanatory. However, the patch also contains some minor changes to frame scripts which expect to be able to call message manager methods with a null target object, which stops working when they stop being global objects. MozReview-Commit-ID: HDT2RvK3F3L