searching for reviewer(build)
4497aa4da9d30c2e8d9e20d59620832b46a46f92: Bug 1481638 Do not pass CFI sanitization flags to MOZ_CARGO_WRAP_LDFLAGS r?Build draft
Tom Ritter <tom@mozilla.com> - Tue, 07 Aug 2018 16:19:55 -0500 - rev 827342
Push 118518 by bmo:tom@mozilla.com at Tue, 07 Aug 2018 21:20:16 +0000
Bug 1481638 Do not pass CFI sanitization flags to MOZ_CARGO_WRAP_LDFLAGS r?Build MozReview-Commit-ID: C85uJBNugiY
60787d9369224bd1d10ee62015cc3c665e1fc4f3: Bug 1481378 - Simplify mozconfig.linux32. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 07 Aug 2018 16:28:13 +0900 - rev 827140
Push 118482 by bmo:mh+mozilla@glandium.org at Tue, 07 Aug 2018 09:59:40 +0000
Bug 1481378 - Simplify mozconfig.linux32. r?build All CI builds for linux32 have been running on 64-bits hosts for a long while now, and there are no 32-bits hosts left. We can remove the special-casing that makes the linux32 builds behave differently depending on the bit-width of the host. Furthermore, configure has been able to deal with adding -m32 on its own, so we don't need to add it to $CC/$CXX manually anymore.
f7588f223a029e67aa374f2045991281ad572f2d: bug 1461992 - Add `mach telemetry-schema` to output build system telemetry schema in json-schema format. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Mon, 06 Aug 2018 13:54:58 -0400 - rev 827025
Push 118444 by bmo:ted@mielczarek.org at Mon, 06 Aug 2018 19:13:04 +0000
bug 1461992 - Add `mach telemetry-schema` to output build system telemetry schema in json-schema format. r?build External systems such as the generic ingestion service will want to work with the more standard json-schema format. This commit adds a `mach telemetry-schema` command to convert the voluptuous schema to json-schema format using the `luscious` Python module. Since that module has not been updated recently, we install and use a fork with some changes. MozReview-Commit-ID: BOECX2tyq21
b40c0af05632e5c827bcbb057cb7f1576157e2aa: bug 1461992 - add a voluptuous schema for build system telemetry. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Fri, 03 Aug 2018 15:41:20 -0400 - rev 827024
Push 118444 by bmo:ted@mielczarek.org at Mon, 06 Aug 2018 19:13:04 +0000
bug 1461992 - add a voluptuous schema for build system telemetry. r?build This change adds a voluptuous schema for build system telemetry, replacing the existing json schema file. Using voluptuous will make it easier to work with the schema from Python code in the build system. A future commit will use a Python module to provide a mach command to convert the voluptuous schema to json schema format for consumption by other systems. MozReview-Commit-ID: 2GimpiOo7fa
334fcdfdce362fa85f73e795d37aceaa7fe90072: bug 1461992 - update vendored copy of voluptuous to 0.11.5. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Mon, 06 Aug 2018 06:45:33 -0400 - rev 827023
Push 118444 by bmo:ted@mielczarek.org at Mon, 06 Aug 2018 19:13:04 +0000
bug 1461992 - update vendored copy of voluptuous to 0.11.5. r?build voluptuous 0.11.1 added support for a `description` argument for Required and Optional objects, which is useful for adding descriptions in the schema that we can persist when converting it to json-schema format. This patch vendors the current version of voluptuous, which is 0.11.5. MozReview-Commit-ID: 2qt1KE8MPYR
e47ab39c8fdee3236a7cc8926394aed3053b48a5: Bug 1480617 - Disable LTO when compiling dummy.c in elfhack. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Aug 2018 07:45:55 +0900 - rev 826115
Push 118240 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:47:12 +0000
Bug 1480617 - Disable LTO when compiling dummy.c in elfhack. r?build For the same reason test-array.c and test-ctors.c need to be built explicitly without LTO.
3c17b54bfd36d3b2f0fdfed1780940d57f4ac12c: Bug 1480605 - Upgrade rust 1.28 toolchain to release. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Aug 2018 07:01:27 +0900 - rev 826114
Push 118239 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:27:20 +0000
Bug 1480605 - Upgrade rust 1.28 toolchain to release. r?build
a67c60d851174a8304719d49e7b2ec76d4b0f8e0: Bug 1480605 - Upgrade rust 1.28 toolchain to release. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 03 Aug 2018 07:01:27 +0900 - rev 826098
Push 118238 by bmo:mh+mozilla@glandium.org at Thu, 02 Aug 2018 22:02:22 +0000
Bug 1480605 - Upgrade rust 1.28 toolchain to release. r?build
baabf641d92cb5484a81e98c8bc1ce106328dba5: Bug 1475071 - Enable --no-sync and --debug-logging when running tup; r?Build draft
Mike Shal <mshal@mozilla.com> - Tue, 31 Jul 2018 10:07:57 -0400 - rev 824664
Push 117969 by bmo:mshal@mozilla.com at Tue, 31 Jul 2018 15:38:05 +0000
Bug 1475071 - Enable --no-sync and --debug-logging when running tup; r?Build The --no-sync flag turns off the SQLite synchronous pragma, so we don't force the disk to sync on every 'mach build'. Since mach always touches a few files (eg: warnings.json, .purgecaches, etc), there is always a minor amount of updates to the database, and syncing them every time just forces an unnecessary delay. The --debug-logging flag saves logs under .tup/log to show what files changes or were deleted, as well as the corresponding build DAG. This can be helpful when trying to investigate why something was rebuilt. MozReview-Commit-ID: L0m7IsYlFUI
040a42df48860614b1cfa820b5e6d07020d0cf65: Bug 1475071 - Bump tup version to v0.7.7; r?Build draft
Mike Shal <mshal@mozilla.com> - Tue, 31 Jul 2018 10:06:27 -0400 - rev 824663
Push 117969 by bmo:mshal@mozilla.com at Tue, 31 Jul 2018 15:38:05 +0000
Bug 1475071 - Bump tup version to v0.7.7; r?Build MozReview-Commit-ID: 55JOVxzWhm4
8ea07b51149b3cd2bce6c4bfc8dac0ea2aca31ea: Bug 1478923 - Remove LLVM_SYMBOLIZER from mozconfig.lto. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:46:51 +0900 - rev 823498
Push 117701 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 13:49:33 +0000
Bug 1478923 - Remove LLVM_SYMBOLIZER from mozconfig.lto. r?build This was cargo-culted from the asan/tsan mozconfigs, but is not necessary for builds without sanitizers.
9e13deeb56f0a55ecf0a6b56dcfb3ae35704704d: Bug 1478919 - Remove the now unused linux64-clang-5 toolchain. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:34:07 +0900 - rev 823497
Push 117701 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 13:49:33 +0000
Bug 1478919 - Remove the now unused linux64-clang-5 toolchain. r?build
48df7664c7514e8fc54b2bc9a05dce79a5071328: Bug 1478919 - Switch Spidermonkey TSAN builds to the default clang. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:31:43 +0900 - rev 823496
Push 117701 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 13:49:33 +0000
Bug 1478919 - Switch Spidermonkey TSAN builds to the default clang. r?build It was kept on clang 5 explicitly in bug 1467658 because of bug 1467673, now fixed.
b2c6ea17c8f5154ca566fa22877cb2009c4612f6: Bug 1478927 - Upgrade clang 6 to 6.0.1 and apply some miscompilation patches. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:53:02 +0900 - rev 823395
Push 117665 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 07:03:24 +0000
Bug 1478927 - Upgrade clang 6 to 6.0.1 and apply some miscompilation patches. r?build https://github.com/rust-lang/rust/issues/52694 is a miscompilation I found in rust when it uses system llvm 5 or 6, that was fixed 5 months ago in the llvm rust bundles. This may or may not affect clang, but considering it was also reported to upstream llvm independently of rust, it's better to side with caution. It doesn't affect 3.9, and bug 1478919 got rid of the last use of clang 5 (except for clang-tidy, but that's not used to compile). The patches come from the llvm trunk from 5 months ago, so they're already in our clang 7 snapshots. Windows static analysis builds are still using an old trunk, but are stuck on bug 1427808. They're "only" for static analysis, though.
886cf8ceefb2f95490b804559f67512d487e0647: Bug 1478927 - Upgrade clang 6 to 6.0.1 and apply some miscompilation patches. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:53:02 +0900 - rev 823394
Push 117664 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 06:59:50 +0000
Bug 1478927 - Upgrade clang 6 to 6.0.1 and apply some miscompilation patches. r?build https://github.com/rust-lang/rust/issues/52694 is a miscompilation I found in rust when it uses system llvm 5 or 6, that was fixed 5 months ago in the llvm rust bundles. This may or may not affect clang, but considering it was also reported to upstream llvm independently of rust, it's better to side with caution. It doesn't affect 3.9, and bug 1478919 got rid of the last use of clang 5 (except for clang-tidy, but that's not used to compile). The patches come from the llvm trunk from 5 months ago, so they're already in our clang 7 snapshots. Windows static analysis builds are still using an old trunk, but it's better to update them separately.
a2069ba40ea441964d14347d7a406c528f5b3814: Bug 1478923 - Remove LLVM_SYMBOLIZER from mozconfig.lto. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:46:51 +0900 - rev 823393
Push 117663 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 06:47:53 +0000
Bug 1478923 - Remove LLVM_SYMBOLIZER from mozconfig.lto. r?build This was cargo-culted from the asan/tsan mozconfigs, but is not necessary for builds without sanitizers.
e56c551468ac98da15e2d47c62b002f1e08a37a9: Bug 1478919 - Remove the now unused linux64-clang-5 toolchain. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:34:07 +0900 - rev 823389
Push 117659 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 06:38:28 +0000
Bug 1478919 - Remove the now unused linux64-clang-5 toolchain. r?build
e13257228b2c20e9dc4502d679d09675c5127eab: Bug 1478919 - Switch Spidermonkey TSAN builds to the default clang. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:31:43 +0900 - rev 823388
Push 117659 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 06:38:28 +0000
Bug 1478919 - Switch Spidermonkey TSAN builds to the default clang. r?build It was kept on clang 5 explicitly in bug 1467658 because of bug 1467673, now fixed.
162b1c7ecca72e6c3b330e68203a51fa019617d2: Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 27 Jul 2018 15:14:06 +0900 - rev 823386
Push 117657 by bmo:mh+mozilla@glandium.org at Fri, 27 Jul 2018 06:20:46 +0000
Bug 1478917 - Apply upstream patch fixing ld64 crash with LTO. r?build While fiddling with clang (upgrading it and applying some miscompilation patches), my mac LTO builds started to fail because ld64 would crash during configure. It turns out, it was crashing trying to print a warning it shouldn't even print out, about failure to create a cache path. This, in turn, is due to a pointer not being initialized in the ld64 code. I sent this upstream, and this was promptly fixed: https://github.com/tpoechtrager/cctools-port/pull/57 However, since our last update of cctools-port, upstream landed a change that broke support for tbd files if you don't compile against the new libtapi library. Doing so is more work than I'm ready to put here, so we just cherry-pick the fix.
39ac2aff9fc4f0fd87a44be43f994c6c89d8544b: bug 1417646 - Pass `-Z run-dsymutil=no` to rustc for mac cross-compiles. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Thu, 05 Jul 2018 10:35:51 -0400 - rev 822790
Push 117472 by bmo:ted@mielczarek.org at Wed, 25 Jul 2018 22:46:17 +0000
bug 1417646 - Pass `-Z run-dsymutil=no` to rustc for mac cross-compiles. r?build When rustc links a mac binary it attempts to run `dsymutil` afterwards and expects to find it in PATH. Our mac cross-compile builds do not have that binary (we use llvm-dsymutil and it's not in PATH) but rustc doesn't have any way to override the tool path. It does provide `-Z run-dsymutil=no` to opt out of running dsymutil, so we'll use that in this scenario. We don't currently hit this issue because we don't link any binaries with rustc in cross-mac builds, but this will unblock building geckodriver there. We additionally need to set `RUSTC_BOOTSTRAP` in this case because this is an unstable option, so this patch extends the existing case for that (for `MOZ_RUST_SIMD`). MozReview-Commit-ID: KNBQkHb2M5d
d57a72016fe0791f8e6566271f00a2f0a6ce7a69: bug 1409276 - pass C/C++ compilers and flags to cargo for use in build scripts. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Thu, 05 Jul 2018 07:22:02 -0400 - rev 822700
Push 117452 by bmo:ted@mielczarek.org at Wed, 25 Jul 2018 19:39:28 +0000
bug 1409276 - pass C/C++ compilers and flags to cargo for use in build scripts. r?build MozReview-Commit-ID: 3uEwzYJUQDA
c12de60121d7b5a37019ba0fbb29ab9040c6ee62: bug 1409276 - disable warnings-as-errors for Rust libraries/programs. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Mon, 16 Jul 2018 13:52:14 -0400 - rev 822698
Push 117452 by bmo:ted@mielczarek.org at Wed, 25 Jul 2018 19:39:28 +0000
bug 1409276 - disable warnings-as-errors for Rust libraries/programs. r?build When compiling C/C++ sources via Rust build scripts there's no point in enabling warnings-as-errors as all such code is third-party code. MozReview-Commit-ID: 5pGH6w9ZE2I
f999890c76992de75f521140cb3a47e6e0c513f6: bug 1409276 - emit COMPUTED_{CFLAGS,CXXFLAGS} for Rust-only directories in the recursive make backend. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Wed, 11 Jul 2018 15:52:26 -0400 - rev 822697
Push 117452 by bmo:ted@mielczarek.org at Wed, 25 Jul 2018 19:39:28 +0000
bug 1409276 - emit COMPUTED_{CFLAGS,CXXFLAGS} for Rust-only directories in the recursive make backend. r?build Currently the recursive make backend skips emitting COMPUTED_CFLAGS etc for Rust-only directories as an optimization. However, we need to pass CFLAGS down to Rust build scripts that compile C/C++ code, so having the COMPUTED_ variables will make it easier to pass the right set of flags. Additionally, ensure that Rust programs wind up in linkables/host_linkables so that they get computed flags emitted. MozReview-Commit-ID: Ld41080dOZN
bb520779ac480599663232b277ad7f16b24d5a2e: Bug 1476475 - Use -W4 for certverifier with clang-cl. r?Build draft
Xidorn Quan <me@upsuper.org> - Fri, 20 Jul 2018 16:34:56 +1000 - rev 820758
Push 116927 by xquan@mozilla.com at Fri, 20 Jul 2018 11:54:34 +0000
Bug 1476475 - Use -W4 for certverifier with clang-cl. r?Build MozReview-Commit-ID: 9OVJ2CFO0Qb
6b834f8484ddf92372bcddf99e2921c10206f25a: Bug 1476475 - Add a bunch of warning suppression to certverifier. r?Build draft
Xidorn Quan <me@upsuper.org> - Fri, 20 Jul 2018 16:34:56 +1000 - rev 820709
Push 116902 by xquan@mozilla.com at Fri, 20 Jul 2018 06:35:31 +0000
Bug 1476475 - Add a bunch of warning suppression to certverifier. r?Build MozReview-Commit-ID: 9OVJ2CFO0Qb
4c26dab2379b229efaefa9e647347c500ebd02f9: Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/. r?Build draft
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 19 Jul 2018 23:05:27 +0900 - rev 820418
Push 116817 by VYV03354@nifty.ne.jp at Thu, 19 Jul 2018 14:23:54 +0000
Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/. r?Build MozReview-Commit-ID: KttvrkWWRPB
13cce5131bbf62e24304ee10e9b3144386c7625e: Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/interfaces/. r?Build draft
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 19 Jul 2018 23:05:27 +0900 - rev 820414
Push 116813 by VYV03354@nifty.ne.jp at Thu, 19 Jul 2018 14:11:45 +0000
Bug 1476948 - Suppress clang-cl warnings from the MIDL generated code in accessible/interfaces/. r?Build MozReview-Commit-ID: KttvrkWWRPB
3332b9e15b3d01aed5d88ef16685c6a6cbc0df12: Bug 1476875 - Change the node.js warning wording not to show up on treeherder as an error. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 19 Jul 2018 16:36:36 +0900 - rev 820235
Push 116761 by bmo:mh+mozilla@glandium.org at Thu, 19 Jul 2018 07:38:01 +0000
Bug 1476875 - Change the node.js warning wording not to show up on treeherder as an error. r?build
e966bd76c941d0a55ece284a3996136eba886e1f: Bug 1476874 - Only link object once in static libraries. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 19 Jul 2018 16:30:19 +0900 - rev 820234
Push 116760 by bmo:mh+mozilla@glandium.org at Thu, 19 Jul 2018 07:31:06 +0000
Bug 1476874 - Only link object once in static libraries. r?build
cbe7cc4c53500744a0f782f0d30c387573697149: Bug 1476486 - Apply clang warning suppression (rather than msvc) in pkix for clang-cl. r?Build draft
Xidorn Quan <me@upsuper.org> - Thu, 19 Jul 2018 11:19:52 +1000 - rev 820169
Push 116737 by xquan@mozilla.com at Thu, 19 Jul 2018 01:20:38 +0000
Bug 1476486 - Apply clang warning suppression (rather than msvc) in pkix for clang-cl. r?Build MozReview-Commit-ID: 6BCF6VYMI88
80472621648eddd6ee14531b3c3deeb5c45abf60: Bug 1476802 - Make toolkit/library/rust/Tupfile work with --dry-run; r?Build draft
Mike Shal <mshal@mozilla.com> - Wed, 18 Jul 2018 17:20:13 -0400 - rev 820103
Push 116726 by bmo:mshal@mozilla.com at Wed, 18 Jul 2018 22:13:33 +0000
Bug 1476802 - Make toolkit/library/rust/Tupfile work with --dry-run; r?Build We shouldn't call _get_backend_file during TupBackend:_init() since self.dry_run is not set yet. Instead we can just call it when we need to add rust rules. MozReview-Commit-ID: 5elqXGFMSuG
ca04dcecfc6c5334e1850accf654db5970604a76: Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well. r?Build draft
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 11:43:53 +1000 - rev 819551
Push 116578 by xquan@mozilla.com at Wed, 18 Jul 2018 04:06:19 +0000
Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well. r?Build MozReview-Commit-ID: CHSmYqnPwWL
0bf82dca52d51ec8911d9a928e67a29528e96762: Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well. r?Build draft
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 11:43:53 +1000 - rev 819514
Push 116573 by xquan@mozilla.com at Wed, 18 Jul 2018 01:44:54 +0000
Bug 1476486 - Apply clang warning suppression in pkix to clang-cl as well. r?Build MozReview-Commit-ID: CHSmYqnPwWL
4ec423203fe859c02e984714b6c535a6401f7915: Bug 1476475 - Disable c++98-compat warnings for clang-cl. r?Build draft
Xidorn Quan <me@upsuper.org> - Wed, 18 Jul 2018 11:29:58 +1000 - rev 819513
Push 116572 by xquan@mozilla.com at Wed, 18 Jul 2018 01:30:33 +0000
Bug 1476475 - Disable c++98-compat warnings for clang-cl. r?Build MozReview-Commit-ID: FOrkf5NgUIL
5a2f56f30f61639c1fa6e3b1e7dec4eb782d0f15: Bug 1476174 - Fix-up the change from bug 1474024 to avoid creating lto object files in installed locations. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 17 Jul 2018 11:29:49 +0900 - rev 819076
Push 116431 by bmo:mh+mozilla@glandium.org at Tue, 17 Jul 2018 04:11:06 +0000
Bug 1476174 - Fix-up the change from bug 1474024 to avoid creating lto object files in installed locations. r?build
e66714b93f168473fe0606616af10f0c97dde3d4: Bug 1474024 - Avoid LTO breaking debug info on macOS builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Tue, 10 Jul 2018 07:09:24 +0900 - rev 816392
Push 115828 by bmo:mh+mozilla@glandium.org at Wed, 11 Jul 2018 05:51:36 +0000
Bug 1474024 - Avoid LTO breaking debug info on macOS builds. r?build
aab71e0e93f97c3072cc7cd6967792410c814366: Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 11:35:31 +0900 - rev 815151
Push 115458 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 21:59:00 +0000
Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build Currently, --enable-lto just implies --enable-linker=lld, which essentially only works on Linux, and assumes one can't do lto with anything other than lld. Which is not true. As a matter of fact, even ld.bfd can do lto, as long as the gold plugin for llvm is available, or when doing lto with GCC instead of clang. Anyways, to allow more lto setups, we adapt the --enable-linker setup to: - work on macOS, which it currently doesn't, and add support for the mac linker (ld64), which, unfortunately, doesn't have a clean way to be detected, so work around that. - default to lld if lto is enable, no linker was explicitly given, the compiler is clang *and* the build target is not macOS.
089b919edfd2305093005fa50c283efec5848695: Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 11:35:31 +0900 - rev 815146
Push 115453 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 21:13:14 +0000
Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build Currently, --enable-lto just implies --enable-linker=lld, which essentially only works on Linux, and assumes one can't do lto with anything other than lld. Which is not true. As a matter of fact, even ld.bfd can do lto, as long as the gold plugin for llvm is available, or when doing lto with GCC instead of clang. Anyways, to allow more lto setups, we adapt the --enable-linker setup to: - work on macOS, which it currently doesn't, and add support for the mac linker (ld64), which, unfortunately, doesn't have a clean way to be detected, so work around that. - default to lld if lto is enable, no linker was explicitly given, the compiler is clang *and* the build target is not macOS.
4767ec59207bd499445c2b9a9bbe3b947ceb6e13: Bug 1473436 - Default to lld for local *nix builds when it is available. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 09:28:49 +0900 - rev 815145
Push 115453 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 21:13:14 +0000
Bug 1473436 - Default to lld for local *nix builds when it is available. r?build
4882dbbe5c229adf088c69523cf075f7638aa89b: Bug 1473436 - Disable elfhack on local builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 09:23:56 +0900 - rev 815144
Push 115453 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 21:13:14 +0000
Bug 1473436 - Disable elfhack on local builds. r?build Because of bug 1423822, we can't enable elfhack and lld at the same time. OTOH, elfhack is not really useful on local builds: it's only used on `make package`. Since we're going to make lld the default if it's available, let's just completely disable elfhack by default on local builds. While here, hide the configure flag when compile environment is disabled.
85501d6a88d7c28a41389724a9d5ec070fd1dc6b: Bug 1457168 - Make configure tests use LINKER_LDFLAGS. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 04 Jul 2018 16:18:48 +0900 - rev 815143
Push 115453 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 21:13:14 +0000
Bug 1457168 - Make configure tests use LINKER_LDFLAGS. r?build Because we have no linking configure test in python configure (yet), we just make old-configure tests use LINKER_LDFLAGS, and make those flags added to LDFLAGS by old-configure at the same time.
7f3467ca0eadb7c3207eee23eb10d1a5a8dce2df: Bug 1473786 - Enable LTO on macOS builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Fri, 06 Jul 2018 11:50:42 +0900 - rev 814758
Push 115331 by bmo:mh+mozilla@glandium.org at Fri, 06 Jul 2018 02:51:27 +0000
Bug 1473786 - Enable LTO on macOS builds. r?build
86bef9c77d33c7a947d1c23ec659044fb6b13925: Bug 1469091 - Build the clang plugin as a host shared library. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 14:58:09 +0900 - rev 814709
Push 115319 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 23:21:08 +0000
Bug 1469091 - Build the clang plugin as a host shared library. r?build This adds just enough host shared library support for this one use case, but also takes shortcuts, because fully supporting host shared library is a deep rabbit hole I'm not ready to take just to fix --enable-lto --enable-clang-plugin on mac builds. One downside is that one my machine the plugin now takes > 80s to build, instead of 15s before, thanks to the lack of unified sources.
ff7b5454a5981d7a35589a6edddf7465b2c823e6: Bug 1473667 - Handle multiple GENERATED_FILES outputs in the faster make backend; r?Build draft
Mike Shal <mshal@mozilla.com> - Thu, 05 Jul 2018 11:48:59 -0400 - rev 814591
Push 115272 by bmo:mshal@mozilla.com at Thu, 05 Jul 2018 18:30:55 +0000
Bug 1473667 - Handle multiple GENERATED_FILES outputs in the faster make backend; r?Build For files that come from the objdir in install manifests (eg: '!buildid.h'), the FasterMake backend runs 'make -C dirname filename' to build the file with the RecursiveMake backend before the install manifest is processed. This works fine for GENERATED_FILES that produce a single target, but if the GENERATED_FILES invocation produces multiple targets, the FasterMake backend will run the command multiple times. Eg: GENERATED_FILES += [('output1', 'output2')] ... make -C dirname output1 make -C dirname output2 These invocations may be run in parallel, and would produce both output1 and output2 twice. Instead we can track the GeneratedFile objects as they are emitted, and only add the first output as a dependency on the install manifest. The RecursiveMake backend is then only invoked once for the whole group of GENERATED_FILES. MozReview-Commit-ID: 6mvkHow2V2i
d8b152444cd1c01fe9068bc5fea652c04fcd14f3: bug 1473121 - Pass -vv to cargo build instead of just --verbose when verbose output is requested. r?build draft
Ted Mielczarek <ted@mielczarek.org> - Tue, 03 Jul 2018 14:17:31 -0400 - rev 814432
Push 115207 by bmo:ted@mielczarek.org at Thu, 05 Jul 2018 11:03:55 +0000
bug 1473121 - Pass -vv to cargo build instead of just --verbose when verbose output is requested. r?build Many Rust build scripts compile C/C++ source files with the cc crate, but cargo doesn't print the output of build scripts unless you pass `-vv`, so pass that instead of just `--verbose` to get that output in automation and builds where verbose output was requested. MozReview-Commit-ID: EUazlKWFsDw
f618ec13264f139719c77aabe777a7c153232188: Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 11:35:31 +0900 - rev 814378
Push 115174 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 04:32:13 +0000
Bug 1469088 - Relax the assumptions of --enable-lto, and make it work for macOS builds. r?build Currently, --enable-lto just implies --enable-linker=lld, which essentially only works on Linux, and assumes one can't do lto with anything other than lld. Which is not true. As a matter of fact, even ld.bfd can do lto, as long as the gold plugin for llvm is available, or when doing lto with GCC instead of clang. Anyways, to allow more lto setups, we adapt the --enable-linker setup to: - work on macOS, which it currently doesn't, and add support for the mac linker (ld64), which, unfortunately, doesn't have a clean way to be detected, so work around that. - default to lld if no linker was explicitly given and the compiler is clang *and* the build target is not macOS.
fbb6d8be50040d0c6f414bf712fd456e82bc09a8: Bug 1473436 - Default to lld for local *nix builds when it is available. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 09:28:49 +0900 - rev 814377
Push 115174 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 04:32:13 +0000
Bug 1473436 - Default to lld for local *nix builds when it is available. r?build
4ebaf7b5efd35ccadcc22bec428e968cbe426111: Bug 1473436 - Disable elfhack on local builds. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 09:23:56 +0900 - rev 814376
Push 115174 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 04:32:13 +0000
Bug 1473436 - Disable elfhack on local builds. r?build Because of bug 1423822, we can't enable elfhack and lld at the same time. OTOH, elfhack is not really useful on local builds: it's only used on `make package`. Since we're going to make lld the default if it's available, let's just completely disable elfhack by default on local builds. While here, hide the configure flag when compile environment is disabled.
8d61b4425fa28c3b1b7c7cfc64ff520510a00934: Bug 1457168 - Make configure tests use LINKER_LDFLAGS. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Wed, 04 Jul 2018 16:18:48 +0900 - rev 814375
Push 115174 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 04:32:13 +0000
Bug 1457168 - Make configure tests use LINKER_LDFLAGS. r?build Because we have no linking configure test in python configure (yet), we just make old-configure tests use LINKER_LDFLAGS, and make those flags added to LDFLAGS by old-configure at the same time.
b8f7c8ac3822f7c7e2d0fd84b2b767711d6b001a: Bug 1473436 - Default to lld for local *nix builds when it is available. r?build draft
Mike Hommey <mh+mozilla@glandium.org> - Thu, 05 Jul 2018 09:28:49 +0900 - rev 814346
Push 115170 by bmo:mh+mozilla@glandium.org at Thu, 05 Jul 2018 01:29:00 +0000
Bug 1473436 - Default to lld for local *nix builds when it is available. r?build