searching for reviewer(birtles)
443c8f1e261efdd616aed67765d181a483a674ff: Bug 1480149 - Disable tab animations for users who prefer reduced animation. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 23 Aug 2018 05:24:35 +0000 - rev 830995
Push 118868 by bmo:zjz@zjz.name at Fri, 24 Aug 2018 07:04:39 +0000
Bug 1480149 - Disable tab animations for users who prefer reduced animation. r=birtles This patch will use the 'prefers-reduced-motion' in order to disable the tab animations. Differential Revision: https://phabricator.services.mozilla.com/D4042
c0c4120ab7c710906236caaf6322b9a37e203332: Bug 1485133 - Remove Web Animation polyfill in video controls r=birtles
Timothy Guan-tin Chien <timdream@gmail.com> - Tue, 21 Aug 2018 22:43:55 +0000 - rev 830728
Push 118854 by bmo:a.beingessner@gmail.com at Wed, 22 Aug 2018 20:13:35 +0000
Bug 1485133 - Remove Web Animation polyfill in video controls r=birtles Differential Revision: https://phabricator.services.mozilla.com/D3918
2c023d39fa5a5163e828fc9702f14e4d6b46e6db: Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 20 Aug 2018 07:03:07 +0000 - rev 830221
Push 118825 by bmo:rob@robwu.nl at Mon, 20 Aug 2018 17:24:40 +0000
Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles MenuButton will listen the HTMLTooltip hidden event even if HTMLTooltip is destroyed. As a result of it, the timer which issued in the MenuButton's event listener might fail due to the target window is destroyed. (e.g., switching the dock mode to bottom from window mode.) This patch will remove this event listener before destroying the HTMLTooltip. Differential Revision: https://phabricator.services.mozilla.com/D3759
fc5c57e9b65b65e98fdc8e792913a5553bb67897: Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 20 Aug 2018 07:03:07 +0000 - rev 830210
Push 118824 by bmo:hskupin@gmail.com at Mon, 20 Aug 2018 15:49:57 +0000
Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles MenuButton will listen the HTMLTooltip hidden event even if HTMLTooltip is destroyed. As a result of it, the timer which issued in the MenuButton's event listener might fail due to the target window is destroyed. (e.g., switching the dock mode to bottom from window mode.) This patch will remove this event listener before destroying the HTMLTooltip. Differential Revision: https://phabricator.services.mozilla.com/D3759
f66c0e3eb00956066ab46c7e359cf7514777e057: Bug 1420020 - Disable all properties-value-inherit-xxx.html on ASAN builds. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 17 Aug 2018 06:32:42 +0000 - rev 829934
Push 118801 by bmo:rbartlensky@mozilla.com at Fri, 17 Aug 2018 12:50:32 +0000
Bug 1420020 - Disable all properties-value-inherit-xxx.html on ASAN builds. r=birtles All tests have been disabled on debug builds since 73ff8c6e0837 [1]. We should also disable them on ASAN builds for now. This will stop intermittent failures on properties-value-inherit-001.html (bug 1420020), and on properties-value-inherit-002.html (bug 1429404 and bug 1444280). There is no intermitent failures bugs for properties-value-inherit-003.html though. There is no other high volume intermittent failure at this moment. [1] https://hg.mozilla.org/mozilla-central/rev/73ff8c6e0837 Differential Revision: https://phabricator.services.mozilla.com/D3583
b1dea6a1cd1135bca0180100f98ce713670d6e0a: Bug 1358510 - Disable properties-value-002.html and properties-value-003.html on debug or ASAN builds as well as properties-value-001.html. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 14 Aug 2018 04:28:56 +0000 - rev 828983
Push 118741 by bmo:kshvmdn@gmail.com at Tue, 14 Aug 2018 18:31:47 +0000
Bug 1358510 - Disable properties-value-002.html and properties-value-003.html on debug or ASAN builds as well as properties-value-001.html. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D3277
ab427e770c87eb95217e49091236fe69dfdf9a9b: Bug 1478106 - Skip properties-value-001.html on ASAN build. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Thu, 09 Aug 2018 22:53:26 +0000 - rev 828230
Push 118651 by bmo:guptatrisha97@gmail.com at Fri, 10 Aug 2018 11:02:58 +0000
Bug 1478106 - Skip properties-value-001.html on ASAN build. r=birtles Skip properties-value-001.html on ASAN build Differential Revision: https://phabricator.services.mozilla.com/D3067
a5569f1c67c04684d7d1ad9b914d12ee39c643b3: Bug 1477367 - Close the popup menu before changing the panel to options panel. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 08 Aug 2018 02:13:38 +0000 - rev 827534
Push 118540 by bmo:bpostelnicu@mozilla.com at Wed, 08 Aug 2018 10:44:22 +0000
Bug 1477367 - Close the popup menu before changing the panel to options panel. r=birtles Pressing the F1 key make the toolbox panel to options panel, However, popup menu doesn't closed at the moment. This patch will close the popup menu in this case. Differential Revision: https://phabricator.services.mozilla.com/D2897
3b4c9a65ddf2179c922be2c13100dbc61a651cb4: Bug 1477088 - Part 1. Force adding the focus to the button in order to handle the key event. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 08 Aug 2018 08:16:12 +0900 - rev 827455
Push 118534 by bmo:gl@mozilla.com at Wed, 08 Aug 2018 04:44:16 +0000
Bug 1477088 - Part 1. Force adding the focus to the button in order to handle the key event. r=birtles The menu button can't receive the key event on macOS since macOS doesn't leave the focus of the menu button even if click the menu button. So this patch will add the focus to the button when clicking the button. Differential Revision: https://phabricator.services.mozilla.com/D2585
61021fadb55e64afc860e88a36bad794ee335aab: Bug 1349416 - Only delay removeEventListener when hiding after mouseup;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 11:02:45 +0000 - rev 826522
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Only delay removeEventListener when hiding after mouseup;r=birtles The inplace-editor is programmatically hiding the autocomplete-popup on TAB and notifies the caller. The caller (eg rule view) will trigger a click on the next focusable element immediately after that. If the HTMLTooltip is still consuming outside clicks at that point the click will be swallowed and the new inplace-editor cannot be created. Depends on D2661 Differential Revision: https://phabricator.services.mozilla.com/D2662
c4578670771fb9cc82c0a39b825159923eff7f2b: Bug 1349416 - Hide HTMLTooltip on mouseup rather than on click;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 11:01:51 +0000 - rev 826521
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Hide HTMLTooltip on mouseup rather than on click;r=birtles A click event is only fired if the element on which mousedown and mouseup happened are the same. If this is not the case, the HTMLTooltip will not be able to hide itself. Listening to mouseup makes the behavior more consistent but forces the hide() method to be always asynchronous, while before it was only asynchronous for tooltips using the XULWrapper. Depends on D2660 Differential Revision: https://phabricator.services.mozilla.com/D2661
c514bf46e52be47e3ebf969cf66e3e8d56605b20: Bug 1349416 - Prevent event tooltip from reappearing when clicking on bubble;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 09:40:07 +0000 - rev 826520
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Prevent event tooltip from reappearing when clicking on bubble;r=birtles Differential Revision: https://phabricator.services.mozilla.com/D2660
ec5ee2990e219b1cd1c95053a21878d69ddad52c: Bug 1349416 - Only delay removeEventListener when hiding after mouseup;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 07:05:51 +0000 - rev 826506
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Only delay removeEventListener when hiding after mouseup;r=birtles The inplace-editor is programmatically hiding the autocomplete-popup on TAB and notifies the caller. The caller (eg rule view) will trigger a click on the next focusable element immediately after that. If the HTMLTooltip is still consuming outside clicks at that point the click will be swallowed and the new inplace-editor cannot be created. Depends on D2661 Differential Revision: https://phabricator.services.mozilla.com/D2662
c4f8eccf14dcdc14dee9aa597c8a42ed31c75555: Bug 1349416 - Hide HTMLTooltip on mouseup rather than on click;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 07:05:43 +0000 - rev 826505
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Hide HTMLTooltip on mouseup rather than on click;r=birtles A click event is only fired if the element on which mousedown and mouseup happened are the same. If this is not the case, the HTMLTooltip will not be able to hide itself. Listening to mouseup makes the behavior more consistent but forces the hide() method to be always asynchronous, while before it was only asynchronous for tooltips using the XULWrapper. Depends on D2660 Differential Revision: https://phabricator.services.mozilla.com/D2661
b7e80d3a6810f1b98fc0703a0772b6657dfb1ed9: Bug 1349416 - Prevent event tooltip from reappearing when clicking on bubble;r=birtles
Julian Descottes <jdescottes@mozilla.com> - Fri, 03 Aug 2018 07:05:30 +0000 - rev 826504
Push 118355 by wisniewskit@gmail.com at Sat, 04 Aug 2018 00:24:59 +0000
Bug 1349416 - Prevent event tooltip from reappearing when clicking on bubble;r=birtles Differential Revision: https://phabricator.services.mozilla.com/D2660
41875a1f3b59f0e1f71713d30b36fae8e5ac4315: Bug 1477862 - Add white-space property into tooltip's label. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Thu, 02 Aug 2018 05:29:22 +0000 - rev 825837
Push 118186 by bmo:bpostelnicu@mozilla.com at Thu, 02 Aug 2018 13:24:00 +0000
Bug 1477862 - Add white-space property into tooltip's label. r=birtles If the width of the devtool window is narrow, tooltip's label has a line break. This patch will prevent it. Differential Revision: https://phabricator.services.mozilla.com/D2636
0626f30fbcd3523f649c7b2d8f1f4b0b108929ee: Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 11:20:53 +0900 - rev 824233
Push 117841 by bmo:nchevobbe@mozilla.com at Mon, 30 Jul 2018 10:39:06 +0000
Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r=birtles WebRender has no layers at all. MozReview-Commit-ID: 7qYE8vONfU9
fcde37a994ae07da1c3d9fae81a90a2fe3386717: Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 11:13:54 +0900 - rev 824232
Push 117841 by bmo:nchevobbe@mozilla.com at Mon, 30 Jul 2018 10:39:06 +0000
Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r=birtles The applying change hints are the same as what we apply for transform style changed from something to 'none'. All test cases pass with this fix fail without the fix. MozReview-Commit-ID: 7HStU26lRPq
4bdbf9fdf090b900aa2c13e90f245ddb1dce00f9: Bug 1478643 - Introduce a new change hint set for added or removed transform style. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 10:51:18 +0900 - rev 824231
Push 117841 by bmo:nchevobbe@mozilla.com at Mon, 30 Jul 2018 10:39:06 +0000
Bug 1478643 - Introduce a new change hint set for added or removed transform style. r=birtles MozReview-Commit-ID: GfK1e5QaOu6
7c62a303f82a12bcd4626c70f45a07ad2e79fec8: Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 10:44:47 +0900 - rev 824230
Push 117841 by bmo:nchevobbe@mozilla.com at Mon, 30 Jul 2018 10:39:06 +0000
Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r=birtles All test cases here pass without any changes on the current trunk, but all counter part test cases for transform introducing in a subsequent patch will fail without the proper fix. MozReview-Commit-ID: 3hgsVfFJPrZ
02e0f0a002b1f7c0ffc24b946cbfd87b22650276: Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 11:20:53 +0900 - rev 823946
Push 117829 by hikezoe@mozilla.com at Mon, 30 Jul 2018 02:21:22 +0000
Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r?birtles WebRender has no layers at all. MozReview-Commit-ID: 7qYE8vONfU9
b3f7c89f623da139b45cd5b7a80cf19ccc4e08b0: Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 11:13:54 +0900 - rev 823943
Push 117826 by hikezoe@mozilla.com at Mon, 30 Jul 2018 02:16:01 +0000
Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles The applying change hints are the same as what we apply for transform style changed from something to 'none'. All test cases pass with this fix fail without the fix. MozReview-Commit-ID: 7HStU26lRPq
1ef094e620ba5bb54c00d9b6e214921aa09eac93: Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 10:51:18 +0900 - rev 823942
Push 117826 by hikezoe@mozilla.com at Mon, 30 Jul 2018 02:16:01 +0000
Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles MozReview-Commit-ID: GfK1e5QaOu6
5d67f9167df796939151cb78bddb8a99028a6f98: Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 10:44:47 +0900 - rev 823941
Push 117826 by hikezoe@mozilla.com at Mon, 30 Jul 2018 02:16:01 +0000
Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles All test cases here pass without any changes on the current trunk, but all counter part test cases for transform introducing in a subsequent patch will fail without the proper fix. MozReview-Commit-ID: 3hgsVfFJPrZ
d454584666cfa59306975027b4261f1df023a6f8: Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 06:08:07 +0900 - rev 823909
Push 117817 by hikezoe@mozilla.com at Sun, 29 Jul 2018 21:08:51 +0000
Bug 1479133 - Use AnimationInfo::GetGenerationFromFrame to get the animation generation for WebRender. r?birtles WebRender has no layers at all. MozReview-Commit-ID: KJoWWusX2az
94d3fe7dfa8f2ed5b68e9749051bd81b1ecdfd8e: Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 06:04:30 +0900 - rev 823908
Push 117817 by hikezoe@mozilla.com at Sun, 29 Jul 2018 21:08:51 +0000
Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles The applying change hints are the same as what we apply for transform style changed from something to 'none'. All test cases pass with this fix fail without the fix.
3410896eb47f10311e98c38fb9528095f5ac2dd4: Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 06:04:30 +0900 - rev 823907
Push 117817 by hikezoe@mozilla.com at Sun, 29 Jul 2018 21:08:51 +0000
Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles
10f75f4221b40b3cdb660e830a4bff65091ead90: Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 06:04:30 +0900 - rev 823906
Push 117817 by hikezoe@mozilla.com at Sun, 29 Jul 2018 21:08:51 +0000
Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles All test cases here pass without any changes on the current trunk, but all counter part test cases for transform introducing in a subsequent patch will fail without the proper fix.
3f9a9bb5d8380cec9688450ffd855f0299e24900: Bug 1478643 - Use nsCSSProperty to check whether the animation is transform or not. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 30 Jul 2018 06:04:29 +0900 - rev 823905
Push 117817 by hikezoe@mozilla.com at Sun, 29 Jul 2018 21:08:51 +0000
Bug 1478643 - Use nsCSSProperty to check whether the animation is transform or not. r?birtles There is no reason to use the display item type.
40aefad0849173c8dbac30cadd1bec8a72408fe9: Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 10:51:49 +0900 - rev 823742
Push 117774 by hikezoe@mozilla.com at Sat, 28 Jul 2018 01:52:20 +0000
Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles The applying change hints are the same as what we apply for transform style changed from something to 'none'. All test cases pass with this fix fail without the fix. MozReview-Commit-ID: 7SKFgJYIXs1
ca3f1fce2b66d04d11178a42d328e6a3f07422c8: Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 10:51:42 +0900 - rev 823741
Push 117774 by hikezoe@mozilla.com at Sat, 28 Jul 2018 01:52:20 +0000
Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles MozReview-Commit-ID: I3O7dd3WVa5
5cf103bbc16a15274cf755f942658cd57a8f676b: Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 10:51:39 +0900 - rev 823740
Push 117774 by hikezoe@mozilla.com at Sat, 28 Jul 2018 01:52:20 +0000
Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles All test cases here pass without any changes on the current trunk, but all counter part test cases for transform introducing in a subsequent patch will fail without the proper fix. MozReview-Commit-ID: A7c2tg6r1po
42c3cd4be3d17e5db061cabb1ba17ec80a1cd83b: Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 08:47:54 +0900 - rev 823735
Push 117771 by hikezoe@mozilla.com at Fri, 27 Jul 2018 23:48:20 +0000
Bug 1478643 - Apply change hints for transform animation in the case where the current transform style is 'none' and no change hint produced in AddLayerChangesForAnimation. r?birtles The applying change hints are the same as what we apply for transform style changed from something to 'none'. All test cases pass with this fix fail without the fix. MozReview-Commit-ID: 6R7HFIg1fIW
04c81a5ebdf1dbb5290bdc6ae9aca1eba790afe0: Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 08:39:29 +0900 - rev 823734
Push 117771 by hikezoe@mozilla.com at Fri, 27 Jul 2018 23:48:20 +0000
Bug 1478643 - Introduce a new change hint set for added or removed transform style. r?birtles MozReview-Commit-ID: GXPgN7yjCki
fab193facff04b89c05e93666c5cc6bc3dd0b3eb: Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 08:39:29 +0900 - rev 823733
Push 117771 by hikezoe@mozilla.com at Fri, 27 Jul 2018 23:48:20 +0000
Bug 1478643 - Add test cases checking finished opacity animation on the compositor. r?birtles All test cases here pass without any changes on the current trunk, but all counter part test cases for transform introducing in a subsequent patch will fail without the proper fix. MozReview-Commit-ID: JsiXewYJOAa
b65f7cc786819a45dce0bef82a37ac96612f3d3f: Bug 1478643 - Use nsCSSProperty to check whether the animation is transform or not. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sat, 28 Jul 2018 08:39:29 +0900 - rev 823732
Push 117771 by hikezoe@mozilla.com at Fri, 27 Jul 2018 23:48:20 +0000
Bug 1478643 - Use nsCSSProperty to check whether the animation is transform or not. r?birtles There is no reason to use the display item type. MozReview-Commit-ID: 5benl86smOt
a1c1b16370154dfd42563f057fb722b37aa34112: Bug 1473209 - Ignore the click event until popup is hidden. r=birtles.
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 27 Jul 2018 13:38:12 +0900 - rev 823448
Push 117683 by dgottwald@mozilla.com at Fri, 27 Jul 2018 11:18:41 +0000
Bug 1473209 - Ignore the click event until popup is hidden. r=birtles. The widget will hide the XUL panel when clicking to the outside of panel automatically. If a user clicks the MenuButton when opening the popup, the popup will hide automatically and mouse click event will be fired on macOS and Linux. (Windows will eat this click event since the consumeoutsideclicks of this panel is false.) As a result of it, the popup menu will be reopened. In order to prevent this, this patch will disable the MenuButton until popup is hidden by using the popuphidden event. This popuphidden event will be fired before the click event of MenuButton, then the click event of MenuButton will be fired after popuphidden immediately. MozReview-Commit-ID: 42xV0aWDmkR
3ce61c578a8658a2100da9996b3579f60e622776: Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 27 Jul 2018 13:38:12 +0900 - rev 823377
Push 117652 by bmo:mantaroh@gmail.com at Fri, 27 Jul 2018 04:49:17 +0000
Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. The widget will hide the XUL panel when clicking to the outside of panel automatically. If a user clicks the MenuButton when opening the popup, the popup will hide automatically and mouse click event will be fired on macOS and Linux. (Windows will eat this click event since the consumeoutsideclicks of this panel is false.) As a result of it, the popup menu will be reopened. In order to prevent this, this patch will disable the MenuButton until popup is hidden by using the popuphidden event. This popuphidden event will be fired before the click event of MenuButton, then the click event of MenuButton will be fired after popuphidden immediately. MozReview-Commit-ID: 42xV0aWDmkR
01f60800423b3a584874401e816d370a43fd8a0b: Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 27 Jul 2018 10:53:16 +0900 - rev 823347
Push 117644 by bmo:mantaroh@gmail.com at Fri, 27 Jul 2018 01:53:44 +0000
Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. The widget will hide the XUL panel when clicking to the outside of panel automatically. If a user clicks the MenuButton when opening the popup, the popup will hide automatically and mouse click event will be fired on macOS and Linux. (Windows will eat this click event since the consumeoutsideclicks of this panel is false.) As a result of it, the popup menu will be reopened. In order to prevent this, this patch will disable the MenuButton until popup is hidden by using the popuphidden event. This popuphidden event will be fired before the click event of MenuButton, then the click event of MenuButton will be fire after popuphidden immediately. So the term of disabling the MenuButton should wait for next click event, this patch will wait for this event by using the timer. (time is zero.) MozReview-Commit-ID: 42xV0aWDmkR
0a9edcc37a80b3d35f225d8fbf6684d957ae98a3: Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 27 Jul 2018 10:26:00 +0900 - rev 823345
Push 117642 by bmo:mantaroh@gmail.com at Fri, 27 Jul 2018 01:31:06 +0000
Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. XUL panel will hide when clicking to the outside of panel automatically. If a user clicks the MenuButton when opening the popup, the popup will be hidden automatically and mouse click event will be fired on macOS and Linux. (Windows will eat this click event since the consumeoutsideclicks of this panel is false.) As a result of it, the popup menu will be reopened. In order to prevent this, this patch will disable the MenuButton until popup is hidden by using popuphidden event. This popuphidden event will be fired before the click event of MenuButton, then the click event of MenuButton will be fire after popuphidden immediately. So the term of disabling the MenuButton should wait for next click event, this patch will wait for this event by using the timer(time is zero). MozReview-Commit-ID: BWAn7lgTvoh
bb66783a4f2b3af7c16b23a357f27b6078a0696a: Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. draft
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 27 Jul 2018 10:07:24 +0900 - rev 823344
Push 117641 by bmo:mantaroh@gmail.com at Fri, 27 Jul 2018 01:23:04 +0000
Bug 1473209 - Ignore the click event until popup is hidden. r?birtles. XUL panel will hide when clicking to the outside of panel automatically. If a user clicks the MenuButton when opening the popup, the popup will be hidden automatically and mouse click event will be fired on macOS and Linux. (Windows will eat this click event since the consumeoutsideclicks of this panel is false.) As a result of it, the popup menu will be reopened. In order to prevent this, this patch will disable the MenuButton until popup is hidden by using popuphidden event. This popuphidden event will be fired before the click event of MenuButton, then the click event of MenuButton will be fire after popuphidden immediately. So the term of disabling the MenuButton should wait for next click event, this patch will wait for this event by using the timer(time is zero). MozReview-Commit-ID: LmyzNpe2TVU
f3def258192799c0cde243d20c0320dc59acfbb4: Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 09:41:14 +0900 - rev 822604
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r=birtles MozReview-Commit-ID: GTnDNRMAWNQ
87cc0fe270bf7eaa92c151ac127b7eedda904629: Bug 1444816 - Drop RefPtr for nsDOMNavigationTiming in DocumentTimeline::ToTimeStamp. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 08:54:01 +0900 - rev 822603
Push 117413 by bmo:andrei.a.lazar@softvision.ro at Wed, 25 Jul 2018 14:42:19 +0000
Bug 1444816 - Drop RefPtr for nsDOMNavigationTiming in DocumentTimeline::ToTimeStamp. r=birtles We don't need to hold the strong reference in DocumentTimeline::ToTimeStamp(). MozReview-Commit-ID: 85UQBoPTjfA
6d23befa2026f8cb8db1afee70423941f0e5426f: Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 09:41:14 +0900 - rev 822260
Push 117331 by hikezoe@mozilla.com at Wed, 25 Jul 2018 00:43:19 +0000
Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r?birtles MozReview-Commit-ID: GTnDNRMAWNQ
7e684fcff22bc5a21830f4f708675cb7a3df3228: Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 08:54:01 +0900 - rev 822255
Push 117328 by hikezoe@mozilla.com at Tue, 24 Jul 2018 23:55:12 +0000
Bug 1444816 - Use navigation start time in the case where the refresh driver's time stamp is behind from the start time to avoid negative timelime time at the very beginning of document load. r?birtles MozReview-Commit-ID: 5TFKoeEgxzJ
2788822d3f848f6dd7193f8a5353e374b6178c17: Bug 1444816 - Drop RefPtr for nsDOMNavigationTiming in DocumentTimeline::ToTimeStamp. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 25 Jul 2018 08:54:01 +0900 - rev 822254
Push 117328 by hikezoe@mozilla.com at Tue, 24 Jul 2018 23:55:12 +0000
Bug 1444816 - Drop RefPtr for nsDOMNavigationTiming in DocumentTimeline::ToTimeStamp. r?birtles We don't need to hold the strong reference in DocumentTimeline::ToTimeStamp(). MozReview-Commit-ID: 85UQBoPTjfA
945a4aa49045c2ceb062bce93da733d11ecde0bd: Bug 1444816 - Use assert_greater_than instead of assert_true for time comparison. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 23 Jul 2018 11:34:51 +0900 - rev 821474
Push 117107 by dgottwald@mozilla.com at Mon, 23 Jul 2018 12:36:09 +0000
Bug 1444816 - Use assert_greater_than instead of assert_true for time comparison. r=birtles It would be easier to understand what happens. MozReview-Commit-ID: 5lidrbNBzFm
8ff77a533f41997b796d0d51b701e129f4aa66f4: Bug 1444816 - Use assert_greater_than instead of assert_true for time comparison. r?birtles draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 23 Jul 2018 11:34:51 +0900 - rev 821351
Push 117074 by hikezoe@mozilla.com at Mon, 23 Jul 2018 02:42:17 +0000
Bug 1444816 - Use assert_greater_than instead of assert_true for time comparison. r?birtles It would be easier to understand what happens. MozReview-Commit-ID: 5lidrbNBzFm
f97be2485d3d7bc791c22e69e44531e2130ab64f: Bug 1474221 - Part 3. Balance vertical padding of doorhanger popup menus and add more horizontal padding. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Jul 2018 15:58:48 +0900 - rev 821102
Push 117018 by bmo:sfoster@mozilla.com at Sat, 21 Jul 2018 04:05:10 +0000
Bug 1474221 - Part 3. Balance vertical padding of doorhanger popup menus and add more horizontal padding. r=birtles MozReview-Commit-ID: 8plpV3rMx8t
a3459b4851d3c5f6938466a8d86aba1fbe404594: Bug 1474221 - Part 2. Make the chevron menu to be doorhanger menu. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 20 Jul 2018 15:58:35 +0900 - rev 821101
Push 117018 by bmo:sfoster@mozilla.com at Sat, 21 Jul 2018 04:05:10 +0000
Bug 1474221 - Part 2. Make the chevron menu to be doorhanger menu. r=birtles This patch will make the chevron menu to doorhanger menu and modify some tests which related with this chevron menu. MozReview-Commit-ID: BkdVHgRlHIw